From unknown Sun Apr 12 21:17:15 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#164: Set DPI to same as local display by default Reply-To: Orion Poplawski , 164@bugs.x2go.org Resent-From: Orion Poplawski Resent-To: x2go-dev@lists.berlios.de Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Wed, 10 Apr 2013 18:18:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: report 164 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: patch Received: via spool by submit@bugs.x2go.org id=B.136561781225067 (code B); Wed, 10 Apr 2013 18:18:02 +0000 Received: (at submit) by bugs.x2go.org; 10 Apr 2013 18:16:52 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from mail.cora.nwra.com (mercury.cora.nwra.com [4.28.99.165]) by ymir (Postfix) with ESMTPS id D2CD55DA6C for ; Wed, 10 Apr 2013 20:16:48 +0200 (CEST) Received: from barry.cora.nwra.com (barry.cora.nwra.com [10.10.20.7]) (authenticated bits=0) by mail.cora.nwra.com (8.14.4/8.14.4) with ESMTP id r3AIGjKO029539 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Wed, 10 Apr 2013 12:16:46 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cora.nwra.com; s=default; t=1365617806; bh=5Xi83ZeyVIcByZLqnbInE/ifjdwBxl49jyOlHnGN220=; h=Message-ID:Date:From:MIME-Version:To:Subject:Content-Type; b=YNYf9Yn2f4fwSecK4ACVXStavihVOQsTfH5Y4fHFyoOiWVWpKWTMGUl/iNtzpolnA wkLjL5qxwwlrfT7HjHxXpWX6nz8E4B0nw7H7wNyzaQEa/oQ2qmqsArQbdEP/1u+IMu UkX2OH1JVfKwBh9ZDJihAJVKfPDBJl0E2Zfh0n+s= Message-ID: <5165AC8D.1050801@cora.nwra.com> Date: Wed, 10 Apr 2013 12:16:45 -0600 From: Orion Poplawski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 MIME-Version: 1.0 To: submit@bugs.x2go.org Content-Type: multipart/mixed; boundary="------------030703050407090705050902" This is a multi-part message in MIME format. --------------030703050407090705050902 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Package: x2goclient Version: 4.0.1.0 Tags: patch I think it would be nice to have sessions set the DPI to that of the local display by default. I'm not entirely sure if physicalDpiX or logicalDpiX is better here. -- Orion Poplawski Technical Manager 303-415-9701 x222 NWRA, Boulder/CoRA Office FAX: 303-415-9702 3380 Mitchell Lane orion@nwra.com Boulder, CO 80301 http://www.nwra.com --------------030703050407090705050902 Content-Type: text/x-patch; name="x2goclient-dpi.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="x2goclient-dpi.patch" diff --git a/onmainwindow.cpp b/onmainwindow.cpp index 31dbc17..5f37cc1 100644 --- a/onmainwindow.cpp +++ b/onmainwindow.cpp @@ -61,8 +61,6 @@ ONMainWindow::ONMainWindow ( QWidget *parent ) :QMainWindow ( parent ) showHaltBtn=false; defaultUseSound=true; defaultSetKbd=true; - defaultSetDPI=false; - defaultDPI=96; extStarted=false; cmdAutologin=false; defaultLink=2; @@ -107,6 +105,16 @@ ONMainWindow::ONMainWindow ( QWidget *parent ) :QMainWindow ( parent ) cmdAutologin=false; +// Try to determine the native DPI and use it for the default + int dpix = QApplication::desktop()->physicalDpiX(); + int dpiy = QApplication::desktop()->physicalDpiY(); + if ( dpix >0 && dpiy >0) { + defaultSetDPI=true; + defaultDPI=(dpix+dpiy)/2; + } else { + defaultSetDPI=false; + defaultDPI=96; + } #ifdef Q_OS_WIN clientSshPort="7022"; @@ -6661,7 +6669,7 @@ void ONMainWindow::showHelp() "--user=\t\t select user 'username'\n" "--geomerty=x|fullscreen\t set default geometry, default " "value '800x600'\n" - "--dpi=\t\t\t set dpi of x2goagent to dpi, default not set\n" + "--dpi=\t\t\t set dpi of x2goagent to dpi, default set to same as local display\n" "--link= set default link type, " "default 'adsl'\n" "--pack=\t\t set default pack method, default " --------------030703050407090705050902--