X2Go Bug report logs - #1586
pyhoca-cli does not honor the -k (--ssh-privkey) option

Full log

🔗 View this message in rfc822 format

MIME-Version: 1.0
X-Mailer: MIME-tools 5.509 (Entity 5.509)
X-Loop: owner@bugs.x2go.org
From: owner@bugs.x2go.org (X2Go Bug Tracking System)
Subject: Bug#1586 closed by Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
 (Closing...)
Message-ID: <handler.1586.b1586.17053513614828.notifdone@bugs.x2go.org>
References: <20240115204237.Horde.EDuOJV7EawW0jTxdFl4hW9c@mail.das-netzwerkteam.de>
X-X2go-PR-Message: they-closed 1586
X-X2go-PR-Package: pyhoca-cli
X-X2go-PR-Source: pyhoca-cli
Date: Mon, 15 Jan 2024 20:45:02 +0000
Content-Type: multipart/mixed; boundary="----------=_1705351502-5489-0"

[Message part 1 (text/plain, inline)]

This is an automatic notification regarding your Bug report
which was filed against the pyhoca-cli package:

#1586: pyhoca-cli does not honor the -k (--ssh-privkey) option

It has been closed by Mike Gabriel <mike.gabriel@das-netzwerkteam.de>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Mike Gabriel <mike.gabriel@das-netzwerkteam.de> by
replying to this email.


-- 
1586: https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=1586
X2Go Bug Tracking System
Contact owner@bugs.x2go.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: 1586@bugs.x2go.org

Subject: Closing...

Date: Mon, 15 Jan 2024 20:42:37 +0000

[Message part 3 (text/plain, inline)]

Control: close -1

We are migrating our debbugs bug tracker instance to X2Go GitLab's  
issue tracker.

This issue is probably resolved by MR!5 at
https://gitlab.x2go.org/x2go/client/libs/python-x2go/-/merge_requests/5

Thus, closing...

Mike

-- 

DAS-NETZWERKTEAM
c\o Technik- und Ökologiezentrum Eckernförde
Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde
mobile: +49 (1520) 1976 148
landline: +49 (4351) 850 8940

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

[Message part 4 (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Eric Monson <ericjmonson@gmail.com>

To: submit@bugs.x2go.org

Subject: pyhoca-cli does not honor the -k (--ssh-privkey) option

Date: Thu, 14 Apr 2022 18:16:35 -0600

[Message part 6 (text/plain, inline)]

Package: pyhoca-cli
Version: 0.4.0.3

I've created a session and defined a private key (not at the location
~/.ssh/id_rsa). In the command line, I run "pyhocal-cli -k <private_key>
...".  However, pyhoca-cli still attempts to use ~/.ssh/id_rsa.

Here's what I believe happens:
x2go/defaults.py: autologin is defaulted to True
x2go/utils.py: autologin is translated to 'look_for_keys', so look_for_keys
is now set to True
x2go/backends/control/plain.py (in the function connect): We hit is
following if statement:
  if look_for_keys:
    key_filename = None
    pkey = None
(so key_filename and pkey are cleared)

Finally in backends/control/plain.py, we hit the if statement that calls
one of 3 paramiko connect calls. However, since key_filename and pkey are
set to None, but look_for_keys is set to true, the software ends up trying
to use the ~/.ssh/id_rsa file, if that doesn't work, it will then ask for a
password, but never uses the passed in private key.

If you comment out the if statement in "plain.py":
  if look_for_keys:
    key_filename = None
    pkey = None

then the software does in fact use the private key passed in at the command
line. I don't know why that if statement is there. I'm sure there is a
reason, but don't know the codebase well enough to say that would be a
global fix.

[Message part 7 (text/html, inline)]

Send a report that this bug log contains spam.