From unknown Tue Apr 07 17:31:35 2026 MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) X-Loop: owner@bugs.x2go.org From: owner@bugs.x2go.org (X2Go Bug Tracking System) Subject: Bug#1586 closed by Mike Gabriel (Closing...) Message-ID: References: <20240115204237.Horde.EDuOJV7EawW0jTxdFl4hW9c@mail.das-netzwerkteam.de> X-X2go-PR-Message: they-closed 1586 X-X2go-PR-Package: pyhoca-cli X-X2go-PR-Source: pyhoca-cli Date: Mon, 15 Jan 2024 20:45:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1705351502-5489-0" This is a multi-part message in MIME format... ------------=_1705351502-5489-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This is an automatic notification regarding your Bug report which was filed against the pyhoca-cli package: #1586: pyhoca-cli does not honor the -k (--ssh-privkey) option It has been closed by Mike Gabriel . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Mike Gabriel by replying to this email. --=20 1586: https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=3D1586 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems ------------=_1705351502-5489-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 1586) by bugs.x2go.org; 15 Jan 2024 20:42:41 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from fregna.das-netzwerkteam.de (fregna.das-netzwerkteam.de [148.251.53.130]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 0A67A5DAD6 for <1586@bugs.x2go.org>; Mon, 15 Jan 2024 21:42:38 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [IPv6:2a01:4f8:202:1381::105]) by fregna.das-netzwerkteam.de (Postfix) with ESMTPS id EE71B60153 for <1586@bugs.x2go.org>; Mon, 15 Jan 2024 20:42:37 +0000 (UTC) Received: from das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id D08A3C05B0 for <1586@bugs.x2go.org>; Mon, 15 Jan 2024 21:42:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=das-netzwerkteam.de; s=dkim; t=1705351357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=1S/7QxJtPCaL43Y/Rg2nXC/pvxeMtVDmWnwAQupfDYA=; b=KisYtUe1Zng1Uytj2o6sT5SCCtBtc5CX6rKn1ZRX8b+WGRpsAmOZQKoT9L7VCOzTLPNCpZ cOpulOK6ES5VBTSDSGdNeNzihcCXa4/bBJmMd7Um2O2Uda1e5RYVugfq727Qn4tAVzTgnI zTUk2jLgOtOS04YW+T9mohWIDBaqadbKLp0E16PRKCyLta/thiMfKI4QVTyS5oAC/FQX27 6bELphDXkwlsLE66rWxoBucxvu8hLjSCZa6CRWEJruvNRG5cVLEnWGHEqocC3w0bhXFXQM SH9C3ymdx0qFZRbgxAJE39tdgFfhRpf/yTjaL1SHCRTTFMo2OdKbLAvoSonvyOa1fdqsDN SbKrYt9PuQd7VWOqzFoXV6DLn66Us1f9qaAqvP9HBIoVyNsvkPcLzMsrb2ZdjGREjMkcL8 JI9mQPUKAgkO0XokdQuWO7tcT1R/o4umjr1iQKT9Jd8j4iAj8YKR8wtqNQXjc+a3plPSZa LRFnUyd6eDIdfO3as+GTOFX6GL9RYvFgRC1EDrgoE1M0kBxsIcYFWOUtlYnOFRW7tN8ByB qXxXe4btgRS6hQ3UYTKqA7V+F36kKhYT1ulIhbWrobLT26oTVl1fTlVKnFifyyTNVWcNWR +WoxyEMuy0pDsH6UrEBbA6gdXjX0O1nCQwgOdqOj+0DcMI0erH/Mk= Received: from [153.92.39.241] ([153.92.39.241]) by mail.das-netzwerkteam.de (Horde Framework) with HTTPS; Mon, 15 Jan 2024 20:42:37 +0000 Date: Mon, 15 Jan 2024 20:42:37 +0000 Message-ID: <20240115204237.Horde.EDuOJV7EawW0jTxdFl4hW9c@mail.das-netzwerkteam.de> From: Mike Gabriel To: 1586@bugs.x2go.org Subject: Closing... User-Agent: Horde Application Framework 5 Accept-Language: de,en Organization: DAS-NETZWERKTEAM X-Originating-IP: 153.92.39.241 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36 Content-Type: multipart/signed; boundary="=_zayCHgQumqRjvGOX5C4pZWP"; protocol="application/pgp-signature"; micalg=pgp-sha512 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_zayCHgQumqRjvGOX5C4pZWP Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Control: close -1 We are migrating our debbugs bug tracker instance to X2Go GitLab's=20=20 issue=20tracker. This issue is probably resolved by MR!5 at https://gitlab.x2go.org/x2go/client/libs/python-x2go/-/merge_requests/5 Thus, closing... Mike --=20 DAS-NETZWERKTEAM c\o=20Technik- und =C3=96kologiezentrum Eckernf=C3=B6rde Mike Gabriel, Marienthaler Str. 17, 24340 Eckernf=C3=B6rde mobile: +49 (1520) 1976 148 landline: +49 (4351) 850 8940 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de --=_zayCHgQumqRjvGOX5C4pZWP Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIzBAABCgAdFiEEm/uu6GwKpf+/IgeCmvRrMCV3GzEFAmWlmLwACgkQmvRrMCV3 GzGofQ/+MOVn8XlpIZlgyoRgXpHPsEw9UnRRqmIBL495RtEWYkj/Sa/lWVU5YK6Y OKXKbsJQESSrwQIGJ8IIKEan3BSpmG7z5kSWNuI/7161JhfrumLsMrIkm1tf0yZ0 7X19kYybjIbRbj5Td/vyhU+00H+u3Kw3fkDu/MuhDY5Yotl3URybJUjyYnAlO+9d xVi5m1ivBcq8USikY7synd/EB5XQz5bN+uT93iIb07Q38cv19CgBOpZtx6hFzNCk hDTzO5MUi7AjKm8igOjpacirW4rGihinvFraQmB5WNWplW7BmR48YL4CCWgsdPlM f0TtNmypcNUOpX8XZUQ58WnvR+tQ+7IVOBhLgAcMK7WLYuXiVU1iGm9LeHIGLbIN Tyh12Dx6g5wdK/7IcrOQm/FlboJEgHHCiGkZiVlkPewvDfJEtrRJgIE6Zh4PtQg/ Q0toP8V14tzkj2xMpUK3Xxg8aK73bvH+w+wqurpYA0YR1FZEYCtFccBVo7X5EB2o bShFj0X6QZShooxV9L8gTSfffY4LBo2/WKTXCLLu8WMfY6qlQNYbgu9kSsIsSZCo YCL0weIJQikifso5EEfPEJHEvPiXSjXisXvFkM9ZAgbKpxuq0dhBTulYGI8P5g90 pexCyIduLB+31AYVDqjS2Boel8+Ro1MtSEpqekrLqEAhK8XIYnk= =ImPQ -----END PGP SIGNATURE----- --=_zayCHgQumqRjvGOX5C4pZWP-- ------------=_1705351502-5489-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by bugs.x2go.org; 15 Apr 2022 00:16:55 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.7 required=3.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 77BCB5DA94 for ; Fri, 15 Apr 2022 02:16:48 +0200 (CEST) Received: by mail-lf1-x12a.google.com with SMTP id bu29so11807614lfb.0 for ; Thu, 14 Apr 2022 17:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=hdEOOGX3yC2hPay2NI1euxsxwESj6Uj7mwsJgENchBk=; b=eU26nOJHebA+sBG4VukkZt8t6FstoMy//YuTaB2IbQYxJRK1r0DsPcMqHVv3sYtSJ9 KJ1SRw0alqR33AvwwuQtkOrb9Z4k7uqT1XQJOFdzPKDQWStYlnY5p50SJ9g/3cAjm1k3 JuzedYjplm7tcVzV5YBNh6y90/vEOUMIs7t0IRAbt0VMTp7KOzQYHn6JXcANIdxn06CM lpOyDuQpTQgVQPQCI0Qs5XBEhZzNOQwAuagYR2MxGVV/XuEi7SLDRUygsLPNhTUFWGyl Tk05PCdow+P9fXg87uU/o3Il01LtHO0O4iUb5VP+O9EPOa3BdnTlozFxl+NFPhcJvpxd u+pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=hdEOOGX3yC2hPay2NI1euxsxwESj6Uj7mwsJgENchBk=; b=dyAqIksdC5wF5IuapvK0iPg/7Gdu5lADHv9JUlt0bkWaNpWUIATJQJWWJKxBWZiXF8 KV4V7Sm3/hq0QU/QaZDttcDpye6QojUCC16VCUypMtfeKhc2pHXT7p45QdgKz8xXOLuB +oqHNUUzol4SdMSxFB225nGS6qQAqzmjSF1iLuPoar3JFpQW9zTfWhzgcVDMFZT1VqEh cJWSAuop5JwDcx+10nYn14UCJ2kOnSCJO89bOf6bWGl1hifMy4BqB1dEbqJvOrNszByO KtEI6M3yuamzpb9egeSl/8TOWviPsstXP3z8J3Sl5TMKQvsIUImtrjwKCHnxyqsa1wnc CKsg== X-Gm-Message-State: AOAM532wVGehg+kD2kPeeGf195BWIa4gQe99Wf9g38M2kRUCnsWXWD2r CenRP2RwbKMV3JfvXLheV4IkS8aAGw9ve+TssLjIWuSALcPh X-Google-Smtp-Source: ABdhPJwiHTr89Gpo97fXNhy1YsbXUB0ZvRFAdTquB3/NG1AXZJ221L+iWDhWnLwDPDSisGzCYZ/OdRjmqghcwOwkuFk= X-Received: by 2002:a05:6512:1504:b0:44b:36e:b50d with SMTP id bq4-20020a056512150400b0044b036eb50dmr3431893lfb.558.1649981807283; Thu, 14 Apr 2022 17:16:47 -0700 (PDT) MIME-Version: 1.0 From: Eric Monson Date: Thu, 14 Apr 2022 18:16:35 -0600 Message-ID: Subject: pyhoca-cli does not honor the -k (--ssh-privkey) option To: submit@bugs.x2go.org Content-Type: multipart/alternative; boundary="0000000000008251ea05dca65366" --0000000000008251ea05dca65366 Content-Type: text/plain; charset="UTF-8" Package: pyhoca-cli Version: 0.4.0.3 I've created a session and defined a private key (not at the location ~/.ssh/id_rsa). In the command line, I run "pyhocal-cli -k ...". However, pyhoca-cli still attempts to use ~/.ssh/id_rsa. Here's what I believe happens: x2go/defaults.py: autologin is defaulted to True x2go/utils.py: autologin is translated to 'look_for_keys', so look_for_keys is now set to True x2go/backends/control/plain.py (in the function connect): We hit is following if statement: if look_for_keys: key_filename = None pkey = None (so key_filename and pkey are cleared) Finally in backends/control/plain.py, we hit the if statement that calls one of 3 paramiko connect calls. However, since key_filename and pkey are set to None, but look_for_keys is set to true, the software ends up trying to use the ~/.ssh/id_rsa file, if that doesn't work, it will then ask for a password, but never uses the passed in private key. If you comment out the if statement in "plain.py": if look_for_keys: key_filename = None pkey = None then the software does in fact use the private key passed in at the command line. I don't know why that if statement is there. I'm sure there is a reason, but don't know the codebase well enough to say that would be a global fix. --0000000000008251ea05dca65366 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Package: pyhoca-cli
Version: 0.4.0.3
I've created a session and defined a=C2=A0private=C2=A0key = (not at the location ~/.ssh/id_rsa). In the command line, I run "pyhoc= al-cli=C2=A0-k <private_key> ...".=C2=A0 However, pyhoca-cli sti= ll attempts to use ~/.ssh/id_rsa.

Here's what = I believe happens:
x2go/defaults.py: autologin is defaulted to Tr= ue
x2go/utils.py: autologin is translated to 'look_for_keys&#= 39;, so look_for_keys is now set to True
x2go/backends/control/pl= ain.py (in the function connect): We hit is following if statement:
=C2=A0 if look_for_keys:
=C2=A0 =C2=A0 key_filename =3D None
=C2= =A0 =C2=A0 pkey =3D None
(so key_filename and pkey are cleare= d)

Finally in backends/control/plain.py, we hit th= e if statement that calls one of 3 paramiko connect calls. However, since k= ey_filename and pkey are set to None, but look_for_keys is set to true, the= =C2=A0software ends up trying to use the ~/.ssh/id_rsa file, if that doesn&= #39;t work, it will then ask for a password, but never uses the passed in p= rivate key.

If you comment out the if statement in= "plain.py":
=C2=A0 if look_for_keys:
=C2=A0 =C2=A0 = key_filename =3D None
=C2=A0 =C2=A0 pkey =3D None

then the software does in fact use the private key passed in at the = command line. I don't know why that if statement is there. I'm sure= there is a reason, but don't know the codebase well enough to say that= would be a global fix.
--0000000000008251ea05dca65366-- ------------=_1705351502-5489-0--