From unknown Tue Mar 10 17:25:04 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#1571: Terminate session button selected by default on timeout Reply-To: Joe Dight , 1571@bugs.x2go.org Resent-From: Joe Dight Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Wed, 24 Nov 2021 13:55:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: report 1571 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: patch Received: via spool by submit@bugs.x2go.org id=B.163776194610094 (code B); Wed, 24 Nov 2021 13:55:02 +0000 Received: (at submit) by bugs.x2go.org; 24 Nov 2021 13:52:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=BAYES_05,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from balrog.mythic-beasts.com (balrog.mythic-beasts.com [IPv6:2a00:1098:0:82:1000:0:2:1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 0F7C95DAE5 for ; Wed, 24 Nov 2021 14:52:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ntmail.uk; s=mythic-beasts-k1; h=Subject:To:From:Date; bh=jR3fFGyBARbcce1dG+rzQma/C0UceoqZKVLfeD/4BGc=; b=dZec3YZ+6+bvIicmvuq2hoVpbM GuZ4wx7wqrotLaWo2LwwB9sqthhsJhZqYVbawEHJF4BvzEjLeggxTcrfcwlOgK0RI6yP9cr+iPol+ Ixu3ifXuzpaZqoiguoT3ugDbH7+IZHR03PJhSdVhJTyZmPGIyAS8Ypps/mdk13pMt3f7/BSlPM0U0 L5uenOWvLmDL9jzHdU/pwspRcsewqpEhrpdmnhBFjEbfaVqyA1XdyDIZQRX/ntv0ud5dYATxZyrCx dhoWB2p6E6JmM1rgcldonlisO8+CGRTLZclwp5Z5rDHxWdc8VlPcC2CeP3Rh9jQLyc94x3juYP3Th AUuY3XZg==; Received: from [92.22.46.35] (port=57986 helo=[192.168.1.109]) by balrog.mythic-beasts.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1mpsgr-00040K-25 for submit@bugs.x2go.org; Wed, 24 Nov 2021 13:52:05 +0000 Content-Type: multipart/mixed; boundary="------------z1qgBqWC1HNp6U400IhsgxJJ" Message-ID: Date: Wed, 24 Nov 2021 13:51:53 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Content-Language: en-GB From: Joe Dight To: submit@bugs.x2go.org X-BlackCat-Spam-Score: 0 This is a multi-part message in MIME format. --------------z1qgBqWC1HNp6U400IhsgxJJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Package: x2goclient Version: 4.1.2.2 Tag: patch If the connection drops a dialog box asks to terminate the session or continue, with terminate selected by default. Continue should be selected by default. This doesn't seem to be intended (the constructor is called incorrectly), and the attached patch fixes it for me. --------------z1qgBqWC1HNp6U400IhsgxJJ Content-Type: text/x-patch; charset=UTF-8; name="messagebox.diff" Content-Disposition: attachment; filename="messagebox.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NyYy9vbmdldHBhc3MuY3BwIGIvc3JjL29uZ2V0cGFzcy5jcHAKaW5k ZXggNmU4YzRlZS4uNzU1OTBlOSAxMDA2NDQKLS0tIGEvc3JjL29uZ2V0cGFzcy5jcHAKKysr IGIvc3JjL29uZ2V0cGFzcy5jcHAKQEAgLTgzLDcgKzgzLDcgQEAgaW50IHgyZ29NYWluICgg aW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSApCiAgICAgICAgICAgICB7CiAgICAgICAgICAgICAg ICAgdGV4dD1RT2JqZWN0Ojp0cigiTm8gcmVzcG9uc2UgcmVjZWl2ZWQgZnJvbSB0aGUgcmVt b3RlIHNlcnZlci4gRG8geW91IHdhbnQgdG8gdGVybWluYXRlIHRoZSBjdXJyZW50IHNlc3Np b24/Iik7CiAgICAgICAgICAgICAgICAgaW50IHJlej1RTWVzc2FnZUJveDo6cXVlc3Rpb24g KCAwLCBjYXB0aW9uLHRleHQsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBRTWVzc2FnZUJveDo6WWVzLAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgUU1lc3NhZ2VCb3g6OlllcyB8IFFNZXNzYWdl Qm94OjpObywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFFNZXNzYWdlQm94OjpObyApOwogICAgICAgICAgICAgICAgIGlmKHJlej09UU1lc3Nh Z2VCb3g6OlllcyAmJiBhcmdzLmNvdW50KCk+OSkKICAgICAgICAgICAgICAgICB7CkBAIC05 OCw3ICs5OCw3IEBAIGludCB4MmdvTWFpbiAoIGludCBhcmdjLCBjaGFyICphcmd2W10gKQog ICAgICAgICAgICAgfQogICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgIHJldHVy biAgUU1lc3NhZ2VCb3g6OnF1ZXN0aW9uICggMCwgY2FwdGlvbix0ZXh0LAotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUU1lc3NhZ2VCb3g6Olll cywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFFN ZXNzYWdlQm94OjpZZXMgfCBRTWVzc2FnZUJveDo6Tm8sCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBRTWVzc2FnZUJveDo6Tm8gKTsKICAgICAg ICAgfQogICAgICAgICByZXR1cm4gLTE7Cg== --------------z1qgBqWC1HNp6U400IhsgxJJ--