Subject: Bug#1571: Terminate session button selected by default on timeout

From: Joe Dight <[email-masked]>
Date: Wed, 24 Nov 2021 13:51:53 +0000

Package: x2goclient
Version: 4.1.2.2
Tag: patch

If the connection drops a dialog box asks to terminate the session or
continue, with terminate selected by default. Continue should be
selected by default.

This doesn't seem to be intended (the constructor is called
incorrectly), and the attached patch fixes it for me.

diff --git a/src/ongetpass.cpp b/src/ongetpass.cpp
index 6e8c4ee..75590e9 100644
--- a/src/ongetpass.cpp
+++ b/src/ongetpass.cpp
@@ -83,7 +83,7 @@ int x2goMain ( int argc, char *argv[] )
             {
                 text=QObject::tr("No response received from the remote server. Do you want to terminate the current session?");
                 int rez=QMessageBox::question ( 0, caption,text,
-                                                QMessageBox::Yes,
+                                                QMessageBox::Yes | QMessageBox::No,
                                                 QMessageBox::No );
                 if(rez==QMessageBox::Yes && args.count()>9)
                 {
@@ -98,7 +98,7 @@ int x2goMain ( int argc, char *argv[] )
             }
             else
                 return  QMessageBox::question ( 0, caption,text,
-                                                QMessageBox::Yes,
+                                                QMessageBox::Yes | QMessageBox::No,
                                                 QMessageBox::No );
         }
         return -1;