From Moritz.Struebe@informatik.uni-erlangen.de Tue Apr 16 09:24:42 2013 Received: (at 155) by bugs.x2go.org; 16 Apr 2013 07:24:42 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: * X-Spam-Status: No, score=1.0 required=5.0 tests=FILL_THIS_FORM_SHORT, URIBL_BLOCKED autolearn=no version=3.3.2 X-Greylist: delayed 603 seconds by postgrey-1.34 at ymir; Tue, 16 Apr 2013 09:24:42 CEST Received: from faui40.informatik.uni-erlangen.de (faui40.informatik.uni-erlangen.de [131.188.34.40]) by ymir (Postfix) with ESMTPS id 2BCDF5DB11; Tue, 16 Apr 2013 09:24:42 +0200 (CEST) Received: from [IPv6:2001:638:a000:4134::ffff:51] (faui48e.informatik.uni-erlangen.de [IPv6:2001:638:a000:4134::ffff:51]) by faui40.informatik.uni-erlangen.de (Postfix) with ESMTP id 67F3D58C6BD; Tue, 16 Apr 2013 09:14:38 +0200 (CEST) Message-ID: <516CFA5E.5040304@informatik.uni-erlangen.de> Date: Tue, 16 Apr 2013 09:14:38 +0200 From: Moritz Struebe Organization: Uni Erlangen-Nuernberg User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 MIME-Version: 1.0 To: Mike Gabriel , 155@bugs.x2go.org, x2go-dev@lists.berlios.de CC: Thomas Hanschke , control@bugs.x2go.org Subject: Re: [X2Go-Dev] Bug#155: 25 user logon problem References: <1364484683.17230.2.camel@thh-imedia-S1300> <20130415230840.103249kxioog6tso@mail.das-netzwerkteam.de> In-Reply-To: <20130415230840.103249kxioog6tso@mail.das-netzwerkteam.de> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha1; boundary="------------ms050308050607050503090609" Dies ist eine kryptografisch unterzeichnete Nachricht im MIME-Format. --------------ms050308050607050503090609 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2013-04-15 23:08, Mike Gabriel wrote: > > @Devs: I suspect we have to query x2gogetport 3x times during one run > of x2gostartagent to make sure that more-than-one instances of > x2gostartagent (run by different users at the very same time, a > typical class room situation) do not interfere with each other.=20 I don't know how you come to the 3x conclusion, but looking at the code I'd suggest that USED_NONSSH_PORTS as well as USED_PORTS either be turned into a function or get updated within the while-loop. That should reduce the amount of failures. > This probably has to happen in x2goresume-session, as well.=20 Considering the amount of perl and code duplication we should consider putting that into a function and sourcing it or rewriting the whole thing in perl. Unfortunately currently time is very scarce for me. Morty --=20 Dipl.-Ing. Moritz 'Morty' Struebe (Wissenschaftlicher Mitarbeiter) Lehrstuhl f=FCr Informatik 4 (Verteilte Systeme und Betriebssysteme) Friedrich-Alexander-Universit=E4t Erlangen-N=FCrnberg Martensstr. 1 91058 Erlangen Tel : +49 9131 85-25419 Fax : +49 9131 85-28732 eMail : struebe@informatik.uni-erlangen.de WWW : http://www4.informatik.uni-erlangen.de/~morty --------------ms050308050607050503090609 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Kryptografische Unterschrift MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIPITCC BCEwggMJoAMCAQICAgDHMA0GCSqGSIb3DQEBBQUAMHExCzAJBgNVBAYTAkRFMRwwGgYDVQQK ExNEZXV0c2NoZSBUZWxla29tIEFHMR8wHQYDVQQLExZULVRlbGVTZWMgVHJ1c3QgQ2VudGVy MSMwIQYDVQQDExpEZXV0c2NoZSBUZWxla29tIFJvb3QgQ0EgMjAeFw0wNjEyMTkxMDI5MDBa Fw0xOTA2MzAyMzU5MDBaMFoxCzAJBgNVBAYTAkRFMRMwEQYDVQQKEwpERk4tVmVyZWluMRAw DgYDVQQLEwdERk4tUEtJMSQwIgYDVQQDExtERk4tVmVyZWluIFBDQSBHbG9iYWwgLSBHMDEw ggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDpm8NnhfkNrvWNVMOWUDU9YuluTO2U 1wBblSJ01CDrNI/W7MAxBAuZgeKmFNJSoCgjhIt0iQReW+DieMF4yxbLKDU5ey2QRdDtoAB6 fL9KDhsAw4bpXCsxEXsM84IkQ4wcOItqaACa7txPeKvSxhObdq3u3ibo7wGvdA/BCaL2a869 080UME/15eOkyGKbghoDJzANAmVgTe3RCSMqljVYJ9N2xnG2kB3E7f81hn1vM7PbD8URwoqD oZRdQWvY0hD1TP3KUazZve+Sg7va64sWVlZDz+HVEz2mHycwzUlU28kTNJpxdcVs6qcLmPkh nSevPqM5OUhqjK3JmfvDEvK9AgMBAAGjgdkwgdYwcAYDVR0fBGkwZzBloGOgYYZfaHR0cDov L3BraS50ZWxlc2VjLmRlL2NnaS1iaW4vc2VydmljZS9hZl9Eb3dubG9hZEFSTC5jcmw/LWNy bF9mb3JtYXQ9WF81MDkmLWlzc3Vlcj1EVF9ST09UX0NBXzIwHQYDVR0OBBYEFEm3xs/oPR9/ 6kR7Eyn38QpwPt5kMB8GA1UdIwQYMBaAFDHDeRu69VPXF+CJei0XbAqzK50zMA4GA1UdDwEB /wQEAwIBBjASBgNVHRMBAf8ECDAGAQH/AgECMA0GCSqGSIb3DQEBBQUAA4IBAQA74Vp3wEgX 3KkY7IGvWonwvSiSpspZGBJw7Cjy565/lizn8l0ZMfYTK3S9vYCyufdnyTmieTvhERHua3iR M347XyYndVNljjNj7s9zw7CSI0khUHUjoR8Y4pSFPT8z6XcgjaK95qGFKUD2P3MyWA0Ja6ba hWzAP7uNZmRWJE6uDT8yNQFb6YyC2XJZT7GGhfF0hVblw/hc843uR7NTBXDn5U2KaYMo4RMJ hp5eyOpYHgwf+aTUWgRo/Sg+iwK2WLX2oSw3VwBnqyNojWOl75lrXP1LVvarQIc01BGSbOyH xQoLBzNytG8MHVQs2FHHzL8w00Ny8TK/jM5JY6gA9/IcMIIFNzCCBB+gAwIBAgIECr6fXjAN BgkqhkiG9w0BAQUFADBaMQswCQYDVQQGEwJERTETMBEGA1UEChMKREZOLVZlcmVpbjEQMA4G A1UECxMHREZOLVBLSTEkMCIGA1UEAxMbREZOLVZlcmVpbiBQQ0EgR2xvYmFsIC0gRzAxMB4X DTA3MDcxOTA4MzMxOVoXDTE5MDYzMDAwMDAwMFowgaMxCzAJBgNVBAYTAkRFMQ8wDQYDVQQI EwZCYXllcm4xETAPBgNVBAcTCEVybGFuZ2VuMSgwJgYDVQQKEx9Vbml2ZXJzaXRhZXQgRXJs YW5nZW4tTnVlcm5iZXJnMQ0wCwYDVQQLEwRSUlpFMQ8wDQYDVQQDEwZGQVUtQ0ExJjAkBgkq hkiG9w0BCQEWF2NhQHJyemUudW5pLWVybGFuZ2VuLmRlMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEAt4zo7dRsCRRgHOL7iMEQXwWSXMbFa8Acei7z6I0pxFUxT18yK4n+fgq4 f/cCDMaWjKJ4KWY6p78qUiFZRG0zCw6YPesxyVen2KUbt4hTvS4TzZrPULDs3ZXej22Ug+UM frVlcrxcJA7Tm7/O5uotER46J1xX6KuW6vnjyG7L6JREwa6jAaAfW2b2XVffvfleqS+QXCdT NSSEWIAHC1qPEhnTbaAwIltrlFeP4tJm/7rsw9OpCZ2gx/dZKzzOkzznj5FJI81uKcoOjgoB GR9o2ROJvfoc8x8xO7lWIFHlMi5En+AAe1XdgL5RxyOmP/LhdQ34Siqyo4OUWxW/33goCQID AQABo4IBuTCCAbUwEgYDVR0TAQH/BAgwBgEB/wIBATALBgNVHQ8EBAMCAQYwHQYDVR0OBBYE FPRz8/rGQrPGXGnAWL50OPlhK45iMB8GA1UdIwQYMBaAFEm3xs/oPR9/6kR7Eyn38QpwPt5k MCIGA1UdEQQbMBmBF2NhQHJyemUudW5pLWVybGFuZ2VuLmRlMIGIBgNVHR8EgYAwfjA9oDug OYY3aHR0cDovL2NkcDEucGNhLmRmbi5kZS9nbG9iYWwtcm9vdC1jYS9wdWIvY3JsL2NhY3Js LmNybDA9oDugOYY3aHR0cDovL2NkcDIucGNhLmRmbi5kZS9nbG9iYWwtcm9vdC1jYS9wdWIv Y3JsL2NhY3JsLmNybDCBogYIKwYBBQUHAQEEgZUwgZIwRwYIKwYBBQUHMAKGO2h0dHA6Ly9j ZHAxLnBjYS5kZm4uZGUvZ2xvYmFsLXJvb3QtY2EvcHViL2NhY2VydC9jYWNlcnQuY3J0MEcG CCsGAQUFBzAChjtodHRwOi8vY2RwMi5wY2EuZGZuLmRlL2dsb2JhbC1yb290LWNhL3B1Yi9j YWNlcnQvY2FjZXJ0LmNydDANBgkqhkiG9w0BAQUFAAOCAQEARMHGwyEK31G2lGZ8MeYwocnQ MBLi0JIQdP5XtbPJ7cd3IoKhl0XU1+ZpCzN35kgrwmpjHpar73uSrmjcZEjZKxGzis70osCX wCmDGrzk4oLggiRxkXjpMZoGBAeIUwOppw9P73Gm13yjbDjjHlCwOxSMq4nmc8kw6eMvK5my nO+0as8Iq6BndmKM8CfMQdaR4DFMWnF/c5FTQQxfcp14PIhvPkEY8KXIwHXSyhpTbQaUnkAP LKagH+e8HPRti6uHDZfqQkwyZoKApwg4Klq851LKSvNNQGUSkUOnlYg+NcaLpjiRBZ2n+GTS Y02WFwXTAH66k/Nclhmq9IeWkW3iZjCCBb0wggSloAMCAQICBxL4KPF3HOUwDQYJKoZIhvcN AQEFBQAwgaMxCzAJBgNVBAYTAkRFMQ8wDQYDVQQIEwZCYXllcm4xETAPBgNVBAcTCEVybGFu Z2VuMSgwJgYDVQQKEx9Vbml2ZXJzaXRhZXQgRXJsYW5nZW4tTnVlcm5iZXJnMQ0wCwYDVQQL EwRSUlpFMQ8wDQYDVQQDEwZGQVUtQ0ExJjAkBgkqhkiG9w0BCQEWF2NhQHJyemUudW5pLWVy bGFuZ2VuLmRlMB4XDTExMTIwMjEwNDEzOFoXDTE0MTIwMTEwNDEzOFowfDELMAkGA1UEBhMC REUxKDAmBgNVBAoTH1VuaXZlcnNpdGFldCBFcmxhbmdlbi1OdWVybmJlcmcxKjAoBgNVBAsT IURlcGFydG1lbnQgb2YgQ29tcHV0ZXIgU2NpZW5jZSA0IDEXMBUGA1UEAxMOTW9yaXR6IFN0 cnVlYmUwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCfzPZGUhN/6df7oXojpNRT SyvDGmg/fhiOeAxQnN+DX9bLSMQtKs/xqrFhubYtEgcb94ontUuGrsGFxJERfJtuK1OeqyMB /Rne6GiSjH88Ut6nmykynS+2GeDsB6xgYn7CTIcZP6pC95zxK0qn+XSzaoMTiV1jcc3uxRLV UlvlAn4W8Z2rIvocTnLnIX6rk6nopjmfQQ1JeLOKOC8ztkZDhXvCg5vkZ38okkD9GEB118VE xZdulknZJCyrdNBBNsJgy9DnMqPzsQXjmZQP0aTMx0wWVfy5xxrT4qM+FKDIBY6RG4n+pfnO Af35Yc8aL6+XtYyKH67Y+gfk1vnEGa+/AgMBAAGjggIaMIICFjAJBgNVHRMEAjAAMAsGA1Ud DwQEAwIF4DApBgNVHSUEIjAgBggrBgEFBQcDAgYIKwYBBQUHAwQGCisGAQQBgjcUAgIwHQYD VR0OBBYEFMLK3xJsufrPkUH99qzwp1lh2GNLMB8GA1UdIwQYMBaAFPRz8/rGQrPGXGnAWL50 OPlhK45iMDQGA1UdEQQtMCuBKU1vcml0ei5TdHJ1ZWJlQGluZm9ybWF0aWsudW5pLWVybGFu Z2VuLmRlMIGfBgNVHR8EgZcwgZQwSKBGoESGQmh0dHA6Ly9jZHAxLnBjYS5kZm4uZGUvdW5p LWVybGFuZ2VuLW51ZXJuYmVyZy1jYS9wdWIvY3JsL2NhY3JsLmNybDBIoEagRIZCaHR0cDov L2NkcDIucGNhLmRmbi5kZS91bmktZXJsYW5nZW4tbnVlcm5iZXJnLWNhL3B1Yi9jcmwvY2Fj cmwuY3JsMIG4BggrBgEFBQcBAQSBqzCBqDBSBggrBgEFBQcwAoZGaHR0cDovL2NkcDEucGNh LmRmbi5kZS91bmktZXJsYW5nZW4tbnVlcm5iZXJnLWNhL3B1Yi9jYWNlcnQvY2FjZXJ0LmNy dDBSBggrBgEFBQcwAoZGaHR0cDovL2NkcDIucGNhLmRmbi5kZS91bmktZXJsYW5nZW4tbnVl cm5iZXJnLWNhL3B1Yi9jYWNlcnQvY2FjZXJ0LmNydDANBgkqhkiG9w0BAQUFAAOCAQEAkhCt 8To6NRpOL/p31V5rKM8LWWyBrWW9ppyJaeFHeqmAiPPC+HMpO/364s14VTT637s2/zYMgbbl pU6AfY9c1uAmjK/PoF21R2r7PIebtCDU8ScFYaJ121L0MsvTPq8mPRUp0vm8pFMO6I4+FQnh YElXD5Avw/R7SO45cR82iZbI/jDDxaGehTZwflULM/6GZU6LcjbRI5OkEs/C5FksP67WwneO COD5RL8PB2Ta/ur9+m/9A6tvOACRLjXFjl080e6xSAs9bSJdrHQQ3d2PencaSCb5XVm1K/pO nTR6YicTk39CG6zbq/zdyzL1tK4oBg2BdTOgg0d8ZYlwGU084jGCBC4wggQqAgEBMIGvMIGj MQswCQYDVQQGEwJERTEPMA0GA1UECBMGQmF5ZXJuMREwDwYDVQQHEwhFcmxhbmdlbjEoMCYG A1UEChMfVW5pdmVyc2l0YWV0IEVybGFuZ2VuLU51ZXJuYmVyZzENMAsGA1UECxMEUlJaRTEP MA0GA1UEAxMGRkFVLUNBMSYwJAYJKoZIhvcNAQkBFhdjYUBycnplLnVuaS1lcmxhbmdlbi5k ZQIHEvgo8Xcc5TAJBgUrDgMCGgUAoIICUzAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwG CSqGSIb3DQEJBTEPFw0xMzA0MTYwNzE0MzhaMCMGCSqGSIb3DQEJBDEWBBQxezAHHcxj+qIM QvhQQaZFOHTLFjBsBgkqhkiG9w0BCQ8xXzBdMAsGCWCGSAFlAwQBKjALBglghkgBZQMEAQIw CgYIKoZIhvcNAwcwDgYIKoZIhvcNAwICAgCAMA0GCCqGSIb3DQMCAgFAMAcGBSsOAwIHMA0G CCqGSIb3DQMCAgEoMIHABgkrBgEEAYI3EAQxgbIwga8wgaMxCzAJBgNVBAYTAkRFMQ8wDQYD VQQIEwZCYXllcm4xETAPBgNVBAcTCEVybGFuZ2VuMSgwJgYDVQQKEx9Vbml2ZXJzaXRhZXQg RXJsYW5nZW4tTnVlcm5iZXJnMQ0wCwYDVQQLEwRSUlpFMQ8wDQYDVQQDEwZGQVUtQ0ExJjAk BgkqhkiG9w0BCQEWF2NhQHJyemUudW5pLWVybGFuZ2VuLmRlAgcS+CjxdxzlMIHCBgsqhkiG 9w0BCRACCzGBsqCBrzCBozELMAkGA1UEBhMCREUxDzANBgNVBAgTBkJheWVybjERMA8GA1UE BxMIRXJsYW5nZW4xKDAmBgNVBAoTH1VuaXZlcnNpdGFldCBFcmxhbmdlbi1OdWVybmJlcmcx DTALBgNVBAsTBFJSWkUxDzANBgNVBAMTBkZBVS1DQTEmMCQGCSqGSIb3DQEJARYXY2FAcnJ6 ZS51bmktZXJsYW5nZW4uZGUCBxL4KPF3HOUwDQYJKoZIhvcNAQEBBQAEggEAcl5dZViK6g/t TngMKyhdfA4WMrmK4b7x8uNUqcQf5WgQaz5uJH5jZl1/OLDKW9BzxnWyvwBD5lG/6HMbBxSM CCzOZB8ctKnqBb5+3q465Vq7mwxShjv1xhHM1AoU3cZq64R7jd5nOIsZu7SBwbhVMC+gsmdz iMasx1ElHqqVTtgmAEf1XfagCTsQkLiEyU93dpGJO8On7r+C2juc2OItDvVvufr5vZvuL90B C3cTEIp4wLjKmxHkYBFPXfkLqnyeWEXZqpoP+gVfWc37eOPnbfqTZ6QOr3+hThlof6vx6Kye ZWlhg+FzUg9Ga/7HJH7DVqhyy87cZ40VJGHikVMMGgAAAAAAAA== --------------ms050308050607050503090609--