Subject: Logfile corruption

From: Ulrich Sibiller <[email-masked]>
Date: Fri, 2 Apr 2021 17:47:15 +0200

Package: x2goserver
Version: 4.1.0.3

See attached patch for a fix to the session.log being corrupted when
nxagent is printing a lot of debug output.
From 03f01e18f10f77cab789fa14d2074f359f8bc2c7 Mon Sep 17 00:00:00 2001
From: Ulrich Sibiller <[email-masked]>
Date: Fri, 12 Mar 2021 11:17:32 +0100
Subject: [PATCH 1/4] Prevent logfile corruption.

Both stderr redirection and and errors= in the options file wrote to
the same file which lead to corruption with lots of debug output.
---
 x2goserver/bin/x2gostartagent | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/x2goserver/bin/x2gostartagent b/x2goserver/bin/x2gostartagent
index 887cb32..7be7900 100755
--- a/x2goserver/bin/x2gostartagent
+++ b/x2goserver/bin/x2gostartagent
@@ -417,7 +417,7 @@ if [[ -n "${X2GO_NXOPTIONS}" ]]; then
 	X2GO_NXOPTIONS="${X2GO_NXOPTIONS%,},"
 fi
 
-echo "nx/nx,link=${X2GO_LINK},pack=${X2GO_PACK},limit=0,root=${SESSION_DIR},cache=8M,images=32M,type=${X2GO_TYPE},id=${SESSION_NAME},cookie=${X2GO_COOKIE},errors=${SESSION_LOG},kbtype=${kbtype_option},${option_geometry}xinerama=${xinerama_option},resize=${X2GO_RESIZE},fullscreen=${X2GO_FULLSCREEN},accept=${REMOTE},listen=${GR_PORT}${clipboard},client=linux,menu=0,${X2GO_NXOPTIONS}state=${STATE_FILE}:${X2GO_PORT}" >"${SESSION_DIR}/options"
+echo "nx/nx,link=${X2GO_LINK},pack=${X2GO_PACK},limit=0,root=${SESSION_DIR},cache=8M,images=32M,type=${X2GO_TYPE},id=${SESSION_NAME},cookie=${X2GO_COOKIE},errors=${SESSION_LOG}_errors,kbtype=${kbtype_option},${option_geometry}xinerama=${xinerama_option},resize=${X2GO_RESIZE},fullscreen=${X2GO_FULLSCREEN},accept=${REMOTE},listen=${GR_PORT}${clipboard},client=linux,menu=0,${X2GO_NXOPTIONS}state=${STATE_FILE}:${X2GO_PORT}" >"${SESSION_DIR}/options"
 
 NX_AGENT=":${X2GO_PORT}"
 SAVED_DISPLAY="${DISPLAY}"
-- 
2.9.3