From giuseppe.ragusa@hotmail.com Mon Mar 1 08:57:54 2021 Received: (at submit) by bugs.x2go.org; 1 Mar 2021 07:57:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on ymir.das-netzwerkteam.de X-Spam-Level: * X-Spam-Status: No, score=1.7 required=3.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,FORGED_HOTMAIL_RCVD2,FREEMAIL_FROM,SPF_HELO_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from wforward4-smtp.messagingengine.com (wforward4-smtp.messagingengine.com [64.147.123.34]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 257BE5DA77 for ; Mon, 1 Mar 2021 08:57:42 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailforward.west.internal (Postfix) with ESMTP id 7A261600 for ; Mon, 1 Mar 2021 02:57:39 -0500 (EST) Received: from imap38 ([10.202.2.88]) by compute4.internal (MEProxy); Mon, 01 Mar 2021 02:57:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=GXRJFBqozGXUGKYrff0SP4QkMprPv 0MgIUQ0ubJDzTQ=; b=vtoiKL9KiMkpD6bJLH8F9eM7WpEUZoEtT+ndDHGHZS6/E gdHQ9jQ9rDlr0wb4eab62LbNXSCQG2WMLNaQpPtpH9lEmainGiaE8RVsuiOs1o2z EczUXOfMOB2GVM7riXE7A6Rq3GD9GIze454YWGPjVdWrtN1ZhdELmjDbY+V/lRmB 2Jj6snYnKsDwNe7dNapmIhsGlUkZKH6vqViLRJbcuAxE37yTuMQ3MBLXhzrw3XsW KW/HSVhRyYUUDQLx3gwm6dIUVXlmTOPd+H3PEUPT0RamIZk0GRIzG+d03p+wKTSt sdpr58g7pVFzzqH3k5gBbdTOkcxFTcvDusB4eY43A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrleejgdduudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfffhffvufgtsehmtderre erredtnecuhfhrohhmpedfifhiuhhsvghpphgvucftrghguhhsrgdfuceoghhiuhhsvghp phgvrdhrrghguhhsrgeshhhothhmrghilhdrtghomheqnecuggftrfgrthhtvghrnhepie fgjeehteehheeiuefggeeiheduleekgfehjedvteeukedvgfeigeffgfelhedtnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhiuhhsvghpph gvrdhrrghguhhsrgeshhhothhmrghilhdrtghomh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id F1FC1CA005D; Mon, 1 Mar 2021 02:57:37 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-206-g078a48fda5-fm-20210226.001-g078a48fd Mime-Version: 1.0 Message-Id: Date: Mon, 01 Mar 2021 08:56:54 +0100 From: "Giuseppe Ragusa" To: submit@bugs.x2go.org Subject: x2gocleansessions has hardcoded sleep time Content-Type: multipart/mixed; boundary=dc8cd126e3c042abb9af44f5fadf2a59 --dc8cd126e3c042abb9af44f5fadf2a59 Content-Type: text/plain Package: x2goserver Version: 4.1.0.4 Tag: patch Severity: wishlist The x2gocleansessions program has a hardcoded sleep time of 2 seconds. Several requests to make it configurable have been seen in mailing list. In my specific case, a machine with many active sessions from AD users (SSSD on CentOS7) experiences almost constant undesired extra load (sssd_be): the issue goes away when configuring a 3600 seconds sleep time in /etc/x2go/x2goserver.conf by adding a section like this: [x2gocleansessions] sleep-time = 3600 Please find attached a git-formatted patch against latest version. I can provide a patch for older versions (is_int missing in Utils). Many thanks. Best regards, Giuseppe Ragusa --dc8cd126e3c042abb9af44f5fadf2a59 Content-Disposition: attachment;filename="x2gocleansessions.patch" Content-Type: application/octet-stream; name="x2gocleansessions.patch" Content-Transfer-Encoding: BASE64 ZGlmZiAtLWdpdCBhL3gyZ29zZXJ2ZXIvc2Jpbi94MmdvY2xlYW5zZXNzaW9ucyBiL3gyZ29z ZXJ2ZXIvc2Jpbi94MmdvY2xlYW5zZXNzaW9ucwppbmRleCA2OGVkOWVmNC4uMWE4YjUyM2Eg MTAwNzU1Ci0tLSBhL3gyZ29zZXJ2ZXIvc2Jpbi94MmdvY2xlYW5zZXNzaW9ucworKysgYi94 Mmdvc2VydmVyL3NiaW4veDJnb2NsZWFuc2Vzc2lvbnMKQEAgLTEzOCw2ICsxMzgsMTIgQEAg ZWxzaWYgKCRwaWQgPT0gMCApCiAJCX0KIAl9CiAKKwlteSAkc2xlZXBfdGltZT0kQ29uZmln LT5wYXJhbSgieDJnb2NsZWFuc2Vzc2lvbnMuc2xlZXAtdGltZSIpOworCWlmICghKGlzX2lu dCAoJHNsZWVwX3RpbWUsIDApKSkgeworCQlsb2dfbWVzc2FnZSAoJ3dhcm5pbmcnLCAiQ2xl YW5zZXNzaW9ucyBzbGVlcCB0aW1lIFwiJHNsZWVwX3RpbWVcIiBpbnZhbGlkL25vdCBhbiBp bnRlZ2VyLCBvdmVycmlkaW5nIHdpdGggZGVmYXVsdCBvZiAyLiIpOworCQkkc2xlZXBfdGlt ZSA9IDI7CisJfQorCiAJbXkgJHN1cGVyZW5pY2VfZW5hYmxlID0gaXNfdHJ1ZSgkQ29uZmln LT5wYXJhbSgic3VwZXJlbmljZXIuZW5hYmxlIikpOwogCW15ICRzdXBlcmVuaWNlX2ZvcmNl dXNlciA9IGlzX3RydWUoJENvbmZpZy0+cGFyYW0oInN1cGVyZW5pY2VyLmZvcmNlLXVzZXIt cmVuaWNlIikpOwogCkBAIC0xODAsNyArMTg2LDcgQEAgZWxzaWYgKCRwaWQgPT0gMCApCiAJ bXkgJHVzZXI7CiAJbXkgJGVmZmVjdGl2ZV91c2VyOwogCi0Jd2hpbGUoc2xlZXAgMikKKwl3 aGlsZShzbGVlcCAkc2xlZXBfdGltZSkKIAl7CiAJCW15ICRvdXRwPXN5c3RlbV9jYXB0dXJl X3N0ZG91dF9vdXRwdXQoIiR4MmdvX2xpYl9wYXRoL3gyZ29saXN0c2Vzc2lvbnNfc3FsIiwg IiRzZXJ2Iik7CiAJCW15IEBvdXRwPXNwbGl0KCJcbiIsIiRvdXRwIik7Cg== --dc8cd126e3c042abb9af44f5fadf2a59--