Subject: Bug#1508: non Latin 1 passwords are rejected

From: Sylvain Cuaz <[email-masked]>
Date: Fri, 27 Nov 2020 14:26:18 +0100

Package: x2goclient
Version: 4.1.2.2

Passwords with accents are rejected by x2goclient while working fine directly with ssh.

Client OS Ubuntu 20.04.1 LTS with libssh 0.9.3-2ubuntu2.1
Server OS Ubuntu 16.04.6 LTS

According to the documentation of ssh_userauth_password(), passwords should be passed as UTF-8. But 
sshmasterconnection.cpp passes auth_password.toLatin1(). I think just changing to 
auth_password.toUtf8() should suffice.

Same thing goes for ssh_userauth_kbdint_setanswer() and maybe other calls.

https://api.libssh.org/stable/group__libssh__auth.html#ga50c0c150f8c4703e7ee49b3e3e3ca215

https://api.libssh.org/stable/group__libssh__auth.html#ga75e44b1f27059a00080f80fac0107a20