From X2Go-ML-1@baur-itcs.de Thu Oct 15 11:54:30 2020 Received: (at submit) by bugs.x2go.org; 15 Oct 2020 09:54:33 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.75]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 385AE5DAFB for ; Thu, 15 Oct 2020 11:54:30 +0200 (CEST) Received: from [192.168.0.15] ([82.212.29.219]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.145]) with ESMTPSA (Nemesis) id 1Mq2Sa-1k7hsy2sKI-00n7Mj for ; Thu, 15 Oct 2020 11:53:58 +0200 To: submit@bugs.x2go.org From: Stefan Baur Subject: Wishlist Bug: look for Branding-/Background-SVGs in well-known locations Autocrypt: addr=X2Go-ML-1@baur-itcs.de; prefer-encrypt=mutual; keydata= xsBNBFLfOiwBCACzIiDVwWVRvuMzgSAvXRFRaPaZOSB8s84PG1oGLfmqhwzF44vj1Xv4tcKD mvu0TsLTksOkvop8WwGYeeU8lDaxEG1zyN8SOu1WU/FPEKw2jITRox8yIrSkUsMkWYuxdjv/ 9XcAh9qaPsHP7E1jD6/wVZuYZkuX6W41Nxt06VsvDGCfrbQh4ya7w1IiSnoQeIHNNQVN9f3j xcHLj5S5YriSCThtbFCdr3AJXfF5iMolu8kLgAXM0bH1C7PxAjM/pQjWmdMVN/Y+uXXzcMO8 8aQ0f0q3QeGWxCAP2xwBapUfP6LHDRPp/tV7P7ji8wKlabrSGdv0M9Qd9pn/YCYQE0ZdABEB AAHNJlN0ZWZhbiBCYXVyIDxwb3N0bWFzdGVyQHN0ZWZhbmJhdXIuZGU+wsCCBBMBAgAsAhsj BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4ACGQEFAlwtWmgFCRK0IbcACgkQbt30GM2+URkj nwgAixhVoMxijCsh9jxxCUYBj7lC5HYhJmlAB+bZOfl1XI8xqMLw8YGECfu0VSe++FlaOAuc gArofqu79E2+wKxPaqW2lC94eKR1+kgkDOJyqckYj2Xmyi+vDfrOWjbyawIwiq5FUW2CB6zv nkTr68ZQ43mAVC1zz2tpAikn2Af4/OdHwUBzSAOpUt4rDbXDe93WW34XuyG2RDma6kE1Cr0u ilqvzKOz5SYp5ASmCyaA0wCzs7fjTy2KuMlOCSFRzwPJpzddr8rS9ZiTLdia/BZvShBEjOq4 MZHWYv+RGK5RB4eDzw0KbPszXRJBUdXiZIcI0jqbC57Ht64ok3lXquXp987ATQRS3zosAQgA 4KPXmGU1XE8CTRJ/4m/f8MTri3JfEvGJTerWwC2hBuXHGWrSBmmRNAdJHzNTvq5IoR9tQ6Cb Nrqxf6alr/v34Vr2bUg0s+jlK9TWOkVLAFoz6zytm/2BrRBIZ5So6Ymfc6efwsScsHOI++wi pzqELkpluqtXysb13RsBVLxBdp5TZCVPjCc9pLWjudfjEagQt2oJgtO2WndasrKvoZYkfRi6 oSCK9B84YjNJoRF00LdK3n7K3SBvj4UPSl+ygzLVaD+3ZdIlbhX+bfn/Vp/10xdJ+/U8Fr7l 7umrBKr17D8eO3mRYMGY9w1qc+pfNGOR76GIbPWj2tPVaBD9nmUaowARAQABwsBlBBgBAgAP AhsMBQJcLVqtBQkStCH9AAoJEG7d9BjNvlEZInkIAIcchwZxurIpwJJR8qMMXD+RSvj7mY55 VIXOKUX0uAUTEoJTzFcqbdGkzcJB9y0NlUo9dv4chPT21M61y0bjJjhaDUshCLa1+YyFSSWp GBOKrLIsWusqC9zVwgf7TtjVmXt23jZwoDWjXoMlg9eQONMi5Z4u+lDOyPKD+lGJAcjJkQsI zL9hha3vuhmUclxgdALTJWzQBp+Y7u9QDub4uqf/TyuDpYASiP0winBRfTug+XjP5YZjU//P 07H9WhiUCsHp6L9j3QzvrovVy2zz0j7JhyhW3e957vHz2skkSVv3QGtHMswcgK3XaQ9YdgWO ELHmBhevaIcJIxDvTBl3pYQ= Message-ID: <79f56027-637e-9fb2-a87b-aaf044f7edc7@baur-itcs.de> Date: Thu, 15 Oct 2020 11:53:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:8EUJBIeSFlcA2ZN+pdYkHPjdeDVHd9G86p22s3R6ujW34EQyNAl F2XpkCU3Z/q36db3vyuCOe8UK4UMqO99+MZFMGE0WuhwET4vgHn9o/25LNiLVygmkgjahCu GPZvGWnoS5NUO3YmbF+STmFCml9TfCQ+qHYKhtYhyIx42tQX2kYcMzSaDNQ1RXgiaSdGYA4 z4TCQawh8evyzBwEJnYJQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:OtygUmoRR5c=:5eQmkUWOW4j63Y5GXX+cK3 sEDc0vvaOxcAdPTRUghfQ41faNJqh1wOgNJrhSFhNUxabqrjkGyqiqujS0EgmNH31QPXB3dK6 4o+e1wk62fqjEJ7F4+jatNH1PxqdJN8xm1K7EZMNCi7FEohDfcUj0ObxLjFOEujpO8ztxuU1N 07IrinXCLNUVzlfZwIQYyFBiCp0If86ndpdNdh63YQZOzLi6lOyHOWAoG/kVALlTN1LLJSQ9X JbKh3m1YLDJQkWtAsI1ga6J+g38fZir2hM/ORjzfgmf3d6wihnxChkDRkmW7kJoc+QVGfyWFu PmZFYOMYXU0HIaq3Hqg3I5v/I65vXFN6Hguua5DnHxd5BqUv4awtKd9KxvoZeIhmX3pOsuQ7t ZmImObL1dbM0wgPvahfT7fyFKLyCnD9HqSF7muaRXwIzFQooRo4EOyM3cETK1/AFJFqxkVWXA 69K/gwM3hw== package: x2goclient priority: wishlist At the moment, X2GoClient has two SVGs "baked in", namely the ones for the background image and the branding in the lower left corner. These can be overridden with command line parameters. I would suggest a folder /usr/share/x2goclient/logos on Linux/macOS, and \x2goclient\logos on Windows, where these SVGs are placed instead. On Linux, /etc/x2goclient/logos should be a symlink to /usr/share/x2goclient/logos. On Client startup, it would then scan /etc/x2goclient/logos (or \x2goclient\logos) for these files, and use them. That way, swapping out these logos does not require adding --background or --branding to the call - on Windows, you would simply overwrite them with the logos of your choice, on Linux/macOS, you would replace the symlink with an actual directory and place your custom logos there - just like we do it for /etc/x2go/applications on the server. The command line parameters should remain in the code to support legacy installations. It MAY make sense to keep a minimum set of logos "baked in" (maybe a black on white "ERROR" text) to indicate when the file-based ones could not be found. Kind Regards, Stefan Baur -- BAUR-ITCS UG (haftungsbeschränkt) Geschäftsführer: Stefan Baur Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243 From ulrich.sibiller@gmail.com Thu Oct 15 12:26:14 2020 Received: (at 1500) by bugs.x2go.org; 15 Oct 2020 10:26:17 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 784E35DAFB; Thu, 15 Oct 2020 12:26:14 +0200 (CEST) Received: by mail-yb1-f173.google.com with SMTP id h6so1807134ybi.11; Thu, 15 Oct 2020 03:26:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fOFRlpAgD9hutFIxVsXWNSHexvki/dbtbCFHfUPBY4E=; b=VmTmF+d3QccmAdcaRLxyL2Qroa8XnleXwTF1Js5m9hs6CRLKufx/vbFFs6bwK6r9V8 Tb6B1JvKebWHP4pyTMAm7wi1ZrSar+5kVurvfwon9UVHGhqXeMOddMu2P7qjeOI+KNRc nQvgLw4ocsT0mEyaSqh93ohjjj+Cy31OXVT1UPn5cBvcf5zq/JqJ+4iq/PZn3W3zk6MN ZxTDPax1Lvd8OzCJR0MzjpeVjG0h6uLG2loLmQxcCo1Jxwe0StR6Q7DKfQG5uJ2KN5jA +ACw026S8eFzU9bWzZtL7QJRdch9/Sr+qO1wBJhQyw6ZIlWvVUmSMvp7QrIGt1C6FOew yNSQ== X-Gm-Message-State: AOAM531+Q5noDzFvgJGwpF4RUcasxm3oDUiAFoNwXdOJikDSomv86R0d JW4TDIbd7gS4Sy6847Jhprd0eIoNQ4HqI22LbHc= X-Google-Smtp-Source: ABdhPJxIACZBYcSJX8ygwdoL21SMjNVDGkXhI9WQoBA3k+TBtGCHz8mUsGCqncv6R1vQ85V1SNICWTXO176W/1NE3p0= X-Received: by 2002:a25:1ed7:: with SMTP id e206mr4313999ybe.505.1602757543071; Thu, 15 Oct 2020 03:25:43 -0700 (PDT) MIME-Version: 1.0 References: <79f56027-637e-9fb2-a87b-aaf044f7edc7@baur-itcs.de> In-Reply-To: <79f56027-637e-9fb2-a87b-aaf044f7edc7@baur-itcs.de> From: Ulrich Sibiller Date: Thu, 15 Oct 2020 12:25:16 +0200 Message-ID: Subject: Re: [X2Go-Dev] Bug#1500: Wishlist Bug: look for Branding-/Background-SVGs in well-known locations To: Stefan Baur , 1500@bugs.x2go.org Cc: submit@bugs.x2go.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Better approach: The default logos will come in a dedicated directory. In addition there's a defined path .../x2go-branding which is neither delivered nor created by the x2goclient package. IFF the directory exists and contains the required files these are taken instead of the default ones. You can then pack a x2go-branding-mycompany package and install that completely independently from the x2go installation. There's a restriction that only one such package may be installed. Drawback: you cannot use two differently branded x2goclients in parallel, but can you run x2goclient twice at all? Uli On Thu, Oct 15, 2020 at 11:56 AM Stefan Baur wrote= : > > package: x2goclient > priority: wishlist > > At the moment, X2GoClient has two SVGs "baked in", namely the ones for > the background image and the branding in the lower left corner. These > can be overridden with command line parameters. > > I would suggest a folder /usr/share/x2goclient/logos on Linux/macOS, and > \x2goclient\logos on Windows, where these SVGs are placed > instead. On Linux, /etc/x2goclient/logos should be a symlink to > /usr/share/x2goclient/logos. > > On Client startup, it would then scan /etc/x2goclient/logos (or > \x2goclient\logos) for these files, and use them. > > That way, swapping out these logos does not require adding --background > or --branding to the call - on Windows, you would simply overwrite them > with the logos of your choice, on Linux/macOS, you would replace the > symlink with an actual directory and place your custom logos there - > just like we do it for /etc/x2go/applications on the server. > > The command line parameters should remain in the code to support legacy > installations. > > It MAY make sense to keep a minimum set of logos "baked in" (maybe a > black on white "ERROR" text) to indicate when the file-based ones could > not be found. > > Kind Regards, > Stefan Baur > > -- > BAUR-ITCS UG (haftungsbeschr=C3=A4nkt) > Gesch=C3=A4ftsf=C3=BChrer: Stefan Baur > Eichen=C3=A4ckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 > Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243 > _______________________________________________ > x2go-dev mailing list > x2go-dev@lists.x2go.org > https://lists.x2go.org/listinfo/x2go-dev