From unknown Sat Apr 18 16:59:50 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#1476: [X2Go-Dev] Bug#1476: x2goclient interface code needs refactoring to make it more accessible and make improvements easier to implement and test Reply-To: Mike Gabriel , 1476@bugs.x2go.org Resent-From: Mike Gabriel Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Mon, 08 Jun 2020 07:55:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 1476 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: References: Received: via spool by 1476-submit@bugs.x2go.org id=B1476.159160289110087 (code B ref 1476); Mon, 08 Jun 2020 07:55:02 +0000 Received: (at 1476) by bugs.x2go.org; 8 Jun 2020 07:54:51 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,SPF_HELO_NONE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from fregna.das-netzwerkteam.de (fregna.das-netzwerkteam.de [148.251.53.130]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 608A25DAE7 for <1476@bugs.x2go.org>; Mon, 8 Jun 2020 09:54:47 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [IPv6:2a01:4f8:202:1381::105]) by fregna.das-netzwerkteam.de (Postfix) with ESMTPS id 7E9DD605B5; Mon, 8 Jun 2020 07:54:46 +0000 (UTC) Received: from das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 76D20C0247; Mon, 8 Jun 2020 09:54:46 +0200 (CEST) Received: from business-90-187-115-117.pool2.vodafone-ip.de (business-90-187-115-117.pool2.vodafone-ip.de [90.187.115.117]) by mail.das-netzwerkteam.de (Horde Framework) with HTTPS; Mon, 08 Jun 2020 07:54:46 +0000 Date: Mon, 08 Jun 2020 07:54:46 +0000 Message-ID: <20200608075446.Horde.GCbByAWEYdCZIPr7R8dhv9L@mail.das-netzwerkteam.de> From: Mike Gabriel To: Dave Chamberlin-Kidd , 1476@bugs.x2go.org In-Reply-To: User-Agent: Horde Application Framework 5 Accept-Language: de,en Organization: DAS-NETZWERKTEAM X-Originating-IP: 90.187.115.117 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0 Content-Type: multipart/signed; boundary="=_RgkLdzCXQvZ9WKjluT-oZBw"; protocol="application/pgp-signature"; micalg=pgp-sha512 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_RgkLdzCXQvZ9WKjluT-oZBw Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Dave, On So 07 Jun 2020 17:49:21 CEST, Dave Chamberlin-Kidd wrote: > Package: x2goclient > Version: 4.1.2.3 > Severity: wishlist > Tag: patch > > There are a number of minor issues, oddities and limitations with the > current x2goclient gui which would be good to fix, resolve and improve on= . > Like all projects however the core team have more important issues to > resolve. The code in its current state is difficult to understand and ame= nd > and as it has no tests it is risky for developers to make functional > changes unless they spend a lot of time getting to know the code and doin= g > extensive manual testing. > > Attached are 10 small refactorings which start extracting out some of the > code into smaller functions. As the code is separated out it becomes easi= er > to understand and change. > > There are no functional changes in these patches, nor do they attempt or > claim to fix any known issues. On their own the benefit of these patches = is > limited however the hope is that over time I will be able to submit more > refactorings as I learn more and then start fixing issues and improving t= he > UI. Extracting out functions is just one of many techniques that can be > used to make code cleaner but in my experience it's a good one to start > with. It should also be noted that sometimes code is extracted "as is" ev= en > when it is clear further refactoring can be done to improve things, this = is > by design in order to keep risk and size of patches to a minimum. > > Cheers > Dave Thanks for your patches. As the GitLab server for X2Go is in reach,=20=20 I'd=20like to postpone patch review until its there. I'd be happy if you=20= =20 could=20file a merge request then and we dive into your proposals. Thanks+Greets, Mike --=20 DAS-NETZWERKTEAM c\o=20Technik- und =C3=96kologiezentrum Eckernf=C3=B6rde Mike Gabriel, Marienthaler Str. 17, 24340 Eckernf=C3=B6rde mobile: +49 (1520) 1976 148 landline: +49 (4351) 850 8940 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de --=_RgkLdzCXQvZ9WKjluT-oZBw Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIzBAABCgAdFiEEm/uu6GwKpf+/IgeCmvRrMCV3GzEFAl7d7sQACgkQmvRrMCV3 GzHWuQ//dSG3hieNtM0VpM6WKKtAaK1s4REREK9LJb21K5UZpwKGIBbx4zhU/baS mVeiJcbELWiNR/PsefCpkGP+EavQ7FMnZc8y8i/J/IbdwgP3eYt+jqsdj8qnbEvJ ArMHQhM46j0mK29dVoCACepltXA35D56CbwNXvwGCmCiGJcPXuBVyVeJZbl/BMOq H30LxjulsukHqEYz7IMU5kEzFJECWG1RXAUCpU2LPCALHbK9o/YMRz1p1h/BWZDM I4FtCPh1H7nS+YJbgc4DAYY7koXpS2VYC76ct0IVOZt7z8SMITfEovaIHKotPUnY O4jtXvjNz7QNqjOwnOgHLlA9ODeU+L5xnXwvHNzRw5g82yvDB3dc/QdkMEZvSImF 6sYQCRLdW8xRLim3NQCO0LWwJuwvf30e+F7i3+q4ka93cS6a0/xCyQNwLsdEwEv6 M4WUxJZaiKxrrBvhKS7kNG20/rVOPwlceQ6g7hQST5RHUKJLBz4N5s54wi+Vxr5b a2iQ3W9kqBzHIFvqZlBuy5vHbZj2lJ7oXhPWP/vekesy/dD8tX8rgdJKKI0uu9Kf QrPir5fIyblnLcJld3F/1E617ltLK8fRHyci9tWZrCpkZEyi4uTYb3Nm1UmGnXZi 0Kw92//X65LpbQT9GrHmsUQzPvXgrqVTz4MAlD3Bbvgim1jeRO0= =078v -----END PGP SIGNATURE----- --=_RgkLdzCXQvZ9WKjluT-oZBw--