X2Go Bug report logs - #1469
X2Go Client connection issue (Socket error)

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Melroy van den Berg <melroy89@protonmail.com>

Date: Mon, 18 May 2020 18:55:02 UTC

Severity: normal

Tags: pending

Found in version 4.1.2.2

Fixed in version 4.1.2.3

Done: X2Go Release Manager X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log


Message #35 received at 1469@bugs.x2go.org (full text, mbox, reply):

Received: (at 1469) by bugs.x2go.org; 19 May 2020 21:28:36 +0000
From melroy89@protonmail.com  Tue May 19 23:24:45 2020
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,FREEMAIL_REPLYTO_END_DIGIT,
	HTML_MESSAGE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED
	autolearn=no autolearn_force=no version=3.4.2
Received: from mail-40137.protonmail.ch (mail-40137.protonmail.ch [185.70.40.137])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 562BB5DAF0
	for <1469@bugs.x2go.org>; Tue, 19 May 2020 23:24:17 +0200 (CEST)
Date: Tue, 19 May 2020 21:24:09 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
	s=protonmail; t=1589923453;
	bh=4uxOm4VXH3JH7DymW/RQnJ4HesyxjnuiD3vbooqYnao=;
	h=Date:To:From:Reply-To:Subject:From;
	b=nptJgc/L2OTC5w1in4KhGFowGL2MMoVdt2hkHmw6Q+sKOzjP32BTAzNuY+bsTI6UW
	 Er1qtZheLBpDVdWR7aAEvQefc+q7TN0Hby/wJwwKd7NKfDjGxitUSAfxd1zF740oBM
	 oty0kUGixeOL/MNsbbQHkonc1+qnU3qOFsj0aCOA=
To: "1469@bugs.x2go.org" <1469@bugs.x2go.org>, Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
From: Melroy van den Berg <melroy89@protonmail.com>
Reply-To: Melroy van den Berg <melroy89@protonmail.com>
Subject: But wait; there is more... patches!
Message-ID: <VnStfHqOfEV696XWKKjeMSuahU9XjhK2Txgit7J8BASDxM9h7eFulrhhTX481UZ4QDaWEvDllKfWhjB1nhYCeZfXEgVGQ0jo-T87qRzFgBU=@protonmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="b1_f1c3740bfb6ee79fae139d70cf52c605"
[Message part 1 (text/plain, inline)]
Hi Mike & Uli,

As Mike suggested, I redone all changes (plus even some more bonus items).
Since I was in a separate git branch I could run the format-patch easily via:git format-patch master. Thanks for the suggestion.

@Uli I'm using the auto-formatter for C++ built-in in VS Code.

I think the end-result with all the separate patches makes more sense now, sorry I didn't do it right away. I think once I have a wiki account, I will add all these best practices your x2go wiki. Instead of Attachment: <your-patch.diff>: https://wiki.x2go.org/doku.php/wiki:bugs?s[]=git&s[]=patch#bug_submission_with_a_patch.

See the attachments for all the patches in this mail (11 in total). Thanks in advance.

Best regards,
Melroy van den Berg
[Message part 2 (text/html, inline)]
[0002-endl-for-every-debug-line.patch (text/x-patch, attachment)]
[0003-send-eof-before-close.patch (text/x-patch, attachment)]
[0004-return-false-in-all-bad-cases.patch (text/x-patch, attachment)]
[0006-Remove-deprecated-call-and-use-new-libssh-API-call.-.patch (text/x-patch, attachment)]
[0005-Refactor-and-fix-channel-session-closes.patch (text/x-patch, attachment)]
[0007-Fix-when-not-password-auth.-Otherwise-you-get-double.patch (text/x-patch, attachment)]
[0010-Mark-as-unused-explicitly.patch (text/x-patch, attachment)]
[0011-improve-gitignore-why-not.patch (text/x-patch, attachment)]
[0008-Correct-retval-check.-Plus-some-minor-formatting.patch (text/x-patch, attachment)]
[0009-Another-missing-endl.patch (text/x-patch, attachment)]
[0001-First-auto-format-the-code-for-readability-and-human.patch (text/x-patch, attachment)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Fri Apr 19 03:03:08 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.