From unknown Sun Apr 26 06:21:48 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#1469: [X2Go-Dev] Bug#1469: Patch! Reply-To: Mike Gabriel , 1469@bugs.x2go.org Resent-From: Mike Gabriel Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Tue, 19 May 2020 19:50:10 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 1469 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: References: Received: via spool by 1469-submit@bugs.x2go.org id=B1469.158991772119000 (code B ref 1469); Tue, 19 May 2020 19:50:10 +0000 Received: (at 1469) by bugs.x2go.org; 19 May 2020 19:48:41 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.5 required=3.0 tests=BAYES_00,KHOP_HELO_FCRDNS, SPF_HELO_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from fregna.das-netzwerkteam.de (fregna-internal.das-netzwerkteam.de [IPv6:2a01:4f8:202:1381::1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id E674F5DAF0 for <1469@bugs.x2go.org>; Tue, 19 May 2020 21:48:33 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [148.251.201.105]) by fregna.das-netzwerkteam.de (Postfix) with ESMTPS id 5F97C605B1; Tue, 19 May 2020 19:48:33 +0000 (UTC) Received: from das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 5761BC0195; Tue, 19 May 2020 21:48:33 +0200 (CEST) Received: from [37.123.126.38] ([37.123.126.38]) by mail.das-netzwerkteam.de (Horde Framework) with HTTPS; Tue, 19 May 2020 19:48:33 +0000 Date: Tue, 19 May 2020 19:48:33 +0000 Message-ID: <20200519194833.Horde.kr6XjaMhAMOcOXrvwxL5PjI@mail.das-netzwerkteam.de> From: Mike Gabriel To: Melroy van den Berg , 1469@bugs.x2go.org In-Reply-To: User-Agent: Horde Application Framework 5 Accept-Language: de,en Organization: DAS-NETZWERKTEAM X-Originating-IP: 37.123.126.38 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0 Content-Type: multipart/signed; boundary="=_mXA6mNgrNWoJDlZN3GRzIQY"; protocol="application/pgp-signature"; micalg=pgp-sha512 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_mXA6mNgrNWoJDlZN3GRzIQY Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Melroy, On Di 19 Mai 2020 03:59:16 CEST, Melroy van den Berg wrote: > Hi, > > I did some refactoring in the sshmasterconnection.cpp file. I think=20=20 >=20it can definitely use some clean-up and further splitting functions=20= =20 >=20and even into multiple files eventually. > I cloned the master branch of code.x2go.org/x2goclient repo. > > The changes I applied are in the attachment of this mail (a git=20=20 >=20patch file). I think closing previous sessions and connection solved=20= =20 >=20my strange SSH connection is resulting into Socket error: No such=20=20 >=20file or directory". > Although X2Go client is calling [libssh=20=20 >=20calls](https://api.libssh.org/master/index.html) (libssh version=20=20 >=20currently in use runtime on my host is: 0.7.0). > For some reason this vague error message popped-up by libssh,=20=20 >=20properly a result of previous session being created and not=20=20 >=20correctly closed. And/or not closed in the right order (/missing API=20= =20 >=20calls), like a good example: > > ssh_channel_send_eof(channel); > ssh_channel_close(channel); > ssh_channel_free(channel); > > And I created yet again a new YT video showing my result: > https://youtu.be/vmASLJq0CKM > (including some brief explanation what I did so far, I also ran an=20=20 >=20formatted on the code, because it was very very hard to read with=20=20 >=20all the wrong indents) > > I also made another video showing yet another bug I found regarding=20=20 >=20the SSH tunneling (during some heavy testing), the only solution was=20= =20 >=20to restart the whole docker image: > https://youtu.be/xEpIyo84fWc (I think this issue is unrelated, but=20=20 >=20maybe wise to take serious as well) > > Again see attachment for the patch (branched from master). > > Regards, > Melroy van den Berg Thanks for working on X2Go Client. With your patch, there is a problem=20= =20 though.=20It is barely unreviewable, because you have so many changes=20=20 (also=20white space changes) in one patch file. Please clone the X2Go Client Git repo, add atomic changes with good=20=20 commit=20messages. Keep white-space changes and technical changes fully=20= =20 separate=20(ideally: technical changes first, white-space changes last). Then export your patches using 'git format-patch=20=20 ..HEAD'=20and send us the set of patches instead=20= =20 this=20one bulk commit/patch. Thanks for your efforts!!! Mike --=20 DAS-NETZWERKTEAM c\o=20Technik- und =C3=96kologiezentrum Eckernf=C3=B6rde Mike Gabriel, Marienthaler Str. 17, 24340 Eckernf=C3=B6rde mobile: +49 (1520) 1976 148 landline: +49 (4351) 850 8940 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de --=_mXA6mNgrNWoJDlZN3GRzIQY Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIzBAABCgAdFiEEm/uu6GwKpf+/IgeCmvRrMCV3GzEFAl7EOA8ACgkQmvRrMCV3 GzFn2A//X//HyvYzul7mJ2DcMOD6G+qptGqAbt7qVQIIFjfKk2WoCdDpqAqXxpk6 gGINPq7+y5p7go6NKQ+lbjndnrdr/qmsuo+e8SP5Pw5erG85ZdFPmHhFgUZebbH1 75pteRCh2O3HifDewoZZcfPAEnFBmTfV0BuTXLRxTAXoJExvJY9qK1XSnyi3+SfU aIyNilfvOmlhBlJrn1oT3OpvNIiWE3kGMtZnDSrmP48ADkBR5E6btKggxGcfpSZV VAxZmI+C6dY2fBgDCNmHrbU/sDOL1isMu3SEW6ZlIz6LzK/OgF6XFL6UjDzmV854 CrrG+8OGJ35qB4uER4Aih66XYI8Ifnie0PuSjfEV3gIRELFGKa1pxR0/XT8kjHax LhfvudUIDqoxFsKg3LjisQKAW5fL6PH+EojyEjGTqmzkXnc9PFJ8ZWM3eE0rSafN xzDh/iAbiZ/UehtZP4DZy2agk1e5cPSTil5ZIkISDSxKoImvEd8xvkRaLuvqWgmQ V2bW3t4wqOTFibjZD/8K8C2YPSuj8sJieqQQBT1791DqiWJgnU1eW/lC9EW4w1zw vth3c8UMXPK2A0YWn+/RSAkFmltmC2i+XKnby7GdSEM6+F79+dDh+J0FSW/NTKKD fMzcn4lEkq4ddZxYhb4id2+VxO5c9ogXuPG9gIYaVkp/VPvvVo4= =kEws -----END PGP SIGNATURE----- --=_mXA6mNgrNWoJDlZN3GRzIQY--