X2Go Bug report logs - #1458
unattended Debian installations (using preseed) fail when x2gobroker-ssh is involved

version graph

Package: x2gobroker-ssh; Maintainer for x2gobroker-ssh is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2gobroker-ssh is src:x2gobroker.

Reported by: Stefan Baur <X2Go-ML-1@baur-itcs.de>

Date: Fri, 17 Apr 2020 14:10:54 UTC

Severity: normal

Tags: pending

Fixed in version

Full log

đź”— View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#1458: [X2Go-Dev] Bug#1458: unattended Debian installations (using preseed) fail when x2gobroker-ssh is involved
Reply-To: uli42@gmx.de, 1458@bugs.x2go.org
Resent-From: Ulrich Sibiller <ulrich.sibiller@gmail.com>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Fri, 17 Apr 2020 14:30:05 +0000
Resent-Message-ID: <handler.1458.B1458.158713353315135@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 1458
X-X2Go-PR-Package: x2gobroker-ssh
References: <09a01d9f-1db4-ad20-e0f5-d08889ab89f6@baur-itcs.de> <09a01d9f-1db4-ad20-e0f5-d08889ab89f6@baur-itcs.de>
Received: via spool by 1458-submit@bugs.x2go.org id=B1458.158713353315135
          (code B ref 1458); Fri, 17 Apr 2020 14:30:05 +0000
Received: (at 1458) by bugs.x2go.org; 17 Apr 2020 14:25:33 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	autolearn_force=no version=3.4.2
Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 97CD15DAE5;
	Fri, 17 Apr 2020 16:25:25 +0200 (CEST)
Received: by mail-yb1-xb33.google.com with SMTP id h205so1120701ybg.6;
        Fri, 17 Apr 2020 07:25:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
X-Gm-Message-State: AGi0PuZFtAdzdhKjVZe3kiyAhntVNQ0yRwXSV46QTXXcB6YN4ZWX+8Mu
X-Google-Smtp-Source: APiQypLitlZZOmg4NiF8200d7+t+qvek/5H1O8vmEaafOnPNxN4BEdXSKWsfB/qRindhDHOFsH7HgYTk/YPSpsy/uEg=
X-Received: by 2002:a5b:785:: with SMTP id b5mr2607239ybq.505.1587133524089;
 Fri, 17 Apr 2020 07:25:24 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <09a01d9f-1db4-ad20-e0f5-d08889ab89f6@baur-itcs.de>
From: Ulrich Sibiller <ulrich.sibiller@gmail.com>
Date: Fri, 17 Apr 2020 16:24:57 +0200
Message-ID: <CANVnVYJuGhHgK0o2RNZ15-V80faqGY1ngcWaH+6oM4LJGW-5mg@mail.gmail.com>
To: Stefan Baur <X2Go-ML-1@baur-itcs.de>, 1458@bugs.x2go.org
Cc: submit@bugs.x2go.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
I think it is a totally wrong approach to fiddle with nscd. Creating a
group using system tools should take of that already. If not it's a
bug, I'd say.

Besides: what about sssd that can also cache groups?

On Fri, Apr 17, 2020 at 4:11 PM Stefan Baur <X2Go-ML-1@baur-itcs.de> wrote:
> package: x2gobroker-ssh
> version
> severity: important
> The postinst file for x2gobroker-ssh contains a check to see if the nscd
> binary is somewhere in the path.  If it is, then nscd -i group is
> called, to purge the group cache (which makes sense, as a new group has
> been added in a previous step, so the cached information is outdated).
> If it is not, then it is assumed that nscd is not installed, thus, no
> group information is cached, and thus, no purge is needed.
> This fails to take into account that nscd might be (freshly) installed,
> but not running.  Which is the case during a preseeded Debian
> installation (and probably when running debootstrap as well).
> The result is that "nscd -i group" is called even though nscd isn't
> active at the moment.
> Which triggers a return code of "1".
> Which in turn causes the postinst script to report "1" as its return code.
> This, of course, gets passed back up to the debian-installer, which
> decides to abort the installation, as it seems that something went wrong
> during installation of the package.
> The patch is rather simple: Instead of checking for the presence of the
> executable in the file system, check if it is currently running:
> -                                        if which nscd 1>/dev/null; then
> +                                        if ps -C nscd 1>/dev/null; then
> As this is currently breaking all automated x2gobroker-ssh installs, I
> would suggest releasing a new version containing only this patch ASAP,
> if a full release with all changes since the last proper release of
> x2gobroker-ssh would bring too many changes at once for a timely release.
> Kind Regards,
> Stefan Baur
> --
> BAUR-ITCS UG (haftungsbeschränkt)
> Geschäftsführer: Stefan Baur
> Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364
> Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243
> _______________________________________________
> x2go-dev mailing list
> x2go-dev@lists.x2go.org
> https://lists.x2go.org/listinfo/x2go-dev

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Jan 20 11:21:44 2022; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.