X2Go Bug report logs - #1454
Better explain fullscreen keyboard shortcuts usage on multi display setup

Full log

Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

Received: (at submit) by bugs.x2go.org; 3 Apr 2020 17:17:56 +0000
From oligau@box.oscille.ca  Fri Apr  3 19:17:53 2020
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.7 required=3.0 tests=BAYES_50,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham
	autolearn_force=no version=3.4.2
Received: from box.oscille.ca (box.oscille.ca [144.217.81.64])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id D40855DA8B
	for <submit@bugs.x2go.org>; Fri,  3 Apr 2020 19:17:51 +0200 (CEST)
To: submit@bugs.x2go.org
From: Olivier Gauthier <oligau@oscille.ca>
Subject: Better explain fullscreen keyboard shortcuts usage on multi display
 setup
Message-ID: <46b0f316-8f9b-93d6-1039-033904173565@oscille.ca>
Date: Fri, 3 Apr 2020 13:17:48 -0400
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oscille.ca; s=mail; t=1585934268; bh=3m8DUX59yLgyXsCGQC0aXfeIaYzTyw8b/A1FKHbBR9w=; h=To:From:Subject:Message-ID:Date:MIME-Version:Content-Type:Content-Transfer-Encoding; b=JOa42i/0WBmxxmFjKrzOKzmYwlhwK+8r0645j3jZikvl3LqzRJimfi57iGDMV+wf6Bei6b+5ycVzvIzqlLh/9/jCf7u0ruaz4xUffatKwm1ffNltzMjcL5ZHb/BvYDPD4hj4KE/cFwlKi6MHwtZfJqqeo11B98ujsyRLlCSrmFk=

Package: wiki.x2go.org

Add missing keyboard shortcut Shift + Ctrl + Alt + F to x2goclient 
documentation.

I spent an hour trying to figure why my X2Go session would not want to
go fullscreen over all my screens like I normally do.

I realized I always used Ctrl + Alt + F to go fullscreen as explained at
https://wiki.x2go.org/doku.php/doc:usage:x2goclient. That gave me 
fullscreen
session spanning over all multi display screens as expected.

However, without noticing it, I started using Shift + Ctrl + Alt + F
this morning because my muscle memory have been trained while using
Guacamole menu shortcut (uses Shift-Ctrl-Alt keys to toggle menu).

I did not notice at first, because Shift + Ctrl + Alt + F also works on
X2Go Client, but it only go fullscreen on current display screen.

It puzzled me for a while today, so I went back to wiki page, to figure
I have been using wrong shortcut.

I verified code for key bindings 
(https://code.x2go.org/gitweb?p=nx-libs.git;a=blob;f=etc/keystrokes.cfg;hb=HEAD) 

and it effectively offers two clever options to go full screen on multi
displays.

> 4 <keystroke action="switch_all_screens" Control="1" AltMeta="1" 
key="f" />
> 5 <keystroke action="fullscreen" Control="1" Shift="1" AltMeta="1" 
key="f" />

Here is two wiki patches to help clarify documentation around full 
screen usage
on multi display setups. Feel free to rephrase any way you want.

-- 
Olivier

-- 
doc/usage/x2goclient.txt
70c70,71
<   * Ctrl + Alt + F: toggle fullscreen/windowed
---
>   * Ctrl + Alt + F: toggle windowed/fullscreen over all screens
>   * Shift + Ctrl + Alt + F: toggle windowed/fullscreen on current 
screen only

doc/usage/multi-display.txt
19a20,26
>
> ===== Use keyboard shortcuts to go fullscreen over one or all 
displays  =====
>
> There is two different ways to enter fullscreen from keyboard 
shortcuts. One goes fullscreen over all screens, the other goes 
fullscreen only on current screen.
>
>   * Ctrl + Alt + F: toggle windowed/fullscreen over all screens
>   * Shift + Ctrl + Alt + F: toggle windowed/fullscreen on current 
screen only

Send a report that this bug log contains spam.