From unknown Thu Mar 28 14:19:58 2024 X-Loop: owner@bugs.x2go.org Subject: Bug#1398: x2goclient hardcoded default PATHs portability Reply-To: "Averell D." , 1398@bugs.x2go.org Resent-From: "Averell D." Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Sat, 27 Jul 2019 17:35:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: report 1398 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: Received: via spool by submit@bugs.x2go.org id=B.156424878923943 (code B); Sat, 27 Jul 2019 17:35:02 +0000 Received: (at submit) by bugs.x2go.org; 27 Jul 2019 17:33:09 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=3.0 tests=BAYES_40,SPF_HELO_NONE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 1E7F25DAF2 for ; Sat, 27 Jul 2019 19:32:59 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VjBYTJxyjWqO for ; Sat, 27 Jul 2019 19:32:52 +0200 (CEST) X-Greylist: delayed 1913 seconds by postgrey-1.35 at ymir.das-netzwerkteam.de; Sat, 27 Jul 2019 19:32:52 CEST Received: from aibo.runbox.com (aibo.runbox.com [91.220.196.211]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 9159F5DAE3 for ; Sat, 27 Jul 2019 19:32:52 +0200 (CEST) Received: from [10.9.9.202] (helo=mailfront20.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1hrQ42-0000Wf-8M for submit@bugs.x2go.org; Sat, 27 Jul 2019 19:00:58 +0200 Received: by mailfront20.runbox with esmtpsa (uid:848532 ) (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1hrQ3x-0006Vt-3O for submit@bugs.x2go.org; Sat, 27 Jul 2019 19:00:53 +0200 To: submit@bugs.x2go.org From: "Averell D." Message-ID: Date: Sat, 27 Jul 2019 19:00:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Package: x2goclient Version: 4.1.0.3 x2goclient assumes some default PATHs that don't necessarily exist in all cases. In particular, this line: https://code.x2go.org/gitweb?p=x2goclient.git;a=blob;f=src/sshprocess.cpp;h=70c3b1ce53322730f50c191e22bdf19e2dbe81a0;hb=HEAD#l204 assumes that x2go* binaries such as x2golistsessions etc. but also tools like xmodmap, xrandr, sed, etc. can be found at these locations. While packaging x2goserver for NixOS (and probably other less mainstream distributions), this creates problems, as there is no server-side patch that can fix commands coming from these clients. Therefore it would be nice to make this PATH configurable, or add an option to look at server-side user-paths, or similar.