From unknown Wed Apr 08 03:23:50 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#1338: openSUSE Tumbleweed RPM builds against obsolete (and nowadays missing) libssh Reply-To: Tristan Miller , 1338@bugs.x2go.org Resent-From: Tristan Miller Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Sun, 28 Oct 2018 20:20:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: report 1338 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: Received: via spool by submit@bugs.x2go.org id=B.154075774813123 (code B); Sun, 28 Oct 2018 20:20:02 +0000 Received: (at submit) by bugs.x2go.org; 28 Oct 2018 20:15:48 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 2BE6E5DAEA for ; Sun, 28 Oct 2018 21:15:42 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oIzph_xapgTc for ; Sun, 28 Oct 2018 21:15:21 +0100 (CET) Received: from balrog.mythic-beasts.com (balrog.mythic-beasts.com [IPv6:2a00:1098:0:82:1000:0:2:1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 744EC5DA26 for ; Sun, 28 Oct 2018 21:15:20 +0100 (CET) Received: from [88.153.49.225] (port=56502 helo=butterfield.nothingisreal.com) by balrog.mythic-beasts.com with esmtpa (Exim 4.90_1) (envelope-from ) id 1gGrSu-0004Sa-Iw for submit@bugs.x2go.org; Sun, 28 Oct 2018 20:15:20 +0000 Received: from pi.nothingisreal.com (localhost [IPv6:::1]) by butterfield.nothingisreal.com (Postfix) with ESMTP id 4E872BE85 for ; Sun, 28 Oct 2018 21:15:15 +0100 (CET) Date: Sun, 28 Oct 2018 21:15:15 +0100 From: Tristan Miller To: submit@bugs.x2go.org Message-ID: <20181028211515.76cdeda7.psychonaut@nothingisreal.com> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/yO3cGQk2EUH3zLP0ye8hQe9" X-BlackCat-Spam-Score: 11 --MP_/yO3cGQk2EUH3zLP0ye8hQe9 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Package: x2goclient Version: 4.1.2.2 Tag: patch The openSUSE Tumbleweed RPM for x2goclient at cannot be built or installed on recent versions of Tumbleweed because it depends on an obsolete version of libssh that is no longer distributed with Tumbleweed. However, updating the dependency to a modern libssh requires changing not only the RPM spec file but also the x2goclient source code. This is because recent versions of libssh install both the standard and threaded libraries in the same library, whereas the existing source code attempts to link them as two unique libraries. Attached is a patch to the spec file that fixes the libssh dependency for Tumbleweed, and applies a patch (also attached) to the x2goclient source code that stops it from trying to link to the nowadays missing ssh_threads library. (Maybe the latter patch should be merged into the official x2goclient source, though of course this depends on what version(s) of libssh the x2goclient developers intend to support.) Attachment: x2goclient.spec.patch Attachment: x2goclient-libssh.patch --MP_/yO3cGQk2EUH3zLP0ye8hQe9 Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=x2goclient.spec.patch --- /usr/src/packages/SPECS/x2goclient.spec 2018-09-05 15:02:44.000000000 +0200 +++ x2goclient.spec 2018-10-28 20:30:41.606190285 +0100 @@ -14,6 +14,7 @@ URL: https://www.x2go.org Source0: https://code.x2go.org/releases/source/%{name}/%{name}-%{version}.tar.gz Source1: x2goclient-rpmlintrc +Patch0: x2goclient-libssh.patch BuildRequires: cups-devel BuildRequires: desktop-file-utils @@ -45,10 +46,15 @@ %if "%{?_vendor}" == "suse" BuildRequires: fdupes update-desktop-files +%if 0%{?suse_version} >= 1500 +BuildRequires: libssh-devel >= 0.8.0 +BuildRequires: pkgconfig(x11) pkgconfig(xpm) pkgconfig(xproto) +%else %if 0%{?suse_version} >= 1130 BuildRequires: pkgconfig(libssh) >= 0.6.3 BuildRequires: pkgconfig(x11) pkgconfig(xpm) pkgconfig(xproto) %endif +%endif %if 0%{?suse_version} && 0%{?suse_version} < 1130 BuildRequires: libssh-devel >= 0.6.3 BuildRequires: xorg-x11-libXpm-devel xorg-x11-proto-devel @@ -110,7 +116,9 @@ sed -i -e '/^QMAKE_BINARY=/s@qmake-qt4@%{_bindir}/qmake@' Makefile sed -i -e '/^LRELEASE_BINARY=/s@lrelease-qt4@%{_bindir}/lrelease@' Makefile %endif - +%if 0%{?suse_version} > 1500 +%patch0 -p1 +%endif %build export PATH=%{_qt4_bindir}:$PATH --MP_/yO3cGQk2EUH3zLP0ye8hQe9 Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=x2goclient-libssh.patch --- x2goclient-4.1.2.2/x2goclient.pro 2018-09-05 15:02:43.000000000 +0200 +++ x2goclient-4.1.2.2.new/x2goclient.pro 2018-10-28 20:08:50.893643887 +0100 @@ -132,7 +132,7 @@ src/compat.cpp \ src/pulsemanager.cpp -LIBS += -lssh -lssh_threads +LIBS += -lssh win32:LIBS += -lAdvAPI32 -lshell32 -lUser32 RC_FILE = res/x2goclient.rc --MP_/yO3cGQk2EUH3zLP0ye8hQe9--