From unknown Wed Apr 08 03:45:19 2026 MIME-Version: 1.0 X-Mailer: MIME-tools 5.507 (Entity 5.507) X-Loop: owner@bugs.x2go.org From: owner@bugs.x2go.org (X2Go Bug Tracking System) Subject: Bug#1322 closed by X2Go Release Manager X2Go Release Manager (X2Go issue (in src:x2goserver) has been marked as closed) Message-ID: References: <20181129045649.1E4815DAEB@ymir.das-netzwerkteam.de> X-X2go-PR-Keywords: pending patch X-X2go-PR-Message: they-closed 1322 X-X2go-PR-Package: x2goserver X-X2go-PR-Source: x2goserver Date: Thu, 29 Nov 2018 05:05:05 +0000 Content-Type: multipart/mixed; boundary="----------=_1543467905-17973-0" This is a multi-part message in MIME format... ------------=_1543467905-17973-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This is an automatic notification regarding your Bug report which was filed against the x2goserver package: #1322: RFE: Allow setting nxagent nx/nx options on the server via x2goagent= .options It has been closed by X2Go Release Manager X2Go Release Manager . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact X2Go Release Manager X= 2Go Release Manager by replying to this email. --=20 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems ------------=_1543467905-17973-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at control) by bugs.x2go.org; 29 Nov 2018 05:01:34 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,NO_RELAYS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id 1E4815DAEB; Thu, 29 Nov 2018 05:56:48 +0100 (CET) From: =?utf-8?q?X2Go_Release_Manager?= X2Go Release Manager To: 1322-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 1322@bugs.x2go.org Subject: X2Go issue (in src:x2goserver) has been marked as closed Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20181129045649.1E4815DAEB@ymir.das-netzwerkteam.de> Date: Thu, 29 Nov 2018 05:56:48 +0100 (CET) close #1322 thanks Hello, we are very hopeful that X2Go issue #1322 reported by you has been resolved in the new release (4.1.0.3) of the X2Go source project »src:x2goserver«. You can view the complete changelog entry of src:x2goserver (4.1.0.3) below, and you can use the following link to view all the code changes between this and the last release of src:x2goserver. http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=2f9ba747f837b253b08e35d26d4f7e022e09f6a2;hp=248ee80e769a6ddd2de820d022cc8ee440525dd6 If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:x2goserver. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:x2goserver Version: 4.1.0.3-0x2go1 Status: RELEASE Date: Thu, 29 Nov 2018 05:55:21 +0100 Fixes: 1322 1325 Changes: x2goserver (4.1.0.3-0x2go1) RELEASED; urgency=medium . [ Mike Gabriel ] * New upstream version (4.1.0.3) - x2goserver.service: Add Documentation= key. - x2goserver/lib/x2gocheckport: chmod a+x. - New bin:pkg: x2goserver-desktopsharing. Move all desktop sharing integration logic from x2godesktopsharing to x2goserver src:pkg. - Don't rely on "ln -sf" to remove a symlink before recreating it. If the target is non-writable, this may fail (observed on a Debian stretch system). Thus, removing the symlink file first and then recreating it. - Massive white-space cleanup (at EOLs). - x2goserver/bin/x2goruncommand: Support IceWM as desktop session type. * debian/x2goserver*.dirs: + Let dirs have a trailing slash in their path (for the human eye merely). * debian/copyright: + Regenerate auto-generated copyright.in file. + Adopt from recent Debian packaging. + Add x2goserver.spec. * debian/control: + Move xfonts-base from D to R. Thanks lintian. + Move C (x2goserver) with versioned x2godesktopsharing, to B. + Don't depend on essential package without version. Drop bash from D. + Bump Standards-Version: to 4.2.1. No changes needed. + Mention "client side printing support" also in descr of bin:pkg x2goserver-common. * debian/*.postinst: + Avoid recursive chmod/chown. Recursive chown/chmod is susceptible to hardlink attacks on mainline, non-Debian kernels. * debian/x2goserver.postinst: + Load debconf module, even if not used (Debian Policy demand). * debian/*.templates: + Move x2goserver and x2goserver-desktopsharing templates into separate files. * debian/po: + Add French translation. Thanks to Jean-Pierre Giraud from the Debian project. (Closes DBTS:#905931). * lintian: + Drop unused debian/x2goserver-printing.lintian-overrides. * debian/*: White-space cleanup. * x2goserver.spec: + Mention "client side printing support" in all pkg descriptions. + Regression fix: Use "desktopsharing" package name above its description, not copy+pasted "extensions". + Regression fix: Make /etc/x2go/desktopsharing be owned by x2goserver- desktopsharing. + Exclude x2go*-desktopsharing scripts and man page in %files x2goserver. . [ Mihai Moldovan ] * New upstream version (4.1.0.3): - x2goserver/lib/x2gocheckport: remove executable flag. This file is STILL not meant to be executed directly. - libx2go-server-db-perl/Makefile: make sure our {C,LD}FLAGS are always appended to the user-provided ones. - x2goserver-desktopsharing/bin/x2goterminate-desktopsharing: replace historical "egrep" with "grep -E". - x2goserver-desktopsharing/bin/x2goterminate-desktopsharing: don't use negative exit codes. - x2goserver-desktopsharing/bin/x2goterminate-desktopsharing: more curly braces, quotes etc. - x2goserver-extensions/bin/x2goserver-run-extensions: replace historical "egrep" with "grep -E". - x2goserver-extensions/bin/x2goserver-run-extensions: don't use negative exit codes. - x2goserver-extensions/bin/x2goserver-run-extensions: more curly braces, quotes etc. - x2goserver/bin/x2gofeaturelist: replace historical "egrep" with "grep -E". - x2goserver/bin/x2gofeaturelist: more curly braces, quotes etc. - x2goserver/bin/x2goruncommand: replace historical "egrep" with "grep -E". - x2goserver/bin/x2goversion: replace historical "egrep" with "grep -E". - x2goserver/bin/x2goversion: more curly braces, quotes etc. - x2goserver/bin/x2gostartagent: use single quotes instead of double quotes for literal strings. - x2goserver-x2goagent/etc/x2goagent.options: re-enable BIG-REQUESTS; newer nx-libs versions (3.5.99.17+) should handle this much better. Fixes: #1325. Fixes: #1321. - misc: copyright updates, but for contributors who haven't been active or requested not to be bumped. - misc: switch to HTTPS-based URLs where appropriate. - misc: update Oleksandr's email address. - misc manpages: pre-release date update. - libx2go-server-db-perl/src/libx2go-server-db-sqlite3-wrapper.c: revamp wrapper, alike to what was done in x2gobroker. * x2goserver.spec: + Pull in openSUSE-release manually on OpenSuSE Tumbleweed to work around a bug. + Also pass %{__global_{c{,pp},ld}flags} down via {C,LD}FLAGS. + Bump nxagent dependency up to 3.5.99.17+. * debian/x2goserver-desktopsharing.postinst: + More curly braces, quotes etc. * debian/x2goserver-desktopsharing.config: + More curly braces, quotes etc. * debian/x2goserver-desktopsharing.postrm: + More curly braces, quotes etc. * debian/libx2go-server-db-perl.postinst: + Replace historical "egrep" with "grep -E". * debian/x2goserver.config: + Replace historical "egrep" with "grep -E". + More curly braces, quotes etc. * debian/control: + Bump nxagent dependency up to 3.5.99.17+. * debian/copyright{,.in}: + Merge copyright entries. + Fix links to our wiki and update to HTTPS. . [ Orion Poplawski ] * New upstream version (4.1.0.3): - x2goserver{/bin/x2gostartagent,-x2goagent/etc/x2goagent.options}: allow setting nxagent nx/nx options on the server via x2goagent.options. Fixes: #1322. ------------=_1543467905-17973-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by bugs.x2go.org; 17 Aug 2018 17:14:10 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 541B65DACF for ; Fri, 17 Aug 2018 19:14:08 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zMGyMfRlvfQA for ; Fri, 17 Aug 2018 19:13:59 +0200 (CEST) X-Greylist: delayed 339 seconds by postgrey-1.35 at ymir.das-netzwerkteam.de; Fri, 17 Aug 2018 19:13:58 CEST Received: from mail.nwra.com (mail.nwra.com [72.52.192.72]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 111EB5DACE for ; Fri, 17 Aug 2018 19:13:58 +0200 (CEST) Received: from barry.cora.nwra.com (inferno.cora.nwra.com [208.187.183.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.nwra.com (Postfix) with ESMTPS id 22D913403CB for ; Fri, 17 Aug 2018 10:08:16 -0700 (PDT) To: submit@bugs.x2go.org From: Orion Poplawski Subject: RFE: Allow setting nxagent nx/nx options on the server via x2goagent.options Message-ID: Date: Fri, 17 Aug 2018 11:08:14 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------5605AD2EF3A86B724448E089" Content-Language: en-US This is a multi-part message in MIME format. --------------5605AD2EF3A86B724448E089 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Package: x2goserver Persion: 4.1.0.2 Tags: patch The attached patch allows the setting of nxagent nx/nx options on the server via x2goagent.options. Very useful for being able to set sleep=0. -- Orion Poplawski Manager of NWRA Technical Systems 720-772-5637 NWRA, Boulder/CoRA Office FAX: 303-415-9702 3380 Mitchell Lane orion@nwra.com Boulder, CO 80301 https://www.nwra.com/ --------------5605AD2EF3A86B724448E089 Content-Type: text/x-patch; name="0001-Allow-setting-nxagent-nx-nx-options-on-the-server-vi.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Allow-setting-nxagent-nx-nx-options-on-the-server-vi.pa"; filename*1="tch" >From d3ad2c284cd404286b2764266bed837e3da2ea71 Mon Sep 17 00:00:00 2001 From: Orion Poplawski Date: Fri, 17 Aug 2018 11:04:03 -0600 Subject: [PATCH] Allow setting nxagent nx/nx options on the server via x2goagent.options --- x2goserver-x2goagent/etc/x2goagent.options | 3 +++ x2goserver/bin/x2gostartagent | 11 +++++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/x2goserver-x2goagent/etc/x2goagent.options b/x2goserver-x2goagent/etc/x2goagent.options index a521d17..b7828b1 100644 --- a/x2goserver-x2goagent/etc/x2goagent.options +++ b/x2goserver-x2goagent/etc/x2goagent.options @@ -33,3 +33,6 @@ X2GO_NXAGENT_DEFAULT_OPTIONS+=" -nolisten tcp" # Disable BIG-REQUESTS, nx-libs does not implement this extension correctly. # Leads to all sorts of weird crashes if left enabled. X2GO_NXAGENT_DEFAULT_OPTIONS+=" -extension BIG-REQUESTS" + +# Extra nxagent nx/nx options, separated by commas. For example: sleep=0 +X2GO_NXOPTIONS="" diff --git a/x2goserver/bin/x2gostartagent b/x2goserver/bin/x2gostartagent index 88d015c..af1e2c4 100755 --- a/x2goserver/bin/x2gostartagent +++ b/x2goserver/bin/x2gostartagent @@ -402,14 +402,17 @@ fi typeset xinerama_option='1' [[ "${x2go_xinerama}" = '0' ]] && xinerama_option='0' +typeset kbtype_option="${X2GO_KBD_TYPE}" if [[ "${X2GO_SET_KBD}" = '0' ]] || [[ "${X2GO_KBD_TYPE}" = 'auto' ]]; then - X2GO_HOST="nx/nx,link=${X2GO_LINK},pack=${X2GO_PACK},limit=0,root=${SESSION_DIR},cache=8M,images=32M,type=${X2GO_TYPE},id=${SESSION_NAME},cookie=${X2GO_COOKIE},errors=${SESSION_LOG},kbtype=null/null,${option_geometry}xinerama=${xinerama_option},resize=${X2GO_RESIZE},fullscreen=${X2GO_FULLSCREEN},accept=${REMOTE},listen=${GR_PORT}${clipboard},client=linux,menu=0,state=${STATE_FILE}" -else - X2GO_HOST="nx/nx,link=${X2GO_LINK},pack=${X2GO_PACK},limit=0,root=${SESSION_DIR},cache=8M,images=32M,type=${X2GO_TYPE},id=${SESSION_NAME},cookie=${X2GO_COOKIE},errors=${SESSION_LOG},kbtype=${X2GO_KBD_TYPE},${option_geometry}xinerama=${xinerama_option},resize=${X2GO_RESIZE},fullscreen=${X2GO_FULLSCREEN},accept=${REMOTE},listen=${GR_PORT}${clipboard},client=linux,menu=0,state=${STATE_FILE}" + kbtype_option="null/null" fi +# Ensure X2GO_NXOPTIONS ends with a , if needed +if [[ -n "${X2GO_NXOPTIONS}" ]]; then + X2GO_NXOPTIONS="${X2GO_NXOPTIONS%,}," +fi -echo "${X2GO_HOST}:${X2GO_PORT}" >"${SESSION_DIR}/options" +echo "nx/nx,link=${X2GO_LINK},pack=${X2GO_PACK},limit=0,root=${SESSION_DIR},cache=8M,images=32M,type=${X2GO_TYPE},id=${SESSION_NAME},cookie=${X2GO_COOKIE},errors=${SESSION_LOG},kbtype=${kbtype_option},${option_geometry}xinerama=${xinerama_option},resize=${X2GO_RESIZE},fullscreen=${X2GO_FULLSCREEN},accept=${REMOTE},listen=${GR_PORT}${clipboard},client=linux,menu=0,${X2GO_NXOPTIONS}state=${STATE_FILE}:${X2GO_PORT}" >"${SESSION_DIR}/options" NX_AGENT=":${X2GO_PORT}" SAVED_DISPLAY="${DISPLAY}" -- 1.8.3.1 --------------5605AD2EF3A86B724448E089-- ------------=_1543467905-17973-0--