X2Go Bug report logs - #1308
"--auth-attempts 0" doesn't deactivate interactive authentication

version graph

Package: pyhoca-cli; Maintainer for pyhoca-cli is X2Go Developers <x2go-dev@lists.x2go.org>; Source for pyhoca-cli is src:pyhoca-cli.

Reported by: <Nico.Lemanski@t-systems.com>

Date: Thu, 19 Jul 2018 12:30:02 UTC

Severity: normal

Tags: pending

Found in version 0.5.0.4

Fixed in version 0.5.99.1

Done: Mike Gabriel Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Bug is archived. No further changes may be made.

Full log


🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#1308: "--auth-attempts 0" doesn't deactivate interactive authentication
Reply-To: <Nico.Lemanski@t-systems.com>, 1308@bugs.x2go.org
Resent-From: <Nico.Lemanski@t-systems.com>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Thu, 19 Jul 2018 12:30:02 +0000
Resent-Message-ID: <handler.1308.B.153200339230697@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: report 1308
X-X2Go-PR-Package: pyhoca-cli
X-X2Go-PR-Keywords: 
Received: via spool by submit@bugs.x2go.org id=B.153200339230697
          (code B); Thu, 19 Jul 2018 12:30:02 +0000
Received: (at submit) by bugs.x2go.org; 19 Jul 2018 12:29:52 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.7 required=3.0 tests=BAYES_50,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU autolearn=ham autolearn_force=no version=3.4.1
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 53A925DAE6
	for <submit@bugs.x2go.org>; Thu, 19 Jul 2018 14:29:50 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id t_AXfBsH_l8Y for <submit@bugs.x2go.org>;
	Thu, 19 Jul 2018 14:29:43 +0200 (CEST)
X-Greylist: delayed 1163 seconds by postgrey-1.35 at ymir.das-netzwerkteam.de; Thu, 19 Jul 2018 14:29:42 CEST
Received: from mailout34.telekom.de (MAILOUT34.telekom.de [194.25.225.146])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 0C4815DACF
	for <submit@bugs.x2go.org>; Thu, 19 Jul 2018 14:29:42 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  d=t-systems.com; i=@t-systems.com; q=dns/txt; s=mail;
  t=1532003382; x=1563539382;
  h=from:to:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=WFU9kseonFzZ5/mfq3SFrHkRfZFuDmJscsEnueO5Yhg=;
  b=Q1jARkC5MCOX/HyXRX8QRwdjhYBHt0woaRxP8E9xBUARM7S8jE6vTEjs
   b1+N8idoGcCgrQarMW0wr/QGx/+9Vnja95x0Vs0VPlnNshaU64XvdkW3b
   yyUbFiZQqVS/NDYedJSld3hRWzX4riOS4Sy5VKhbV3kCrGSW9m4XgMmX0
   wAqSnpC8zMO7rGIfy776hdB/ieiFz4tF7CTX6QUTOsZtHgq9HEAb6g7TL
   8IT6FMsNBsbviFJnXJnWnwrkp3kxjPxNV7a8tnlhSZ+gu9PvdW2s7pxl/
   JoWVaV0NYfp1fo5A040wjPKTdu/1mua+1ZBw1S8gFR2UCMLxwAxKmgpuV
   g==;
Received: from qde8e4.de.t-internal.com ([10.171.255.33])
  by MAILOUT31.dmznet.de.t-internal.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2018 14:01:09 +0200
X-IronPort-AV: E=Sophos;i="5.51,374,1526335200"; 
   d="scan'208";a="297349344"
Received: from he106163.emea1.cds.t-internal.com ([10.169.118.74])
  by QDE8PP.de.t-internal.com with ESMTP/TLS/AES256-SHA; 19 Jul 2018 14:01:06 +0200
Received: from HE106162.EMEA1.cds.t-internal.com (10.169.118.73) by
 HE106163.emea1.cds.t-internal.com (10.169.118.74) with Microsoft SMTP Server
 (TLS) id 15.0.1367.3; Thu, 19 Jul 2018 14:01:04 +0200
Received: from HE106162.EMEA1.cds.t-internal.com ([fe80::18a5:6ec:b055:cc19])
 by HE106162.emea1.cds.t-internal.com ([fe80::18a5:6ec:b055:cc19%26]) with
 mapi id 15.00.1367.000; Thu, 19 Jul 2018 14:01:04 +0200
From: <Nico.Lemanski@t-systems.com>
To: <submit@bugs.x2go.org>
Thread-Topic: "--auth-attempts 0" doesn't deactivate interactive
 authentication
Thread-Index: AdQfVCjX660/+6HlRBKSkLGU4dXt7A==
Date: Thu, 19 Jul 2018 12:01:04 +0000
Message-ID: <5c442719def3421a95cd6fc525fec8ad@HE106162.emea1.cds.t-internal.com>
Accept-Language: de-DE, en-US
Content-Language: de-DE
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.177.45.232]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Package: pyhoca-cli
Version: 0.5.0.4

When I call "pyhoca-cli" with the following options:
	"--password" followed by a wrong password
	"--auth-attempts 0"
I get a password prompt which has actually no effect even if I enter the correct password.

Example:
pyhoca-cli --server 192.168.1.2 -u exampleUser --password 'BADPASSWORD' --auth-attempts 0 -L --libdebug

Output:
[...]
pyhoca-cli[1028] (x2goclient-pylib) NOTICE: initializing X2Go session...
pyhoca-cli[1028] (x2gocontrolsession-pylib) NOTICE: connecting to [192.168.1.2]:22
pyhoca-cli[1028] (x2gocontrolsession-pylib) DEBUG: trying SSH key discovery or agent authentication with server
pyhoca-cli[1028] (x2gocontrolsession-pylib) INFO: unlock SSH private key file with provided password
pyhoca-cli[1028] (x2gocontrolsession-pylib) DEBUG: re-trying SSH key discovery now with passphrase for unlocking the key(s)
pyhoca-cli[1028] (PyHocaCLI) NOTICE: interactive login for user ,,exampleUser''
Password:
pyhoca-cli: error: non-interactive authentication failed
pyhoca-cli[1028] (x2goguardian-pylib) DEBUG: X2Go session guardian thread waking up after 3 seconds
pyhoca-cli[1028] (x2goguardian-pylib) DEBUG: calling session cleanup on profile Pyhoca-Client_Session for terminal session:

Expected behavior:
no password prompt
just exit with returnCode: 203

Suggestion:
In "PyHocaCLI.authenticate()" let "force_password_auth" only become true if "auth_attempts" is greater than 0.

System:
"Oracle Linux Server 7.4"

thanks

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Mar 28 23:25:24 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.