From unknown Mon May 18 02:31:44 2026
MIME-Version: 1.0
X-Mailer: MIME-tools 5.507 (Entity 5.507)
X-Loop: owner@bugs.x2go.org
From: owner@bugs.x2go.org (X2Go Bug Tracking System)
Subject: Bug#1308 closed by Mike Gabriel Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
 (X2Go issue (in src:pyhoca-cli) has been marked as closed)
Message-ID: <handler.1308.c.153732912720184.notifdone@bugs.x2go.org>
References: <20180919035100.211CD5DAEF@ymir.das-netzwerkteam.de>
X-X2go-PR-Keywords: pending
X-X2go-PR-Message: they-closed 1308
X-X2go-PR-Package: pyhoca-cli
X-X2go-PR-Source: pyhoca-cli
Date: Wed, 19 Sep 2018 03:55:12 +0000
Content-Type: multipart/mixed; boundary="----------=_1537329312-21011-0"

This is a multi-part message in MIME format...

------------=_1537329312-21011-0
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=utf-8

This is an automatic notification regarding your Bug report
which was filed against the pyhoca-cli package:

#1308: "--auth-attempts 0" doesn't deactivate interactive authentication

It has been closed by Mike Gabriel Mike Gabriel <mike.gabriel@das-netzwerkt=
eam.de>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Mike Gabriel Mike Gabr=
iel <mike.gabriel@das-netzwerkteam.de> by
replying to this email.


--=20
X2Go Bug Tracking System
Contact owner@bugs.x2go.org with problems

------------=_1537329312-21011-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at control) by bugs.x2go.org; 19 Sep 2018 03:52:07 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,NO_RELAYS,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.1
Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005)
	id 211CD5DAEF; Wed, 19 Sep 2018 05:50:59 +0200 (CEST)
From: =?utf-8?q?Mike_Gabriel?= Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: 1308-submitter@bugs.x2go.org
Cc: control@bugs.x2go.org, 1308@bugs.x2go.org
Subject: X2Go issue (in src:pyhoca-cli) has been marked as closed
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Message-Id: <20180919035100.211CD5DAEF@ymir.das-netzwerkteam.de>
Date: Wed, 19 Sep 2018 05:50:59 +0200 (CEST)

close #1308
thanks

Hello,

we are very hopeful that X2Go issue #1308 reported by you
has been resolved in the new release (0.6.0.0) of the
X2Go source project »src:pyhoca-cli«.

You can view the complete changelog entry of src:pyhoca-cli (0.6.0.0)
below, and you can use the following link to view all the code changes
between this and the last release of src:pyhoca-cli.

    http://code.x2go.org/gitweb?p=pyhoca-cli.git;a=commitdiff;h=1546795abc2ce7ff86851bdbc8658c8e38adcec9;hp=87b6c71c4966ca9abf7139e39c3d122143dded80

If you feel that the issue has not been resolved satisfyingly, feel
free to reopen this bug report or submit a follow-up report with
further observations described based on the new released version
of src:pyhoca-cli.

Thanks a lot for contributing to X2Go!!!

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
X2Go Component: src:pyhoca-cli
Version: 0.6.0.0-0x2go1
Status: RELEASE
Date: Tue, 18 Sep 2018 19:14:37 +0000
Fixes: 984 1287 1308
Changes:
 pyhoca-cli (0.6.0.0-0x2go1) RELEASED; urgency=medium
 .
   * New upstream version (0.5.99.1).
     - Port to Python3. (Fixes: #1287).
     - Add --force-password command line switch to override SSH key detection
       code.
     - Add --try-resume cmd line option and feature.
     - setup.py: Fix version string detection. (Copy+paste flaw...).
     - Fix duplicate password prompt. Regression fix.
     - keyboard handling: Switch to kbd-type auto and kbd-layout null. Should
       auto-detect the client-side keyboard in the X2Go session just fine.
     - pyhoca-cli main programme: Check for DISPLAY env var being set and having
       a usable / expectable value.
     - Add --forward-sshagent / -A cmdline option for enabling SSH agent
       forwarding.
     - Entirely rewrite PyHocaCLI.authenticate() function. (Fixes: #1308).
     - Fix --share-local-folders (aka -F) option and really mount shared folders.
       (Fixes: #984).
     - Make important options work like with OpenSSH's command-line client.
       E.g. pyhoca-cli -l <user> -i <key> -A <host>. This can still be improved
       but helps for now a big deal.
   * debian/rules:
     + Build for Python3, not Python2.
     + Switch to pybuild DH build system.
     + Enforce Python3 build, fix FTBFS.
     + Ignore failures during dh_auto_clean. Helps with build envs that don't have
       python3-setuptools installed when building source packages.
   * debian/control:
     + Fix src:pkg header part.
     + Switch to python3-* dependencies.
     + White-space fix.
     + Bump versioned D (pyhoca-cli): python-x2go (>= 0.5.99.0~).
     + Drop D (pyhoca-cli): python3-argparse. Part of stdlib in Python3
       these days.
   * debian/{control,compat}: Bump to DH version level 9.


------------=_1537329312-21011-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at submit) by bugs.x2go.org; 19 Jul 2018 12:29:52 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.7 required=3.0 tests=BAYES_50,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU autolearn=ham autolearn_force=no version=3.4.1
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 53A925DAE6
	for <submit@bugs.x2go.org>; Thu, 19 Jul 2018 14:29:50 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id t_AXfBsH_l8Y for <submit@bugs.x2go.org>;
	Thu, 19 Jul 2018 14:29:43 +0200 (CEST)
X-Greylist: delayed 1163 seconds by postgrey-1.35 at ymir.das-netzwerkteam.de; Thu, 19 Jul 2018 14:29:42 CEST
Received: from mailout34.telekom.de (MAILOUT34.telekom.de [194.25.225.146])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 0C4815DACF
	for <submit@bugs.x2go.org>; Thu, 19 Jul 2018 14:29:42 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  d=t-systems.com; i=@t-systems.com; q=dns/txt; s=mail;
  t=1532003382; x=1563539382;
  h=from:to:subject:date:message-id:
   content-transfer-encoding:mime-version;
  bh=WFU9kseonFzZ5/mfq3SFrHkRfZFuDmJscsEnueO5Yhg=;
  b=Q1jARkC5MCOX/HyXRX8QRwdjhYBHt0woaRxP8E9xBUARM7S8jE6vTEjs
   b1+N8idoGcCgrQarMW0wr/QGx/+9Vnja95x0Vs0VPlnNshaU64XvdkW3b
   yyUbFiZQqVS/NDYedJSld3hRWzX4riOS4Sy5VKhbV3kCrGSW9m4XgMmX0
   wAqSnpC8zMO7rGIfy776hdB/ieiFz4tF7CTX6QUTOsZtHgq9HEAb6g7TL
   8IT6FMsNBsbviFJnXJnWnwrkp3kxjPxNV7a8tnlhSZ+gu9PvdW2s7pxl/
   JoWVaV0NYfp1fo5A040wjPKTdu/1mua+1ZBw1S8gFR2UCMLxwAxKmgpuV
   g==;
Received: from qde8e4.de.t-internal.com ([10.171.255.33])
  by MAILOUT31.dmznet.de.t-internal.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2018 14:01:09 +0200
X-IronPort-AV: E=Sophos;i="5.51,374,1526335200"; 
   d="scan'208";a="297349344"
Received: from he106163.emea1.cds.t-internal.com ([10.169.118.74])
  by QDE8PP.de.t-internal.com with ESMTP/TLS/AES256-SHA; 19 Jul 2018 14:01:06 +0200
Received: from HE106162.EMEA1.cds.t-internal.com (10.169.118.73) by
 HE106163.emea1.cds.t-internal.com (10.169.118.74) with Microsoft SMTP Server
 (TLS) id 15.0.1367.3; Thu, 19 Jul 2018 14:01:04 +0200
Received: from HE106162.EMEA1.cds.t-internal.com ([fe80::18a5:6ec:b055:cc19])
 by HE106162.emea1.cds.t-internal.com ([fe80::18a5:6ec:b055:cc19%26]) with
 mapi id 15.00.1367.000; Thu, 19 Jul 2018 14:01:04 +0200
From: <Nico.Lemanski@t-systems.com>
To: <submit@bugs.x2go.org>
Subject: "--auth-attempts 0" doesn't deactivate interactive authentication
Thread-Topic: "--auth-attempts 0" doesn't deactivate interactive
 authentication
Thread-Index: AdQfVCjX660/+6HlRBKSkLGU4dXt7A==
Date: Thu, 19 Jul 2018 12:01:04 +0000
Message-ID: <5c442719def3421a95cd6fc525fec8ad@HE106162.emea1.cds.t-internal.com>
Accept-Language: de-DE, en-US
Content-Language: de-DE
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.177.45.232]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Package: pyhoca-cli
Version: 0.5.0.4

When I call "pyhoca-cli" with the following options:
	"--password" followed by a wrong password
	"--auth-attempts 0"
I get a password prompt which has actually no effect even if I enter the co=
rrect password.

Example:
pyhoca-cli --server 192.168.1.2 -u exampleUser --password 'BADPASSWORD' --a=
uth-attempts 0 -L --libdebug

Output:
[...]
pyhoca-cli[1028] (x2goclient-pylib) NOTICE: initializing X2Go session...
pyhoca-cli[1028] (x2gocontrolsession-pylib) NOTICE: connecting to [192.168.=
1.2]:22
pyhoca-cli[1028] (x2gocontrolsession-pylib) DEBUG: trying SSH key discovery=
 or agent authentication with server
pyhoca-cli[1028] (x2gocontrolsession-pylib) INFO: unlock SSH private key fi=
le with provided password
pyhoca-cli[1028] (x2gocontrolsession-pylib) DEBUG: re-trying SSH key discov=
ery now with passphrase for unlocking the key(s)
pyhoca-cli[1028] (PyHocaCLI) NOTICE: interactive login for user ,,exampleUs=
er''
Password:
pyhoca-cli: error: non-interactive authentication failed
pyhoca-cli[1028] (x2goguardian-pylib) DEBUG: X2Go session guardian thread w=
aking up after 3 seconds
pyhoca-cli[1028] (x2goguardian-pylib) DEBUG: calling session cleanup on pro=
file Pyhoca-Client_Session for terminal session:

Expected behavior:
no password prompt
just exit with returnCode: 203

Suggestion:
In "PyHocaCLI.authenticate()" let "force_password_auth" only become true if=
 "auth_attempts" is greater than 0.

System:
"Oracle Linux Server 7.4"

thanks

------------=_1537329312-21011-0--
