From ionic@ionic.de Thu Nov 2 20:08:51 2017 Received: (at 1230) by bugs.x2go.org; 2 Nov 2017 19:08:54 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.7 required=3.0 tests=BAYES_20,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 5DA4C5DACE for <1230@bugs.x2go.org>; Thu, 2 Nov 2017 20:08:51 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id biFBs2RCelpG for <1230@bugs.x2go.org>; Thu, 2 Nov 2017 20:08:44 +0100 (CET) Received: from mail.ionic.de (unknown [IPv6:2001:41d0:a:588b:1::2]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 4B0D45DACD for <1230@bugs.x2go.org>; Thu, 2 Nov 2017 20:08:43 +0100 (CET) Received: from [10.20.40.15] (178.162.222.163.adsl.inet-telecom.org [178.162.222.163]) by mail.ionic.de (Postfix) with ESMTPSA id 42CED4F000A3; Thu, 2 Nov 2017 20:08:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default; t=1509649722; bh=946EFCa4w+F3iXBvrcY6ffUCrsAGNnHpU/auc1H1r64=; h=Subject:To:References:From:Date:In-Reply-To:From; b=K4NkYd/JCPVN0KOPwqAd2kKX5LlAX3/wJSvH9/Q6B/XU+piic9ema7P7Zh8QH81+v XwrmG5KRsVNUJtVA/Cf54weAowHkvxiHnRJ7diJpaEeM+/D0ziIPK1t0bbAIS7dNtt zg8pSpLUXqdmCJcV9Q8XAOPmHM+F6ySFsMggjCDY= Subject: Re: [X2Go-Dev] x2go fails unhelpfully when a session fails to start To: Norman Gray , 1230@bugs.x2go.org References: From: Mihai Moldovan Message-ID: <4eef6d5a-03c4-cfa8-d01c-31badb85fc2c@ionic.de> Date: Thu, 2 Nov 2017 20:08:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sW1pREA0nktnmNkG2OS112fNc2nHdLEDS" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sW1pREA0nktnmNkG2OS112fNc2nHdLEDS Content-Type: multipart/mixed; boundary="9qnTMrnBgCUnBsQPWqexxTunQU2jUPDE3"; protected-headers="v1" From: Mihai Moldovan To: Norman Gray , 1230@bugs.x2go.org Message-ID: <4eef6d5a-03c4-cfa8-d01c-31badb85fc2c@ionic.de> Subject: Re: [X2Go-Dev] x2go fails unhelpfully when a session fails to start References: In-Reply-To: --9qnTMrnBgCUnBsQPWqexxTunQU2jUPDE3 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Control: tag -1 -pending Control: notfixed -1 4.0.1.21 On 10/27/2017 07:02 PM, Norman Gray wrote: > Package: x2goserver > Version: 4.0.1.20 >=20 > When a username is rejected by the 'valid username' test (see separate = > bug report), th= e=20 > session doesn't fail, but simply seems to hang, giving no feedback abou= t=20 > the problem, nor, as far as I can see, reporting anything in the logs. >=20 > To reproduce, attempt to log in using a username such as '123x'. The=20 > session doesn't complete the setup, leaving the user at a blank screen.= >=20 > Suggestion: a user-visible error message should be produced, and an=20 > informative message sent to the system log. I've tried catching errors while inserting values into the database, but = it turns out that doing this is not easily possible, since the current code = relies on brute-force adding of new DB entries and ignoring errors until it succ= eeds. If a hard error occurs that will make any insertion fail, of course this = will loop forever. I'll need to implement something more sophisticated that detects hard err= ors which will always lead to failures. Mihai --9qnTMrnBgCUnBsQPWqexxTunQU2jUPDE3-- --sW1pREA0nktnmNkG2OS112fNc2nHdLEDS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIzBAEBCgAdFiEEbhHQj3UzgcdE8cg8H9Yu2W4lOocFAln7bTkACgkQH9Yu2W4l Ooc7qw//UPEuVI+4ATLMZ1drQPDJXHlKSv+UHP1rtt/50i1bvwp4wsj5w5MMDTv6 2849ry9jFmu+Tyd7WskHMvlDvoJa+40QWPkszcLrrt8bzIOTzg7TMvZa+cMIASAX 5VIVoHVjZ76hPpN7w0PqLlnt/28LEdRKBRQSnDEPEq/nHNAnvpsToVL5nfWSgVT0 O5m2o+RYfMwn22JZQAFhj7Ppf7N5x5fJrXX2pRlVwvhiEX0bP7fsZVf6yDek+hXH c5vgSbf3oI2UhAktSe5LJiYbhyMn28KBO/XVOQoerQA0A2g2YpHuyh+bJcq1F9Z9 TBu+m/pXMGgWFODJ0XVzuFoLB6UfKn/pkEv05QearroW2CTNnmahzeQVRNliaxHC vVKMvXP1HLriO7+LqZUmjQJJ+dfY+CKXJIvzcMQgK8hWoyCfwWGcEm2R7voRi0vq 8jbNoYBWEGS5Uwz9iGrmjBYIAR8t9xbsZS+fRLnPLwzF6FKjdUI1/0o0pO2hARnk yNQX9+69sRq72sTm8rkJ2ISdcHVFl3u73bOk73AESv/68VKy6ho/AeYekKkelMPH u/ynDW7sLPC9YBYRqKZEYhFW5/o/qKkjd8YQjyO1D1bodFSmDwvolnGe3hwjsQXG /LbJ3uuEig48PZidXqGXJO35R8Y5OzwaU1/G3evfPn+FkjSN8Rs= =+/RQ -----END PGP SIGNATURE----- --sW1pREA0nktnmNkG2OS112fNc2nHdLEDS--