From x2go@ymir.das-netzwerkteam.de Thu Feb 15 21:42:38 2018 Received: (at control) by bugs.x2go.org; 15 Feb 2018 20:42:38 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id ED91E5DAEC; Thu, 15 Feb 2018 21:42:22 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g7jTpPAclo2X; Thu, 15 Feb 2018 21:42:18 +0100 (CET) Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id 6FD1A5DAEF; Thu, 15 Feb 2018 21:42:05 +0100 (CET) From: =?utf-8?q?X2Go_Release_Manager?= X2Go Release Manager To: 1227-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 1227@bugs.x2go.org Subject: X2Go issue (in src:x2goclient) has been marked as closed Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20180215204205.6FD1A5DAEF@ymir.das-netzwerkteam.de> Date: Thu, 15 Feb 2018 21:42:05 +0100 (CET) close #1227 thanks Hello, we are very hopeful that X2Go issue #1227 reported by you has been resolved in the new release (4.1.1.1) of the X2Go source project »src:x2goclient«. You can view the complete changelog entry of src:x2goclient (4.1.1.1) below, and you can use the following link to view all the code changes between this and the last release of src:x2goclient. http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=eef4bf3e0e618b15cbf6649e9dbb07d99e57ad00;hp=f0fb9c49b1c30fd025c2c7c9094fa662b8b09b4d If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:x2goclient. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:x2goclient Version: 4.1.1.1-0x2go1 Status: RELEASE Date: Thu, 15 Feb 2018 21:38:31 +0100 Fixes: 408 559 1122 1209 1214 1227 Changes: x2goclient (4.1.1.1-0x2go1) RELEASED; urgency=medium . [ Mihai Moldovan ] * New upstream version (4.1.1.1): - src/pulsemanager.cpp: print out PA --version output as a debug message. - macbuild.sh: also bundle xauth binary as nxauth binary. - macbuild.sh: switch to bundling PulseAudio 11.1 since it's now available in MacPorts. - src/sshmasterconnection.cpp: don't ask for private key passphrase if auto-login merely failed due to the server denying the public key. Fixes: #1122. - src/{httpbrokerclient,onmainwindow,sshmasterconnection}.{cpp,h}: introduce new passphrase_type enum and replace the old verificationCode boolean value with that. Allows using more messages, including a new one for plain password prompts. Adapt usage accordingly. The implementation is ugly, but there's no good way around that (short of using C++11 features). The enum would really logically belong to ONMainWindow, but since we also have to use it in SshMasterConnection, that may not include onmainwindow.h to avoid a circular dependency, it has to be part of SshMasterConnection for now. - src/sshmasterconnection.cpp: query for password if it wasn't already provided. Fixes: #1122. This usually happens if auto-login is enabled, which bypasses the password prompt. If auto-login fails, authentication normally continues via challenge auth or plain passwords, but since users had no chance to input a password, such authentication will always fail. Give users a way to enter passwords, in case the auto-login failed. - src/onmainwindow.cpp: finally include version information in debug output. - res/i18n/x2goclient_*.ts: apply last change to translation files directly. - src/sshmasterconnection.cpp: error out with a useful error message in case no password has been provided when doing password authentication. - src/sshmasterconnection.cpp: don't output an empty error message if password authencation has been requested but the server does not support this mechanism. Fixes: #408. - src/onmainwindow.cpp: wrap user name for client-side mounts in quotes. Fixes: #559. Will fail with user names that contain quotes, but oh well... - {example/x2goclient-cli,src/onmainwindow.cpp}: remove hopefully obsolete HOSTNAME exporting into environment. - src/onmainwindow.cpp: remove client-side LD_LIBRARY_PATH meddling. Nothing of value is in that directory and nxproxy hasn't needed that for years. - src/settingswidgets.cpp: don't incorrectly enable whole display settings in single display setups. Let debugging mode override this behavior, though. - src/onmainwindow.cpp: pass X2GO_RANDR_XINERAMA=[yes,no] to x2gostartagent as an environment variable based upon the xinerama session setting. Has no effect when connecting to older X2Go Server versions and handles startup correctly with X2Go Server 4.1.0.0. - src/onmainwindow.cpp: fix another leaked X2goSettings object. - src/onmainwindow.cpp: rename xinerama env variable on session startup to X2GO_XINERAMA in accordance with server changes. - src/onmainwindow.cpp: supply xinerama option as another parameter to x2goresume-session on session resume. - src/sessionbutton.cpp: make button non-sensitive in bottom right part if it's editable. Fixes: #1214. - {src/{help.cpp,onmainwindow.{cpp,h}},man/man1/x2goclient.1}: reformat, whitespace fixes, split out close button slot in a separate function. - src/onmainwindow.{cpp,h}: let close button be a member variable. - src/onmainwindow.cpp: disable and enable close button during and after connection startup. - src/onmainwindow.cpp: initialize directRDP to false to be able to call slotSuspendSessFromSt () even if no session has previously been started. - src/onmainwindow.cpp: only initialize directRDP variable if platform is Linux. Fixes compile failures on Windows and OS X. - src/onmainwindow.cpp: always create close button, but either hide or show it based upon whether --closebt was provided or not. - src/onmainwindow.cpp: revert 3060183a78d8b6bd81bec9968c985c38bfd1e5c2. Being able to suspend sessions via the close button is complex and unnecessary, since in thinclient mode, for which this feature is useful, users will not be able to see the client window while a session is executing, due to it running in full screen mode. - src/onmainwindow.cpp: always enable close button, let it log out from a broker if already authenticated or close the client on click. Fixes: #1209. - man/man1/x2goclient.1: clarify what the close button now does. It either lets the user re-login to the broker or closes the client. - src/onmainwindow.cpp: correctly initialize brokerAuthentication member of ConfigFile struct. - {res/{img/png/close-button.png,resources.qrc}, src/{{onmainwindow,httpbrokerclient}.{cpp,h},help.cpp}, man/man1/x2goclient.1}: rename close button to broker logout button. Reimplement the way it is shown - disable it upon startup and only enable it after successful broker authentication. - man/man1/x2goclient.1: add missing escape signs before dash/minus characters. . [ Oleksandr Shneyder ] * New upstream version (4.1.1.1): - Change echo mode for user input in InteractionDialog. . [ Walid Moghrabi ] * New upstream version (4.1.1.1): - {res/img/png/,res/resources.qrc}: add close-button.png file. - {src/{help.cpp,onmainwindow.{cpp,h}},man/man1/x2goclient.1}: add new option --closebt. Fixes: #1227. Adds a close button in the top-left client corner (maybe next to the halt button) that currently just terminates the client.