From unknown Thu Apr 09 09:47:22 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#1227: Close button in thinclient mode Reply-To: Walid MOGHRABI , 1227@bugs.x2go.org Resent-From: Walid MOGHRABI Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Fri, 20 Oct 2017 09:40:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: report 1227 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: patch Received: via spool by submit@bugs.x2go.org id=B.15084922086826 (code B); Fri, 20 Oct 2017 09:40:02 +0000 Received: (at submit) by bugs.x2go.org; 20 Oct 2017 09:36:48 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id B36F25DACB for ; Fri, 20 Oct 2017 11:36:40 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mbH2jBdbKjwr for ; Fri, 20 Oct 2017 11:36:25 +0200 (CEST) Received: from zm-01.servicemagic.eu (zm-01.servicemagic.eu [176.31.236.17]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 6C7D55DAC9 for ; Fri, 20 Oct 2017 11:36:25 +0200 (CEST) Received: from localhost (localhost.localdomain [127.0.0.1]) by zm-01.servicemagic.eu (Postfix) with ESMTP id 31B91806980EF for ; Fri, 20 Oct 2017 11:36:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 zm-01.servicemagic.eu 31B91806980EF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=servicemagic.eu; s=frmailing; t=1508492184; bh=Hdldr4B1SILbMmADw83msk4/VDIvJr9N5FmuDm3bHls=; h=Date:From:To:In-Reply-To:Subject:From; b=UTXEvtScvG14cTrwvdJz3impwgfmzyg77xxhqbTB08tmcImgZSg3SXXKiL0eX9bsR epirRNS18C8RbBt3BvOOYtGfeuWzTZ93/SM8PrWvKS/Er10rpp1QXyJLb5hSiqNZdm ZN+s9wv2Bv/GXnx+edr9UWsc0GP6QLg3A8KxKAI0= X-Amavis-Modified: Mail body modified (using disclaimer) - zm-01.servicemagic.eu X-Virus-Scanned: amavisd-new at servicemagic.eu Received: from zm-01.servicemagic.eu ([127.0.0.1]) by localhost (zm-01.servicemagic.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 76FvSl7c4AIw for ; Fri, 20 Oct 2017 11:36:23 +0200 (CEST) Received: from zm-01.servicemagic.eu (localhost.localdomain [127.0.0.1]) by zm-01.servicemagic.eu (Postfix) with ESMTP id 97296806C3E5B for ; Fri, 20 Oct 2017 11:36:23 +0200 (CEST) Date: Fri, 20 Oct 2017 11:36:23 +0200 (CEST) From: Walid MOGHRABI To: submit@bugs.x2go.org Message-ID: <770613922.23149205.1508492183476.JavaMail.root@servicemagic.eu> In-Reply-To: <1577356094.23148413.1508491803276.JavaMail.root@servicemagic.eu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_23149202_196796780.1508492183474" X-Originating-IP: [10.33.100.58] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - GC62 (Linux)/7.2.0_GA_2669) ------=_Part_23149202_196796780.1508492183474 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit package: x2goclient priority: wishlist tags: patch This is a proposal patch for a close button in addition to the current halt button in thinclient mode. Context : When logged in (right after the credentials prompt, in the client view where all available session slots are listed), if you entered by mistake and just want to get back to the credential form, there is o way to "logout". Only possibilities are : * halt button but it will shutdown the computer * log to a remote X2Go session then logout which is a annoying process. The patch is not complete, currently it adds the button but the same way as for halt button and it simply close the client which is slow instead of just get back to the credential form which would be smoother and faster. Regards, Walid Moghrabi TRAVAUX.COM BAT I - PARC CEZANNE 2 290 AVENUE GALILEE - CS 80403 13591 AIX EN PROVENCE CEDEX 3 --- DISCLAIMER: This e-mail is private and confidential and may contain proprietary or legally privileged information. It is for the intended recipient only. If you have received this email in error, please notify the author by replying to it and then destroy it. If you are not the intended recipient you must not use, disclose, distribute, copy, print or rely on this e-mail or any attachment. Thank you ------=_Part_23149202_196796780.1508492183474 Content-Type: text/x-patch; name=Adds-a-close-button-in-thinclient-mode.patch Content-Disposition: attachment; filename=Adds-a-close-button-in-thinclient-mode.patch Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL21hbi9tYW4xL3gyZ29jbGllbnQuMSBiL21hbi9tYW4xL3gyZ29jbGllbnQu MQppbmRleCA1NzM4MDQ3Li5mNGQyYzIyIDEwMDY0NAotLS0gYS9tYW4vbWFuMS94MmdvY2xpZW50 LjEKKysrIGIvbWFuL21hbjEveDJnb2NsaWVudC4xCkBAIC0xOTEsNiArMTkxLDEwIEBACiBcKihU PFxmQlwtXC1oYWx0YnRcZlJcKihUPgogU2hvdyBhICJTaHV0ZG93biIgYnV0dG9uIGluIHRoZSB0 b3AgbGVmdCBjb3JuZXIgb2YgWDJHbyBDbGllbnQuIFdoZW4gcHJlc3NlZCwgWDJHbyBDbGllbnQg d2lsbCBjcmVhdGUgdGhlIGZpbGUKICRIT01FLy5oYWx0LiBBbiBleHRlcm5hbCBzY3JpcHQgaGFz IHRvIHdhdGNoIGZvciB0aGlzIGZpbGUgYW5kIHRyaWdnZXIgYSB0aGluY2xpZW50IHNodXRkb3du IG9uY2UgaXQgYXBwZWFycy4KKy5UUAorXCooVDxcZkJcLVwtY2xvc2VidFxmUlwqKFQ+CitTaG93 IGEgIkNsb3NlIiBidXR0b24gaW4gdGhlIHRvcCBsZWZ0IGNvcm5lciBvZiBYMkdvIENsaWVudCB3 aGVuIGxvZ2dlZCBpbiBicm9rZXIvdGhpbmNsaWVudCBtb2RlLiAKK1doZW4gcHJlc3NlZCwgWDJH byBDbGllbnQgd2lsbCBiZSBjbG9zZWQgYW5kIGF1dG9tYXRpY2FseSByZXN0YXJ0ZWQgaWYgaW4g dGhpbmNsaWVudCBtb2RlLgogCiAuU0ggUE9SVEFCTEUgT1BUSU9OUwogWDJHbyBDbGllbnQgY2Fu IGJlIGluc3RhbGxlZCBvbiBhIFVTQi1GbGFzaGRyaXZlIGFzIGEgcG9ydGFibGUgYXBwbGljYXRp b25zLiBJZiBpbnN0YWxsZWQgdGhhdCB3YXksIHRoZSBmb2xsb3dpbmcKZGlmZiAtLWdpdCBhL3Jl cy9pbWcvcG5nL2Nsb3NlLWJ1dHRvbi5wbmcgYi9yZXMvaW1nL3BuZy9jbG9zZS1idXR0b24ucG5n Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmY1Yjk5MGYKLS0tIC9kZXYvbnVs bAorKysgYi9yZXMvaW1nL3BuZy9jbG9zZS1idXR0b24ucG5nCkJpbmFyeSBmaWxlcyBkaWZmZXIK ZGlmZiAtLWdpdCBhL3Jlcy9yZXNvdXJjZXMucXJjIGIvcmVzL3Jlc291cmNlcy5xcmMKaW5kZXgg NDc4YmI1NS4uZWFkZGY2MSAxMDA2NDQKLS0tIGEvcmVzL3Jlc291cmNlcy5xcmMKKysrIGIvcmVz L3Jlc291cmNlcy5xcmMKQEAgLTE2LDYgKzE2LDcgQEAKICAgICAgICA8ZmlsZT5pbWcvcG5nL3Nl c3NfaWNvLnBuZzwvZmlsZT4KICAgICAgICA8ZmlsZT5pbWcvcG5nL2ljb180NDB4MTgwLnBuZzwv ZmlsZT4KICAgICAgICA8ZmlsZT5pbWcvcG5nL3Bvd2VyLWJ1dHRvbi5wbmc8L2ZpbGU+CisgICAg ICAgPGZpbGU+aW1nL3BuZy9jbG9zZS1idXR0b24ucG5nPC9maWxlPgogICAgICAgIDxmaWxlPmlt Zy9pY29ucy8xMjh4MTI4L3gyZ28ucG5nPC9maWxlPgogICAgICAgIDxmaWxlPmltZy9pY29ucy8x Mjh4MTI4L2ZvbGRlci5wbmc8L2ZpbGU+CiAgICAgICAgPGZpbGU+aW1nL2ljb25zLzEyOHgxMjgv eDJnb3Nlc3Npb24ucG5nPC9maWxlPgpkaWZmIC0tZ2l0IGEvc3JjL2hlbHAuY3BwIGIvc3JjL2hl bHAuY3BwCmluZGV4IDBlNTRkZjYuLjZmZWVmMWUgMTAwNjQ0Ci0tLSBhL3NyYy9oZWxwLmNwcAor KysgYi9zcmMvaGVscC5jcHAKQEAgLTEyNSw2ICsxMjUsNyBAQAogICBBRERfT1BUICgiLS1sZGFw LXByaW50aW5nIiwgUVRfVFJBTlNMQVRFX05PT1AgKCJIZWxwIiwgIkFsbG93cyBjbGllbnQgc2lk ZSBwcmludGluZyBpbiBMREFQIG1vZGUuIikpOwogICBBRERfT1BUICgiLS10aGluY2xpZW50Iiwg UVRfVFJBTlNMQVRFX05PT1AgKCJIZWxwIiwgIkVuYWJsZXMgdGhpbmNsaWVudCBtb2RlLiBTdGFy dHMgd2l0aG91dCBhIHdpbmRvdyBtYW5hZ2VyLiIpKTsKICAgQUREX09QVCAoIi0taGFsdGJ0Iiwg UVRfVFJBTlNMQVRFX05PT1AgKCJIZWxwIiwgIkVuYWJsZXMgc2h1dGRvd24gYnV0dG9uLiIpKTsK KyAgQUREX09QVCAoIi0tY2xvc2VidCIsIFFUX1RSQU5TTEFURV9OT09QICgiSGVscCIsICJFbmFi bGVzIGNsb3NlIGJ1dHRvbi4iKSk7CiAgIEFERF9PUFQgKCItLWFkZC10by1rbm93bi1ob3N0cyIs IFFUX1RSQU5TTEFURV9OT09QICgiSGVscCIsICJBZGRzIFJTQSBrZXkgZmluZ2VycHJpbnQgdG8g XCIuc3NoL2tub3duX2hvc3RzXCIgaWYgYXV0aGVudGljaXR5IG9mIHRoZSBzZXJ2ZXIgY2FuJ3Qg YmUgZGV0ZXJtaW5lZC4iKSk7CiAgIEFERF9PUFQgKCItLWxkYXA9PGhvc3Q6cG9ydDpkbj4iLCBR VF9UUkFOU0xBVEVfTk9PUCAoIkhlbHAiLCAiU3RhcnRzIHdpdGggTERBUCBzdXBwb3J0LiBFeGFt cGxlOiAtLWxkYXA9bGRhcHNlcnZlcjozODk6bz1vcmdhbml6YXRpb24sYz1kZSIpKTsKICAgQURE X09QVCAoIi0tbGRhcDE9PGhvc3Q6cG9ydD4iLCBRVF9UUkFOU0xBVEVfTk9PUCAoIkhlbHAiLCAi RGVmaW5lcyB0aGUgZmlyc3QgTERBUCBmYWlsb3ZlciBzZXJ2ZXIuIikpOwpkaWZmIC0tZ2l0IGEv c3JjL29ubWFpbndpbmRvdy5jcHAgYi9zcmMvb25tYWlud2luZG93LmNwcAppbmRleCBlMWRhMmM4 Li4zNjljMzhjIDEwMDY0NAotLS0gYS9zcmMvb25tYWlud2luZG93LmNwcAorKysgYi9zcmMvb25t YWlud2luZG93LmNwcApAQCAtNzgsNiArNzgsNyBAQAogICAgIHRoaW5Nb2RlPWZhbHNlOwogICAg IGNsb3NlRGlzY29ubmVjdD1mYWxzZTsKICAgICBzaG93SGFsdEJ0bj1mYWxzZTsKKyAgICBzaG93 Q2xvc2VCdG49ZmFsc2U7CiAgICAgZGVmYXVsdFVzZVNvdW5kPXRydWU7CiAgICAgZGVmYXVsdFNl dEtiZD10cnVlOwogICAgIGV4dFN0YXJ0ZWQ9ZmFsc2U7CkBAIC01MjMsNiArNTI0LDI1IEBACiAg ICAgICAgIGNvbm5lY3QoYkhhbHQsU0lHTkFMKGNsaWNrZWQoKSksdGhpcywgU0xPVChzbG90U2h1 dGRvd25UaGluQ2xpZW50KCkpKTsKICAgICB9CiAKKyAgICBpZiAoc2hvd0Nsb3NlQnRuKQorICAg IHsKKyAgICAgICAgUVB1c2hCdXR0b24qIGJDbG9zZT1uZXcgUVB1c2hCdXR0b24oYmdGcmFtZSk7 CisgICAgICAgIFFQaXhtYXAgcCgiOi9pbWcvcG5nL2Nsb3NlLWJ1dHRvbi5wbmciKTsKKyAgICAg ICAgYkNsb3NlLT5zZXRJY29uKHApOworICAgICAgICBiQ2xvc2UtPnNldEZvY3VzUG9saWN5KFF0 OjpOb0ZvY3VzKTsKKyAgICAgICAgYkNsb3NlLT5zZXRGaXhlZFNpemUoMzIsMzIpOworICAgICAg ICBpZiAoc2hvd0hhbHRCdG4pCisgICAgICAgIHsKKyAgICAgICAgICAgIGJDbG9zZS0+bW92ZSg0 MCwxMCk7CisgICAgICAgIH0KKyAgICAgICAgZWxzZQorICAgICAgICB7CisgICAgICAgICAgICBi Q2xvc2UtPm1vdmUoMTAsMTApOworICAgICAgICB9CisgICAgICAgIGJDbG9zZS0+c2hvdygpOwor ICAgICAgICBjb25uZWN0KGJDbG9zZSxTSUdOQUwoY2xpY2tlZCgpKSx0aGlzLCBTTE9UKGNsb3Nl KCkpKTsKKyAgICB9CisKICAgICBpZiAoYnJva2VyTW9kZSkKICAgICB7CiAgICAgICAgIGJyb2tl cj1uZXcgSHR0cEJyb2tlckNsaWVudCAoIHRoaXMsICZjb25maWcgKTsKQEAgLTc0MDUsNiArNzQy NSwxMSBAQAogICAgICAgICBzaG93SGFsdEJ0bj10cnVlOwogICAgICAgICByZXR1cm4gdHJ1ZTsK ICAgICB9CisgICAgaWYgKHBhcmFtID09ICItLWNsb3NlYnQiKQorICAgIHsKKyAgICAgICAgc2hv d0Nsb3NlQnRuPXRydWU7CisgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KICAgICBpZiAoIHBh cmFtPT0iLS1oaWRlIiApCiAgICAgewogICAgICAgICBzdGFydEhpZGRlbj10cnVlOwpkaWZmIC0t Z2l0IGEvc3JjL29ubWFpbndpbmRvdy5oIGIvc3JjL29ubWFpbndpbmRvdy5oCmluZGV4IDVkM2Q3 MjguLjExNmIxNmMgMTAwNjQ0Ci0tLSBhL3NyYy9vbm1haW53aW5kb3cuaAorKysgYi9zcmMvb25t YWlud2luZG93LmgKQEAgLTc5Niw2ICs3OTYsNyBAQAogICAgIGJvb2wgdXNlTGRhcDsKICAgICBi b29sIHNob3dUb29sQmFyOwogICAgIGJvb2wgc2hvd0hhbHRCdG47CisgICAgYm9vbCBzaG93Q2xv c2VCdG47CiAgICAgYm9vbCBuZXdTZXNzaW9uOwogICAgIGJvb2wgcnVuU3RhcnRBcHA7CiAgICAg Ym9vbCBsZGFwT25seTsK ------=_Part_23149202_196796780.1508492183474 Content-Type: image/png; name=close-button.png Content-Disposition: attachment; filename=close-button.png Content-Transfer-Encoding: base64 iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAABHNCSVQICAgIfAhkiAAAAAlwSFlz AAAJOgAACToB8GSSSgAAABl0RVh0U29mdHdhcmUAd3d3Lmlua3NjYXBlLm9yZ5vuPBoAAAOqSURB VFiFvZdBT2NVFMf/z6R9jS66oISWLhpXbBzaRj+AMTEaF7p5tAv4BC00Ma5MgELUuDJuBnTRPWlY QPQDCAHb0bhg4Ya0uNCZQFtJBp0mQkt+LsrDy2tLHzOMJ7mL9+655/8/595z7rmWfApgS3pH0oeS 3pT0uqSwpAtJjyU1JP0q6XtJP1iWde7X9ijgSeBb4C/8yxnwDRAbZd+6BTgkaVHSx5JeNecajYYO Dw91enoq27YVj8cVj8cViUS8ZtqSvpb0hWVZ/9zF6xjwk+lSrVZjaWmJ6elpJA0cyWSS5eVl6vW6 NyJVIOoXPAk8dleenJyQy+UIBAJDgb0jEAiQz+dpNBomiT+AB6PAo1eKAFQqFaLRqG9g74hEIuzs 7JgkngDxYeAhM+wbGxvYtv3c4O6wbZtyuezdjtAgAp+7Gvv7+/cCbpKoVComiVUv+CTQdvd8YmKi z0gikSAcDo8EC4fDJBKJvv/RaJRms+kSeHbjUNLLcwByuVzf4lKpBEC73SaTyQwFdxyHdrsNQKlU 6ptfWFgwo7DugttcFZlardZ32hOJxI186nQ6ZLPZPuPZbJZOp3ND1xuJYDBopuhTICjgA/fP4uLi wJC6Xg0jMQi83W4P3LJisWiqvSd6JRNgaJHJZDJ9AC6JQeCdTgfHcQbaSqVSpuqagJ8Bjo+Pbz1c juP0AV1eXtLtdm/863a7zM7O3mrLKFCPBPwJsLu7O/KEDyJxV3BJ7O3tuUuaAi4Atra2fOW04zh9 XrvR8AMuie3tbXfZ+SuSziXJtm35EcsaeoHeOjdUgEOAg4ODkcxnZmZGbsHc3Nydt2AHoNVq3Rl8 2CEcRcKoiI8ErLtfyWTypadhOp02VR8KeN/9Wl5efumFaHV11VR71y3FZ/D/lOKjoyN3uleKrw7i dTXM5/N9xu/rMioUCia/NTMTYvSuSBqNxsAu6EWv41gsRqvVcsH/xtsjAp+5s5VK5V4bklAoRLVa Nb1fkVfotWTXWuVy+V5IhEIhNjc3TfAf6T1y+oVeU/q7q1mtVl+oKY3FYl7PnwCTA8ENEg8wOuNm s8n8/Pyd2vJgMEihUDD3nCvH3rgV3BOJG9Tr9TrFYpFUKjUUOJ1Os7KyYqaaGfaJQVijnmafSvpE 0mvmXKvVun6aSdLY2JimpqY0Pj7uNfNM0leSvnzux+pVNNbpFQ6/8hRYw8dzzPf9Sa9qvS3pI0lv 6b/nuSSdSfpN0i+SvpO0Y1nWhR+7/wK4kB9e3ZQSGAAAAABJRU5ErkJggg== ------=_Part_23149202_196796780.1508492183474--