From unknown Fri May 01 17:17:10 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#1183: [X2Go-Dev] Bug#1183: Pass broker creds to RDP client as plaintext Reply-To: Mike Gabriel , 1183@bugs.x2go.org Resent-From: Mike Gabriel Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Wed, 31 May 2017 20:00:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 1183 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: patch Received: via spool by 1183-submit@bugs.x2go.org id=B1183.149626072130116 (code B ref 1183); Wed, 31 May 2017 20:00:02 +0000 Received: (at 1183) by bugs.x2go.org; 31 May 2017 19:58:41 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 4393C5DAD3 for <1183@bugs.x2go.org>; Wed, 31 May 2017 21:58:40 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Dwe-wFogG9hk for <1183@bugs.x2go.org>; Wed, 31 May 2017 21:58:33 +0200 (CEST) Received: from fregna.das-netzwerkteam.de (fregna.das-netzwerkteam.de [148.251.53.130]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 637A05DACE for <1183@bugs.x2go.org>; Wed, 31 May 2017 21:58:33 +0200 (CEST) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [IPv6:2a01:4f8:202:1381::105]) by fregna.das-netzwerkteam.de (Postfix) with ESMTPS id 0F47A60748; Wed, 31 May 2017 19:58:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 03AA5C7C8A; Wed, 31 May 2017 21:58:33 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QMEavv4nciCW; Wed, 31 May 2017 21:58:28 +0200 (CEST) Received: from das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id 73CE8C7C85; Wed, 31 May 2017 21:58:28 +0200 (CEST) Received: from p57B5CC09.dip0.t-ipconnect.de (p57B5CC09.dip0.t-ipconnect.de [87.181.204.9]) by mail.das-netzwerkteam.de (Horde Framework) with HTTPS; Wed, 31 May 2017 19:58:28 +0000 Date: Wed, 31 May 2017 19:58:28 +0000 Message-ID: <20170531195828.Horde.vAcyRcGCGpIX0L09g1bH-8e@mail.das-netzwerkteam.de> From: Mike Gabriel To: Walid MOGHRABI , 1183@bugs.x2go.org References: <1917592832.211198.1490277173586.JavaMail.root@servicemagic.eu> <1693780969.10950067.1496241649670.JavaMail.root@servicemagic.eu> In-Reply-To: <1693780969.10950067.1496241649670.JavaMail.root@servicemagic.eu> User-Agent: Horde Application Framework 5 Accept-Language: de,en Organization: DAS-NETZWERKTEAM X-Originating-IP: 87.181.204.9 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 Content-Type: multipart/signed; boundary="=_pXq0OcvXuYV6HgJ8HoRarfo"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_pXq0OcvXuYV6HgJ8HoRarfo Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Walid, On Mi 31 Mai 2017 16:40:49 CEST, Walid MOGHRABI wrote: > package: x2goclient > priority: wishlist > tags: patch > > This is a proposal patch in order to let the RDP client use the=20=20 >=20credentials used at broker auth login so that users can enter them=20= =20 >=20only once in broker mode. > > This patch also add support for --close-disconnect in broker mode + RDP I just looked at your patch. Requests before patch can get accepted: 1. Please split up the RDP broker creds as session creds from the=20=20 --close-disconnect=20change. 2. Please let the cmdline option start with --broker-... --broker-use-creds-for-session 3. Don't limit this functionality to RDP sessions only. It is=20=20 useful=20for all sorts of session types (X2Go, DirectRDP, DirectXDMCP if already in (there were=20=20 rumours=20about such a new feature)). Thanks for your work on X2Go, Mike --=20 DAS-NETZWERKTEAM mike=20gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de --=_pXq0OcvXuYV6HgJ8HoRarfo Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIzBAABCAAdFiEEm/uu6GwKpf+/IgeCmvRrMCV3GzEFAlkvIGMACgkQmvRrMCV3 GzGmWQ//V7hpqpHA4DMO6nsv1Ftv8xf4MMpnCKcOdtaoQWIoI/fQpFtqFJQw32EO DaacVob6IjsEG6yuvnMfcogiuZkuUUj8qNonuC/5Y7dtc74xarr/asVzmBBzZhJv Qp8w1te2/GPPjf1cqHRNEmzz5KSRrT+aUvtEgPXjxF7wO43w4+xi2qCiFGS4RLMK gx4Z0WFiXQFN1G2Gip4fKove4MAlafK5fvKKVrxAmwKskBWq5c/ggF632VY6W+7y T1JF3QN7rmZO7pBXNE/01vRvZ5mXUg62NgBYSywL/0NP03ABkJX2eynx6ST3GpCU JF19qebh0ATxQZCDHX18mQHW7+Ur2Nc7OJ9iy6wARMdqvwRlacVIShe8dGEDAqfg 9mA8oQjI6AEzuNxl7T+PwT9J0b3JsrqpojtjuYkts1o+7Q79B3QT8lOUPR99mVAe 32Kk2ZOW5lcXhP46j5VAH6cudMQzn8jncnGvv82kwFehTioQ690g5FGVdN76gXPj VzK+jGXC4mtRVLrAhJFbvFhhfedW1adH5B2+Pl6WzDmERNWv6RPnvosa4iVPotjT se+/bStZSFybFVhOEbY0T/gLmD+oZt4ybbP8Z5uW9z5cjHQ8WCLOwdhhCEXahigu 3e5lW88SVbbxrqL/AIwLR69jkMu8Y80sdo84WtzSJYIjvCGv0nQ= =/S6D -----END PGP SIGNATURE----- --=_pXq0OcvXuYV6HgJ8HoRarfo--