From unknown Sat May 16 01:18:26 2026
MIME-Version: 1.0
X-Mailer: MIME-tools 5.507 (Entity 5.507)
X-Loop: owner@bugs.x2go.org
From: owner@bugs.x2go.org (X2Go Bug Tracking System)
Subject: Bug#1165 closed by X2Go Release Manager X2Go Release Manager
 <git-admin@x2go.org> (X2Go issue (in src:x2goclient) has been marked as
 closed)
Message-ID: <handler.1165.c.150926318524206.notifdone@bugs.x2go.org>
References: <20171029074553.3A79A5DADC@ymir.das-netzwerkteam.de>
X-X2go-PR-Keywords: patch pending
X-X2go-PR-Message: they-closed 1165
X-X2go-PR-Package: x2goclient
X-X2go-PR-Source: x2goclient
Date: Sun, 29 Oct 2017 07:50:11 +0000
Content-Type: multipart/mixed; boundary="----------=_1509263411-25172-0"

This is a multi-part message in MIME format...

------------=_1509263411-25172-0
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=utf-8

This is an automatic notification regarding your Bug report
which was filed against the x2goclient package:

#1165: Random background support

It has been closed by X2Go Release Manager X2Go Release Manager <git-admin@=
x2go.org>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact X2Go Release Manager X=
2Go Release Manager <git-admin@x2go.org> by
replying to this email.


--=20
X2Go Bug Tracking System
Contact owner@bugs.x2go.org with problems

------------=_1509263411-25172-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at control) by bugs.x2go.org; 29 Oct 2017 07:46:25 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.1
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 69B045DAD8;
	Sun, 29 Oct 2017 08:46:22 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id n12kFiXdAD9u; Sun, 29 Oct 2017 08:46:18 +0100 (CET)
Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005)
	id 3A79A5DADC; Sun, 29 Oct 2017 08:45:53 +0100 (CET)
From: =?utf-8?q?X2Go_Release_Manager?= X2Go Release Manager <git-admin@x2go.org>
To: 1165-submitter@bugs.x2go.org
Cc: control@bugs.x2go.org, 1165@bugs.x2go.org
Subject: X2Go issue (in src:x2goclient) has been marked as closed
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Message-Id: <20171029074553.3A79A5DADC@ymir.das-netzwerkteam.de>
Date: Sun, 29 Oct 2017 08:45:53 +0100 (CET)

close #1165
thanks

Hello,

we are very hopeful that X2Go issue #1165 reported by you
has been resolved in the new release (4.1.1.0) of the
X2Go source project »src:x2goclient«.

You can view the complete changelog entry of src:x2goclient (4.1.1.0)
below, and you can use the following link to view all the code changes
between this and the last release of src:x2goclient.

    http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=eafcb63c2ac63ae7ce43886949945e710c81bd3d;hp=add03ee78f3dcbee3317bf17a08dcb2cbeb12ee7

If you feel that the issue has not been resolved satisfyingly, feel
free to reopen this bug report or submit a follow-up report with
further observations described based on the new released version
of src:x2goclient.

Thanks a lot for contributing to X2Go!!!

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
X2Go Component: src:x2goclient
Version: 4.1.1.0-0x2go1
Status: RELEASE
Date: Sun, 29 Oct 2017 08:43:45 +0100
Fixes: 31 499 592 870 930 966 1093 1100 1119 1121 1152 1165 1185 1186
Changes:
 x2goclient (4.1.1.0-0x2go1) RELEASED; urgency=medium
 .
   [ Mihai Moldovan ]
   * New upstream version (4.1.1.0):
     - src/sshmasterconnection.cpp: use ssh_channel_listen_forward () instead
       of ssh_forward_listen () for newer libssh versions. Fixes: #870.
     - src/sshmasterconnection.cpp: with libssh 0.6.0 and newer, get the public
       key via ssh_get_server_publickey () (0.8.0 and higher) or
       ssh_get_publickey () (0.7.x and lower) and its hash via
       ssh_get_publickey_hash () instead of using the deprecated
       ssh_get_pubkey_hash () function. Additionally, replace free () with the
       more appropriate ssh_string_free_char () function after using
       ssh_get_hexa (). This will break on very old systems with a hopelessly
       outdated libssh version, but we do not care about these systems in the
       first place.
     - src/sshmasterconnection.cpp: replace string_free () with its successor
       ssh_string_free (). Will break on ancient systems, but we don't care.
     - src/sshmasterconnection.cpp: replace deprecated channel_new () function
       with ssh_channel_new (). Might break on ancient systems, but we don't
       care. Also, add error handling in case ssh_channel_new () failed...
     - src/sshmasterconnection.cpp: replace deprecated channel_open_forward ()
       function with ssh_channel_open_forward (). Might break on ancient
       systems, but we don't care.
     - src/sshmasterconnection.cpp: replace deprecated channel_open_session ()
       function with ssh_channel_open_session (). Might break on ancient
       systems, but we don't care.
     - src/sshmasterconnection.cpp: replace deprecated channel_request_exec ()
       function with ssh_channel_request_exec (). Might break on ancient
       systems, but we don't care.
     - src/sshmasterconnection.cpp: replace deprecated channel_poll () function
       with ssh_channel_poll (). Might break on ancient systems, but we don't
       care.
     - src/sshmasterconnection.cpp: replace deprecated channel_read () function
       with ssh_channel_read (). Might break on ancient systems, but we don't
       care.
     - src/sshmasterconnection.cpp: replace deprecated channel_is_eof ()
       function with ssh_channel_is_eof (). Might break on ancient systems, but
       we don't care.
     - src/sshmasterconnection.cpp: replace deprecated channel_write ()
       function with ssh_channel_write (). Might break on ancient systems, but
       we don't care.
     - src/sshmasterconnection.cpp: replace deprecated channel_send_eof ()
       function with ssh_channel_send_eof (). Might break on ancient systems,
       but we don't care.
     - src/sshmasterconnection.cpp: replace deprecated channel_close ()
       function with ssh_channel_close (). Might break on ancient systems, but
       we don't care.
     - src/sshmasterconnection.cpp: replace deprecated channel_free () function
       with ssh_channel_free (). Might break on ancient systems, but we don't
       care.
     - src/sshmasterconnection.cpp: use QString::arg () to insert function name
       and thus deduplicate error translation messages. Also re-add the full
       stop sign and remove it when needed for x2goDebug.
     - src/sshmasterconnection.cpp: fix up some debug strings.
     - src/sshmasterconnection.cpp: port more occurrences of "QString to C
       string" akin to 1b21d75f2c10609f3586f5b5e0b4ceb7fca83fdd.
     - src/sshmasterconnection.cpp: enable parsing of ~/.ssh/config.
       Fixes: #1121. Shorthands as host names and other bells and whistles like
       inferred port or user name values are now supported.
     - src/{onmainwindow,httpbrokerclient}.cpp: fix up error/warning message
       displayed when the server-specified key is unknown, but we have another
       key type stored already.
     - src/pulsemanager.cpp: fix up a debug string. Qt drops a space where I'd
       like to have one and inserts a space where I'd like none, so work around
       that fancifully.
     - src/sshmasterconnection.cpp: libssh < 0.6.0 does not have the
       ssh_options_get () API, but instead expects users to pull out
       information directly from the ssh_session structure. This fixes compile
       issues on systems with older libssh versions.
     - src/sshmasterconnection.cpp: turns out libssh < 0.6.0 doesn't support
       fetching the host, port and username parameters at all. We're in the
       clear for non-SSH-proxied connections and can use config file parsing,
       but have to disable config file parsing in the proxy settings, as
       there's no way to query the remote endpoint information. As a result we
       will be unable to open a new socket to the remote endpoint and proxying
       will fail badly.
     - src/x2goutils.cpp: ensure that add_to_path () also processes the first
       value passed. Fixes startup problems in MacPorts. Fixes: #1093.
     - res/i18n/x2goclient_et.ts: various fixups for the Estonian translation
       file.
     - res/i18n/x2goclient_*.ts: go the extra mile and fix up translation files
       manually after the "anothertype" fix in
       8e503d89ee2d03a313c3deff11f0516fce503022.
     - {src/{onmainwindow,httpbrokerclient}.cpp,res/i18n/x2goclient_*.ts}: fix
       another occurrence of a string missing a space separator between words
       and update translation files.
     - src/onmainwindow.cpp: don't duplicate depth warning message needlessly,
       use correct plural forms in translations and split string up in a
       translation-friendly form. I'll leave translators to handle this beast,
       as languages are unique in the number of plural forms and the like.
     - {src/printdialog.cpp,res/i18n/x2goclient_*.ts}: drop spurious left-over
       parenthesis in warning message and adapt translations.
     - src/onmainwindow.cpp: make the "not loading translator" message
       non-translatable, as it doesn't make a lot of sense to actually
       translate it.
     - {src/{configdialog,x2goutils}.cpp,res/i18n/x2goclient_*.ts}: change
       XQuartz project homepage references, adapt translations.
     - src/pulsemanager.{cpp,h}: make get_* () functions const.
     - src/pulsemanager.{cpp,h}: make is_server_running () const.
     - src/pulsemanager.{cpp,h}: add new pulse_version_valid_ boolean class
       member variable, set it correctly and use it whenever the version is
       accessed.
     - src/pulsemanager.cpp: make fetch_pulseaudio_version () more resilient.
       Instead of aborting hard when the version number could not be detected,
       break out of the loops only. We can make stuff work, even if the version
       is unknown. Or just continue without PA support as such.
     - src/pulsemanager.{cpp,h}: add show_startup_warning () for both PA server
       and (debug) startup sound playback.
     - src/pulsemanager.cpp: check server_binary_ before using it and jump over
       code that assumes the PA server binary to be available.
     - src/pulsemanager.cpp: don't fail hard on OS X if the PA server binary
       could not be found in the constructor. We can live without PA and will
       show a warning message to the user later on when PA is supposed to be
       started.
     - src/pulsemanager.cpp: deduplicate warning/error messages - make use of
       show_startup_warning (). This does imply changes to the translation
       files, coming up next.
     - res/i18n/x2goclient_*.ts: regenerate translation files and fix up some
       SSH and PulseManager messages manually, where possible.
     - src/x2ogutils.h: guard UNUSED macro definition.
     - {macbuild.sh,src/{x2goutils.h,{pulsemanager,onmainwindow}.cpp},
        x2goclient.pro}: make MacPorts prefix selectable at compile time. Much
       cleaner for downstream package maintainers (like, for instance, MacPorts
       itself.)
     - res/i18n/x2goclient_fi.ts: remove outdated comment.
     - src/sshprocess.cpp: bind direct tunnel socket to localhost instead of
       any address. Fixes: #31.
     - src/onmainwindow.cpp: check for sessionExplorer->getLastSession() to be
       valid in all places but obvious ones. Fixes: #499.
     - src/sshmasterconnection.cpp: use new PKI-based libssh API for public key
       authentication for libssh 0.6.0 and higher. Fixes: #1119.
     - src/sshmasterconnection.cpp: add YubiKey challenge auth prompt.
     - src/sshmasterconnection.cpp: fix compile errors on pre-libssh-0.6.0
       systems and add a TOCTU-race check to see if the file exists prior to
       calling privatekey_from_file () on such systems. Additionally fix a type
       issue.
     - macbuild.sh: fix long-standing issue that made the DMG bundle contain a
       symlink made up of only a space to /Applications.
     - res/img/icons/dmg: add new image disk.svg, used as the basis for the new
       OS X DMG bundle icon.
     - res/img/icons/dmg: add new disk-drive-and-x2goclient icon for use as the
       volume icon of the OS X DMG bundle.
     - macbuild.sh: use the new volume icon that actually also looks like a
       disk drive. Fixes: #930.
     - src/onmainwindow.cpp: typo fix only.
     - src/onmainwindow.cpp: do not automatically set login user name to
       current system user if empty. Unbreaks default user name fetching via
       libssh. Might break some use cases (especially RDP, XDMCP).
     - src/x2goclient.cpp: revert change bypassing the UNIX cleanup helper.
     - src/onmainwindow.cpp: revert old behavior and select user name field
       after a session has been suspended/terminated if user name was not
       provided. Do not insert an user name, though, but leave it to
       autodetection by default.
     - src/sshmasterconnection.cpp: fix SSH-proxied connections with port
       numbers of zero.
       In order to authenticate the remote server, SSH-proxied connections must
       be reset to their remote host and port values after connecting via the
       SSH tunnel. If the original port value was zero, setting it was skipped,
       leading to connections like $REMOTE_HOST:$PROXY_PORT, which is certainly
       wrong. Fetch the inferred port value and set this instead, fixing this
       issue.
     - Makefile: add new QMAKE_OPTS variable so that packagers can pass
       additional options to qmake directly.
     - src/sshmasterconnection.cpp: typo fix in log message only.
     - src/sshmasterconnection.cpp: don't leak ssh_session data, free it once
       we're done with it.
     - Makefile: qmake seems to act weird if QMAKE_C(XX)FLAGS starts with a
       space followed by additional non-whitespace characters. Refactor the
       variables a bit to work around this issue.
     - Makefile: turns out the only somewhat portable way to do something like
       this is via shell hackery.
     - Makefile: reset to the original state and make sure that we don't pass
       CXXFLAGS on to the actual build process to not override the values
       generated by qmake.
     - Makefile: the only way to prevent variables on the command line to be
       passed down seems to be to remove them from MAKEOVERRIDES.
       .MAKEOVERRIDES is the FreeBSD-make-equivalent variable. MAKEFLAGS has no
       effect on this behavior, so removing it again.
     - Makefile: add comment explaining why we need to do this in the first
       place and why it's so complicated.
     - src/sshmasterconnection: ignore "garbage", but require at least one line
       to start with a known challenge auth prompt. Fixes: #966.
     - x2goclient.pro: add libssh_threads library. We need this since X2Go
       Client is multi-threaded.
     - copy-deps-win32.bat: also copy libssh_threads.dll to go with the
       previous change.
     - src/{onmainwindow,sshmasterconnection}.{cpp,h}: correctly initialize and
       finalize libssh. We ought to do both only once - in our main thread.
       Previously, we initialized libssh in a new thread, which might be
       problematic.
     - src/sessionexplorer.cpp: open the correct tab when editing a session
       from the exports menu.
     - src/onmainwindow.cpp: try to workaround window placement if settings
       contain a (newly) invalid position (e.g., a position that refers to a
       disconnected display.)
     - src/onmainwindow.cpp: try to find a display that can hold the window's
       position fetched from the sizes settings. Use the default if none could
       be found.
     - src/onmainwindow.cpp: fix up main window position check; use
       QRect.intersects ().
     - src/pulsemanager.{cpp,h}: rename shutdownState to shutdown_state_,
       reorder in initializer list.
     - res/i18n/: regenerate translations.
     - res/i18n/x2goclient_es.ts: fixup Spanish translation file.
     - res/i18n/x2goclient_et.ts: fixup some typos in the Estonian translation
       file.
     - res/i18n/x2goclient_sv.ts: add singular form to translation entry as
       discussed on list.
     - res/i18n/x2goclient_es.ts: add singular form to translation entry as
       discussed off list.
     - res/i18n/x2goclient_nl.ts: various fixups for Dutch translation file.
     - res/i18n/x2goclient_nb_no.ts: various fixups for Bokmål (Norway)
       translation file.
     - res/i18n/x2goclient_nl.ts: fix whitespace issues in Dutch translation
       file and re-add numerus form translation.
     - res/i18n/x2goclient_nb_no.ts: various fixups for Bokmål (Norway)
       translation file, including numerus form.
     - src/sshmasterconnection.cpp: for proxied connections, fetch the user
       name matching the given host, not proxy host.
     - res/i18n/x2goclient_fi.ts: various fixups for Finnish translation file.
     - res/i18n/x2goclient_fi.ts: another tiny whitespace fixup for Finnish
       translation file.
     - src/onmainwindow.cpp: fix "XMDCP" typo.
     - res/i18n/x2goclient_de.ts: various fixups for German translation file.
     - src/onmainwindow.cpp: fix "loose" vs. "lose" spelling mistake.
     - res/i18n/x2goclient_et.ts: remove obsolete and wrongly capitalized
       "x2go" part from an Estonian translation message.
     - res/i18n/x2goclient_sv.ts: minor whitespace fixup.
     - res/i18n/x2goclient_*.ts: apply "XMDCP" -> "XDMCP" fix manually to
       translation files.
     - res/i18n/x2goclient_nb_no.ts: remove obsolete comments (leading to
       problems when regenerating translation files.)
     - res/i18n/x2goclient_nl.ts: remove obsolete comments (leading to problems
       when regenerating translation files.)
     - res/i18n/x2goclient_*.ts: regenerate translations.
     - res/i18n/x2goclient_fi.ts: various fixups for Finnish translation file.
     - src/sshmasterconnection.cpp: spelling fix. (Quiting -> Quitting)
     - x2gobrowserplugin-2.4_1/src/qtbrowserplugin.cpp: spelling fix.
       (convertable -> convertible)
   * x2goclient.spec:
     - Respect %{optflags} and pass QMAKE_STRIP=: to fix missing debug info
       issues.
 .
   [ Oleksandr Shneyder ]
   * New upstream version (4.1.1.0):
     - Interaction with SSH server (for example for changing
       expired password). Fixes: #592.
     - Fixing setting widget style issue in InteractionDialog on
       Windows client.
     - SSH Interaction for SSH Broker and SSH Server.
     - SSH Iteraction for method keyboard-interactive.
     - Move PulseManager MsgBox functions to main window:
       GUI functions should be used only from main thread.
     - Check "norecord" option on the first start of PulseAudio.
     - Disable/Enable PulseAudio in config dialog.
       New command line options:
       --disable-pulse to disable start of PulseAudio
       --disable-pulse-record to disable audio input.
     - Check if PulseAudio running at session start and resuming
       when sound is enabled. Show warning if PulseAudio not running
       and disable the sound support for the session to avoid
       session freezes.
     - Add session config file option "sshproxysamekey". With this option
       client will use for proxy authentication same key as for X2Go server.
       This is important in first case for broker users, where key can be
       generated "on the fly". Maybe it makes sence to add this option in UI
       and command line later.
     - Correct negative display coordinates for FS sessions.
 .
   [ Robert Parts ]
   * New upstream version (4.1.1.0):
     - res/i18n/x2goclient_et.ts: update Estonian translation file.
     - res/i18n/x2goclient_et.ts: update Estonian translation file.
 .
   [ Martti Pitkänen ]
   * New upstream version (4.1.1.0):
     - res/i18n/x2goclient_fi.ts: update Finnish translation file.
     - res/i18n/x2goclient_fi.ts: update Finnish translation file.
     - res/i18n/x2goclient_fi.ts: update Finnish translation file.
 .
   [ Mike DePaulo ]
   * New upstream version (4.1.1.0):
     - Windows: Upgrade PulseAudio from 6.0 to 7.1
       Fixes: #1152 Issues with audio when playing HTML5 videos
     - Windows: Remove uninstaller from start menu.
       It is still available in "Programs and Features".
     - Windows: Upgrade Win32 OpenSSL from 1.0.1t to 1.0.2k
       Fixes numerous CVEs
     - Windows: Upgrade libssh from 0.7.0 to 0.7.4 (while maintaining
       Pageant support).
       The possibly relevant changes are:
         + CVE-2016-0739 was fixed
         + improved id_ed25519 support
         + numerous bug fixes
     - Windows: Update PuTTY from 0.67 to 0.68
       The possibly relevant changes are:
         + CVE-2016-6167 was fixed (did not affect X2Go Client by
           default because the installation dir is not writeable by
           users)
         + CVE-2017-6542 was fixed
     - Don't override PATH for the actual session or application
       command.
       Fixes: #1100
 .
   [ Walid Moghrabi ]
   * New upstream version (4.1.1.0):
     - {src/{help.cpp,onmainwindow.{cpp,h}},man/man1/x2goclient.1}: let
       --background take a directory and randomly pick an SVG file in there.
       Fixes: #1165.
     - {src/{help.cpp,onmainwindow.{cpp,h}},man/man1/x2goclient.1}:
       pass-through broker credentials when connecting to a direct RDP session.
       Fixes: #1185.
       Adds a new  --broker-use-creds-for-session parameter.
     - src/onmainwindow.cpp: support --close-disconnect for direct RDP
       sessions. Fixes: #1186.
 .
   [ Daniel Lindgren ]
   * New upstream version (4.1.1.0):
     - res/i18n/x2goclient_sv.ts: update Swedish translation file.
 .
   [ Ricardo Díaz Martín ]
   * New upstream release (4.1.1.0):
     - res/i18n/x2goclient_es.ts: update Spanish translation file.
 .
   [ Jos Wolfkamp ]
   * New upstream version (4.1.1.0):
     - res/i18n/x2goclient_nl.ts: update Dutch translation file.
     - res/i18n/x2goclient_nl.ts: update Dutch translation file.
 .
   [ Klaus Ade Johnstad ]
   * New upstream version (4.1.1.0):
     - res/i18n/x2goclient_nb_no.ts: update Bokmål (Norway) translation file.
     - res/i18n/x2goclient_nb_no.ts: update Bokmål (Norway) translation file.
 .
   [ Stefan Baur ]
   * New upstream release (4.1.1.0):
     - res/i18n/x2goclient_de.ts: update German translation file.
 .
   [ Sébastien Ducoulombier ]
   * New upstream version (4.1.1.0):
     - res/i18n/x2goclient_fr.ts: update French translation file.


------------=_1509263411-25172-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at submit) by bugs.x2go.org; 23 Mar 2017 13:53:10 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham autolearn_force=no version=3.4.1
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 2B1BA5DAD0
	for <submit@bugs.x2go.org>; Thu, 23 Mar 2017 14:53:08 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id oNAxhE6jl-jn for <submit@bugs.x2go.org>;
	Thu, 23 Mar 2017 14:53:01 +0100 (CET)
Received: from zm-01.servicemagic.eu (zm-01.servicemagic.eu [176.31.236.17])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 089595DA4C
	for <submit@bugs.x2go.org>; Thu, 23 Mar 2017 14:53:00 +0100 (CET)
Received: from localhost (localhost.localdomain [127.0.0.1])
	by zm-01.servicemagic.eu (Postfix) with ESMTP id 78284807FF9B9
	for <submit@bugs.x2go.org>; Thu, 23 Mar 2017 14:52:58 +0100 (CET)
X-Amavis-Modified: Mail body modified (using disclaimer) -
	zm-01.servicemagic.eu
X-Virus-Scanned: amavisd-new at servicemagic.eu
Received: from zm-01.servicemagic.eu ([127.0.0.1])
	by localhost (zm-01.servicemagic.eu [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 1OLvZrJHrKmQ for <submit@bugs.x2go.org>;
	Thu, 23 Mar 2017 14:52:57 +0100 (CET)
Received: from zm-01.servicemagic.eu (localhost.localdomain [127.0.0.1])
	by zm-01.servicemagic.eu (Postfix) with ESMTP id 411BC80B17593
	for <submit@bugs.x2go.org>; Thu, 23 Mar 2017 14:52:57 +0100 (CET)
Date: Thu, 23 Mar 2017 14:52:53 +0100 (CET)
From: Walid MOGHRABI <w.moghrabi@servicemagic.eu>
To: submit@bugs.x2go.org
Message-ID: <1917592832.211198.1490277173586.JavaMail.root@servicemagic.eu>
In-Reply-To: <1719550560.33223559.1484326519373.JavaMail.root@servicemagic.eu>
Subject: Random background support
MIME-Version: 1.0
Content-Type: multipart/mixed; 
	boundary="----=_Part_211196_742579119.1490277173584"
X-Originating-IP: [10.33.100.60]
X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - GC57 (Linux)/7.2.0_GA_2669)

------=_Part_211196_742579119.1490277173584
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

package: x2goclient
priority: wishlist
tags: patch

This is a proposal patch in order to add support for randomly picked backround image from a directory.

I did this because I'd like to have my TCEs load different pictures each time they're on a bit like the welcome picture on Windows 10.
This patch only check if the --background parameter is a directory and if so, pick randomly a SVG file from it.


Regards,
Walid Moghrabi

TRAVAUX.COM
BAT I - PARC CEZANNE 2 290 AVENUE GALILEE - CS 80403
13591 AIX EN PROVENCE CEDEX 3

---
DISCLAIMER: This e-mail is private and confidential and may contain proprietary or legally privileged information. It is for the intended recipient only. If you have received this email in error, please notify the author by replying to it and then destroy it. If you are not the intended recipient you must not use, disclose, distribute, copy, print or rely on this e-mail or any attachment. Thank you
------=_Part_211196_742579119.1490277173584
Content-Type: text/x-patch; name=x2goclient-random-background-support.patch
Content-Disposition: attachment;
 filename=x2goclient-random-background-support.patch
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL21hbi9tYW4xL3gyZ29jbGllbnQuMSBiL21hbi9tYW4xL3gyZ29jbGllbnQu
MQppbmRleCBkOTBhODg4Li5jOWUxNTMxIDEwMDY0NAotLS0gYS9tYW4vbWFuMS94MmdvY2xpZW50
LjEKKysrIGIvbWFuL21hbjEveDJnb2NsaWVudC4xCkBAIC05NCw5ICs5NCwxMCBAQCBUaGUgc3Vw
cG9ydCBpbmZvcm1hdGlvbiBpcyBwcm92aWRlZCB2aWEgYSBzaW1wbGUgSFRNTCBmaWxlLiBFeGFt
cGxlOgogLlJFCiAuXH0KIC5UUAotXCooVDxcZkJcLVwtYmFja2dyb3VuZD08c3ZnLWZpbGU+XGZS
XCooVD4KK1wqKFQ8XGZCXC1cLWJhY2tncm91bmQ9PHN2Zy1maWxlfGRpcj5cZlJcKihUPgogVXNl
IGEgY3VzdG9tL2JyYW5kZWQgYmFja2dyb3VuZCBpbWFnZSAoU1ZHIGZvcm1hdCkgZm9yIFgyR28g
Q2xpZW50J3MgbWFpbiB3aW5kb3cgKGkuZS4gcmVwbGFjZSB0aGUgYmx1ZSBncmFkaWVudCBhcmVh
CiBpbiBYMkdvIENsaWVudCBieSBzb21lIGJhY2tncm91bmQgb2YgeW91ciBvd24gKGJ1c2luZXNz
L3dvcmtncm91cC9wcm9qZWN0KS4KK0lmIGEgZGlyZWN0b3J5IGlzIGdpdmVuLCB3aWxsIHJhbmRv
bWx5IHBpY2sgYSBTVkcgZmlsZSBpbnNpZGUuCiAuVFAKIFwqKFQ8XGZCXC1cLWJyYW5kaW5nPTxz
dmctZmlsZT5cZlJcKihUPgogVXNlIGEgY3VzdG9tIGljb24gKFNWRyBmb3JtYXQpIGZvciBhZGRp
dGlvbmFsIGJyYW5kaW5nIHRvIHJlcGxhY2UgdGhlIGRlZmF1bHQgaW4gdGhlIGxvd2VyIGxlZnQg
Y29ybmVyIG9mIFgyR28gQ2xpZW50J3MgbWFpbiB3aW5kb3cuCmRpZmYgLS1naXQgYS9zcmMvaGVs
cC5jcHAgYi9zcmMvaGVscC5jcHAKaW5kZXggZTNjYjFkZS4uMDVjNzA4ZiAxMDA2NDQKLS0tIGEv
c3JjL2hlbHAuY3BwCisrKyBiL3NyYy9oZWxwLmNwcApAQCAtMTU0LDcgKzE1NCw3IEBAIGhlbHA6
OnBhcmFtc190IGhlbHA6OmJ1aWxkX3BhcmFtcyAoKSB7CiAgIEFERF9PUFQgKCItLWJyb2tlci1z
c2gta2V5PTxwYXRoIHRvIGtleT4iLCBRVF9UUkFOU0xBVEVfTk9PUCAoIkhlbHAiLCAiU2V0cyB0
aGUgcGF0aCB0byBhbiBTU0gga2V5IHRvIHVzZSBmb3IgYXV0aGVudGljYXRpb24gYWdhaW5zdCBh
biBTU0ggc2Vzc2lvbiBicm9rZXIuIFRoZSBjbGllbnQncyBiZWhhdmlvciBpcyB1bmRlZmluZWQg
aWYgdGhpcyBmbGFnIGlzIHVzZWQgZm9yIG5vbi1TU0ggc2Vzc2lvbiBicm9rZXJzLiIpKTsKICAg
QUREX09QVCAoIi0tYnJva2VyLWF1dG9sb2dpbiIsIFFUX1RSQU5TTEFURV9OT09QICgiSGVscCIs
ICJFbmFibGVzIHRoZSB1c2Ugb2YgdGhlIGRlZmF1bHQgU1NIIGtleSBvciBTU0ggYWdlbnQgZm9y
IGF1dGhlbnRpY2F0aW9uIGFnYWluc3QgYW4gU1NIIHNlc3Npb24gYnJva2VyLiBUaGUgY2xpZW50
J3MgYmVoYXZpb3IgaXMgdW5kZWZpbmVkIGlmIHRoaXMgZmxhZyBpcyB1c2VkIGZvciBub24tU1NI
IHNlc3Npb24gYnJva2Vycy4iKSk7CiAgIEFERF9PUFQgKCItLWJyb2tlci1ub2F1dGgiLCBRVF9U
UkFOU0xBVEVfTk9PUCAoIkhlbHAiLCAiRG9lcyBub3QgYXNrIGZvciB1c2VyIGNyZWRlbnRpYWxz
IGR1cmluZyBzZXNzaW9uIGJyb2tlciBhdXRoZW50aWNhdGlvbi4gVGhpcyBjYW4gYmUgdXNlZnVs
IGlmIHlvdSBhcmUgdXNpbmcgYW4gSFRUUChTKSBzZXNzaW9uIGJyb2tlciB3aXRob3V0IGF1dGhl
bnRpY2F0aW9uLiBJZiB5b3UgcnVuIGFuIEhUVFAoUykgc2VydmVyIHdpdGhvdXQgYXV0aGVudGlj
YXRpb24sIGJ1dCB3aXRoIHVzZXItc3BlY2lmaWMgcHJvZmlsZXMsIHRoZW4gcHV0IHRoZSB1c2Vy
IG5hbWUgaW50byB0aGUgYnJva2VyIFVSTCAocmVmZXIgdG8gLS1icm9rZXItdXJsLikgVGhlIHVz
ZXIgbmFtZSB0aGVuIHdpbGwgYmUgZXh0cmFjdGVkIGZyb20gdGhlIGJyb2tlciBVUkwgYW5kIGJl
IHNlbnQgdG8gdGhlIHNlc3Npb24gYnJva2VyLiBUaGUgY2xpZW50J3MgYmVoYXZpb3IgaXMgdW5k
ZWZpbmVkIGlmIHRoaXMgZmxhZyBpcyB1c2VkIGZvciBub24tSFRUUChTKSBzZXNzaW9uIGJyb2tl
cnMuIikpOwotICBBRERfT1BUICgiLS1iYWNrZ3JvdW5kPTxzdmctZmlsZT4iLCBRVF9UUkFOU0xB
VEVfTk9PUCAoIkhlbHAiLCAiVXNlIGEgY3VzdG9tL2JyYW5kZWQgYmFja2dyb3VuZCBpbWFnZSAo
U1ZHIGZvcm1hdCkgZm9yIFgyR28gQ2xpZW50J3MgbWFpbiB3aW5kb3cuIikpOworICBBRERfT1BU
ICgiLS1iYWNrZ3JvdW5kPTxzdmctZmlsZXxkaXI+IiwgUVRfVFJBTlNMQVRFX05PT1AgKCJIZWxw
IiwgIlVzZSBhIGN1c3RvbS9icmFuZGVkIGJhY2tncm91bmQgaW1hZ2UgKFNWRyBmb3JtYXQpIGZv
ciBYMkdvIENsaWVudCdzIG1haW4gd2luZG93LiBJZiBkaXJlY3RvcnkgaXMgZ2l2ZW4sIHdpbGwg
cmFuZG9tbHkgcGljayBhIFNWRyBmaWxlIGluc2lkZS4iKSk7CiAgIEFERF9PUFQgKCItLWJyYW5k
aW5nPTxzdmctZmlsZT4iLCBRVF9UUkFOU0xBVEVfTk9PUCAoIkhlbHAiLCAiVXNlIGEgY3VzdG9t
IGljb24gKFNWRyBmb3JtYXQpIGZvciBhZGRpdGlvbmFsIGJyYW5kaW5nIHRvIHJlcGxhY2UgdGhl
IGRlZmF1bHQgaW4gdGhlIGxvd2VyIGxlZnQgY29ybmVyIG9mIFgyR28gQ2xpZW50J3MgbWFpbiB3
aW5kb3cuIikpOwogCiAjIHVuZGVmIE5FV0xJTkUKZGlmZiAtLWdpdCBhL3NyYy9vbm1haW53aW5k
b3cuY3BwIGIvc3JjL29ubWFpbndpbmRvdy5jcHAKaW5kZXggNWRkMzkwNi4uOGFjM2Y2OCAxMDA2
NDQKLS0tIGEvc3JjL29ubWFpbndpbmRvdy5jcHAKKysrIGIvc3JjL29ubWFpbndpbmRvdy5jcHAK
QEAgLTM0MiwxMCArMzQyLDI2IEBAIE9OTWFpbldpbmRvdzo6T05NYWluV2luZG93ICggUVdpZGdl
dCAqcGFyZW50ICkgOlFNYWluV2luZG93ICggcGFyZW50ICkKIAogCiAjaWZuZGVmIFFfV1NfSElM
RE9OCisKKwkvLyBTZWUgaWYgQkdGaWxlIGlzIGEgZGlyZWN0b3J5IGFuZCByZXRyaWV2ZSBhIFNW
RyBmaWxlIHJhbmRvbWx5IGZyb20gd2l0aGluCisJUUZpbGVJbmZvIEJHRGlyKEJHRmlsZSk7CisJ
aWYgKEJHRGlyLmlzRGlyKCkpCisJeworCQlRRGlySXRlcmF0b3IgaXQoQkdGaWxlLCBRU3RyaW5n
TGlzdCgpIDw8ICIqLnN2ZyIsIFFEaXI6OkZpbGVzLCBRRGlySXRlcmF0b3I6Ok5vSXRlcmF0b3JG
bGFncyk7CisJCVFTdHJpbmdMaXN0IGZpbGVMaXN0OworCQl3aGlsZSAoaXQuaGFzTmV4dCgpKQor
CQkJZmlsZUxpc3QgPDwgaXQubmV4dCgpOworCisJCXFzcmFuZChRVGltZTo6Y3VycmVudFRpbWUo
KS5tc2VjKCkpOworCQlpbnQgbWF4PWZpbGVMaXN0LnNpemUoKTsKKwkJaW50IHJhbmRvbV9zZWxl
Y3Rvcj0oc3RhdGljX2Nhc3Q8aW50PigxICsgKHN0YXRpY19jYXN0PGZsb2F0PihxcmFuZCgpKSAv
IFJBTkRfTUFYICogbWF4KSkpIC0gMTsKKwkJQkdGaWxlPWZpbGVMaXN0LmF0KHJhbmRvbV9zZWxl
Y3Rvcik7CisJfQorCiAgICAgaWYgKEJHRmlsZS5zaXplKCkpCi0gICAgICAgIGJnRnJhbWU9bmV3
IFNWR0ZyYW1lICggKCBRU3RyaW5nICkgQkdGaWxlLHRydWUsZnIgKTsKKyAgIAkgICAgYmdGcmFt
ZT1uZXcgU1ZHRnJhbWUgKCAoIFFTdHJpbmcgKSBCR0ZpbGUsdHJ1ZSxmciApOwogICAgIGVsc2UK
LSAgICAgICAgYmdGcmFtZT1uZXcgU1ZHRnJhbWUgKCAoIFFTdHJpbmcgKSAiOi9pbWcvc3ZnL2Jn
LnN2ZyIsdHJ1ZSxmciApOworICAgCSAgICBiZ0ZyYW1lPW5ldyBTVkdGcmFtZSAoICggUVN0cmlu
ZyApICI6L2ltZy9zdmcvYmcuc3ZnIix0cnVlLGZyICk7CiAjZWxzZQogICAgIGJnRnJhbWU9bmV3
IFNWR0ZyYW1lICggKCBRU3RyaW5nICkgIjovaW1nL3N2Zy9iZ19oaWxkb24uc3ZnIix0cnVlLGZy
ICk7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL3NyYy9vbm1haW53aW5kb3cuaCBiL3NyYy9vbm1haW53
aW5kb3cuaAppbmRleCAzN2I0NTRjLi44OGY3NDE3IDEwMDY0NAotLS0gYS9zcmMvb25tYWlud2lu
ZG93LmgKKysrIGIvc3JjL29ubWFpbndpbmRvdy5oCkBAIC00Niw2ICs0Niw3IEBACiAjaW5jbHVk
ZSA8UVByb2Nlc3NFbnZpcm9ubWVudD4KICNpbmNsdWRlICJzc2htYXN0ZXJjb25uZWN0aW9uLmgi
CiAjaW5jbHVkZSAibm9uX21vZGFsX21lc3NhZ2Vib3guaCIKKyNpbmNsdWRlIDxRRGlySXRlcmF0
b3I+CiAKIAogI2lmZGVmIFFfT1NfV0lOCg==
------=_Part_211196_742579119.1490277173584--

------------=_1509263411-25172-0--
