X2Go Bug report logs - #1164
proposed patch for 2800-x2go-thinclientconfig in live-build-x2go overlay to handle custom image urls passed in as kernel boot options

version graph

Package: live-build-x2go; Maintainer for live-build-x2go is (unknown);

Reported by: Seth Galitzer <sgsax@ksu.edu>

Date: Tue, 21 Mar 2017 19:10:02 UTC

Severity: normal

Found in version master

Done: Mihai Moldovan <ionic@ionic.de>

Bug is archived. No further changes may be made.

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#1164: proposed patch for 2800-x2go-thinclientconfig in live-build-x2go overlay to handle custom image urls passed in as kernel boot options
Reply-To: Mihai Moldovan <ionic@ionic.de>, 1164@bugs.x2go.org
Resent-From: Mihai Moldovan <ionic@ionic.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: owner@bugs.x2go.org
X-Loop: owner@bugs.x2go.org
Resent-Date: Tue, 25 Apr 2017 21:20:02 +0000
Resent-Message-ID: <handler.1164.B1164.149315506815530@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 1164
X-X2Go-PR-Package: live-build-x2go, feature/openbox branch
X-X2Go-PR-Keywords: 
Received: via spool by 1164-submit@bugs.x2go.org id=B1164.149315506815530
          (code B ref 1164); Tue, 25 Apr 2017 21:20:02 +0000
Received: (at 1164) by bugs.x2go.org; 25 Apr 2017 21:17:48 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_BLOCKED,T_SPF_HELO_TEMPERROR,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.1
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id DA7735DACF
	for <1164@bugs.x2go.org>; Tue, 25 Apr 2017 23:17:44 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 8Ki3DUQyXdcP for <1164@bugs.x2go.org>;
	Tue, 25 Apr 2017 23:17:37 +0200 (CEST)
Received: from Root24.de (powered.by.root24.eu [5.135.3.88])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 8D92D5DA4A
	for <1164@bugs.x2go.org>; Tue, 25 Apr 2017 23:17:37 +0200 (CEST)
Received: from [10.30.16.13] (178.162.222.41.adsl.inet-telecom.org [178.162.222.41])
	by mail.ionic.de (Postfix) with ESMTPSA id 253AE4F00647;
	Tue, 25 Apr 2017 23:17:35 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default;
	t=1493155055; bh=mrPiYyHh9YDjK7iFYMP1JZ0a7YqqTCbgL4u0GV8bTjY=;
	h=Subject:To:References:From:Date:In-Reply-To:From;
	b=KiDAY84FivXWYuA42YXxLo13C/W53KcAAicSUV8hC0CLsr/U6VMQemLRo6L5iH4PX
	 p3rRamgDP7+mkLGDaAWspD7c8AIuMKcEDb80OE8ydQMxnG+afXRFN9bWjW3iML5woJ
	 TiJgSsDeIqnDhwbq0pUzXxf0VE0VxOUrkb8+QMSU=
To: Seth Galitzer <sgsax@ksu.edu>, 1164@bugs.x2go.org
References: <cfb1831d-d288-992c-6149-90e4a8cb25f9@ksu.edu>
From: Mihai Moldovan <ionic@ionic.de>
Message-ID: <bfc2c5f3-76b6-11bb-b6b0-95fc56ff53fa@ionic.de>
Date: Tue, 25 Apr 2017 23:17:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <cfb1831d-d288-992c-6149-90e4a8cb25f9@ksu.edu>
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="kihvJl79BaMgQiu7QgiBdHOPHbKtTKMTA"

[Message part 1 (text/plain, inline)]
Control: reassign -1 live-build-x2go master
Control: close -1

On 03/21/2017 07:54 PM, Seth Galitzer wrote:
> Package: live-build-x2go, feature/openbox branch
> Version: git commit e4cfc12441e587d89d0b2b90021ee5fb5799a46f
> Tag: patch
> 
> The attached patch updates the 2800-x2go-thinclientconfig hook file in 
> the overlay tree from the feature/openbox branch of live-build-x2go used 
> to build live boot images for the Thin Client Environment for 
> X2Goclient. Full path in the tree is 
> [live-build-x2go.git]/config/includes.chroot/lib/live/config/2800-x2go-thinclientconfig.
> 
> It provides two things:
> 1) handle backgroundurl option as passed in as a kernel boot option and 
> used by --background flag when invoking x2goclient on the commandline
> 2) handle brandingurl option as passed in as a kernel boot option and 
> used by --branding flag when invoking x2goclient on the commandline per 
> patch provided in bug #1162
> 
> This patch was built and tested against the most recent commit to the 
> branch with id e4cfc12441e587d89d0b2b90021ee5fb5799a46f and timestamped 
> Sun, 29 Jan 2017 13:53:42 +0000 (14:53 +0100).
> 
> Thank you for your consideration.

Applied as
https://code.x2go.org/gitweb?p=live-build-x2go.git;a=commitdiff;h=b432b4f506e1fb4ced0096bf7b1f76bf5465df2a
with fixup in
https://code.x2go.org/gitweb?p=live-build-x2go.git;a=commitdiff;h=65d1f40a812f4ae95dddd97c85b995b10ba9e678



Mihai



[signature.asc (application/pgp-signature, attachment)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu Nov 6 03:56:51 2025; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.