From unknown Thu Mar 28 22:55:15 2024 X-Loop: owner@bugs.x2go.org Subject: Bug#1153: X2Go issue (in src:x2goserver) has been marked as closed Reply-To: X2Go Release Manager X2Go Release Manager , 1153-quiet@bugs.x2go.org Resent-To: Mike Gabriel X-Loop: owner@bugs.x2go.org Resent-Date: Wed, 08 Nov 2017 14:10:07 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: report 1153 X-X2Go-PR-Package: x2goserver X-X2Go-PR-Keywords: pending patch Received: via spool by 1153-submitter@bugs.x2go.org id=U1153.15101501057318 (code U ref 1153); Wed, 08 Nov 2017 14:10:07 +0000 Received: (at 1153-submitter) by bugs.x2go.org; 8 Nov 2017 14:08:25 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00, TO_NO_BRKTS_PCNT,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id F40DE5DADC; Wed, 8 Nov 2017 15:08:00 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M6kQinWNu__9; Wed, 8 Nov 2017 15:07:51 +0100 (CET) Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id F0CD95DACF; Wed, 8 Nov 2017 15:04:45 +0100 (CET) From: X2Go Release Manager X2Go Release Manager To: 1153-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 1153@bugs.x2go.org Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20171108140445.F0CD95DACF@ymir.das-netzwerkteam.de> Date: Wed, 8 Nov 2017 15:04:45 +0100 (CET) close #1153 thanks Hello, we are very hopeful that X2Go issue #1153 reported by you has been resolved in the new release (4.0.1.21) of the X2Go source project »src:x2goserver«. You can view the complete changelog entry of src:x2goserver (4.0.1.21) below, and you can use the following link to view all the code changes between this and the last release of src:x2goserver. http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=b8cd8ad873763b546632b8b1ee2762e058da75f4;hp=2c504692966fa2ac456961c2fe561f53c33536b5 If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:x2goserver. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:x2goserver Version: 4.0.1.21-0x2go1 Status: RELEASE Date: Wed, 08 Nov 2017 15:01:58 +0100 Fixes: 1151 1153 1198 1229 1230 Changes: x2goserver (4.0.1.21-0x2go1) RELEASED; urgency=medium . [ Mihai Moldovan ] * New upstream version (4.0.1.21): - x2goserver/sbin/x2gocleansessions: don't overzealously try to remove old nxagent sockets. If the nxagent process already vanished, simply forget the remembered session. Otherwise we might delete sockets that have been re-assigned to other sessions in the meantime. - x2goserver/bin/x2gostartagent: convert X2GO_PORT searching algorithm to pure bash and let script fail if no display port is available. - x2goserver/sbin/x2gocleansessions: fix syntax error introduced in last change to this file. - x2goserver/bin/x2gosetkeyboard: make compatible with changes in Arctica's nxagent. Also change to an all-bash algorithm. Fixes: #1151. - x2goserver/bin/x2gosetkeyboard: fix a typo that caused the script to not work properly - with or without Arctica's nx-libs. - x2goserver/bin/x2gosetkeyboard: rename ${setxkbcomp_opts} to ${setxkbmap_opts}, that's what it really is. - x2goserver/bin/x2gosetkeyboard: setxkbmap expects a parameter called "-option", but nxagent uses the key "options". Make setxkbmap happy. - x2goserver/bin/x2gosetkeyboard: $BASH_REMATCH is tricky, actually fetch the first match. In the $BASH_REMATCH array, index 0 contains the *full* match, while indices 1+ only contain the partial matches. We're only interested in the first partial match. - x2goserver/bin/x2gosetkeyboard: only match up the first ending quote character in a non-greedy way. This will not support nested quotes within values, but we probably don't need this feature anyway. - x2goserver/bin/x2gostartagent: try to enable lingering via systemd's loginctl utility before calling x2goagent. Fixes: #1198. - x2goserver-xsession/etc/Xsession: support Devuan just like Debian, give useful error message in case the OS is unknown. - x2goserver/bin/x2gostartagent: fetch hostname via "hostname -s" and do not rely on the HOSTNAME variable. The latter is only set automatically by bash if it's not already part of the environment. We might get "garbage" in this way (and one user actually did.) - x2goserver/bin/x2golistshadowsessions: whitespace only. - x2goserver/sbin/x2gocleansessions: close syslog at program exit. - x2goserver/sbin/x2gocleansessions: whitespace only. - x2goserver/bin/x2golistshadowsessions: copy and use a few needed utility functions from x2gocleansessions. - x2goserver/bin/x2golistshadowsessions: mark unavailable functionality with FIXME comments. - x2goserver-xsession/etc/Xsession: add support for OS RT via /etc/os-rt-release (file needs to be created by upstream first, bug pending.) - x2goserver/{bin/x2golistshadowsessions, lib/x2go{dbwrapper.pm,sqlitewrapper.pl}}: backport listshadowsessions* DB functions and unmark them as FIXME entries. - x2goserver/lib/x2go{sqlitewrapper.pl,utils.pm}: allow arbitrary-length user names, user names starting with digits and drop $ as a valid user name character. Fixes: #1229. - x2goserver/bin/x2goruncommand: use dbus-run-session to start a new dbus user session if available. Only for full desktop sessions. Backported from a Debian patch. - x2goserver/bin/x2goresume-session: backport HOSTNAME changes from x2goserver/bin/x2gostartagent. - x2goserver/bin/x2go{resume-session,startagent}: catch errors while inserting values into database more gracefully. Fixes: #1230. - x2goserver/bin/x2gostartagent: write hostname errors to stderr to make X2Go Client (and maybe PyHoca?) fail. - x2goserver/{bin/x2go{runcommand,suspend-session}, sbin/x2gocleansessions}: remove hopefully redundant HOSTNAME export commands. - x2goserver/etc/x2goagent.options: remove file, moved to x2goagent. - x2goserver/Makefile: actually unreference x2goagent.options file as well. - x2goserver/bin/x2go{resume-session,startagent}: revert error catching while inserting values into database. The current code structure relies on ignoring failures and retrying until an operation succeeded, which may eventually happen or just as well may never happen. We need something smarter here. - x2goserver/bin/x2gostartagent: log x2goagent startup command to syslog in debug mode. * x2goserver.spec: - Add mandatory perl-generators Build-Requires as per https://fedoraproject.org/wiki/Changes/Build_Root_Without_Perl - Correct usage of mime and desktop database upgrade scriptlets and dependencies. Fedora mandates to not depend upon shared-mime-info, even not for the scriplets. Additionally, FC24 has deprecated usage of the mime database update scriptlet and FC25 has deprecated usage of the desktop database update scriptlet. (Open)SUSE mandates to pull in shared-mime-info and desktop-file-utils as post/postun scriptlet dependencies and provides special macros since 11.4. Older versions are handled via the usual commands. - Simplify systemd usage a bit and make sure that it's restarted on Fedora and RHEL-based distros. FIXME: Not enabled by default on FC/RHEL/*SuSE. - Use Suggests instead of Recommends, as an even weaker dependency. We can live just fine without printing or fmbindings and no functions of the x2goserver package as well will be impacted. The DEB control file also uses "Suggests" for this. - Fix RPM spec syntax error in shared-mime-info dependency section. - Fix %{?fedora} macro usage. - Add the correct package name to the %posttrans scriptlet, we only need it for x2goserver-fmbindings. - Make sure that we don't go into branches just because a macro is not defined on our platform. - Work around a bug in SuSE's mime DB update script... - Make sure that there's always at least one (nil) command in the if command list. - Break older SLES builds on purpose to see what branch is *actually* taken. Will be reverted shortly. - Fix typo in %if condition (0%?{?fedora} instead of 0%{?fedora}.) - Contrary to other information that says "brackets" and consistent with RPM's source code, grouping is done via "(" and ")" in conditions. - More platform-specific condition fixup. - Pull in shared-mime-info as a build requirement only on *SuSE and add comment regarding why desktop-file-utils is always needed. - Also add a trans(action)-requirement on shared-mime-info for older RHEL-based distros. - RPM spec does not allow %elif or %elseif, which lead to all weird kinds of errors. Split these up into nested conditions. - There is no %trans scriptlet, we're using %posttrans, so the dependency should be specified as Requires(posttrans) as well. - Pull in dbus-run-session if possible. Only available on Fedora, SLE12+ and OpenSuSE 13+. - Pull in x2goagent >= 3.5.0.33 explicitly, first version that reflects the x2goagent.options file move. * debian/po: - Tiny fixup on author name. * debian/control: - Whitespace fixes. - Add BD on dh-systemd. We'll need it for systemd integration. - Depend upon dbus for dbus-run-session. - Pull in x2goagent >= 3.5.0.33 explicitly, first version that reflects the x2goagent.options file move. * debian/rules: - Call the systemd addon to process and install the systemd service file. - Don't fail if we don't have the systemd addon. Systems that don't have that will likely not use systemd in the first place. . [ Martti Pitkänen ] * debian/po: - Translate DebConf templates to Finnish. . [ Orion Paplowski ] * x2goserver.spec: - Requires(post) does not imply Requires, and missing ones on grep and the SQLite perl module. - Fedora >= 21 and (Open)SUSE >= 11 now allow Recommends. - perl(:MODULE_COMPAT...) is only needed for perl modules. Drop from x2goserver-printing and x2goserver-xsession. - Delete .packlist which may be in different locations. - Sort some %files entries. . [ Mike Gabriel ] * New upstream version (4.0.1.21): - x2goserver/bin/x2goruncommand: stop exporting LD_LIBRARY_PATH when using Arctica's nx-libs and its new Xinerama feature. Fixes: #1153. - Make x2goruncommand aware of the LXQt desktop shell. - x2goserver/x2gosqlitewrapper.c: fix implicit declaration of execv(). - x2goserver/: backport x2golistshadowsessions.