X2Go Bug report logs - #1136
Multiple issues with x2gousbmount

version graph

Package: x2gousbmount; Maintainer for x2gousbmount is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2gousbmount is src:x2gothinclient.

Reported by: Stefan Baur <X2Go-ML-1@baur-itcs.de>

Date: Sat, 14 Jan 2017 13:00:01 UTC

Severity: normal

Tags: pending

Fixed in version

Done: X2Go Release Manager X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log

đź”— View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#1136: [X2Go-Dev] Bug#1136: Bug#1136: Multiple issues with x2gousbmount
Reply-To: Stefan Baur <X2Go-ML-1@baur-itcs.de>, 1136@bugs.x2go.org
Resent-From: Stefan Baur <X2Go-ML-1@baur-itcs.de>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Thu, 19 Jan 2017 09:15:02 +0000
Resent-Message-ID: <handler.1136.B1136.148481703619650@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 1136
X-X2Go-PR-Package: x2gousbmount
Received: via spool by 1136-submit@bugs.x2go.org id=B1136.148481703619650
          (code B ref 1136); Thu, 19 Jan 2017 09:15:02 +0000
Received: (at 1136) by bugs.x2go.org; 19 Jan 2017 09:10:36 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
X-Spam-Status: No, score=-1.4 required=3.0 tests=BAYES_00,RCVD_IN_SORBS_SPAM
	autolearn=no version=3.3.2
Received: from localhost (localhost [])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id C4CD93CDDB
	for <1136@bugs.x2go.org>; Thu, 19 Jan 2017 10:10:35 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([])
	by localhost (ymir.das-netzwerkteam.de []) (amavisd-new, port 10024)
	with ESMTP id z5zQe8VHUV-N for <1136@bugs.x2go.org>;
	Thu, 19 Jan 2017 10:10:29 +0100 (CET)
Received: from mout.kundenserver.de (mout.kundenserver.de [])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id E1AD83CDDA
	for <1136@bugs.x2go.org>; Thu, 19 Jan 2017 10:10:28 +0100 (CET)
Received: from [] ([]) by mrelayeu.kundenserver.de
 (mreue004 []) with ESMTPSA (Nemesis) id
 0LupVN-1cLa9F0DRZ-0102VN; Thu, 19 Jan 2017 10:10:28 +0100
To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 1136@bugs.x2go.org
References: <20170116153521.Horde.LtzyCP979XMaQ4JQud7x5xG@mail.das-netzwerkteam.de>
From: Stefan Baur <X2Go-ML-1@baur-itcs.de>
Message-ID: <566a0c04-404d-2331-494b-6de277cb824e@baur-itcs.de>
Date: Thu, 19 Jan 2017 10:10:17 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
MIME-Version: 1.0
In-Reply-To: <20170119090205.Horde.FEmoMNMlvQRDrYc2X2yv5LZ@mail.das-netzwerkteam.de>
Content-Type: multipart/signed; micalg=pgp-sha256;
X-Provags-ID: V03:K0:II9SETcIgl6K3ZyJvu5+zTRcdh04aRELW1Iy/oNd+lY6WCzDGWu
X-UI-Out-Filterresults: notjunk:1;V01:K0:78Afeaj6Hr8=:D+tuHmV9ySUBysLfXdXGEO
[Message part 1 (text/plain, inline)]
Am 19.01.2017 um 10:02 schrieb Mike Gabriel:
>> Because if you *do* call x2goclient [...] --thinclient [...] for that
>> minidesktop session, then the new detection in the subroutine
>> check_x2gothinclientmode will trigger on that as well, so the "|| ..."
>> part would no longer be needed.
> Not sure what you mean by that.

*sigh* ...

Old code: Checks for presence of x2gothinclientd
          (sub check_x2gothinclientd)

New code: Checks for presence of x2goclient with --thinclient option
          (sub check_x2gothinclientmode)

Old code:
if ( check_x2gothinclientd() ||  ( -d
"/usr/share/doc/x2gothinclient-minidesktop" ) )

-> "Either x2gothinclientd is running or directory
/usr/share/doc/x2gothinclient-minidesktop exists"

If, on the Minidesktop, x2goclient would be called with --thinclient,
that line could be shortened to:
if ( check_x2gothinclientmode() )

Pleas pay attention to this: Your statement

> Basically, you don't want x2gousbmount
> interfere with udisks(2) which is what the MATE session manager uses to
> manage pluggable storage devices.

contradicts what the code currently in the X2Go repo (NOT our latest,
suggested changes) is doing - in other words, the present code DOES run
x2goumount when the minidesktop is detected, so it WILL interfere with
udisks/MATE session manager - so either you are wrong, or you have an
issue there.


BAUR-ITCS UG (haftungsbeschränkt)
Geschäftsführer: Stefan Baur
Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364
Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243

[signature.asc (application/pgp-signature, attachment)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Fri Feb 23 09:37:10 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.