X2Go Bug report logs - #1124
FTBFS on non-Linux platforms

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Date: Fri, 9 Dec 2016 13:45:02 UTC

Severity: normal

Tags: pending

Found in version 4.0.5.2

Fixed in version 4.0.5.3

Done: X2Go Release Manager <git-admin@x2go.org>

Bug is archived. No further changes may be made.

Full log


Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

Received: (at submit) by bugs.x2go.org; 9 Dec 2016 13:44:59 +0000
From mike.gabriel@das-netzwerkteam.de  Fri Dec  9 14:44:57 2016
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,URIBL_BLOCKED
	autolearn=ham version=3.3.2
Received: from localhost (localhost [127.0.0.1])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTP id AD01A3CC49
	for <submit@bugs.x2go.org>; Fri,  9 Dec 2016 14:44:57 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de
Received: from ymir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id vgxUvx9NYN4H for <submit@bugs.x2go.org>;
	Fri,  9 Dec 2016 14:44:39 +0100 (CET)
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 2EBB33CC48
	for <submit@bugs.x2go.org>; Fri,  9 Dec 2016 14:44:39 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [IPv6:2a01:4f8:131:20c1:5254:ff:fe24:f0dd])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id E96A4A6D
	for <submit@bugs.x2go.org>; Fri,  9 Dec 2016 14:44:38 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 73E873C0B7
	for <submit@bugs.x2go.org>; Fri,  9 Dec 2016 14:44:38 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id vcdwvD8OWWUF for <submit@bugs.x2go.org>;
	Fri,  9 Dec 2016 14:44:32 +0100 (CET)
Received: from das-netzwerkteam.de (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id F0E673C033
	for <submit@bugs.x2go.org>; Fri,  9 Dec 2016 14:44:31 +0100 (CET)
Received: from p5B284C85.dip0.t-ipconnect.de (p5B284C85.dip0.t-ipconnect.de
 [91.40.76.133]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP;
 Fri, 09 Dec 2016 13:44:31 +0000
Date: Fri, 09 Dec 2016 13:44:31 +0000
Message-ID: <20161209134431.Horde.8sVoe7Jv2AKvlRO63t7-Aln@mail.das-netzwerkteam.de>
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: submit@bugs.x2go.org
Subject: FTBFS on non-Linux platforms
User-Agent: Horde Application Framework 5
Accept-Language: de,en
Organization: DAS-NETZWERKTEAM
X-Originating-IP: 91.40.76.133
X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Firefox/45.0
Content-Type: multipart/signed; boundary="=_Qo7WJWKltx3aXbsCXGy6s4e";
 protocol="application/pgp-signature"; micalg=pgp-sha256
MIME-Version: 1.0
[Message part 1 (text/plain, inline)]
Package: x2goclient
Severity: normal
Version: 4.0.5.2

Hi Mihai,

In sharewidget.cpp, there is an awkward ifdef structure that causes an  
FTBFS on non-Linux but Unix-like platforms (e.g. Debian GNU/Hurd or  
Debian GNU/kFreeBSD):

```
#ifdef Q_OS_WIN
    QString fromCode=tr ( "WINDOWS-1252" );
#endif
#ifdef Q_OS_DARWIN
    QString fromCode="UTF-8";
#endif
#ifdef Q_OS_LINUX
    QString fromCode=tr ( "ISO8859-1" );
#endif
```

Please fix this upstream and I'll cherry-pick your commit and fix the  
Debian package of x2goclient.

See here for build logs:  
https://buildd.debian.org/status/package.php?p=x2goclient

Greets,
Mike
-- 

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
mobile: +49 (1520) 1976 148
landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Wed Sep 23 16:13:29 2020; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.