From unknown Sun May 17 02:51:47 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#1124: FTBFS on non-Linux platforms Reply-To: Mike Gabriel , 1124@bugs.x2go.org Resent-From: Mike Gabriel Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Fri, 09 Dec 2016 13:45:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: report 1124 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: Received: via spool by submit@bugs.x2go.org id=B.148129109932273 (code B); Fri, 09 Dec 2016 13:45:02 +0000 Received: (at submit) by bugs.x2go.org; 9 Dec 2016 13:44:59 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id AD01A3CC49 for ; Fri, 9 Dec 2016 14:44:57 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vgxUvx9NYN4H for ; Fri, 9 Dec 2016 14:44:39 +0100 (CET) Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 2EBB33CC48 for ; Fri, 9 Dec 2016 14:44:39 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [IPv6:2a01:4f8:131:20c1:5254:ff:fe24:f0dd]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id E96A4A6D for ; Fri, 9 Dec 2016 14:44:38 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 73E873C0B7 for ; Fri, 9 Dec 2016 14:44:38 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vcdwvD8OWWUF for ; Fri, 9 Dec 2016 14:44:32 +0100 (CET) Received: from das-netzwerkteam.de (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTPS id F0E673C033 for ; Fri, 9 Dec 2016 14:44:31 +0100 (CET) Received: from p5B284C85.dip0.t-ipconnect.de (p5B284C85.dip0.t-ipconnect.de [91.40.76.133]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Fri, 09 Dec 2016 13:44:31 +0000 Date: Fri, 09 Dec 2016 13:44:31 +0000 Message-ID: <20161209134431.Horde.8sVoe7Jv2AKvlRO63t7-Aln@mail.das-netzwerkteam.de> From: Mike Gabriel To: submit@bugs.x2go.org User-Agent: Horde Application Framework 5 Accept-Language: de,en Organization: DAS-NETZWERKTEAM X-Originating-IP: 91.40.76.133 X-Remote-Browser: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 Content-Type: multipart/signed; boundary="=_Qo7WJWKltx3aXbsCXGy6s4e"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 This message is in MIME format and has been PGP signed. --=_Qo7WJWKltx3aXbsCXGy6s4e Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Package: x2goclient Severity: normal Version: 4.0.5.2 Hi Mihai, In sharewidget.cpp, there is an awkward ifdef structure that causes an=20= =20 FTBFS=20on non-Linux but Unix-like platforms (e.g. Debian GNU/Hurd or=20=20 Debian=20GNU/kFreeBSD): ``` #ifdef Q_OS_WIN QString fromCode=3Dtr ( "WINDOWS-1252" ); #endif #ifdef Q_OS_DARWIN QString fromCode=3D"UTF-8"; #endif #ifdef Q_OS_LINUX QString fromCode=3Dtr ( "ISO8859-1" ); #endif ``` Please fix this upstream and I'll cherry-pick your commit and fix the=20=20 Debian=20package of x2goclient. See here for build logs:=20=20 https://buildd.debian.org/status/package.php?p=3Dx2goclient Greets, Mike --=20 DAS-NETZWERKTEAM mike=20gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de --=_Qo7WJWKltx3aXbsCXGy6s4e Content-Type: application/pgp-signature Content-Description: Digitale PGP-Signatur Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYSrU/AAoJEJr0azAldxsxShsQAK1K0PNSH2Oa+Pe/jBFmqjkX rt0Jfvz/LlyIluSZnXtrLbmHksqS35SO1HJxCEb8Gy+vIqxqKcBKWfrSks/dJLqR 8eUawH/55G8yZbfyWC3zr/QQCBGlDvInMXTwnapE+33pbkw5RliLlZ6xuS+2B43z rmsWhnsv0CJFJJ32m6iBcWxIwogXAMTH/gUcspbBxBsh7/Dy7JylQwVcbXwHp7zQ av54BSOx1S2b7ixDfu5b6Rl5UhNFi+0ermDpSvzHrQ97SJn7NqprwEbPYL1OObOi BnnkDiIV7VqoybTHANleC5cEzbavIKti7hI7nSGJdp18TBsjC5Ck3ichs2JFBIWk DKlVhdZFvqUYFWrCvTxSCSsuevk6HIN8UX4g3g17xwEfeVuA9acYwopm7UiartAZ UKiADrJHIjsU0dje8X5AZ92CP8MbzZwx8nYyKae1ufVCSjwdgi960EjWilduQ2il fXukY/w8j+c6HofjXH6pEIgnjOQQipP08H/hzNFZNWDLDEEvELywslDn+FbHZChL gw9ZK/ii9m45tdPMhj2X510IH0Jrz14DifrO5//jRDgtZLG1lbFHjnvyUkKdsDw7 TdycQd1F+zdekOd3vUa+p/1zqtW7iN+aMiIH+tX/HBrpw7xtqndPkNOYVWWKNQIR T89fk2JXkyvuGLEX14aO =Zob2 -----END PGP SIGNATURE----- --=_Qo7WJWKltx3aXbsCXGy6s4e--