From unknown Thu Mar 28 14:20:19 2024 X-Loop: owner@bugs.x2go.org Subject: Bug#1122: x2goclient spurously asks for passphrase on autologin Reply-To: Arne Wichmann , 1122@bugs.x2go.org Resent-From: Arne Wichmann Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Thu, 08 Dec 2016 18:05:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: report 1122 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: Received: via spool by submit@bugs.x2go.org id=B.148122024414115 (code B); Thu, 08 Dec 2016 18:05:02 +0000 Received: (at submit) by bugs.x2go.org; 8 Dec 2016 18:04:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=3.0 tests=BAYES_50,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 00FD25DBE7 for ; Thu, 8 Dec 2016 19:04:03 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nI1C0a1NXRr7 for ; Thu, 8 Dec 2016 19:03:56 +0100 (CET) X-Greylist: delayed 307 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Thu, 08 Dec 2016 19:03:55 CET Received: from apu.snow-crash.org (apu.snow-crash.org [78.47.227.179]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 878B25DAC1 for ; Thu, 8 Dec 2016 19:03:55 +0100 (CET) Received: from chao.old-forest.org (arne.local [10.99.0.2]) by apu.snow-crash.org (Postfix) with ESMTP id A682186D40 for ; Thu, 8 Dec 2016 18:58:48 +0100 (CET) Received: from anhrefn ([192.168.10.23] helo=anhrefn.saar.de) by chao.old-forest.org with esmtps (Exim 4.84_2) (envelope-from ) id 1cF2xy-00083z-Vp for submit@bugs.x2go.org; Thu, 08 Dec 2016 18:58:48 +0100 Received: from aw by anhrefn.saar.de with local (Exim 4.87) (envelope-from ) id 1cF2yI-00016O-QC for submit@bugs.x2go.org; Thu, 08 Dec 2016 18:59:06 +0100 Date: Thu, 8 Dec 2016 18:59:06 +0100 From: Arne Wichmann To: submit@bugs.x2go.org Message-ID: <20161208175906.GD20753@anhrefn.saar.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8w3uRX/HFJGApMzv" Content-Disposition: inline Return-Receipt-To: aw@anhrefn.saar.de X-message-flag: Outluck ist kaputt :-) User-Agent: Mutt/1.5.23 (2014-03-12) --8w3uRX/HFJGApMzv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Package: x2goclient Version: 4.0.5.2 When using=20 x2goclient --pgp-card and not using a Smartcard, after typing a password there will be a popup window asking for a passphrase even though no usable keys are available. (The problem arose at a Thinclient of a customer who in some cases does not use their smartcards.) After some digging into the problem I think that the autologin flag should be cleared after SshMasterConnection::userAuthAuto has been tried once. Alternatively SshMasterConnection::userAuthAuto could check if there are usable keys before asking for a passphrase. Or it could check if a password has already been given.=20 cu AW --=20 [...] If you don't want to be restricted, don't agree to it. If you are coerced, comply as much as you must to protect yourself, just don't support it. Noone can free you but yourself. (crag, on Debian Planet) Arne Wichmann (aw@saar.de) --8w3uRX/HFJGApMzv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJYSZ9kAAoJEENYfBy4DUs+HwQP/2fT3ADbK1AvS332H44S4dGA Va5RYjoGPn312yC1BwruBMMPdk5QYYHxAHmHJvM0wtzlHFmHftq9RCVPzHUu/LPV ojjwdJuk2SdTcp70pCsyHs56IPQcAevjN5QtKm4eutI2OcnG34kXs6mRUIBSo8gO afm8Gnbf42cno9xx0olHKxwwqfOJkzqDD1hxlSnGL+ybIQ8Irl2Zvr215fJmQtHh kqO/pOCCogoeLpxSddOcHsb8a/9c3U27QtU1IHB0S5yPeWCR9c7WU5bMxhNWvzIL gIyiuixr+edmd+pjAeoCpNeBylFhhKBd8Kz5IBJQ1pMSent/kcqzYotyg3iYSpxj X0Nq1na49AkxaXgkDP+GbBfydQJJneFM71j0kbkn2wR/ocG36VF8BTez0pnPqERG MCdkag9jbDwL6ELwSURfTaiL6wxUuq1zHbIZompZXK6f1rQyvyOk9eyxij5HjLrU O8HA8aC3cgQLwMmxa7hPfBzDyTV5pSIxtEFyo0sqW+2q/x1a6+axPShu99w+a9O6 f2C7Zt+/rb795aFPxcobJ+iKO7VNxJiOnMHo+fpHgR9hMELlaM1tWFh4LKcIyxkk 6x3C758opxi7z17SzKqJ04VLJlkYoPxwGKJzn6+C6LGbxQqX/dDzuF6UaFEOBNLi VdSD3pAo8zh5/ceoBhGf =KeRp -----END PGP SIGNATURE----- --8w3uRX/HFJGApMzv-- From unknown Thu Mar 28 14:20:19 2024 X-Loop: owner@bugs.x2go.org Subject: Bug#1122: Patch Reply-To: Arne Wichmann , 1122@bugs.x2go.org Resent-From: Arne Wichmann Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Wed, 08 Mar 2017 12:55:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 1122 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: Received: via spool by 1122-submit@bugs.x2go.org id=B1122.148897764710970 (code B ref 1122); Wed, 08 Mar 2017 12:55:02 +0000 Received: (at 1122) by bugs.x2go.org; 8 Mar 2017 12:54:07 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=3.0 tests=BAYES_50,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 1A6FF5DA85; Wed, 8 Mar 2017 13:54:05 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oJMjHbLV8j4x; Wed, 8 Mar 2017 13:53:58 +0100 (CET) X-Greylist: delayed 569 seconds by postgrey-1.35 at ymir.das-netzwerkteam.de; Wed, 08 Mar 2017 13:53:58 CET Received: from apu.snow-crash.org (crusty.snow-crash.org [213.239.193.199]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 39D8D5DA2B; Wed, 8 Mar 2017 13:53:58 +0100 (CET) Received: from chao-revive (arne.local [10.99.0.2]) by apu.snow-crash.org (Postfix) with ESMTP id 0F1F78061B; Wed, 8 Mar 2017 13:44:29 +0100 (CET) Received: from [192.168.10.23] (helo=anhrefn.saar.de) by chao-revive with esmtps (Exim 4.88) (envelope-from ) id 1clayk-00077b-U5; Wed, 08 Mar 2017 13:46:06 +0100 Received: from aw by anhrefn.saar.de with local (Exim 4.88) (envelope-from ) id 1clax4-0006eM-0S; Wed, 08 Mar 2017 13:44:22 +0100 Date: Wed, 8 Mar 2017 13:44:11 +0100 From: Arne Wichmann To: 1122@bugs.x2go.org Cc: control@bugs.x2go.org Message-ID: <20170308124411.GB16588@anhrefn.saar.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0eh6TmSyL6TZE2Uz" Content-Disposition: inline Return-Receipt-To: aw@anhrefn.saar.de X-message-flag: Outluck ist kaputt :-) User-Agent: Mutt/1.5.23 (2014-03-12) --0eh6TmSyL6TZE2Uz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable tag #1122 patch thanks Hi... So, I created an experimental patch which makes the problem go away. cu AW ---- diff --git a/debian/changelog b/debian/changelog index dc1fbbf..c57c678 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +x2goclient (4.1.0.1-0x2go1.1) UNRELEASED; urgency=3Dmedium + + * Non-maintainer upload. + * Do not ask passphrase on autologin + + -- Arne Wichmann Wed, 08 Mar 2017 13:32:51 +0100 + x2goclient (4.1.0.1-0x2go1) UNRELEASED; urgency=3Dmedium =20 [ Mihai Moldovan ] diff --git a/src/sshmasterconnection.cpp b/src/sshmasterconnection.cpp index 8e620c2..ab6398e 100644 --- a/src/sshmasterconnection.cpp +++ b/src/sshmasterconnection.cpp @@ -1150,6 +1150,8 @@ bool SshMasterConnection::userAuthAuto() { int rc =3D ssh_userauth_autopubkey ( my_ssh_session, "" ); int i=3D0; +#define NO_PASSPHRASE_ON_AUTOLOGIN +#ifndef NO_PASSPHRASE_ON_AUTOLOGIN while(rc !=3D SSH_AUTH_SUCCESS) { keyPhraseReady=3Dfalse; @@ -1173,6 +1175,7 @@ bool SshMasterConnection::userAuthAuto() break; } } +#endif =20 if ( rc !=3D SSH_AUTH_SUCCESS ) { ---- --=20 [...] If you don't want to be restricted, don't agree to it. If you are coerced, comply as much as you must to protect yourself, just don't support it. Noone can free you but yourself. (crag, on Debian Planet) Arne Wichmann (aw@saar.de) --0eh6TmSyL6TZE2Uz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJYv/yVAAoJEBCK3pl2AP+JBmsP/iRrOEgrGYMIBM6quaLHD2NJ ynFvYVhlFtfUYJTOqXpSzxCfOv+1ZaPG55UbbJPQfVGp4WaKM4yfFZwQU/UIcpcV BBCtxBXAL2nIVYNPNslnBqeoEfW7ZRWG00do4AkxERM8ID5aHLe27YinSFmrNFQj U6viNLWUCk5An45A0pC6kUd3BJwusfxWsbLqXRFlRiIPxq5crd1q8AsRe8NJGvZc LLfR2HomvF0wNM84o4YmpkF3YAEmAzj55rJ/eSb2uwQuckFZ6Scb5F5IRcrOQ/UR q50e4GleiQpkKRG0sjsb4AehPr+zj4W01S993saRq2YRbngMIZjW74A8khl/e5K5 yXJ6SjM+tSP3yXl9c9ZMhHGufArs988T1YeEZUW8MqOK21PWQO5TJ3u+OKeV7wNk hmRUYCf7XEtHA6unOLq89GlxKiGiaHIH5CNAek2IukvTCAYqiKaBlEEm66m1D9ye 62+93aPIW781vCjkNJMuyawFdTiPIsa8YDesE7hIljUrMqXCiJittL5bauJHQnPR uh+Y3yAgOrVQDNGaAYBO3UCyTi8p9iv+r7QYPhDKIzlK6zsilJU/HTCXZsTnUreh ojxOHNbordtf/z2yY6U8BJLKNWI6RwtgfYZduvSoMybARdDrboMtbpZj5zg3AC1b 8AAfv0aTHvph9tLtkImT =Flx9 -----END PGP SIGNATURE----- --0eh6TmSyL6TZE2Uz-- From unknown Thu Mar 28 14:20:19 2024 X-Loop: owner@bugs.x2go.org Subject: Bug#1122: X2Go issue (in src:x2goclient) has been marked as pending for release Reply-To: Mihai Moldovan , 1122@bugs.x2go.org Resent-From: Mihai Moldovan Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Sun, 10 Dec 2017 05:05:03 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 1122 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: patch Received: via spool by 1122-submit@bugs.x2go.org id=B1122.151288227012871 (code B ref 1122); Sun, 10 Dec 2017 05:05:03 +0000 Received: (at 1122) by bugs.x2go.org; 10 Dec 2017 05:04:30 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 1A4FD5DAD2; Sun, 10 Dec 2017 06:04:20 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5EtIT3i4mUr8; Sun, 10 Dec 2017 06:04:04 +0100 (CET) Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id 9D7865DAD0; Sun, 10 Dec 2017 06:04:03 +0100 (CET) From: Mihai Moldovan To: 1122-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 1122@bugs.x2go.org Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Mailer: http://snipr.com/post-receive-tag-pending Message-Id: <20171210050403.9D7865DAD0@ymir.das-netzwerkteam.de> Date: Sun, 10 Dec 2017 06:04:03 +0100 (CET) tag #1122 pending fixed #1122 4.1.1.1 thanks Hello, X2Go issue #1122 (src:x2goclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=248d227 The issue will most likely be fixed in src:x2goclient (4.1.1.1). light+love X2Go Git Admin (on behalf of the sender of this mail) --- commit 248d22794db8f63d26187fe21045b64e12088427 Author: Mihai Moldovan Date: Sun Dec 10 06:03:29 2017 +0100 debian/changelog: add bug closure for #1122. diff --git a/debian/changelog b/debian/changelog index 5cdc048..e3a4322 100644 --- a/debian/changelog +++ b/debian/changelog @@ -8,6 +8,7 @@ x2goclient (4.1.1.1-0x2go1) UNRELEASED; urgency=medium in MacPorts. - src/sshmasterconnection.cpp: don't ask for private key passphrase if auto-login merely failed due to the server denying the public key. + Fixes: #1122. - src/{httpbrokerclient,onmainwindow,sshmasterconnection}.{cpp,h}: introduce new passphrase_type enum and replace the old verificationCode boolean value with that. Allows using more messages, including a new one @@ -18,11 +19,12 @@ x2goclient (4.1.1.1-0x2go1) UNRELEASED; urgency=medium include onmainwindow.h to avoid a circular dependency, it has to be part of SshMasterConnection for now. - src/sshmasterconnection.cpp: query for password if it wasn't already - provided. This usually happens if auto-login is enabled, which bypasses - the password prompt. If auto-login fails, authentication normally - continues via challenge auth or plain passwords, but since users had no - chance to input a password, such authentication will always fail. Give - users a way to enter passwords, in case the auto-login failed. + provided. Fixes: #1122. This usually happens if auto-login is enabled, + which bypasses the password prompt. If auto-login fails, authentication + normally continues via challenge auth or plain passwords, but since + users had no chance to input a password, such authentication will always + fail. Give users a way to enter passwords, in case the auto-login + failed. - src/onmainwindow.cpp: finally include version information in debug output. - res/i18n/x2goclient_*.ts: apply last change to translation files From unknown Thu Mar 28 14:20:19 2024 X-Loop: owner@bugs.x2go.org Subject: Bug#1122: X2Go issue (in src:x2goclient) has been marked as closed Reply-To: X2Go Release Manager X2Go Release Manager , 1122@bugs.x2go.org Resent-From: X2Go Release Manager X2Go Release Manager Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Thu, 15 Feb 2018 20:45:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 1122 X-X2Go-PR-Package: x2goclient X-X2Go-PR-Keywords: patch pending Received: via spool by 1122-submit@bugs.x2go.org id=B1122.15187273547349 (code B ref 1122); Thu, 15 Feb 2018 20:45:02 +0000 Received: (at 1122) by bugs.x2go.org; 15 Feb 2018 20:42:34 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 3DBC35DAEA; Thu, 15 Feb 2018 21:42:18 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M3lQs3L4ftY4; Thu, 15 Feb 2018 21:42:13 +0100 (CET) Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id A5DB05DA2B; Thu, 15 Feb 2018 21:42:04 +0100 (CET) From: X2Go Release Manager X2Go Release Manager To: 1122-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 1122@bugs.x2go.org Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20180215204204.A5DB05DA2B@ymir.das-netzwerkteam.de> Date: Thu, 15 Feb 2018 21:42:04 +0100 (CET) close #1122 thanks Hello, we are very hopeful that X2Go issue #1122 reported by you has been resolved in the new release (4.1.1.1) of the X2Go source project »src:x2goclient«. You can view the complete changelog entry of src:x2goclient (4.1.1.1) below, and you can use the following link to view all the code changes between this and the last release of src:x2goclient. http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=eef4bf3e0e618b15cbf6649e9dbb07d99e57ad00;hp=f0fb9c49b1c30fd025c2c7c9094fa662b8b09b4d If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:x2goclient. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:x2goclient Version: 4.1.1.1-0x2go1 Status: RELEASE Date: Thu, 15 Feb 2018 21:38:31 +0100 Fixes: 408 559 1122 1209 1214 1227 Changes: x2goclient (4.1.1.1-0x2go1) RELEASED; urgency=medium . [ Mihai Moldovan ] * New upstream version (4.1.1.1): - src/pulsemanager.cpp: print out PA --version output as a debug message. - macbuild.sh: also bundle xauth binary as nxauth binary. - macbuild.sh: switch to bundling PulseAudio 11.1 since it's now available in MacPorts. - src/sshmasterconnection.cpp: don't ask for private key passphrase if auto-login merely failed due to the server denying the public key. Fixes: #1122. - src/{httpbrokerclient,onmainwindow,sshmasterconnection}.{cpp,h}: introduce new passphrase_type enum and replace the old verificationCode boolean value with that. Allows using more messages, including a new one for plain password prompts. Adapt usage accordingly. The implementation is ugly, but there's no good way around that (short of using C++11 features). The enum would really logically belong to ONMainWindow, but since we also have to use it in SshMasterConnection, that may not include onmainwindow.h to avoid a circular dependency, it has to be part of SshMasterConnection for now. - src/sshmasterconnection.cpp: query for password if it wasn't already provided. Fixes: #1122. This usually happens if auto-login is enabled, which bypasses the password prompt. If auto-login fails, authentication normally continues via challenge auth or plain passwords, but since users had no chance to input a password, such authentication will always fail. Give users a way to enter passwords, in case the auto-login failed. - src/onmainwindow.cpp: finally include version information in debug output. - res/i18n/x2goclient_*.ts: apply last change to translation files directly. - src/sshmasterconnection.cpp: error out with a useful error message in case no password has been provided when doing password authentication. - src/sshmasterconnection.cpp: don't output an empty error message if password authencation has been requested but the server does not support this mechanism. Fixes: #408. - src/onmainwindow.cpp: wrap user name for client-side mounts in quotes. Fixes: #559. Will fail with user names that contain quotes, but oh well... - {example/x2goclient-cli,src/onmainwindow.cpp}: remove hopefully obsolete HOSTNAME exporting into environment. - src/onmainwindow.cpp: remove client-side LD_LIBRARY_PATH meddling. Nothing of value is in that directory and nxproxy hasn't needed that for years. - src/settingswidgets.cpp: don't incorrectly enable whole display settings in single display setups. Let debugging mode override this behavior, though. - src/onmainwindow.cpp: pass X2GO_RANDR_XINERAMA=[yes,no] to x2gostartagent as an environment variable based upon the xinerama session setting. Has no effect when connecting to older X2Go Server versions and handles startup correctly with X2Go Server 4.1.0.0. - src/onmainwindow.cpp: fix another leaked X2goSettings object. - src/onmainwindow.cpp: rename xinerama env variable on session startup to X2GO_XINERAMA in accordance with server changes. - src/onmainwindow.cpp: supply xinerama option as another parameter to x2goresume-session on session resume. - src/sessionbutton.cpp: make button non-sensitive in bottom right part if it's editable. Fixes: #1214. - {src/{help.cpp,onmainwindow.{cpp,h}},man/man1/x2goclient.1}: reformat, whitespace fixes, split out close button slot in a separate function. - src/onmainwindow.{cpp,h}: let close button be a member variable. - src/onmainwindow.cpp: disable and enable close button during and after connection startup. - src/onmainwindow.cpp: initialize directRDP to false to be able to call slotSuspendSessFromSt () even if no session has previously been started. - src/onmainwindow.cpp: only initialize directRDP variable if platform is Linux. Fixes compile failures on Windows and OS X. - src/onmainwindow.cpp: always create close button, but either hide or show it based upon whether --closebt was provided or not. - src/onmainwindow.cpp: revert 3060183a78d8b6bd81bec9968c985c38bfd1e5c2. Being able to suspend sessions via the close button is complex and unnecessary, since in thinclient mode, for which this feature is useful, users will not be able to see the client window while a session is executing, due to it running in full screen mode. - src/onmainwindow.cpp: always enable close button, let it log out from a broker if already authenticated or close the client on click. Fixes: #1209. - man/man1/x2goclient.1: clarify what the close button now does. It either lets the user re-login to the broker or closes the client. - src/onmainwindow.cpp: correctly initialize brokerAuthentication member of ConfigFile struct. - {res/{img/png/close-button.png,resources.qrc}, src/{{onmainwindow,httpbrokerclient}.{cpp,h},help.cpp}, man/man1/x2goclient.1}: rename close button to broker logout button. Reimplement the way it is shown - disable it upon startup and only enable it after successful broker authentication. - man/man1/x2goclient.1: add missing escape signs before dash/minus characters. . [ Oleksandr Shneyder ] * New upstream version (4.1.1.1): - Change echo mode for user input in InteractionDialog. . [ Walid Moghrabi ] * New upstream version (4.1.1.1): - {res/img/png/,res/resources.qrc}: add close-button.png file. - {src/{help.cpp,onmainwindow.{cpp,h}},man/man1/x2goclient.1}: add new option --closebt. Fixes: #1227. Adds a close button in the top-left client corner (maybe next to the halt button) that currently just terminates the client. From unknown Thu Mar 28 14:20:19 2024 MIME-Version: 1.0 X-Mailer: MIME-tools 5.507 (Entity 5.507) X-Loop: owner@bugs.x2go.org From: owner@bugs.x2go.org (X2Go Bug Tracking System) Subject: Bug#1122 closed by X2Go Release Manager X2Go Release Manager (X2Go issue (in src:x2goclient) has been marked as closed) Message-ID: References: <20180215204204.A5DB05DA2B@ymir.das-netzwerkteam.de> X-X2go-PR-Keywords: patch pending X-X2go-PR-Message: they-closed 1122 X-X2go-PR-Package: x2goclient X-X2go-PR-Source: x2goclient Date: Thu, 15 Feb 2018 20:45:06 +0000 Content-Type: multipart/mixed; boundary="----------=_1518727506-8542-0" This is a multi-part message in MIME format... ------------=_1518727506-8542-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This is an automatic notification regarding your Bug report which was filed against the x2goclient package: #1122: x2goclient spurously asks for passphrase on autologin It has been closed by X2Go Release Manager X2Go Release Manager . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact X2Go Release Manager X= 2Go Release Manager by replying to this email. --=20 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems ------------=_1518727506-8542-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at control) by bugs.x2go.org; 15 Feb 2018 20:42:42 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.1 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 3DBC35DAEA; Thu, 15 Feb 2018 21:42:18 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M3lQs3L4ftY4; Thu, 15 Feb 2018 21:42:13 +0100 (CET) Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id A5DB05DA2B; Thu, 15 Feb 2018 21:42:04 +0100 (CET) From: =?utf-8?q?X2Go_Release_Manager?= X2Go Release Manager To: 1122-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 1122@bugs.x2go.org Subject: X2Go issue (in src:x2goclient) has been marked as closed Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20180215204204.A5DB05DA2B@ymir.das-netzwerkteam.de> Date: Thu, 15 Feb 2018 21:42:04 +0100 (CET) close #1122 thanks Hello, we are very hopeful that X2Go issue #1122 reported by you has been resolved in the new release (4.1.1.1) of the X2Go source project »src:x2goclient«. You can view the complete changelog entry of src:x2goclient (4.1.1.1) below, and you can use the following link to view all the code changes between this and the last release of src:x2goclient. http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=eef4bf3e0e618b15cbf6649e9dbb07d99e57ad00;hp=f0fb9c49b1c30fd025c2c7c9094fa662b8b09b4d If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:x2goclient. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:x2goclient Version: 4.1.1.1-0x2go1 Status: RELEASE Date: Thu, 15 Feb 2018 21:38:31 +0100 Fixes: 408 559 1122 1209 1214 1227 Changes: x2goclient (4.1.1.1-0x2go1) RELEASED; urgency=medium . [ Mihai Moldovan ] * New upstream version (4.1.1.1): - src/pulsemanager.cpp: print out PA --version output as a debug message. - macbuild.sh: also bundle xauth binary as nxauth binary. - macbuild.sh: switch to bundling PulseAudio 11.1 since it's now available in MacPorts. - src/sshmasterconnection.cpp: don't ask for private key passphrase if auto-login merely failed due to the server denying the public key. Fixes: #1122. - src/{httpbrokerclient,onmainwindow,sshmasterconnection}.{cpp,h}: introduce new passphrase_type enum and replace the old verificationCode boolean value with that. Allows using more messages, including a new one for plain password prompts. Adapt usage accordingly. The implementation is ugly, but there's no good way around that (short of using C++11 features). The enum would really logically belong to ONMainWindow, but since we also have to use it in SshMasterConnection, that may not include onmainwindow.h to avoid a circular dependency, it has to be part of SshMasterConnection for now. - src/sshmasterconnection.cpp: query for password if it wasn't already provided. Fixes: #1122. This usually happens if auto-login is enabled, which bypasses the password prompt. If auto-login fails, authentication normally continues via challenge auth or plain passwords, but since users had no chance to input a password, such authentication will always fail. Give users a way to enter passwords, in case the auto-login failed. - src/onmainwindow.cpp: finally include version information in debug output. - res/i18n/x2goclient_*.ts: apply last change to translation files directly. - src/sshmasterconnection.cpp: error out with a useful error message in case no password has been provided when doing password authentication. - src/sshmasterconnection.cpp: don't output an empty error message if password authencation has been requested but the server does not support this mechanism. Fixes: #408. - src/onmainwindow.cpp: wrap user name for client-side mounts in quotes. Fixes: #559. Will fail with user names that contain quotes, but oh well... - {example/x2goclient-cli,src/onmainwindow.cpp}: remove hopefully obsolete HOSTNAME exporting into environment. - src/onmainwindow.cpp: remove client-side LD_LIBRARY_PATH meddling. Nothing of value is in that directory and nxproxy hasn't needed that for years. - src/settingswidgets.cpp: don't incorrectly enable whole display settings in single display setups. Let debugging mode override this behavior, though. - src/onmainwindow.cpp: pass X2GO_RANDR_XINERAMA=[yes,no] to x2gostartagent as an environment variable based upon the xinerama session setting. Has no effect when connecting to older X2Go Server versions and handles startup correctly with X2Go Server 4.1.0.0. - src/onmainwindow.cpp: fix another leaked X2goSettings object. - src/onmainwindow.cpp: rename xinerama env variable on session startup to X2GO_XINERAMA in accordance with server changes. - src/onmainwindow.cpp: supply xinerama option as another parameter to x2goresume-session on session resume. - src/sessionbutton.cpp: make button non-sensitive in bottom right part if it's editable. Fixes: #1214. - {src/{help.cpp,onmainwindow.{cpp,h}},man/man1/x2goclient.1}: reformat, whitespace fixes, split out close button slot in a separate function. - src/onmainwindow.{cpp,h}: let close button be a member variable. - src/onmainwindow.cpp: disable and enable close button during and after connection startup. - src/onmainwindow.cpp: initialize directRDP to false to be able to call slotSuspendSessFromSt () even if no session has previously been started. - src/onmainwindow.cpp: only initialize directRDP variable if platform is Linux. Fixes compile failures on Windows and OS X. - src/onmainwindow.cpp: always create close button, but either hide or show it based upon whether --closebt was provided or not. - src/onmainwindow.cpp: revert 3060183a78d8b6bd81bec9968c985c38bfd1e5c2. Being able to suspend sessions via the close button is complex and unnecessary, since in thinclient mode, for which this feature is useful, users will not be able to see the client window while a session is executing, due to it running in full screen mode. - src/onmainwindow.cpp: always enable close button, let it log out from a broker if already authenticated or close the client on click. Fixes: #1209. - man/man1/x2goclient.1: clarify what the close button now does. It either lets the user re-login to the broker or closes the client. - src/onmainwindow.cpp: correctly initialize brokerAuthentication member of ConfigFile struct. - {res/{img/png/close-button.png,resources.qrc}, src/{{onmainwindow,httpbrokerclient}.{cpp,h},help.cpp}, man/man1/x2goclient.1}: rename close button to broker logout button. Reimplement the way it is shown - disable it upon startup and only enable it after successful broker authentication. - man/man1/x2goclient.1: add missing escape signs before dash/minus characters. . [ Oleksandr Shneyder ] * New upstream version (4.1.1.1): - Change echo mode for user input in InteractionDialog. . [ Walid Moghrabi ] * New upstream version (4.1.1.1): - {res/img/png/,res/resources.qrc}: add close-button.png file. - {src/{help.cpp,onmainwindow.{cpp,h}},man/man1/x2goclient.1}: add new option --closebt. Fixes: #1227. Adds a close button in the top-left client corner (maybe next to the halt button) that currently just terminates the client. ------------=_1518727506-8542-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by bugs.x2go.org; 8 Dec 2016 18:04:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=3.0 tests=BAYES_50,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 00FD25DBE7 for ; Thu, 8 Dec 2016 19:04:03 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nI1C0a1NXRr7 for ; Thu, 8 Dec 2016 19:03:56 +0100 (CET) X-Greylist: delayed 307 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Thu, 08 Dec 2016 19:03:55 CET Received: from apu.snow-crash.org (apu.snow-crash.org [78.47.227.179]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 878B25DAC1 for ; Thu, 8 Dec 2016 19:03:55 +0100 (CET) Received: from chao.old-forest.org (arne.local [10.99.0.2]) by apu.snow-crash.org (Postfix) with ESMTP id A682186D40 for ; Thu, 8 Dec 2016 18:58:48 +0100 (CET) Received: from anhrefn ([192.168.10.23] helo=anhrefn.saar.de) by chao.old-forest.org with esmtps (Exim 4.84_2) (envelope-from ) id 1cF2xy-00083z-Vp for submit@bugs.x2go.org; Thu, 08 Dec 2016 18:58:48 +0100 Received: from aw by anhrefn.saar.de with local (Exim 4.87) (envelope-from ) id 1cF2yI-00016O-QC for submit@bugs.x2go.org; Thu, 08 Dec 2016 18:59:06 +0100 Date: Thu, 8 Dec 2016 18:59:06 +0100 From: Arne Wichmann To: submit@bugs.x2go.org Subject: x2goclient spurously asks for passphrase on autologin Message-ID: <20161208175906.GD20753@anhrefn.saar.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8w3uRX/HFJGApMzv" Content-Disposition: inline Return-Receipt-To: aw@anhrefn.saar.de X-message-flag: Outluck ist kaputt :-) User-Agent: Mutt/1.5.23 (2014-03-12) --8w3uRX/HFJGApMzv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Package: x2goclient Version: 4.0.5.2 When using=20 x2goclient --pgp-card and not using a Smartcard, after typing a password there will be a popup window asking for a passphrase even though no usable keys are available. (The problem arose at a Thinclient of a customer who in some cases does not use their smartcards.) After some digging into the problem I think that the autologin flag should be cleared after SshMasterConnection::userAuthAuto has been tried once. Alternatively SshMasterConnection::userAuthAuto could check if there are usable keys before asking for a passphrase. Or it could check if a password has already been given.=20 cu AW --=20 [...] If you don't want to be restricted, don't agree to it. If you are coerced, comply as much as you must to protect yourself, just don't support it. Noone can free you but yourself. (crag, on Debian Planet) Arne Wichmann (aw@saar.de) --8w3uRX/HFJGApMzv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJYSZ9kAAoJEENYfBy4DUs+HwQP/2fT3ADbK1AvS332H44S4dGA Va5RYjoGPn312yC1BwruBMMPdk5QYYHxAHmHJvM0wtzlHFmHftq9RCVPzHUu/LPV ojjwdJuk2SdTcp70pCsyHs56IPQcAevjN5QtKm4eutI2OcnG34kXs6mRUIBSo8gO afm8Gnbf42cno9xx0olHKxwwqfOJkzqDD1hxlSnGL+ybIQ8Irl2Zvr215fJmQtHh kqO/pOCCogoeLpxSddOcHsb8a/9c3U27QtU1IHB0S5yPeWCR9c7WU5bMxhNWvzIL gIyiuixr+edmd+pjAeoCpNeBylFhhKBd8Kz5IBJQ1pMSent/kcqzYotyg3iYSpxj X0Nq1na49AkxaXgkDP+GbBfydQJJneFM71j0kbkn2wR/ocG36VF8BTez0pnPqERG MCdkag9jbDwL6ELwSURfTaiL6wxUuq1zHbIZompZXK6f1rQyvyOk9eyxij5HjLrU O8HA8aC3cgQLwMmxa7hPfBzDyTV5pSIxtEFyo0sqW+2q/x1a6+axPShu99w+a9O6 f2C7Zt+/rb795aFPxcobJ+iKO7VNxJiOnMHo+fpHgR9hMELlaM1tWFh4LKcIyxkk 6x3C758opxi7z17SzKqJ04VLJlkYoPxwGKJzn6+C6LGbxQqX/dDzuF6UaFEOBNLi VdSD3pAo8zh5/ceoBhGf =KeRp -----END PGP SIGNATURE----- --8w3uRX/HFJGApMzv-- ------------=_1518727506-8542-0--