From aw@old-forest.org Thu Dec 8 19:04:03 2016 Received: (at submit) by bugs.x2go.org; 8 Dec 2016 18:04:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=3.0 tests=BAYES_50,URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 00FD25DBE7 for ; Thu, 8 Dec 2016 19:04:03 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nI1C0a1NXRr7 for ; Thu, 8 Dec 2016 19:03:56 +0100 (CET) X-Greylist: delayed 307 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Thu, 08 Dec 2016 19:03:55 CET Received: from apu.snow-crash.org (apu.snow-crash.org [78.47.227.179]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 878B25DAC1 for ; Thu, 8 Dec 2016 19:03:55 +0100 (CET) Received: from chao.old-forest.org (arne.local [10.99.0.2]) by apu.snow-crash.org (Postfix) with ESMTP id A682186D40 for ; Thu, 8 Dec 2016 18:58:48 +0100 (CET) Received: from anhrefn ([192.168.10.23] helo=anhrefn.saar.de) by chao.old-forest.org with esmtps (Exim 4.84_2) (envelope-from ) id 1cF2xy-00083z-Vp for submit@bugs.x2go.org; Thu, 08 Dec 2016 18:58:48 +0100 Received: from aw by anhrefn.saar.de with local (Exim 4.87) (envelope-from ) id 1cF2yI-00016O-QC for submit@bugs.x2go.org; Thu, 08 Dec 2016 18:59:06 +0100 Date: Thu, 8 Dec 2016 18:59:06 +0100 From: Arne Wichmann To: submit@bugs.x2go.org Subject: x2goclient spurously asks for passphrase on autologin Message-ID: <20161208175906.GD20753@anhrefn.saar.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8w3uRX/HFJGApMzv" Content-Disposition: inline Return-Receipt-To: aw@anhrefn.saar.de X-message-flag: Outluck ist kaputt :-) User-Agent: Mutt/1.5.23 (2014-03-12) --8w3uRX/HFJGApMzv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Package: x2goclient Version: 4.0.5.2 When using=20 x2goclient --pgp-card and not using a Smartcard, after typing a password there will be a popup window asking for a passphrase even though no usable keys are available. (The problem arose at a Thinclient of a customer who in some cases does not use their smartcards.) After some digging into the problem I think that the autologin flag should be cleared after SshMasterConnection::userAuthAuto has been tried once. Alternatively SshMasterConnection::userAuthAuto could check if there are usable keys before asking for a passphrase. Or it could check if a password has already been given.=20 cu AW --=20 [...] If you don't want to be restricted, don't agree to it. If you are coerced, comply as much as you must to protect yourself, just don't support it. Noone can free you but yourself. (crag, on Debian Planet) Arne Wichmann (aw@saar.de) --8w3uRX/HFJGApMzv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJYSZ9kAAoJEENYfBy4DUs+HwQP/2fT3ADbK1AvS332H44S4dGA Va5RYjoGPn312yC1BwruBMMPdk5QYYHxAHmHJvM0wtzlHFmHftq9RCVPzHUu/LPV ojjwdJuk2SdTcp70pCsyHs56IPQcAevjN5QtKm4eutI2OcnG34kXs6mRUIBSo8gO afm8Gnbf42cno9xx0olHKxwwqfOJkzqDD1hxlSnGL+ybIQ8Irl2Zvr215fJmQtHh kqO/pOCCogoeLpxSddOcHsb8a/9c3U27QtU1IHB0S5yPeWCR9c7WU5bMxhNWvzIL gIyiuixr+edmd+pjAeoCpNeBylFhhKBd8Kz5IBJQ1pMSent/kcqzYotyg3iYSpxj X0Nq1na49AkxaXgkDP+GbBfydQJJneFM71j0kbkn2wR/ocG36VF8BTez0pnPqERG MCdkag9jbDwL6ELwSURfTaiL6wxUuq1zHbIZompZXK6f1rQyvyOk9eyxij5HjLrU O8HA8aC3cgQLwMmxa7hPfBzDyTV5pSIxtEFyo0sqW+2q/x1a6+axPShu99w+a9O6 f2C7Zt+/rb795aFPxcobJ+iKO7VNxJiOnMHo+fpHgR9hMELlaM1tWFh4LKcIyxkk 6x3C758opxi7z17SzKqJ04VLJlkYoPxwGKJzn6+C6LGbxQqX/dDzuF6UaFEOBNLi VdSD3pAo8zh5/ceoBhGf =KeRp -----END PGP SIGNATURE----- --8w3uRX/HFJGApMzv--