From unknown Sat Apr 18 09:12:34 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#1118: [X2Go-Dev] Share folder is broken for x2goclient-4.0.5.2-2016.09.20-setup.exe Reply-To: Mihai Moldovan , 1118@bugs.x2go.org Resent-From: Mihai Moldovan Resent-To: x2go-dev@lists.x2go.org Resent-CC: owner@bugs.x2go.org X-Loop: owner@bugs.x2go.org Resent-Date: Tue, 29 Nov 2016 17:50:01 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: followup 1118 X-X2Go-PR-Package: x2goclient-4.0.5.2-2016.09.20-setup X-X2Go-PR-Keywords: Received: via spool by 1118-submit@bugs.x2go.org id=B1118.148044167428308 (code B ref 1118); Tue, 29 Nov 2016 17:50:01 +0000 Received: (at 1118) by bugs.x2go.org; 29 Nov 2016 17:47:54 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS autolearn=ham version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 7DCDA3BC8A for <1118@bugs.x2go.org>; Tue, 29 Nov 2016 18:47:51 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KJNACi15P-vl for <1118@bugs.x2go.org>; Tue, 29 Nov 2016 18:47:44 +0100 (CET) Received: from Root24.de (powered.by.root24.eu [5.135.3.88]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 8C4623BC7D for <1118@bugs.x2go.org>; Tue, 29 Nov 2016 18:47:44 +0100 (CET) Received: from nopileos.local (178.162.222.41.adsl.inet-telecom.org [178.162.222.41]) by mail.ionic.de (Postfix) with ESMTPSA id DA0954F00066; Tue, 29 Nov 2016 18:47:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ionic.de; s=default; t=1480441664; bh=JnHK7Y0WwqDIWU8XAeM/RU+RmYImRnopnjZ1NUMHzuA=; h=Subject:To:References:From:Date:In-Reply-To:From; b=HJ51cUJ7cDt8tm+BAEIReUzUXF2zA+Eyr1PiMQqxycvkIniA2qOt+5TKwRKBzmCL6 Y5ehTYj7NFrs3BC5PIMvI/jGJrcd1rtgx1NIEG+OVkV7xLCwLh52ygi4WJskfwTsbs NxOalvnzi3CD7eWiRVdlG1z0PlFeh3C3deS25Z7w= To: Michael , 1118@bugs.x2go.org References: From: Mihai Moldovan Message-ID: <2a11eb7c-be89-f040-dba6-46d6bca48bf0@ionic.de> Date: Tue, 29 Nov 2016 18:47:41 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="D09c906F7ai3o6jS6JOUXjgm5NL42CW9O" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --D09c906F7ai3o6jS6JOUXjgm5NL42CW9O Content-Type: multipart/mixed; boundary="p2rrEdXNUnw5sU4TvBiwxWKdoob6llUXV"; protected-headers="v1" From: Mihai Moldovan To: Michael , 1118@bugs.x2go.org Message-ID: <2a11eb7c-be89-f040-dba6-46d6bca48bf0@ionic.de> Subject: Re: [X2Go-Dev] Share folder is broken for x2goclient-4.0.5.2-2016.09.20-setup.exe References: In-Reply-To: --p2rrEdXNUnw5sU4TvBiwxWKdoob6llUXV Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Control: reassign -1 x2goclient 4.0.5.2 Control: tag -1 win32 On 29.11.2016 05:55 AM, Michael wrote: > Package: x2goclient-4.0.5.2-2016.09.20-setup > Version: x2goclient-4.0.5.2-2016.09.20-setup >=20 > Steps to reproduce: >=20 > 1. Install x2goclient-4.0.5.2-2016.09.20-setup.exe >=20 > 2. Make sure C:\Users\XXXXXXX\.x2go\etc does not exist, or delete it if= existed. >=20 > 3. Create a new session to a x2go server. >=20 > 4. Enable share folder and watch the bug report window. >=20 > From the source code: >=20 > 9931 void ONMainWindow::startWinServers() > 9932 { > 9952 generateHostKey(RSA_KEY_TYPE); >=20 > For Windows, we only generate RSA_KEY, but in >=20 > 8013 QString ONMainWindow::createRSAKey() > 8014 { > 8043 #ifdef Q_OS_WIN > 8044 rsa.setFileName ( > 8045 wapiShortFileName ( > 8046 homeDir+"\\.x2go\\etc\\ssh_host_dsa_key.pub" ) ); > 8056 if ( !rsa.open ( QIODevice::ReadOnly | QIODevice::Text ) ) > 8057 { >=20 >=20 > We check DSA_KEY instead, which of course would not exist. >=20 > To fix this bug: >=20 > 8046 - homeDir+"\\.x2go\\etc\\ssh_host_dsa_key.pub" ) ); > 8046 + homeDir+"\\.x2go\\etc\\ssh_host_rsa_key.pub" ) ); I'm aware of that bug, but probably won't fix it directly. That thing sho= uldn't come up with the new code in my bugfix/osx branch, since I've rewritten a= lmost all of the host key, client key (as used for the local [*not* remote] ssh= daemon) and ssh daemon handling. Changing portions there on the current m= aster branch would only lead to biggish conflicts while rebasing - that's not r= eally worth the effort. I'm rather concentrating on getting the other functiona= lity done and release-worthy instead, which will automatically fix this bug. Mihai --p2rrEdXNUnw5sU4TvBiwxWKdoob6llUXV-- --D09c906F7ai3o6jS6JOUXjgm5NL42CW9O Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCgAGBQJYPb89AAoJEB/WLtluJTqHXV8P/3SD+rwaK4wYR9EBicavgJfH hUSiaYBPOYY5P8erLTKdJtxCNVR9NcnOCCwotTFM8qsYegiO7Y9dZGdF7FUAg+ul GwH3zf8MvygKuLt8mE9h6p/jWaqGjTFeY5cuNkQRhlmWcDf9gMGXCPp83PIN7V45 YNJiLZ5agg76BWsQDilXLzFgnqt5nEiGFfxKusvDoA6BUo0Rp+cKKOIzzfv6otq/ kpRRuP+HyvUkD9x+L5YQhMADIdXrCFI02ZSPdqtvmXw7VU8gh/UfB6dbjkhoOthe uTXxXDQGZFdGKCSI/q4zsExd8ksRUW3gtKsm6XuwC7lpE8hpShoDNKTwcoVsd46A nPbJN0nQ9HKCu422vhCvauV1CFXaMH+8/Y2PeA7C1RTGI7OBFaDnKmHPMftXPOKA KzJgJxlfbaQALP6Fo0T7aqqGx3QbdAdHDK+COJcmwNhrDUvcPm8huOK5p4y8Jnjo vid5ZONet+TnmAHaTxOSqhgleR3pBY/v4rBnBGAjtEsOWvoB6Wh3egnfpXp+AG6Q ddXjzmjncREr9sMNRSJSHDUqonBUlVRYsBCqX/6bpqzPj7UhX80rOS33NvhxxM4+ l3yxbawHbfJ4rqhlnFlOuBtNmJMTyiZfrAgOmMOANtAKsZidUN8F4vYqI2u7FTTe Ublw7EcSgMka2JM+6vMa =fTwc -----END PGP SIGNATURE----- --D09c906F7ai3o6jS6JOUXjgm5NL42CW9O--