From unknown Sat Apr 18 07:54:04 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#1118: Share folder is broken for x2goclient-4.0.5.2-2016.09.20-setup.exe Reply-To: Michael , 1118@bugs.x2go.org Resent-From: Michael Resent-To: x2go-dev@lists.x2go.org Resent-CC: owner@bugs.x2go.org X-Loop: owner@bugs.x2go.org Resent-Date: Tue, 29 Nov 2016 05:00:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: report 1118 X-X2Go-PR-Package: x2goclient-4.0.5.2-2016.09.20-setup X-X2Go-PR-Keywords: Received: via spool by submit@bugs.x2go.org id=B.14803953518800 (code B); Tue, 29 Nov 2016 05:00:02 +0000 Received: (at submit) by bugs.x2go.org; 29 Nov 2016 04:55:51 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-0.1 required=3.0 tests=BAYES_40,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE autolearn=ham version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 1FD065DA85 for ; Tue, 29 Nov 2016 05:55:50 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S5-4YLrYia5f for ; Tue, 29 Nov 2016 05:55:32 +0100 (CET) Received: from mail-ua0-f174.google.com (mail-ua0-f174.google.com [209.85.217.174]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id CDA7F5DA82 for ; Tue, 29 Nov 2016 05:55:31 +0100 (CET) Received: by mail-ua0-f174.google.com with SMTP id 20so166853825uak.0 for ; Mon, 28 Nov 2016 20:55:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=w0gaWwV/DGc149H/oSdibbqRQOepp70H4aHSMif9zzQ=; b=jmOukeY7rIE25ge8NPQfgo//qQJw+tdGEpk3gSZOeQkwtRGVhITrr9Th5I2bcA8QF6 2gleBpNUOq24rTVkZBVhc6z/SYCkrFKSCM3DCTSA0WjKLdbmIKDHdMKFZ7xvrd6iL0KK KzN0AyzZlGIBBux2JvxQQWY49oeWWj37O8qwaKb89KB3Ra9pivJsdBX3QhgpEtfjgJj2 qhZKom4WcPDOhRnnzp4pALlPT3fBrYzfzWe4KnArMZidSeq4121er0gIIBqORdsl/gO/ +/wmaOCH2aWqWNLGARrYJZ+Ke956Tytj1R1NZQDJ565y5jC+vvwmjMCXB48qiA4Dutb8 gOEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=w0gaWwV/DGc149H/oSdibbqRQOepp70H4aHSMif9zzQ=; b=LLpJ2KzvEMSTPPJ9e5cv73YHfJlDQSHbGsG/mit0bkO1wJnaPl31nvZOauc0JR2kWL V0crUryDJBOgm9qDqMNKrsxpRTG2pwKaUrQt6S61GPa4plQ34Zu7r19OH0YndoZhstSD 4b+TFh1CXK9T9sjX1fQRWGSVEbF3h8rSxbXHQYIg6uscbrrSpPqn32LkBjTVgOddjoK1 FcYi6AykbT1GCjK0vcs36ZqiOu01v3jullsm/uxN42EjGdrrqn5IWHvsxboea/GK5P3a 13LWu8j+ROrjIAco9tvxWYMQrMHVogDeEuJ+CwTerQbLDxeV/YGoFpx1XbZdP8AjZNvv L+Ag== X-Gm-Message-State: AKaTC02JX2XKC0mRYenBJW48NNszC+GAAKt9Wf4svlSDrrrLiK6zeExHOBuY/nKdMGJ4byXIYLrfs5ajVXSXeA== X-Received: by 10.176.17.18 with SMTP id e18mr19455640uab.19.1480395330546; Mon, 28 Nov 2016 20:55:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.176.83.156 with HTTP; Mon, 28 Nov 2016 20:55:10 -0800 (PST) From: Michael Date: Tue, 29 Nov 2016 15:55:10 +1100 Message-ID: To: submit@bugs.x2go.org Content-Type: multipart/alternative; boundary=f403045e3b6ecdf1860542696537 --f403045e3b6ecdf1860542696537 Content-Type: text/plain; charset=UTF-8 Package: x2goclient-4.0.5.2-2016.09.20-setup Version: x2goclient-4.0.5.2-2016.09.20-setup Steps to reproduce: 1. Install x2goclient-4.0.5.2-2016.09.20-setup.exe 2. Make sure C:\Users\XXXXXXX\.x2go\etc does not exist, or delete it if existed. 3. Create a new session to a x2go server. 4. Enable share folder and watch the bug report window. >From the source code: 9931 void ONMainWindow::startWinServers() 9932 { 9952 generateHostKey(RSA_KEY_TYPE); For Windows, we only generate RSA_KEY, but in 8013 QString ONMainWindow::createRSAKey() 8014 { 8043 #ifdef Q_OS_WIN 8044 rsa.setFileName ( 8045 wapiShortFileName ( 8046 homeDir+"\\.x2go\\etc\\ssh_host_dsa_key.pub" ) ); 8056 if ( !rsa.open ( QIODevice::ReadOnly | QIODevice::Text ) ) 8057 { We check DSA_KEY instead, which of course would not exist. To fix this bug: 8046 - homeDir+"\\.x2go\\etc\\ssh_host_dsa_key.pub" ) ); 8046 + homeDir+"\\.x2go\\etc\\ssh_host_rsa_key.pub" ) ); --f403045e3b6ecdf1860542696537 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 
Package: =
x2goclient-4.0.5.2-2016.09.20-setup
Version: x2goclient-4.0.5.2-2016.09.20-setup

Steps t=
o reproduce:
1. Install x2goclient-4.0.5.2-2016.09.20-se=
tup.exe

2. Make sure C:\Users\XXXXXXX\.x2go\etc does not exist, or d=
elete it if existed.
3. Create a new session to a x2go server=
.
4. Enable share folder and watch the bug report window.
=

From the source code:

9931 void ONMainWindow::startWi=
nServers()
9932 {
9952         generateHostKey(RSA_KEY_TYPE);
For Windows, we only generate RSA_KEY, but in

8013 QString ONMainWindow::createRSAKey=
()
8014 {
8043 #ifdef Q_OS_WIN
8044     rsa.setFileName (
8045 =
        wapiShortFileName (
8046             homeDir+"\\.x2go\\etc\=
\ssh_host_dsa_key.pub" =
) );
8056     if ( !rsa.open ( QIODevice::ReadOnly | QIODevice::Text ) )=

8057     {


We check DSA_KEY instead, which of course would n=
ot exist.
To fix this bug:

8046=C2=A0=C2=A0 - =C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 homeDir+"\\.x2go\\etc\\ssh_host_dsa_key.pub&q= uot; ) );
8046=C2=A0=C2=A0 + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = homeDir+"\\.x2go\\etc\\ssh_host_rsa_key.pub" ) );
--f403045e3b6ecdf1860542696537--