X2Go Bug report logs - #105
Logic errors in x2goruncommand

version graph

Package: x2goserver; Maintainer for x2goserver is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goserver is src:x2goserver.

Reported by: "Matthew L. Dailey" <matthew.l.dailey@dartmouth.edu>

Date: Fri, 18 Jan 2013 17:18:02 UTC

Severity: normal

Tags: moreinfo, pending

Merged with 64

Found in versions 4.0.0.1, 3.1.1.9-0~623~precise1

Fixed in version 4.0.0.2

Done: mike@das-netzwerkteam.de (Mike Gabriel)

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

X-Loop: git-admin@x2go.org
Subject: Bug#105: Logic errors in x2goruncommand
Reply-To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 105@bugs.x2go.org
Resent-From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Resent-To: x2go-dev@lists.berlios.de
Resent-CC: X2Go Developers <x2go-dev@lists.berlios.de>
X-Loop: git-admin@x2go.org
Resent-Date: Mon, 11 Feb 2013 21:48:01 +0000
Resent-Message-ID: <handler.105.B105.13606191941852@bugs.x2go.org>
Resent-Sender: git-admin@x2go.org
X-X2Go-PR-Message: followup 105
X-X2Go-PR-Package: x2goserver
X-X2Go-PR-Keywords: 
Received: via spool by 105-submit@bugs.x2go.org id=B105.13606191941852
          (code B ref 105); Mon, 11 Feb 2013 21:48:01 +0000
Received: (at 105) by bugs.x2go.org; 11 Feb 2013 21:46:34 +0000
Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199])
	by ymir (Postfix) with ESMTPS id E657A5DA6B;
	Mon, 11 Feb 2013 22:46:33 +0100 (CET)
Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98])
	by freya.das-netzwerkteam.de (Postfix) with ESMTPS id C213CC07;
	Mon, 11 Feb 2013 22:46:33 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id A21EE3BA5D;
	Mon, 11 Feb 2013 22:46:33 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de
Received: from grimnir.das-netzwerkteam.de ([127.0.0.1])
	by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id BSaXIcDQE4jU; Mon, 11 Feb 2013 22:46:33 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 712753BA98;
	Mon, 11 Feb 2013 22:46:33 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 4822E3BA5D;
	Mon, 11 Feb 2013 22:46:33 +0100 (CET)
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	grimnir.das-netzwerkteam.de
X-Spam-Flag: NO
X-Spam-Status: No, hits=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00,
	URIBL_BLOCKED autolearn=ham version=3.3.1 running as userid=
X-Spam-Level: 
X-Spam-Bayes-Score: 0.0000
Received: by grimnir.das-netzwerkteam.de (Postfix, from userid 33)
	id CFACD3BA96; Mon, 11 Feb 2013 22:46:32 +0100 (CET)
Received: from 149-27-142-46.pool.kielnet.net
 (149-27-142-46.pool.kielnet.net [46.142.27.149]) by
 mail.das-netzwerkteam.de (Horde Framework) with HTTP; Mon, 11 Feb 2013
 22:46:32 +0100
Message-ID: <20130211224632.600264ay805gf7aw@mail.das-netzwerkteam.de>
X-Priority: 3 (Normal)
Date: Mon, 11 Feb 2013 22:46:32 +0100
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: "Matthew L. Dailey" <matthew.l.dailey@dartmouth.edu>, 105@bugs.x2go.org
Cc: control@bugs.x2go.org
References: <7AD4B654-3C34-40A2-8C95-C370F80A20AC@dartmouth.edu>
In-Reply-To: <7AD4B654-3C34-40A2-8C95-C370F80A20AC@dartmouth.edu>
MIME-Version: 1.0
Content-Type: multipart/signed;
 boundary="=_60blhjvunv08";
 protocol="application/pgp-signature";
 micalg="pgp-sha1"
Content-Transfer-Encoding: 7bit
User-Agent: Internet Messaging Program (IMP) H3 (4.3.4)
[Message part 1 (text/plain, inline)]
tag #105 pending
thanks

Hi Matthew,

On Fr 18 Jan 2013 18:15:56 CET "Matthew L. Dailey" wrote:

> Package: x2goserver
> Version: 4.1.0.0
>
> Greetings.
>
> In working on a deployment of X2Go on some Ubuntu machines, I found  
> some logic errors in the x2goruncommand script that cased it not to  
> determine the proper session to run for Gnome or Unity on Ubuntu  
> 12.04 (and probably others). In essence, the script was testing the  
> return code of bc, rather than the actual answer (1 or 0) to the  
> boolean question being passed to it.
>
> Here is a patch (also attached) that fixes this problem and I can  
> verify that this works on at least Ubuntu 12.04 systems. I don't  
> have any others I can easily test on. I'm not crazy about the quotes  
> both outside and inside $(), but I think it should be okay. Perhaps  
> a more adept bash programmer might have a better suggestion. :-)
>
> Thanks for your attention and please let me know if you have any  
> questions or need any other information. And, thanks for your hard  
> work on this terrific project!

Thanks for spotting this issue!!!

Fixed in Git Vcs:
http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=cd23b80ca2f1056500e8b78cedebf60089086bda

The fix will be available in X2Go Server 4.0.0.1 (next release).

Greets,
Mike


-- 

DAS-NETZWERKTEAM
mike gabriel, rothenstein 5, 24214 neudorf-bornstein
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.


X2Go Developers <owner@bugs.x2go.org>. Last modified: Wed Jun 19 11:35:10 2019; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.