From unknown Tue May 19 15:22:45 2026 X-Loop: git-admin@x2go.org Subject: Bug#105: Logic errors in x2goruncommand Reply-To: Mike Gabriel , 105@bugs.x2go.org Resent-From: Mike Gabriel Resent-To: x2go-dev@lists.berlios.de Resent-CC: X2Go Developers X-Loop: git-admin@x2go.org Resent-Date: Mon, 11 Feb 2013 21:48:01 +0000 Resent-Message-ID: Resent-Sender: git-admin@x2go.org X-X2Go-PR-Message: followup 105 X-X2Go-PR-Package: x2goserver X-X2Go-PR-Keywords: Received: via spool by 105-submit@bugs.x2go.org id=B105.13606191941852 (code B ref 105); Mon, 11 Feb 2013 21:48:01 +0000 Received: (at 105) by bugs.x2go.org; 11 Feb 2013 21:46:34 +0000 Received: from freya.das-netzwerkteam.de (freya.das-netzwerkteam.de [88.198.48.199]) by ymir (Postfix) with ESMTPS id E657A5DA6B; Mon, 11 Feb 2013 22:46:33 +0100 (CET) Received: from grimnir.das-netzwerkteam.de (grimnir.das-netzwerkteam.de [78.46.204.98]) by freya.das-netzwerkteam.de (Postfix) with ESMTPS id C213CC07; Mon, 11 Feb 2013 22:46:33 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id A21EE3BA5D; Mon, 11 Feb 2013 22:46:33 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at grimnir.das-netzwerkteam.de Received: from grimnir.das-netzwerkteam.de ([127.0.0.1]) by localhost (grimnir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BSaXIcDQE4jU; Mon, 11 Feb 2013 22:46:33 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 712753BA98; Mon, 11 Feb 2013 22:46:33 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by grimnir.das-netzwerkteam.de (Postfix) with ESMTP id 4822E3BA5D; Mon, 11 Feb 2013 22:46:33 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on grimnir.das-netzwerkteam.de X-Spam-Flag: NO X-Spam-Status: No, hits=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham version=3.3.1 running as userid= X-Spam-Level: X-Spam-Bayes-Score: 0.0000 Received: by grimnir.das-netzwerkteam.de (Postfix, from userid 33) id CFACD3BA96; Mon, 11 Feb 2013 22:46:32 +0100 (CET) Received: from 149-27-142-46.pool.kielnet.net (149-27-142-46.pool.kielnet.net [46.142.27.149]) by mail.das-netzwerkteam.de (Horde Framework) with HTTP; Mon, 11 Feb 2013 22:46:32 +0100 Message-ID: <20130211224632.600264ay805gf7aw@mail.das-netzwerkteam.de> X-Priority: 3 (Normal) Date: Mon, 11 Feb 2013 22:46:32 +0100 From: Mike Gabriel To: "Matthew L. Dailey" , 105@bugs.x2go.org Cc: control@bugs.x2go.org References: <7AD4B654-3C34-40A2-8C95-C370F80A20AC@dartmouth.edu> In-Reply-To: <7AD4B654-3C34-40A2-8C95-C370F80A20AC@dartmouth.edu> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=_60blhjvunv08"; protocol="application/pgp-signature"; micalg="pgp-sha1" Content-Transfer-Encoding: 7bit User-Agent: Internet Messaging Program (IMP) H3 (4.3.4) This message is in MIME format and has been PGP signed. --=_60blhjvunv08 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit tag #105 pending thanks Hi Matthew, On Fr 18 Jan 2013 18:15:56 CET "Matthew L. Dailey" wrote: > Package: x2goserver > Version: 4.1.0.0 > > Greetings. > > In working on a deployment of X2Go on some Ubuntu machines, I found > some logic errors in the x2goruncommand script that cased it not to > determine the proper session to run for Gnome or Unity on Ubuntu > 12.04 (and probably others). In essence, the script was testing the > return code of bc, rather than the actual answer (1 or 0) to the > boolean question being passed to it. > > Here is a patch (also attached) that fixes this problem and I can > verify that this works on at least Ubuntu 12.04 systems. I don't > have any others I can easily test on. I'm not crazy about the quotes > both outside and inside $(), but I think it should be okay. Perhaps > a more adept bash programmer might have a better suggestion. :-) > > Thanks for your attention and please let me know if you have any > questions or need any other information. And, thanks for your hard > work on this terrific project! Thanks for spotting this issue!!! Fixed in Git Vcs: http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=cd23b80ca2f1056500e8b78cedebf60089086bda The fix will be available in X2Go Server 4.0.0.1 (next release). Greets, Mike -- DAS-NETZWERKTEAM mike gabriel, rothenstein 5, 24214 neudorf-bornstein fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb --=_60blhjvunv08 Content-Type: application/pgp-signature Content-Description: Digitale PGP-Unterschrift Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAABAgAGBQJRGWa4AAoJEJr0azAldxsxEkMP/iXvcee6yyOlVudr5/fo/GSC xdKehWg8FjNFG+XTVc70HNBBYaehV6Q7JbCwJHJyLegELQ/SThwuw/6wJcOcpTff 1qLKVydOVmOww2gJwLJopMbGsmvaS6D/UsxoM0WA4XwQmv+7ykbHewMH9wpsu9eV /sDRZT2DiCysmmfvW9FJapE0u8wOvr1VTSX9z3VJDWwQ0nKUtGBdaZpO5by8K7IU UKWVZnh4Ce6b7O30fUK5g3Jm5EHUjEseOSp7VRhchet6Z5HHDShwKxum+zxbdFVS uVCzqOdN5IwA/I/nsGYDnpqoxhiq6mRZmCg1kXgqvLmcd7ubr/ohnkfuxTs7caeK zA/9z2KX4efAkRPq0tu5AxeVEX+Ssel7VqVti9jx56zEBahrjNEhwxFcav6LCcCh PcP2cv9hEDr9ENdEw4N0ECudsImtw5DzQXn7NY1OPkjg0y55N+MzDE0ujloaYnp+ ZhKr1kkhBx2SLQLpu5XJvyP2sDyNraag3WTVhjW6bi4yuoJfVTiNlVlzy/JTnKf+ mjsZC/uFpPmqwfKF6NOF1U7pOsYSZLRk3MN7NXP2wBzpWyT4q5qgCey8awcNyc1Y ETaj0o8aBL8bnBeHmWnnyqJowbmOXMhxDVGOt3dPiF8pfSI5aSU6UEppetyRQZof P9cysSeAsh5E31GJXv5D =ttHm -----END PGP SIGNATURE----- --=_60blhjvunv08--