Subject: Bug#1034: Fix a segfault in x2goclient with OpenBSD

From: Denis Fondras <[email-masked]>
Date: Sat, 14 May 2016 12:19:12 +0200

Package: x2goclient
Version: 4.0.5.1
Tag: patch

When compiling X2Go client on OpenBSD5.9/amd64, x2goclient will segfault in
SshMasterConnection::channelLoop(). The culprit is the declaration of buffer[]
inside the code of this function, moving it outside of channelLoop() fixes the
segfault.

--- src/sshmasterconnection.cpp	Sun May  8 16:58:37 2016
+++ src/sshmasterconnection.cpp	Sun May  8 17:02:54 2016
@@ -54,6 +54,7 @@
 // #define SSH_DEBUG
 
 static bool isLibSshInited=false;
+char buffer[1024*512]; //512K buffer
 
 const QString SshMasterConnection::challenge_auth_code_prompts_[] = {
   "Verification code:",
@@ -1464,7 +1465,6 @@
             copy();
         copyRequestMutex.unlock();
 
-        char buffer[1024*512]; //512K buffer
         int nbytes;
         fd_set rfds;