X2Go Bug report logs - #1013
x2gobroker-daemon doesn't return error when it can't spawn/bind to port

Full log

Message #26 received at control@bugs.x2go.org (full text, mbox, reply):

Received: (at control) by bugs.x2go.org; 13 Sep 2018 13:26:51 +0000
From x2go@ymir.das-netzwerkteam.de  Thu Sep 13 15:26:35 2018
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,NO_RELAYS,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.1
Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005)
	id 3812D5DAEE; Thu, 13 Sep 2018 15:26:35 +0200 (CEST)
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
To: 1013-submitter@bugs.x2go.org
Cc: control@bugs.x2go.org, 1013@bugs.x2go.org
Subject: X2Go issue (in src:x2gobroker) has been marked as pending for release
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
X-Mailer: http://snipr.com/post-receive-tag-pending
Message-Id: <20180913132635.3812D5DAEE@ymir.das-netzwerkteam.de>
Date: Thu, 13 Sep 2018 15:26:35 +0200 (CEST)

tag #1013 pending
fixed #1013 0.0.4.0
thanks

Hello,

X2Go issue #1013 (src:x2gobroker) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

    http://code.x2go.org/gitweb?p=x2gobroker.git;a=commitdiff;h=c3067f0

The issue will most likely be fixed in src:x2gobroker (0.0.4.0).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit c3067f00df60d43ebbbecf5dd6f0f8da3c4221e4
Author: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Date:   Thu Sep 13 15:26:01 2018 +0200

    bin/x2gobroker: If binding the http server fails, a non-zero exit code should be returned. (Fixes: #1013).

diff --git a/debian/changelog b/debian/changelog
index fc33189..7217c4f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -75,6 +75,8 @@ x2gobroker (0.0.4.0-0x2go1) UNRELEASED; urgency=medium
       install into x2gobroker bin:pkg (on DEB based systems).
     - Makefile.docupload: Add apidoc target (running sphinx-apidoc).
     - docs/source: Initialize Sphinx API documentation's .rst files.
+    - bin/x2gobroker: If binding the http server fails, a non-zero exit code
+      should be returned. (Fixes: #1013).
   * debian/*:
     + Trigger Makefile's install target and install those files. Drop debhelper
       from-source-installation magic.

Send a report that this bug log contains spam.