From unknown Mon May 25 06:14:40 2026 MIME-Version: 1.0 X-Mailer: MIME-tools 5.507 (Entity 5.507) X-Loop: owner@bugs.x2go.org From: owner@bugs.x2go.org (X2Go Bug Tracking System) Subject: Bug#1013 closed by X2Go Release Manager X2Go Release Manager (X2Go issue (in src:x2gobroker) has been marked as closed) Message-ID: References: <20190202210825.4CF6B5DAED@ymir.das-netzwerkteam.de> X-X2go-PR-Keywords: pending X-X2go-PR-Message: they-closed 1013 X-X2go-PR-Package: x2gobroker-daemon X-X2go-PR-Source: x2gobroker Date: Sat, 02 Feb 2019 21:10:16 +0000 Content-Type: multipart/mixed; boundary="----------=_1549141816-32059-0" This is a multi-part message in MIME format... ------------=_1549141816-32059-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This is an automatic notification regarding your Bug report which was filed against the x2gobroker-daemon package: #1013: x2gobroker-daemon doesn't return error when it can't spawn/bind to p= ort It has been closed by X2Go Release Manager X2Go Release Manager . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact X2Go Release Manager X= 2Go Release Manager by replying to this email. --=20 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems ------------=_1549141816-32059-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at control) by bugs.x2go.org; 2 Feb 2019 21:08:51 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,NO_RELAYS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id 4CF6B5DAED; Sat, 2 Feb 2019 22:08:25 +0100 (CET) From: =?utf-8?q?X2Go_Release_Manager?= X2Go Release Manager To: 1013-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 1013@bugs.x2go.org Subject: X2Go issue (in src:x2gobroker) has been marked as closed Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20190202210825.4CF6B5DAED@ymir.das-netzwerkteam.de> Date: Sat, 2 Feb 2019 22:08:25 +0100 (CET) close #1013 thanks Hello, we are very hopeful that X2Go issue #1013 reported by you has been resolved in the new release (0.0.4.0) of the X2Go source project »src:x2gobroker«. You can view the complete changelog entry of src:x2gobroker (0.0.4.0) below, and you can use the following link to view all the code changes between this and the last release of src:x2gobroker. http://code.x2go.org/gitweb?p=x2gobroker.git;a=commitdiff;h=a2455880e34e31546054ce50abd1512c61430b51;hp=dbea0c7c20c58e6783ea796691f0881131ad6590 If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:x2gobroker. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:x2gobroker Version: 0.0.4.0-0x2go1 Status: RELEASE Date: Sat, 02 Feb 2019 21:50:29 +0100 Fixes: 1013 1234 1240 1252 1315 Changes: x2gobroker (0.0.4.0-0x2go1) RELEASED; urgency=medium . [ Mike Gabriel ] * New upstream version (0.0.4.0): - Bump upstream version to 0.0.4.0. - Port to Python 3. (Fixes: #1240). - Drop left-over debug print() call. - Makefile: Assure that setup.py is run under Python3. - Improve debugging messages during authentication phase. - x2gobroker/basicauth.py: Fix call of base64.decodestring on Python3. - Unit tests: Fix deep misunderstanding in the way allow-deny vs. deny-allow should actually work. - x2gobroker/brokers/base_broker.py: Entire rewrite of check_profile_acls() method. (Fixes: #1234). - x2gobroker/tests/test_web_plain_base.py: Add test case for passwords with accentuated characters (using the testsuite_authmech for now). - Makefile: Support skipping installation of the x2gobroker PyModule. Useful when building with CDBS on Debian. - Makefile: Compress man pages. - Makefile: Run setup.py build at build time. - tmpfiles.d utilization: Create RUNDIR/x2gobroker via tmpfiles.d system. Fixes missing dir and flawed permissions when running under systemd. - etc/x2gobroker.conf: Mention the per-profile option for enabling/disabling load checker support. - sbin/{x2gobroker-pubkeyauthorizer,x2gobroker-keygen}: Use proper octal numbers for file permissions. - sbin/x2gobroker-pubkeyauthorizer: Fix key lookup in os.environ for Python3. - sbin/x2gobroker-pubkeyauthorizer: Some string/bytecode fixes for Python3. Plus urllib -> urllib.request. - sbin/x2gobroker-pubkeyauthorizer: Improve key integrity checker and move it further up. Plus one more Python2 -> Python3 issue fixed. - sbin/x2gobroker-pubkeyauthorizer: Drop unused binascii import. - x2gobroker-pubkeyauthorizer: Tiny Python2to3 fix. - load checker integration: Make the default-use-load-checker option work like all other default-* options. - uccs frontend: Convert datetime.datetime object to string before answering the http request with it. - x2gobroker/agent (check_load()): Bail out if no remote agent is given. - x2gobroker-testagent: Convert to Python3 (using 2to3 tool). - x2gobroker-loadchecker: Python3'ify iteration over dict keys. - x2gobroker/utils.py: Provide helper functions for pretty-formatting key fingerprints. - x2gobroker-keygen: Use new fingerprint formatting functions. - x2gobroker/agent.py: Bail out if no hostaddr contained in remote_agent. - x2gobroker/agent.py: No load-checking when remote_agent is set to 'LOCAL'. - x2gobroker/agent.py: Better sanity checks for remote_agent and its dict keys hostname and hostaddr. - x2gobroker/loadchecker.py: Report properly to the logger if we fail to obtain a load factor. - x2gobroker-loadchecker.service: loadchecker service needs to chuid to system user x2gobroker. (Fixes: #1252). - x2gobroker-loadchecker.service: File ownership should be x2gobroker:x2gobroker, too. - x2gobroker-loadchecker: No chown/chmod if we are not running as root (which is mostly the case). - x2gobroker/brokers/inifile_broker.py: Make sure profile['name'] has a fallback if not given in the session profile. - x2gobroker/brokers/inifile_broker.py: Also check for presence of 'host' and 'sshport'. - UCCS API change for X2Go Sessions: Rename "SessionType" to "Command". - obligatory profile keys: Move from inifile backend to UCCS frontend, as those requirements are frontend specific. - UCCS: Start working on API version 5. - x2gobroker/uccsjson.py: Hide private Python class properties from JSON dict (like ._api_version). - UCCS frontend: Fix API version check. - UCSS frontend: Propagate API version onwards to the X2GoServer JSON generator class. - infile broker backend: Fix handling of empty lists in session profile and session profile defaults. - etc/x2gobroker-wsgi.apache.*: Drop Apache2.2 support. - Log to system broker.log file when run via x2gobroker-ssh. - Getting started documentation: Rework document, convert to markdown, install into x2gobroker bin:pkg (on DEB based systems). - Makefile.docupload: Add apidoc target (running sphinx-apidoc). - docs/source: Initialize Sphinx API documentation's .rst files. - bin/x2gobroker: If binding the http server fails, a non-zero exit code should be returned. (Fixes: #1013). - x2gobroker/loadchecker.py: Don't re-read the x2gobroker.conf during each cycle of the load checking loop. Rather read it on service startup and require a service restart when x2gobroker.conf has been changed. - x2gobroker/loadchecker.py: Avoid rare cases where at the end of a load checking cycle a negative sleep time would have been calculated. (Fixes: #1315). Thanks to Walid Moghrabi for catching this. - HTTP broker: Add &login= support to plain and json broker frontends. - SSH broker: Add --login option. This now supports X2Go Broker user and X2Go Server username being different accounts. - bin/x2gobroker: Correctly use split_host_address() function call. - bin/x2gobroker: Don't override already defined logger objects, define them properly where needed. - Convert one more unicode object into (Python3) string. - x2gobroker/tests/test_broker_agent.py: Assure that tests are run without loadchecker usage. - broker-use-load-checker profile option: Also tolerate 'TRUE' and 'True'. - x2gobroker/agent.py: Fix failing execution of LOCAL broker agent. As the LOCAL broker agent is executed setuid root, we cannot Popen.terminate() (which is unneeded anyway) the process after its execution. - Ignore SSH broker events for now. Not sure if we will ever support that. - Finalize API documentation. - Fix regression flaw in x2gobroker/web/json.py, introduced by commit 9fa371e9. * debian/*: + Trigger Makefile's install target and install those files. Drop debhelper from-source-installation magic. * debian/{control,compat}: Bump to DH version level 9. * debian/{control,x2gobroker-common.install}: + Split out common files into non-Pythonian bin:pkg. * debian/*.install: + Add EOLs at EOF. + Add tmpfiles.d files into bin:pkgs. + Fix installation to /usr/lib/python3.x paths. * debian/control: + Drop from D (several bin:pkgs): python3-argparse, argparse is shipped with Python3 core. + Switch from libapache2-mod-wsgi to libapache2-mod-wsgi-py3. + Add B-D: dh-python. + Add B-D: python3-netaddr (for unit tests). * debian/x2gobroker-loadchecker.postinst: + Do chown/chmod on the correct file (not authservice.log, but loadchecker.log). * debian/python-x2gobroker-doc.doc-base: + Drop leading white-space in Abstract: field. * x2gobroker.spec: + Adapt to Python3 port. + Bump package version. + CentOS 6 + 7 have python34-devel, not python3-devel. + Enable debug_packages for openSUSE Tumbleweed (suse_version > 1500). + CentOS 6 + 7 have python34-setuptools, not python3-setuptools. + Fix removal of conf files in tmpfiles.d where needed. + Install tmpfiles.d configs into bin:pkgs. + Only install tmpfiles.d configs on systems that support/have systemd. + Some path fixes for the new tmpfiles.d/. + Make sure the build chroot has all it needs to run the PyModule's unit tests. + Let's try to get unit tests working on Fedora first... . [ Mihai Moldovan ] * New upstream version (0.0.4.0): - src/x2gobroker-{agent,ssh}.c: catch errors in setuid wrappers and add general return clause to make compilers happy. - Makefile: make sure that we actually append our custom CFLAGS and LDFLAGS values, even if passed in through the make command line. - src/x2gobroker-{agent,ssh}.c: fix compile warnings/errors. - src/x2gobroker-{agent,ssh}.c: fix more compile errors. - misc: copyright update. - misc: switch to HTTPS-based URLs where appropriate. - man/*: update date and version stamps pre-release. - misc: add missing coding modelines. * x2gobroker.spec: - Add %debug_package macro when debugging is to be enabled, hoping that it will actually generate proper debuginfo (and -source) sub packages owning files. - Whitespace only. - Remove obsolete EPEL 5 support. - Switch to HTTPS-based links. - Use more curly braces. - Pull in gcc and redhat-rpm-config. - Re-enable debug file generation to see which OS versions still fail. - %exclude does not work with curly braces, revert. - Remove %debug_package macro usage, breaks builds nowadays. - Pass down global flags in CFLAGS and LDFLAGS. - Fix %{__global_ldflags} usage if variable does not exist. - Commands don't seem to work when wrapped in curly braces (at least on *SuSE), so revert. ------------=_1549141816-32059-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by bugs.x2go.org; 22 Mar 2016 09:54:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00 autolearn=ham version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 1E6825DAB9 for ; Tue, 22 Mar 2016 10:54:55 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8gkpw6TGMqGM for ; Tue, 22 Mar 2016 10:54:49 +0100 (CET) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.134]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id F226D5DA92 for ; Tue, 22 Mar 2016 10:54:48 +0100 (CET) Received: from [192.168.0.171] ([109.193.81.164]) by mrelayeu.kundenserver.de (mreue004) with ESMTPSA (Nemesis) id 0MbtgI-1aSQ2A2Wms-00JKne for ; Tue, 22 Mar 2016 10:54:48 +0100 To: submit@bugs.x2go.org From: Stefan Baur Subject: x2gobroker-daemon doesn't return error when it can't spawn/bind to port Message-ID: <56F11663.5060902@baur-itcs.de> Date: Tue, 22 Mar 2016 10:54:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UHwSxnslJLA1p401MB9OJLQphx9EKwqI6" X-Provags-ID: V03:K0:CeQID6aH+z2XoTfiFMmwDQiVNhXNR4PMrMuEGomYySrh8BZU+Xw pfIT+qC00CE6AY218fCU6VNGIT+zC4RhlLoyrRYHfpmbe4E09z3AHgj/3NMFgkcT0OLxsuJ N6aefaGtJ2ddmmF5HmqAJF+8XD7mkF5ihyrb/gE2jEhlNpg6jEscWMC/MV3GWdEDg4HqJ1A K0+8PtH0xrKqp2eB8OyOA== X-UI-Out-Filterresults: notjunk:1;V01:K0:C7uEFLZO5Wc=:eDnnU4Qjh8fVkpIQRy8ItO KW2qflIzntpSds67R4FCKFmsdbCUM3r4bsDrdLpUn6j5jnhGnfxc/f0sW2Mzm3i2N9ndEK5xG 3TPWbAhk7H+4LMtXiHwzFvNDq3z8JbPMLE/bBNzYfANoFFwjzJ0YBOvfyg4/jrDWuVoIAqsJo XHoivS4k8Z4Q6znFPLQnmzoKObY4uSK5pe2Xqqs3QnMCBGgc70gRsVx3bGv6cwvu4qpp4K3C8 JYlGRWD2HLUa9ligulrX2U0UJmw2QH24gNWdlPaWmA76uxIUKiKIsoCda+AzFY8RhIPwizxD/ 6HSJ1XZiKXbh6hNZ83lBui4Vurdbgnajo3BCmApNugnfmJ5BWvqjsY6vHsWTWwDmrPFyKbLbq VT43QM7IN9W3mNt2qMuphbA+jfieK079JJLdTSdmG+w/6pFmfjTMetVk1qrPq78DsDAiMTYsP PswBMUhOwgAUXK8TP4xD8LWgHEpyZaZ1HtThTJ+5WoUwkFTnja+3eqXU/zJukp9VKpTJv0zT+ oa1sXFOtILTjoZtDQFS9azofX9Oi8b+mr+tBPq+IP7ue24OYa03tyG6mFoVsg3dViOU5glpgr SnrQy2XpqBywlRW25ABfKgrbW2VSVQ9nQ/7yxfd0Xtk+zcVlgINO8PElS4PPPQjYEeD0FjHwz 8Sbg4xzrY+XOpyg5raCWC9/d6bmAVliWfTe5wlS3rb8iBCI2UanZDyhume+FadvJOefQ= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UHwSxnslJLA1p401MB9OJLQphx9EKwqI6 Content-Type: multipart/mixed; boundary="OoHjjxj9T4Bp3wDBh959PMn0P1UxXXd6g" From: Stefan Baur To: submit@bugs.x2go.org Message-ID: <56F11663.5060902@baur-itcs.de> Subject: x2gobroker-daemon doesn't return error when it can't spawn/bind to port --OoHjjxj9T4Bp3wDBh959PMn0P1UxXXd6g Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable package: x2gobroker-daemon version: 0.0.3.0 This is what happened: node:~# service x2gobroker-daemon stop [....] Stopping X2Go Session Broker standalone daemon: x2gobroker-daemonstart-stop-daemon: warning: failed to kill 14170: No such process failed! # huh, wait, what? node:~# ps ax | grep brok 5499 ? S 0:00 x2gobroker-authservice -s /run/x2gobroker/x2gobroker-authservice.socket -o root -g x2gobroker -p 06= 60 18791 pts/0 S+ 0:00 grep brok # no running x2gobroker-daemon, so ... # let's remove the PID file: node:~# rm /run/x2gobroker/x2gobroker-daemon.pid node:~# service x2gobroker-daemon stop node:~# service x2gobroker-daemon start [ ok ] Starting X2Go Session Broker standalone daemon: x2gobroker-daemon.= # looking good so far ... node:~# service x2gobroker-daemon stop [....] Stopping X2Go Session Broker standalone daemon: x2gobroker-daemonstart-stop-daemon: warning: failed to kill 18470: No such process failed! # whoops, again? node:~# ps ax | grep brok 5499 ? S 0:00 x2gobroker-authservice -s /run/x2gobroker/x2gobroker-authservice.socket -o root -g x2gobroker -p 06= 60 18791 pts/0 S+ 0:00 grep brok # no running x2gobroker-daemon, so ... # let's remove the PID file: node:~# rm /run/x2gobroker/x2gobroker-daemon.pid # I wonder what a restart will do? node:~# service x2gobroker-daemon restart [ ok ] Starting X2Go Session Broker standalone daemon: x2gobroker-daemon.= node:~# service x2gobroker-daemon restart [....] Stopping X2Go Session Broker standalone daemon: x2gobroker-daemonstart-stop-daemon: warning: failed to kill 18641: No such process failed! [warn] X2Go Session Broker: stale PID file (/run/x2gobroker/x2gobroker-daemon.pid). Delete it manually! ... (warning= ). node:~# ps ax | grep brok 5499 ? S 0:00 x2gobroker-authservice -s /run/x2gobroker/x2gobroker-authservice.socket -o root -g x2gobroker -p 06= 60 18791 pts/0 S+ 0:00 grep brok # and again, no running x2gobroker-daemon :-( The reason, as I found out later, was, that it tries to bind to 127.0.0.1:8080 by default, and that port is already in use by another process on that machine. IMO, this is a bug: when it can't bind to the port, and thus dies, this should be returned to the start script, so it can report back "FAILED". -Stefan --=20 BAUR-ITCS UG (haftungsbeschr=C3=A4nkt) Gesch=C3=A4ftsf=C3=BChrer: Stefan Baur Eichen=C3=A4ckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243 --OoHjjxj9T4Bp3wDBh959PMn0P1UxXXd6g-- --UHwSxnslJLA1p401MB9OJLQphx9EKwqI6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW8RZnAAoJEG7d9BjNvlEZS00IAKvdn7OfKs2xzQ7mU14c48h3 KJbdvtFpnTcZ6MVjQ+J7YLmJHgOE0S9q36xz8gVMGz42r1gEO1SyWEX1AMhEbjNY DCNzOk1YrKlVsXdH8zLvVidzSazZIN5TsPhXUSP03p/Av1DFnkOoDuKnFrNTTMa3 uHBj7vvsYVMvvie1E+d/43/gX9Vglltncig0G/VE7brj91/kqurF9VpBetQWg3iU F4rqU3tpI+g+DZeWJPoMBhiNApHIu2DQn2f4ntLbbd/9PtT//kUOkuBt43qJQ2VT vjuW/Oj7FVwyX9mTNvCWh4qd7yCGyrSFTWL8G7tKGNek3WHgmUHaiUZHoTVtljA= =W9jw -----END PGP SIGNATURE----- --UHwSxnslJLA1p401MB9OJLQphx9EKwqI6-- ------------=_1549141816-32059-0--