From unknown Tue May 19 13:53:49 2026 X-Loop: owner@bugs.x2go.org Subject: Bug#1013: x2gobroker-daemon doesn't return error when it can't spawn/bind to port Reply-To: Stefan Baur , 1013@bugs.x2go.org Resent-From: Stefan Baur Resent-To: x2go-dev@lists.x2go.org Resent-CC: X2Go Developers X-Loop: owner@bugs.x2go.org Resent-Date: Tue, 22 Mar 2016 09:55:02 +0000 Resent-Message-ID: Resent-Sender: owner@bugs.x2go.org X-X2Go-PR-Message: report 1013 X-X2Go-PR-Package: x2gobroker-daemon X-X2Go-PR-Keywords: Received: via spool by submit@bugs.x2go.org id=B.14586404962730 (code B); Tue, 22 Mar 2016 09:55:02 +0000 Received: (at submit) by bugs.x2go.org; 22 Mar 2016 09:54:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00 autolearn=ham version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 1E6825DAB9 for ; Tue, 22 Mar 2016 10:54:55 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8gkpw6TGMqGM for ; Tue, 22 Mar 2016 10:54:49 +0100 (CET) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.134]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id F226D5DA92 for ; Tue, 22 Mar 2016 10:54:48 +0100 (CET) Received: from [192.168.0.171] ([109.193.81.164]) by mrelayeu.kundenserver.de (mreue004) with ESMTPSA (Nemesis) id 0MbtgI-1aSQ2A2Wms-00JKne for ; Tue, 22 Mar 2016 10:54:48 +0100 To: submit@bugs.x2go.org From: Stefan Baur Message-ID: <56F11663.5060902@baur-itcs.de> Date: Tue, 22 Mar 2016 10:54:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UHwSxnslJLA1p401MB9OJLQphx9EKwqI6" X-Provags-ID: V03:K0:CeQID6aH+z2XoTfiFMmwDQiVNhXNR4PMrMuEGomYySrh8BZU+Xw pfIT+qC00CE6AY218fCU6VNGIT+zC4RhlLoyrRYHfpmbe4E09z3AHgj/3NMFgkcT0OLxsuJ N6aefaGtJ2ddmmF5HmqAJF+8XD7mkF5ihyrb/gE2jEhlNpg6jEscWMC/MV3GWdEDg4HqJ1A K0+8PtH0xrKqp2eB8OyOA== X-UI-Out-Filterresults: notjunk:1;V01:K0:C7uEFLZO5Wc=:eDnnU4Qjh8fVkpIQRy8ItO KW2qflIzntpSds67R4FCKFmsdbCUM3r4bsDrdLpUn6j5jnhGnfxc/f0sW2Mzm3i2N9ndEK5xG 3TPWbAhk7H+4LMtXiHwzFvNDq3z8JbPMLE/bBNzYfANoFFwjzJ0YBOvfyg4/jrDWuVoIAqsJo XHoivS4k8Z4Q6znFPLQnmzoKObY4uSK5pe2Xqqs3QnMCBGgc70gRsVx3bGv6cwvu4qpp4K3C8 JYlGRWD2HLUa9ligulrX2U0UJmw2QH24gNWdlPaWmA76uxIUKiKIsoCda+AzFY8RhIPwizxD/ 6HSJ1XZiKXbh6hNZ83lBui4Vurdbgnajo3BCmApNugnfmJ5BWvqjsY6vHsWTWwDmrPFyKbLbq VT43QM7IN9W3mNt2qMuphbA+jfieK079JJLdTSdmG+w/6pFmfjTMetVk1qrPq78DsDAiMTYsP PswBMUhOwgAUXK8TP4xD8LWgHEpyZaZ1HtThTJ+5WoUwkFTnja+3eqXU/zJukp9VKpTJv0zT+ oa1sXFOtILTjoZtDQFS9azofX9Oi8b+mr+tBPq+IP7ue24OYa03tyG6mFoVsg3dViOU5glpgr SnrQy2XpqBywlRW25ABfKgrbW2VSVQ9nQ/7yxfd0Xtk+zcVlgINO8PElS4PPPQjYEeD0FjHwz 8Sbg4xzrY+XOpyg5raCWC9/d6bmAVliWfTe5wlS3rb8iBCI2UanZDyhume+FadvJOefQ= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UHwSxnslJLA1p401MB9OJLQphx9EKwqI6 Content-Type: multipart/mixed; boundary="OoHjjxj9T4Bp3wDBh959PMn0P1UxXXd6g" From: Stefan Baur To: submit@bugs.x2go.org Message-ID: <56F11663.5060902@baur-itcs.de> Subject: x2gobroker-daemon doesn't return error when it can't spawn/bind to port --OoHjjxj9T4Bp3wDBh959PMn0P1UxXXd6g Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable package: x2gobroker-daemon version: 0.0.3.0 This is what happened: node:~# service x2gobroker-daemon stop [....] Stopping X2Go Session Broker standalone daemon: x2gobroker-daemonstart-stop-daemon: warning: failed to kill 14170: No such process failed! # huh, wait, what? node:~# ps ax | grep brok 5499 ? S 0:00 x2gobroker-authservice -s /run/x2gobroker/x2gobroker-authservice.socket -o root -g x2gobroker -p 06= 60 18791 pts/0 S+ 0:00 grep brok # no running x2gobroker-daemon, so ... # let's remove the PID file: node:~# rm /run/x2gobroker/x2gobroker-daemon.pid node:~# service x2gobroker-daemon stop node:~# service x2gobroker-daemon start [ ok ] Starting X2Go Session Broker standalone daemon: x2gobroker-daemon.= # looking good so far ... node:~# service x2gobroker-daemon stop [....] Stopping X2Go Session Broker standalone daemon: x2gobroker-daemonstart-stop-daemon: warning: failed to kill 18470: No such process failed! # whoops, again? node:~# ps ax | grep brok 5499 ? S 0:00 x2gobroker-authservice -s /run/x2gobroker/x2gobroker-authservice.socket -o root -g x2gobroker -p 06= 60 18791 pts/0 S+ 0:00 grep brok # no running x2gobroker-daemon, so ... # let's remove the PID file: node:~# rm /run/x2gobroker/x2gobroker-daemon.pid # I wonder what a restart will do? node:~# service x2gobroker-daemon restart [ ok ] Starting X2Go Session Broker standalone daemon: x2gobroker-daemon.= node:~# service x2gobroker-daemon restart [....] Stopping X2Go Session Broker standalone daemon: x2gobroker-daemonstart-stop-daemon: warning: failed to kill 18641: No such process failed! [warn] X2Go Session Broker: stale PID file (/run/x2gobroker/x2gobroker-daemon.pid). Delete it manually! ... (warning= ). node:~# ps ax | grep brok 5499 ? S 0:00 x2gobroker-authservice -s /run/x2gobroker/x2gobroker-authservice.socket -o root -g x2gobroker -p 06= 60 18791 pts/0 S+ 0:00 grep brok # and again, no running x2gobroker-daemon :-( The reason, as I found out later, was, that it tries to bind to 127.0.0.1:8080 by default, and that port is already in use by another process on that machine. IMO, this is a bug: when it can't bind to the port, and thus dies, this should be returned to the start script, so it can report back "FAILED". -Stefan --=20 BAUR-ITCS UG (haftungsbeschr=C3=A4nkt) Gesch=C3=A4ftsf=C3=BChrer: Stefan Baur Eichen=C3=A4ckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243 --OoHjjxj9T4Bp3wDBh959PMn0P1UxXXd6g-- --UHwSxnslJLA1p401MB9OJLQphx9EKwqI6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW8RZnAAoJEG7d9BjNvlEZS00IAKvdn7OfKs2xzQ7mU14c48h3 KJbdvtFpnTcZ6MVjQ+J7YLmJHgOE0S9q36xz8gVMGz42r1gEO1SyWEX1AMhEbjNY DCNzOk1YrKlVsXdH8zLvVidzSazZIN5TsPhXUSP03p/Av1DFnkOoDuKnFrNTTMa3 uHBj7vvsYVMvvie1E+d/43/gX9Vglltncig0G/VE7brj91/kqurF9VpBetQWg3iU F4rqU3tpI+g+DZeWJPoMBhiNApHIu2DQn2f4ntLbbd/9PtT//kUOkuBt43qJQ2VT vjuW/Oj7FVwyX9mTNvCWh4qd7yCGyrSFTWL8G7tKGNek3WHgmUHaiUZHoTVtljA= =W9jw -----END PGP SIGNATURE----- --UHwSxnslJLA1p401MB9OJLQphx9EKwqI6--