From unknown Mon Apr 27 22:52:35 2026 MIME-Version: 1.0 X-Mailer: MIME-tools 5.502 (Entity 5.502) X-Loop: owner@bugs.x2go.org From: owner@bugs.x2go.org (X2Go Bug Tracking System) Subject: Bug#1000 closed by X2Go Release Manager (X2Go issue (in src:x2goclient) has been marked as closed) Message-ID: References: <20160324203847.C1E6E5DACD@ymir.das-netzwerkteam.de> X-X2go-PR-Keywords: pending X-X2go-PR-Message: they-closed 1000 X-X2go-PR-Package: x2goclient X-X2go-PR-Source: x2goclient Date: Thu, 24 Mar 2016 20:40:47 +0000 Content-Type: multipart/mixed; boundary="----------=_1458852047-29012-0" This is a multi-part message in MIME format... ------------=_1458852047-29012-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 This is an automatic notification regarding your Bug report which was filed against the x2goclient package: #1000: [PATCH 1/1] sshmasterconnection.cpp: invalid proxy socket It has been closed by X2Go Release Manager . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact X2Go Release Manager <= git-admin@x2go.org> by replying to this email. --=20 X2Go Bug Tracking System Contact owner@bugs.x2go.org with problems ------------=_1458852047-29012-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at control) by bugs.x2go.org; 24 Mar 2016 20:40:10 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id A5F475DACA; Thu, 24 Mar 2016 21:39:31 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ob8RDeS4OPUz; Thu, 24 Mar 2016 21:39:25 +0100 (CET) Received: by ymir.das-netzwerkteam.de (Postfix, from userid 1005) id C1E6E5DACD; Thu, 24 Mar 2016 21:38:47 +0100 (CET) From: X2Go Release Manager To: 1000-submitter@bugs.x2go.org Cc: control@bugs.x2go.org, 1000@bugs.x2go.org Subject: X2Go issue (in src:x2goclient) has been marked as closed Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Message-Id: <20160324203847.C1E6E5DACD@ymir.das-netzwerkteam.de> Date: Thu, 24 Mar 2016 21:38:47 +0100 (CET) close #1000 thanks Hello, we are very hopeful that X2Go issue #1000 reported by you has been resolved in the new release (4.0.5.1) of the X2Go source project »src:x2goclient«. You can view the complete changelog entry of src:x2goclient (4.0.5.1) below, and you can use the following link to view all the code changes between this and the last release of src:x2goclient. http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=4f91293625f1b3c12a1fa0a414424557d82fc65a;hp=b69667ef6d5f762b988e756a85a429792871e88c If you feel that the issue has not been resolved satisfyingly, feel free to reopen this bug report or submit a follow-up report with further observations described based on the new released version of src:x2goclient. Thanks a lot for contributing to X2Go!!! light+love X2Go Git Admin (on behalf of the sender of this mail) --- X2Go Component: src:x2goclient Version: 4.0.5.1-0x2go1 Status: RELEASE Date: Thu, 24 Mar 2016 21:35:30 +0100 Fixes: 487 772 860 916 921 927 928 945 948 953 973 987 1000 Changes: x2goclient (4.0.5.1-0x2go1) RELEASED; urgency=low . [ Mihai Moldovan ] * New upstream release (4.0.5.1): - onmainwindow.cpp: include sshd PID file path option in quotes to support whitespaces within the var directory path on Windows. Add comment to revisit this later on non-Windows-platforms, too. Fixes: #916. - onmainwindow.cpp: do NOT reformat. Reverts most of the previous commit because it breaks code logic. - res/txt/packs: add adaptive method. - {macbuild.sh,x2goclient.pro}: pass MacPorts library and include path's to qmake. Due to the qt4-mac's changes, we do not automatically get these values automatically "appended" in a usable way anymore. - x2gosettings.cpp: let centralSettings () return false on Windows. - onmainwindow.cpp: be more precise in slotScDaemonError () regarding unknown and undefined errors. - onmainwindow.{cpp,h}: don't use a hardcoded path to xmodmap on OS X and handle errors more gracefully. Fixes: #487. - x2goclient.pro: fix typo --stdlib=... -> -stdlib=... Fixes: #973. - onmainwindow.cpp: add some more error handling for parsing the return value of x2golistsessions. As it turns out, it can happen that "invalid" strings are inserted in there, for instance by the perl interpreter itself. We need to skip over these, or the client crashes when splitting up the invalid lines. - macbuild.sh: add stdlib forcing. Should not be used unless you really know what you're doing. If you ponder using this, you probably don't. - res/resources.rcc: add Turkish translation file. Fixes: #987. - onmainwindow.cpp: use lowercase version of locale. Fixes: #953. Fixes loading up the nb_NO translation file, which is actually baked as nb_no into the binary. - sshmasterconnection.cpp: let challenge-auth-based login attempts fallback to normal password authentication if the initial challenge-auth-based attempt was unsuccessful. - sshmasterconnection.{cpp,h}: support variable number of challenge-auth-code-based prompts. - sshmasterconnection.cpp: don't check prompts for full string equality - a matching prefix is good enough. Amongst others, this fixes errors in conditions where the prompt does not contain a trailing whitespace, but X2Go Client expects one. - sshmasterconnection.cpp: add OATH TOTP prompt prefix. Fixes: #860. - res/i18n: refresh translation files again. - res/i18n/x2goclient_nb_no.ts: replace "X-Serv..." with "X.Org Server" where applicable. - res/i18n/x2goclient_nb_no.ts: correctly use "XQuartz" where necessary. - res/i18n/x2goclient_nb_no.ts: whitespace only. - res/i18n/x2goclient_nb_no.ts: fix up some "x2go" -> "X2Go" errors. - res/i18n/x2goclient_nb_no.ts: mark translation strings needing some care ("x2go..." -> "X2Go...") as unfinished for later fixup. - res/i18n/x2goclient_nb_no.ts: fix (meta data) typo introduced with last commit. - res/i18n/x2goclient_nl.ts: fixup translation by respecting the original messages' format and other changes. - res/i18n/x2goclient_de.ts: fixup translation by respecting the original messages' format, fixing typos and general improvements. - res/i18n/x2goclient_es.ts: fixup translation by respecting the original messages' format and other changes. - res/i18n/x2goclient_sv.ts: fixup translation by respecting the original messages' format and other changes. * debian/control: - Change apache2-dev | libc6-dev build dependency back to apache2-dev only. Otherwise, apache2-dev is not installed at all, even though theoretically available. The initial reasoning for this dependency type, apache2-dev not being available on all Ubuntu/Debian platforms, is not true anymore. - Change apache2-dev build dependency yet again to apache2-dev | apache2-threaded-dev. Turns out all Debian distros but wheezy (currently oldstable) have an apache2-dev package. Even oldoldstable (squeeze) does... . [ Oleksandr Shneyder ] * New upstream release (4.0.5.1): - xsettingswidget: compile only on Windows. - Add support for new style command line options of xfreerdp on direct RDP connections. (Fixes: #772). - Replace "::" with "_" for the desktop link name on Windows. - Fix direct RDP in broker mode. - Fix crashing client when editing session from SessionManageDialog. Fixes: #921. - Configure audio input in pulseaudio on Windows. - Reconnect ssh broker in case of IO Error. - Reformat source onmainwindow.cpp. - Disable settings editing if a directory with central settings is exists. - Format long names on session buttons. - Central settings for Linux, Mac and Windows. - Fix VCXSRV parameter to disable PRIMARY clipboard in X2Go Client for Windows. Fixes: #927. - Fix reading settings for direct RDP connections in broker mode. - Auto accept RSA Keys for SSH Broker with --add-to-known-hosts option. . [ Mike Gabriel ] * New upstream release (4.0.5.1): - xinerama.conf: Don't choke if screen coordintate lines in xinerama.conf start with a dash ("-"). (Fixes: #948). . [ Mike DePaulo ] * New upstream release (4.0.5.1): - Windows: Update bundled Win32 OpenSSL from 1.0.1p to 1.0.1q, which fixes the multiple CVEs announced on 2015-12-03. - Windows: Upgrade Cygwin components to latest versions as of 2016-01-21, except for the Cygwin DLL which is still at 1.7.33 in order to avoid breaking folder sharing and printer sharing due to 1.7.34's ACL/permissions changes. (authorized_keys file would often have mode 660 instead of 600) The latest components include most notably: + openssh 6.8p1-1-x2go1 -> 7.1p2-1-x2go1 (security update) + openssl 1.0.2d-1 -> 1.0.2e-1 (security update) - Windows: Update nxproxy from 3.5.0.31 to 3.5.0.32 - Windows: Update Unicode NSIS from 2.46.5 to 2.50.0 Pre-release, which fixes the DLL hijacking security vuln (NSIS bug 1125.) - Windows: Update PuTTY from 0.64 to 0.66, which fixes CVE-2015-5309. - Windows: Remove libzip. libssh no longer uses it. . [ Orion Poplawski ] * New upstream release (4.0.5.1): - ssh{process,masterconnection}.cpp: run bash as a login shell when invoking any command remotely. Fixes: #928. Because this opens the door for ~/.bash_logout and friend scripts to be executed, which may contain calls to ncurses' reset or clear, also set the TERM variable to dump to not have unexpected output on stderr at logout time. - sshmasterconnection.cpp: check correct variable for validity: public key instead of private key (again.) Fixes: #945. . [ Klaus Ade Johnstad ] * New upstream version (4.0.5.1): - res/i18n/x2goclient_nb_no.ts: update Bokmål (Norway) translation file. . [ Heinrich Schuchardt ] * New upstream version (4.0.5.1): - sshmasterconnection.cpp: don't fetch invalid proxy socket. Fixes: #1000. From http://doc.qt.io/qt-4.8/qabstractsocket.html#socketDescriptor: The socket descriptor is not available when QAbstractSocket is in UnconnectedState. So we have to connect to the proxy server first before retrieving the native socket. . [ Daniel Lindgren ] * New upstream version (4.0.5.1): - res/i18n/x2goclient_sv.ts: update Swedish translation file. . [ Sébastien Ducoulombier ] * New upstream version (4.0.5.1): - res/i18n/x2goclient_fr.ts: update French translation file. . [ Jos Wolfkamp ] * New upstream version (4.0.5.1): - res/i18n/x2goclient_nl.ts: update Dutch translation file. . [ Stefan Baur ] * New upstream release (4.0.5.1): - res/i18n/x2goclient_de.ts: update German translation file. . [ Ricardo Díaz Martín ] * New upstream release (4.0.5.1): - res/i18n/x2goclient_es.ts: update Spanish translation file. ------------=_1458852047-29012-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by bugs.x2go.org; 21 Feb 2016 23:14:11 +0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on ymir.das-netzwerkteam.de X-Spam-Level: X-Spam-Status: No, score=0.8 required=3.0 tests=BAYES_50,FREEMAIL_FROM, URIBL_BLOCKED autolearn=ham version=3.3.2 Received: from localhost (localhost [127.0.0.1]) by ymir.das-netzwerkteam.de (Postfix) with ESMTP id 4DD805DA96 for ; Mon, 22 Feb 2016 00:14:07 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ymir.das-netzwerkteam.de Received: from ymir.das-netzwerkteam.de ([127.0.0.1]) by localhost (ymir.das-netzwerkteam.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Lz5kQ2OiYGTU for ; Mon, 22 Feb 2016 00:14:00 +0100 (CET) X-Greylist: delayed 304 seconds by postgrey-1.34 at ymir.das-netzwerkteam.de; Mon, 22 Feb 2016 00:14:00 CET Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 8D9E75DA95 for ; Mon, 22 Feb 2016 00:14:00 +0100 (CET) Received: from LT001.lan ([37.24.8.189]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0LymHf-1ZuykH0KNL-016A7z; Mon, 22 Feb 2016 00:08:50 +0100 From: Heinrich Schuchardt To: submit@bugs.x2go.org Cc: Stefan Baur , Mihai Moldovan , Orion Poplawski , Heinrich Schuchardt Subject: [PATCH 1/1] sshmasterconnection.cpp: invalid proxy socket Date: Mon, 22 Feb 2016 00:08:28 +0100 Message-Id: <1456096108-16599-1-git-send-email-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.1.4 X-Provags-ID: V03:K0:hAQ+Uptkvt4F57jG0nyAMSJkpETT0LPIAXIajuUUXOreBiNg6G2 q8N5ey9iW0yF9tp8w3wawe/f1E4sRIH32eKDp3LqTdpo5ROz3nH/tjAmhKlvyjJYuAEOrSa /LlQW1cyvV8dfD7uhNUpRXYtvzsSQpBHm7cOKDXq/IHVOXGmRRo9zH+3yNL7jIMwS8758+d eHoytJMk7SOFwd8EY9YEw== X-UI-Out-Filterresults: notjunk:1;V01:K0:1/HLEaKg4Oc=:n5XPraHBjDznQ8yqY0H6Sn +c6syrCyHFQ5U3nI2tKJgSZz4mM3pe3BD0BpzdAA7nzsV8B2qePLy3mhCOAH2yfX+beANYD1G QDcOfTMj5XR4X1GUGanhjtDPbmRd4P0xN94xcNfs4CtN3eiiEkfrGoWO/Rm1F0/83N5Ss0jyZ JOcZjXDJ0yEyhfHou/8UrRMI5Yh/4AJPJQ6Z/QN4NWF1C6UwEzHl6eHzzTwKkEC9EyZrfsikH my0udqdFkHvxseBB9gQmDLQnGZEhTF9A3kwnjPygw6917M0ehqmZ4XXZKGBPuyAWY6LZzClhI +Zft+sF0hxeMfntz1GUlfboXSsl05vbE7ytyYJ8dHbUCXYfZ+Ee14gdjacM5Vzis5d8fqe0Mt epDVc4Qjx/8SrUedVQaZtK86k0udgSzBeKYdOwSLz3Pa9ouBy2k/9txQtZAexHkqklXeMkj0S Vb2oKGpVo42rsdrJ0OnidjWqP6DSe8hUmzmun/F7hySp1oVURd82VhF3OcSOKN7Ytat0JEvzo vuGIpgw37id++qvISaYi7kSYbq48U2sKNIhrc+MQT1thW3Ek5CXlJRbCdKhh26PcnbdJEc5K5 +bzmHSVph6PcJPxgX06Tz2CI9nvNXNj90muW+u6qxvYqsbBOWjaG78R14iJ4xWJWdnMJeQn2t 0imzmLRhQSs4a8BNAKlPVG6NUwjG7sqNtfidctXRCU67IhpSZb1XYgbZYse2JOOQo2p7v3tb7 YrbJpdvM97NzqyZj3EIex/nZv5ek9b5lupmJIuXpgFGKxkmK+gKQ4XLrXlI= Package: x2goclient Version: 4.0.5.1 x2goclient shows proxy socket -1 (invalid). http://doc.qt.io/qt-4.8/qabstractsocket.html#socketDescriptor: The socket descriptor is not available when QAbstractSocket is in UnconnectedState. So we have first to connect to the proxy server before retrieving the native socket. Signed-off-by: Heinrich Schuchardt --- src/sshmasterconnection.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sshmasterconnection.cpp b/src/sshmasterconnection.cpp index 5b3cff5..bb69047 100644 --- a/src/sshmasterconnection.cpp +++ b/src/sshmasterconnection.cpp @@ -548,7 +548,6 @@ void SshMasterConnection::run() tcpProxySocket = new QTcpSocket(); tcpProxySocket->setProxy( *tcpNetworkProxy ); tcpProxySocket->connectToHost(host, port); - proxysocket = tcpProxySocket->socketDescriptor(); if (!tcpProxySocket->waitForConnected(30000)) { QString message=tr ( "Cannot connect to proxy server." ); @@ -560,6 +559,7 @@ void SshMasterConnection::run() quit(); return; } + proxysocket = tcpProxySocket->socketDescriptor(); #ifdef DEBUG x2goDebug << "Created HTTP proxy socket: " << proxysocket << endl; #endif -- 2.1.4 ------------=_1458852047-29012-0--