Received: (at submit) by bugs.x2go.org; 5 May 2014 22:32:39 +0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=ham
	version=3.3.2
X-Greylist: delayed 383 seconds by postgrey-1.34 at ymir.das-netzwertkeam.de; Tue, 06 May 2014 00:32:38 CEST
Received: from haldir.han.de (haldir.han.de [5.35.241.151])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 9A1235DB14
	for <submit@bugs.x2go.org>; Tue,  6 May 2014 00:32:38 +0200 (CEST)
Received: by haldir.han.de (Postfix, from userid 10)
	id 4BD8517E001C; Tue,  6 May 2014 00:26:15 +0200 (CEST)
Received: from test.hidden.han.de by hydrops.han.de  with smtp
	(Linux Smail3.1.29.1 #24) id m1WhRPM-0009PMC; Tue, 6 May 2014 00:30 MET DST
Received: (qmail 3963 invoked by uid 500); 5 May 2014 22:25:37 -0000
Date: Tue, 6 May 2014 00:25:37 +0200
From: joerg@hydrops.han.de
To: submit@bugs.x2go.org
Subject: hardcoded /opt/X11/bin/xmodmap in onmainwindow.cpp
Message-ID: <20140505222537.GA3313@hydrops.han.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.21 (2010-09-15)

Package: x2goclient
Version: 4.0.2.0

This bug affects mac clients only.

Systems: 
OSX 10.6.8 + XQuartz 2.7.5 from macports
OSX 10.9.2 + XQuartz 2.7.5 from macports

Macports installs xmodmap in /opt/local/bin and Apple installs it in
/usr/X11/bin . In onmainwindow.ccp there is a hard coded path "/opt/X11/bin/xmodmap"
which may be the correct location for the macosforge package. 

x2goclient does not complain about a missing xmodmap and no modifiers
are set on the server session. Keyboard is at least partially defunct. 

Workaround: symlink some existing xmodmap to the hard coded path works
fine.

IMHO there should be at least an error message, if xmodmap is not found on
client. Additinally the location of xmodmap could be a configuration
parameter.