Message-ID: <1408505056.5466.YahooMailNeo@web125203.mail.ne1.yahoo.com>
Date: Tue, 19 Aug 2014 20:24:16 -0700
From: Gabriel Marcano <gabemarcano@yahoo.com>
Reply-To: Gabriel Marcano <gabemarcano@yahoo.com>
Subject: nx-libs, Jpeg.cpp compilation error with jpeg-9a, with suggested patch
To: "submit@bugs.x2go.org" <submit@bugs.x2go.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="-1476983308-2018442305-1408505117=:5466"

---1476983308-2018442305-1408505117=:5466
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Package: nx-libs
Version: HEAD
Tags: Patch

Found this problem while browsing:
=C2=A0=C2=A0=C2=A0 https://bugs.gentoo.org/show_bug.cgi?id=3D481360

Compiling nx-libs against jpeg-9a leads to a compilation error. Specificall=
y:

=C2=A0=C2=A0=C2=A0 g++ -c -O3 -fno-rtti -fno-exceptions -I../nx-X11/exports=
/include
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -Wmissing-declarations -fPIC -DI=
N_ADDR_T=3Din_addr_t -DVERSION=3D\"3.5.0\"
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -DPACKAGE_NAME=3D\"\" -DPACKAGE_=
TARNAME=3D\"\" -DPACKAGE_VERSION=3D\"\"
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -DPACKAGE_STRING=3D\"\" -DPACKAG=
E_BUGREPORT=3D\"\" -DPACKAGE_URL=3D\"\" -Wall
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -Wpointer-arith=C2=A0=C2=A0 Jpeg=
.cpp
=C2=A0=C2=A0=C2=A0 Jpeg.cpp: In function =E2=80=98int DecompressJpeg16(unsi=
gned char*, int,
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned int, unsigned int, unsi=
gned char*, int)=E2=80=99:
=C2=A0=C2=A0=C2=A0 Jpeg.cpp:443:29: error: invalid conversion from =E2=80=
=98int=E2=80=99 to =E2=80=98boolean=E2=80=99
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [-fpermissive]
=C2=A0=C2=A0=C2=A0 jpeg_read_header(&cinfo, 1);
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^
=C2=A0=C2=A0=C2=A0 In file included from Jpeg.cpp:29:0:
=C2=A0=C2=A0=C2=A0 /usr/include/jpeglib.h:1039:13: note: initializing argum=
ent 2 of =E2=80=98int
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 jpeg_read_header(j_decompress_pt=
r, boolean)=E2=80=99
=C2=A0=C2=A0=C2=A0 EXTERN(int) jpeg_read_header JPP((j_decompress_ptr cinfo,
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 ^
=C2=A0=C2=A0=C2=A0 Jpeg.cpp: In function =E2=80=98int DecompressJpeg24(unsi=
gned char*, int,
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned int, unsigned int, unsi=
gned char*, int)=E2=80=99:
=C2=A0=C2=A0=C2=A0 Jpeg.cpp:584:29: error: invalid conversion from =E2=80=
=98int=E2=80=99 to =E2=80=98boolean=E2=80=99
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [-fpermissive]
=C2=A0=C2=A0=C2=A0 jpeg_read_header(&cinfo, 1);
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^
=C2=A0=C2=A0=C2=A0 In file included from Jpeg.cpp:29:0:
=C2=A0=C2=A0=C2=A0 /usr/include/jpeglib.h:1039:13: note: initializing argum=
ent 2 of =E2=80=98int
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 jpeg_read_header(j_decompress_pt=
r, boolean)=E2=80=99
=C2=A0=C2=A0=C2=A0 EXTERN(int) jpeg_read_header JPP((j_decompress_ptr cinfo,
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 ^
=C2=A0=C2=A0=C2=A0 Jpeg.cpp: In function =E2=80=98int DecompressJpeg32(unsi=
gned char*, int, unsigned
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int, unsigned int, unsigned char=
*, int)=E2=80=99:
=C2=A0=C2=A0=C2=A0 Jpeg.cpp:721:29: error: invalid conversion from =E2=80=
=98int=E2=80=99 to =E2=80=98boolean=E2=80=99
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [-fpermissive]
=C2=A0=C2=A0=C2=A0 jpeg_read_header(&cinfo, 1);
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^
=C2=A0=C2=A0=C2=A0 In file included from Jpeg.cpp:29:0:
=C2=A0=C2=A0=C2=A0 /usr/include/jpeglib.h:1039:13: note: initializing argum=
ent 2 of =E2=80=98int
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 jpeg_read_header(j_decompress_pt=
r, boolean)=E2=80=99
=C2=A0=C2=A0=C2=A0 EXTERN(int) jpeg_read_header JPP((j_decompress_ptr cinfo,
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 ^
=C2=A0=C2=A0=C2=A0 Jpeg.cpp: In function =E2=80=98boolean JpegFillInputBuff=
er(j_decompress_ptr)=E2=80=99:
=C2=A0=C2=A0=C2=A0 Jpeg.cpp:836:10: error: invalid conversion from =E2=80=
=98int=E2=80=99 to =E2=80=98boolean=E2=80=99
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [-fpermissive]
=C2=A0=C2=A0=C2=A0 return 1;
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^
=C2=A0=C2=A0=C2=A0 Makefile:82: recipe for target 'Jpeg.o' failed
=C2=A0=C2=A0=C2=A0 make: *** [Jpeg.o] Error 1

I am attaching a patch to address the problem. Specifically, it appears that
jpeg-9a changed the definition for its "boolean" type from an int to some o=
ther
=C2=A0type (bool in C++, it seems). Using TRUE and FALSE, as provided by th=
e jpeg
library, is what was done to address the problem. After applying the patch
to HEAD (commit 0e3b414ea6ecb6cc359d3b95f5cfeb6096066139), Jpeg.cpp compiles
fine.


Configuration:

Compiling against jpeg-9a.

$ gcc -v
=C2=A0=C2=A0=C2=A0 Using built-in specs.
=C2=A0=C2=A0=C2=A0 COLLECT_GCC=3D/usr/x86_64-pc-linux-gnu/gcc-bin/4.9.0/gcc
=C2=A0=C2=A0=C2=A0 COLLECT_LTO_WRAPPER=3D/usr/libexec/gcc/x86_64-pc-linux-g=
nu/4.9.0/lto-wrapper
=C2=A0=C2=A0=C2=A0 Target: x86_64-pc-linux-gnu
=C2=A0=C2=A0=C2=A0 Configured with: /var/tmp/portage/sys-devel/gcc-4.9.0/wo=
rk/gcc-4.9.0/configure
=C2=A0=C2=A0=C2=A0 --host=3Dx86_64-pc-linux-gnu --build=3Dx86_64-pc-linux-g=
nu --prefix=3D/usr
=C2=A0=C2=A0=C2=A0 --bindir=3D/usr/x86_64-pc-linux-gnu/gcc-bin/4.9.0
=C2=A0=C2=A0=C2=A0 --includedir=3D/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.0/in=
clude
=C2=A0=C2=A0=C2=A0 --datadir=3D/usr/share/gcc-data/x86_64-pc-linux-gnu/4.9.0
=C2=A0=C2=A0=C2=A0 --mandir=3D/usr/share/gcc-data/x86_64-pc-linux-gnu/4.9.0=
/man
=C2=A0=C2=A0=C2=A0 --infodir=3D/usr/share/gcc-data/x86_64-pc-linux-gnu/4.9.=
0/info
=C2=A0=C2=A0=C2=A0 --with-gxx-include-dir=3D/usr/lib/gcc/x86_64-pc-linux-gn=
u/4.9.0/include/g++-v4
=C2=A0=C2=A0=C2=A0 --with-python-dir=3D/share/gcc-data/x86_64-pc-linux-gnu/=
4.9.0/python
=C2=A0=C2=A0=C2=A0 --enable-languages=3Dc,c++,fortran --enable-obsolete --e=
nable-secureplt
=C2=A0=C2=A0=C2=A0 --disable-werror --with-system-zlib --enable-nls --witho=
ut-included-gettext
=C2=A0=C2=A0=C2=A0 --enable-checking=3Drelease --with-bugurl=3Dhttps://bugs=
.gentoo.org/
=C2=A0=C2=A0=C2=A0 --with-pkgversion=3D'Gentoo 4.9.0 p1.0, pie-0.6.0' --ena=
ble-libstdcxx-time
=C2=A0=C2=A0=C2=A0 --enable-shared --enable-threads=3Dposix --enable-__cxa_=
atexit
=C2=A0=C2=A0=C2=A0 --enable-clocale=3Dgnu --enable-multilib --with-multilib=
-list=3Dm32,m64
=C2=A0=C2=A0=C2=A0 --disable-altivec --disable-fixed-point --enable-targets=
=3Dall
=C2=A0=C2=A0=C2=A0 --disable-libgcj --enable-libgomp --disable-libmudflap -=
-disable-libssp
=C2=A0=C2=A0=C2=A0 --enable-lto --without-cloog
=C2=A0=C2=A0=C2=A0 Thread model: posix
=C2=A0=C2=A0=C2=A0 gcc version 4.9.0 (Gentoo 4.9.0 p1.0, pie-0.6.0)=20

$ autoreconf --version
=C2=A0=C2=A0=C2=A0 autoreconf (GNU Autoconf) 2.69


Steps to reproduce:

1. "git clone git://code.x2go.org/nx-libs.git" repository.
2. Change to the "nxcomp" directory.
3. Run "autoreconf" and then do "make Jpeg.o".

Expected outcome:
Successful compilation.

Actual outcome:
Compilation failure, see earlier in the report for the error messages.=

---1476983308-2018442305-1408505117=:5466
Content-Type: text/x-patch; name="nxlibs-jpeg9a.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="nxlibs-jpeg9a.patch"

LS0tIG54Y29tcC9KcGVnLmNwcC5vcmlnCTIwMTQtMDgtMTkgMjI6MjM6MzYuMTM5MDcyNDAwIC0w
NDAwCisrKyBueGNvbXAvSnBlZy5jcHAJMjAxNC0wOC0xOSAyMjoyNToyNC4zMjMxODI4MDAgLTA0
MDAKQEAgLTQ0MCw3ICs0NDAsNyBAQAogCiAgIEpwZWdTZXRTcmNNYW5hZ2VyKCZjaW5mbywgY29t
cHJlc3NlZERhdGEsIGNvbXByZXNzZWRMZW4pOwogCi0gIGpwZWdfcmVhZF9oZWFkZXIoJmNpbmZv
LCAxKTsKKyAganBlZ19yZWFkX2hlYWRlcigmY2luZm8sIFRSVUUpOwogCiAgIGlmIChqcGVnRXJy
b3IpIGdvdG8gQWJvcnREZWNvbXByZXNzSnBlZzE2OwogCkBAIC01ODEsNyArNTgxLDcgQEAKIAog
ICBKcGVnU2V0U3JjTWFuYWdlcigmY2luZm8sIGNvbXByZXNzZWREYXRhLCBjb21wcmVzc2VkTGVu
KTsKIAotICBqcGVnX3JlYWRfaGVhZGVyKCZjaW5mbywgMSk7CisgIGpwZWdfcmVhZF9oZWFkZXIo
JmNpbmZvLCBUUlVFKTsKIAogICBpZiAoanBlZ0Vycm9yKSBnb3RvIEFib3J0RGVjb21wcmVzc0pw
ZWcyNDsKIApAQCAtNzE4LDcgKzcxOCw3IEBACiAKICAgSnBlZ1NldFNyY01hbmFnZXIoJmNpbmZv
LCBjb21wcmVzc2VkRGF0YSwgY29tcHJlc3NlZExlbik7CiAKLSAganBlZ19yZWFkX2hlYWRlcigm
Y2luZm8sIDEpOworICBqcGVnX3JlYWRfaGVhZGVyKCZjaW5mbywgVFJVRSk7CiAKICAgaWYgKGpw
ZWdFcnJvcikgZ290byBBYm9ydERlY29tcHJlc3NKcGVnMzI7CiAKQEAgLTgzMyw3ICs4MzMsNyBA
QAogICBqcGVnU3JjTWFuYWdlci5ieXRlc19pbl9idWZmZXIgPSBqcGVnQnVmZmVyTGVuOwogICBq
cGVnU3JjTWFuYWdlci5uZXh0X2lucHV0X2J5dGUgPSAoSk9DVEVUICopanBlZ0J1ZmZlclB0cjsK
IAotICByZXR1cm4gMTsKKyAgcmV0dXJuIFRSVUU7CiB9CiAKIHN0YXRpYyB2b2lkIEpwZWdTa2lw
SW5wdXREYXRhKGpfZGVjb21wcmVzc19wdHIgY2luZm8sIGxvbmcgbnVtX2J5dGVzKQo=

---1476983308-2018442305-1408505117=:5466--