Message-ID: <53D6AE5D.5010107@gmail.com>
Date: Mon, 28 Jul 2014 22:11:09 +0200
From: Rok Mandeljc <rok.mandeljc@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: submit@bugs.x2go.org
Subject: x2goclient: the local user name that is passed to x2gomountdirs command
 needs to be enclosed in quotation marks
Content-Type: multipart/mixed;
 boundary="------------050208050306070000040809"

This is a multi-part message in MIME format.
--------------050208050306070000040809
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Package: x2goclient
Version: 4.0.2.1+hotfix1

In startX2goMount(), the local user name (cuser) is passed as the third
argument to the x2gomountdirs command that will be executed on the
server side. This user name should be enclosed in quotation marks,
otherwise the x2gomountdirs on server side fails for users who are
unfortunate enough to have put a whitespace character in their Windows
user name.

--------------050208050306070000040809
Content-Type: text/x-patch;
 name="0001-startX2goMount-insert-quotation-marks-around-the-loc.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename*0="0001-startX2goMount-insert-quotation-marks-around-the-loc.pa";
 filename*1="tch"

From 8e51e6835b2935777e83adb1823a7bbd37bbede0 Mon Sep 17 00:00:00 2001
From: Rok Mandeljc <rok.mandeljc@gmail.com>
Date: Mon, 28 Jul 2014 21:51:12 +0200
Subject: [PATCH] startX2goMount(): insert quotation marks around the local
 user name (cuser) that is passed to x2gomountdirs command

Unquoted user name means that the server-side x2gomountdirs command will fail for users who are unfortunate enough to have put a whitespace character in their Windows user name.

Signed-off-by: Rok Mandeljc <rok.mandeljc@gmail.com>
---
 onmainwindow.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/onmainwindow.cpp b/onmainwindow.cpp
index 8acec61..7751c69 100644
--- a/onmainwindow.cpp
+++ b/onmainwindow.cpp
@@ -9230,11 +9230,11 @@ void ONMainWindow::startX2goMount()
         dirs=dirs+"__REVERSESSH_PORT__"+resumingSession.fsPort;
     }
     if ( !rem )
-        cmd="export HOSTNAME && x2gomountdirs dir "+sessionId+" "+cuser+
-            " "+dir->dstKey+" "+dirs;
+        cmd="export HOSTNAME && x2gomountdirs dir "+sessionId+" \""+cuser+
+            "\" "+dir->dstKey+" "+dirs;
     else
-        cmd="export HOSTNAME && x2gomountdirs rem "+sessionId+" "+cuser+
-            " "+dir->dstKey+" "+dirs;
+        cmd="export HOSTNAME && x2gomountdirs rem "+sessionId+" \""+cuser+
+            "\" "+dir->dstKey+" "+dirs;
 
 #ifdef Q_OS_WIN
 
-- 
1.9.3


--------------050208050306070000040809--