Date: Tue, 21 Nov 2017 18:23:32 +0100 (CET)
From: Walid MOGHRABI <w.moghrabi@servicemagic.eu>
To: submit@bugs.x2go.org
Message-ID: <2074085984.30965501.1511285012453.JavaMail.root@servicemagic.eu>
In-Reply-To: <973808472.30963275.1511284532921.JavaMail.root@servicemagic.eu>
Subject: acl-users-allow=ALL superceeds acl-users-deny
MIME-Version: 1.0
Content-Type: multipart/mixed; 
	boundary="----=_Part_30965499_1827115678.1511285012453"

------=_Part_30965499_1827115678.1511285012453
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

package: x2gobroker
priority: normal
tags: patch

When using ACLs with the session broker, I wanted to give access to a session setting to ALL users EXCEPT some (namely "formation{1..9}").
I tried this but it didn't work :

=================================================
[TRAVAUX]
fullscreen=true
clipboard=none
name=TRAVAUX
host=tce-server (10.10.10.1)
acl-users-allow=ALL
acl-users-deny=formation1, formation2, formation3, formation4, formation5, formation6, formation7, formation8, formation9
acl-any-order=deny-allow
=================================================

I played with many settings, changing order, using only the "acl-users-deny" option, ... none of them worked as expected.

I ended in thinking that there was a bug with acl-users-allow=ALL which was taking over any other setting.

I did a little fix that seem to work, at least for this use case.

Regards,
Walid Moghrabi

TRAVAUX.COM
BAT I - PARC CEZANNE 2 290 AVENUE GALILEE - CS 80403
13591 AIX EN PROVENCE CEDEX 3

---
DISCLAIMER: This e-mail is private and confidential and may contain proprietary or legally privileged information. It is for the intended recipient only. If you have received this email in error, please notify the author by replying to it and then destroy it. If you are not the intended recipient you must not use, disclose, distribute, copy, print or rely on this e-mail or any attachment. Thank you
------=_Part_30965499_1827115678.1511285012453
Content-Type: text/x-patch; name=x2gobroker_acl-users-allow.patch
Content-Disposition: attachment; filename=x2gobroker_acl-users-allow.patch
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhLy5naXRpZ25vcmUgYi8uZ2l0aWdub3JlCmluZGV4IDcyODhlZjUuLjE2MDU5
MjUgMTAwNjQ0Ci0tLSBhLy5naXRpZ25vcmUKKysrIGIvLmdpdGlnbm9yZQpAQCAtOSwzICs5LDUg
QEAgZGViaWFuLyoucHJlcm0uZGViaGVscGVyCiBkZWJpYW4vKi5zdWJzdHZhcnMKIGRlYmlhbi8q
eDJnbyovCiAqLmVnZy1pbmZvLworLy5wcm9qZWN0CisvLmdpdGlnbm9yZQpkaWZmIC0tZ2l0IGEv
eDJnb2Jyb2tlci9icm9rZXJzL2Jhc2VfYnJva2VyLnB5IGIveDJnb2Jyb2tlci9icm9rZXJzL2Jh
c2VfYnJva2VyLnB5CmluZGV4IGI2YTZlZTYuLjc5NTVjZGMgMTAwNjQ0Ci0tLSBhL3gyZ29icm9r
ZXIvYnJva2Vycy9iYXNlX2Jyb2tlci5weQorKysgYi94MmdvYnJva2VyL2Jyb2tlcnMvYmFzZV9i
cm9rZXIucHkKQEAgLTQzMSw3ICs0MzEsNyBAQCBjbGFzcyBYMkdvQnJva2VyKG9iamVjdCk6CiAg
ICAgICAgICAgICBfYWxsb3dfdXNlciA9IEZhbHNlCiAgICAgICAgICAgICBfZGVueV91c2VyID0g
RmFsc2UKIAotICAgICAgICAgICAgaWYgdXNlcm5hbWUgaW4gX2FjbHNbJ2FjbC11c2Vycy1hbGxv
dyddIG9yICdBTEwnIGluIF9hY2xzWydhY2wtdXNlcnMtYWxsb3cnXToKKyAgICAgICAgICAgIGlm
ICh1c2VybmFtZSBpbiBfYWNsc1snYWNsLXVzZXJzLWFsbG93J10gb3IgJ0FMTCcgaW4gX2FjbHNb
J2FjbC11c2Vycy1hbGxvdyddKSBhbmQgdXNlcm5hbWUgbm90IGluIF9hY2xzWydhY2wtdXNlcnMt
ZGVueSddOgogICAgICAgICAgICAgICAgIF9hbGxvd191c2VyX292ZXJyaWRlID0gVHJ1ZQogICAg
ICAgICAgICAgICAgIF9hbGxvd191c2VyID0gVHJ1ZQoK

------=_Part_30965499_1827115678.1511285012453--