X2Go Bug report logs - #92
Install icons, images, man page and desktop files through setup.py

Toggle useless messages

Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

From: Orion Poplawski <orion@cora.nwra.com>

To: submit@bugs.x2go.org

Subject: ZeroDivisionError: float division by zero error on startup

Date: Tue, 18 Dec 2012 10:03:17 -0700

Package: phoca-gui
Version: 0.2.1.1

$ pyhoca-gui
Traceback (most recent call last):
  File "/usr/bin/pyhoca-gui", line 375, in <module>
    main()
  File "/usr/bin/pyhoca-gui", line 363, in main
    thisPyHocaGUI = PyHocaGUI(args, logger, liblogger, appname=PROG_NAME, 
version=VERSION)
  File "/usr/lib/python2.7/site-packages/pyhoca/wxgui/frontend.py", line 222, 
in __init__
    wx.App.__init__(self, redirect=False, clearSigInt=False)
  File "/usr/lib64/python2.7/site-packages/wx-2.8-gtk2-unicode/wx/_core.py", 
line 7981, in __init__
    self._BootstrapApp()
  File "/usr/lib64/python2.7/site-packages/wx-2.8-gtk2-unicode/wx/_core.py", 
line 7555, in _BootstrapApp
    return _core_.PyApp__BootstrapApp(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/pyhoca/wxgui/frontend.py", line 243, 
in OnInit
    self.startGUI()
  File "/usr/lib/python2.7/site-packages/pyhoca/wxgui/frontend.py", line 299, 
in startGUI
    self.about = about.PyHocaGUI_AboutFrame(self, 
about_image=self.args.about_image)
  File "/usr/lib/python2.7/site-packages/pyhoca/wxgui/about.py", line 88, in 
__init__
    about_wximage.Rescale(400, 
int(float(400)/about_wximage.Width*about_wximage.Height))
ZeroDivisionError: float division by zero

-- 
Orion Poplawski
Technical Manager                     303-415-9701 x222
NWRA, Boulder Office                  FAX: 303-415-9702
3380 Mitchell Lane                       orion@nwra.com
Boulder, CO 80301                   http://www.nwra.com

Message #10 received at 92@bugs.x2go.org (full text, mbox, reply):

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: Orion Poplawski <orion@cora.nwra.com>, 92@bugs.x2go.org

Cc: control@bugs.x2go.org

Subject: Re: Bug#92: ZeroDivisionError: float division by zero error on startup

Date: Tue, 18 Dec 2012 21:57:20 +0100

[Message part 1 (text/plain, inline)]

tag #92 moreinfo
thanks

On Di 18 Dez 2012 18:03:17 CET Orion Poplawski wrote:

Hi Orion

> $ pyhoca-gui
> Traceback (most recent call last):
>   File "/usr/bin/pyhoca-gui", line 375, in <module>
>     main()
>   File "/usr/bin/pyhoca-gui", line 363, in main
>     thisPyHocaGUI = PyHocaGUI(args, logger, liblogger,  
> appname=PROG_NAME, version=VERSION)
>   File "/usr/lib/python2.7/site-packages/pyhoca/wxgui/frontend.py",  
> line 222, in __init__
>     wx.App.__init__(self, redirect=False, clearSigInt=False)
>   File
"/usr/lib64/python2.7/site-packages/wx-2.8-gtk2-unicode/wx/_core.py",
> line 7981, in __init__
>     self._BootstrapApp()
>   File
"/usr/lib64/python2.7/site-packages/wx-2.8-gtk2-unicode/wx/_core.py",
> line 7555, in _BootstrapApp
>     return _core_.PyApp__BootstrapApp(*args, **kwargs)
>   File "/usr/lib/python2.7/site-packages/pyhoca/wxgui/frontend.py",  
> line 243, in OnInit
>     self.startGUI()
>   File "/usr/lib/python2.7/site-packages/pyhoca/wxgui/frontend.py",  
> line 299, in startGUI
>     self.about = about.PyHocaGUI_AboutFrame(self,  
> about_image=self.args.about_image)
>   File "/usr/lib/python2.7/site-packages/pyhoca/wxgui/about.py",
line
> 88, in __init__
>     about_wximage.Rescale(400,  
> int(float(400)/about_wximage.Width*about_wximage.Height))
> ZeroDivisionError: float division by zero

It seems very likely that your pyhoca-gui instance does not find the  
image folder shipped with it.

Can you check that?

Greets,
Mike


-- 

DAS-NETZWERKTEAM
mike gabriel, rothenstein 5, 24214 neudorf-bornstein
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

Message #17 received at 92@bugs.x2go.org (full text, mbox, reply):

From: Orion Poplawski <orion@cora.nwra.com>

To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Cc: 92@bugs.x2go.org

Subject: Re: Bug#92: ZeroDivisionError: float division by zero error on startup

Date: Tue, 18 Dec 2012 15:22:20 -0700

[Message part 1 (text/plain, inline)]

On 12/18/2012 01:57 PM, Mike Gabriel wrote:
>
> It seems very likely that your pyhoca-gui instance does not find the image
> folder shipped with it.
>
> Can you check that?

Ah, it seems setup.py doesn't do everything it needs to.  The attached patch I 
think does what is needed for the most part.  Doesn't handle the debian links 
file though.

Other notes:
- Categories in pyhoca-gui.desktop needs a trailing semicolon.
- There is /usr/bin/env python at the top of pyhoca/wxgui/messages.py, but I 
imagine that file isn't meant to be executed directly.

Finally, I seem to be able to connect to the server properly, but no window 
ever appears, and no errors.

Seems to be stuck in this loop:

pyhoca-gui[15357] (x2goguardian-pylib) DEBUG: Entering X2Go Guardian client 
management loop...
pyhoca-gui[15357] (x2gocontrolsession-pylib) INFO: executing command on X2Go 
server ,,Vulcan'': sh -c "export HOSTNAME && x2golistsessions"
pyhoca-gui[15357] (x2gocontrolsession-pylib) INFO: executing command on X2Go 
server ,,Vulcan'': sh -c "export HOSTNAME && x2golistmounts 
orion-51-1355520763_stDXFCE_dp24"


[orion@vulcan ~]$ sh -c "export HOSTNAME && x2golistmounts 
orion-51-1355520763_stDXFCE_dp24"
orion orion

[orion@vulcan ~]$


-- 
Orion Poplawski
Technical Manager                     303-415-9701 x222
NWRA, Boulder Office                  FAX: 303-415-9702
3380 Mitchell Lane                       orion@nwra.com
Boulder, CO 80301                   http://www.nwra.com

[pyhoca-gui-install.patch (text/x-patch, attachment)]

Message #26 received at 92@bugs.x2go.org (full text, mbox, reply):

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: Orion Poplawski <orion@cora.nwra.com>

Cc: 92@bugs.x2go.org

Subject: Install icons, images, man page and desktop files through setup.py (was: Re: Bug#92: ZeroDivisionError: float division by zero error on startup)

Date: Thu, 20 Dec 2012 09:59:54 +0100

[Message part 1 (text/plain, inline)]

retitle #92 Install icons, images, man page and desktop files through setup.py
tag #92 pending
thanks

Hi Orion,

On Di 18 Dez 2012 23:22:20 CET Orion Poplawski wrote:

> On 12/18/2012 01:57 PM, Mike Gabriel wrote:
>>
>> It seems very likely that your pyhoca-gui instance does not find the image
>> folder shipped with it.
>>
>> Can you check that?
>
> Ah, it seems setup.py doesn't do everything it needs to.  The  
> attached patch I think does what is needed for the most part.   
> Doesn't handle the debian links file though.

I have added two commits for that to X2Go Git, can you cross-check that?

First one (unfortunately a dirty commit, see at the botton):
http://code.x2go.org/gitweb?p=pyhoca-gui.git;a=commitdiff;h=51c52fb1b0d3f94c6cc9c1d42fe5f84674e6026e

Then for the symlinks:
http://code.x2go.org/gitweb?p=pyhoca-gui.git;a=commitdiff;h=052916c4ea0d523a6db253b4f0ffe394d932aab9

> Other notes:
> - Categories in pyhoca-gui.desktop needs a trailing semicolon.

Done!
http://code.x2go.org/gitweb?p=pyhoca-gui.git;a=commitdiff;h=1a1ab1dbd055d31ec639da9ddf815afc7a55d86f

> - There is /usr/bin/env python at the top of  
> pyhoca/wxgui/messages.py, but I imagine that file isn't meant to be  
> executed directly.

Done!
http://code.x2go.org/gitweb?p=pyhoca-gui.git;a=commitdiff;h=6cdc40a31c8ca51ac9feade208cea13a9157308c

> Finally, I seem to be able to connect to the server properly, but no  
> window ever appears, and no errors.

I will answer that off-BTS as it is not part of this bug report, actually.


Greets,
Mike



-- 

DAS-NETZWERKTEAM
mike gabriel, rothenstein 5, 24214 neudorf-bornstein
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

Message #35 received at 92@bugs.x2go.org (full text, mbox, reply):

From: Orion Poplawski <orion@cora.nwra.com>

To: 92@bugs.x2go.org

Subject: setup.py fails to install symbolic link

Date: Thu, 20 Dec 2012 10:09:10 -0700

With latest git I get:

error: can't copy 'icons_symlinked/PyHoca/16x16/system-search.png': doesn't 
exist or not a regular file

ls -l pyhoca-gui-0.2.1.2/icons_symlinked/PyHoca/16x16/
total 76
-rw-r--r--. 1 orion nwra  914 Dec 20 09:41 applications-development.png
-rw-r--r--. 1 orion nwra  758 Dec 20 09:41 applications-education.png
-rw-r--r--. 1 orion nwra  846 Dec 20 09:41 applications-games.png
-rw-r--r--. 1 orion nwra 1179 Dec 20 09:41 applications-graphics.png
-rw-r--r--. 1 orion nwra 1117 Dec 20 09:41 applications-internet.png
-rw-r--r--. 1 orion nwra 1093 Dec 20 09:41 applications-multimedia.png
-rw-r--r--. 1 orion nwra  841 Dec 20 09:41 applications-office.png
-rw-r--r--. 1 orion nwra  872 Dec 20 09:41 applications-other.png
-rw-r--r--. 1 orion nwra 1251 Dec 20 09:41 applications-system.png
-rw-r--r--. 1 orion nwra  888 Dec 20 09:41 applications-utilities.png
-rw-r--r--. 1 orion nwra 1099 Dec 20 09:41 pyhoca-session.png
-rw-r--r--. 1 orion nwra 1099 Dec 20 09:41 pyhoca-trayicon.png
-rw-r--r--. 1 orion nwra 1099 Dec 20 09:41 pyhoca-winicon.png
-rw-r--r--. 1 orion nwra  846 Dec 20 09:41 question.png
lrwxrwxrwx. 1 orion nwra   68 Dec 20 09:41 system-search.png -> 
/usr/share/icons/gnome-colors-common/16x16/actions/system-search.png
-rw-r--r--. 1 orion nwra 1367 Dec 20 09:41 x2go-logo-rotated.png
-rw-r--r--. 1 orion nwra 1118 Dec 20 09:41 x2go-logo-ubuntu.png
-rw-r--r--. 1 orion nwra  547 Dec 20 09:41 x2go-logo-white-bg.png
-rw-r--r--. 1 orion nwra  705 Dec 20 09:41 x2go.png

I'm not sure this is configured as it should be....

-- 
Orion Poplawski
Technical Manager                     303-415-9701 x222
NWRA, Boulder Office                  FAX: 303-415-9702
3380 Mitchell Lane                       orion@nwra.com
Boulder, CO 80301                   http://www.nwra.com

Message #40 received at 92@bugs.x2go.org (full text, mbox, reply):

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: 13@bugs.x2go.org, 85@bugs.x2go.org, 92@bugs.x2go.org, 37@bugs.x2go.org

Cc: control@bugs.x2go.org

Subject: This issue has been solved in PyHoca-GUI 0.4.0.0

Date: Tue, 12 Feb 2013 19:45:32 +0100

[Message part 1 (text/plain, inline)]

close #13
close #37
close #85
close #92
thanks

The reported issue has been solved in PyHoca-GUI 0.4.0.0.

Greets,
Mike

-- 

DAS-NETZWERKTEAM
mike gabriel, rothenstein 5, 24214 neudorf-bornstein
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

Message #49 received at 92@bugs.x2go.org (full text, mbox, reply):

From: Orion Poplawski <orion@cora.nwra.com>

To: 92@bugs.x2go.org

Subject: Final img setup.py fix

Date: Tue, 12 Feb 2013 13:52:32 -0700

[Message part 1 (text/plain, inline)]

Version: 0.4.0.0
Tags: patch

I've attached a patch to fix the installation of the needed img directory, 
that got messed up copying from the windows part is seems.

It appears to install and run okay with this.

-- 
Orion Poplawski
Technical Manager                     303-415-9701 x222
NWRA, Boulder Office                  FAX: 303-415-9702
3380 Mitchell Lane                       orion@nwra.com
Boulder, CO 80301                   http://www.nwra.com

[pyhoca-gui-img.patch (text/x-patch, attachment)]

Message #54 received at 92@bugs.x2go.org (full text, mbox, reply):

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: Orion Poplawski <orion@cora.nwra.com>

Cc: 92@bugs.x2go.org

Subject: Re: [X2Go-Dev] Bug#92: Final img setup.py fix

Date: Tue, 12 Feb 2013 22:17:14 +0100

[Message part 1 (text/plain, inline)]

On Di 12 Feb 2013 21:52:32 CET Orion Poplawski wrote:

> Version: 0.4.0.0
> Tags: patch
>
> I've attached a patch to fix the installation of the needed img  
> directory, that got messed up copying from the windows part is seems.
>
> It appears to install and run okay with this.

Thanks for spotting. Committed!
http://code.x2go.org/gitweb?p=pyhoca-gui.git;a=commitdiff;h=440c0c8b9587707e85c87f1cd606d2feeba84260

Mike

-- 

DAS-NETZWERKTEAM
mike gabriel, rothenstein 5, 24214 neudorf-bornstein
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

Message #59 received at 92@bugs.x2go.org (full text, mbox, reply):

From: Orion Poplawski <orion@cora.nwra.com>

To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Cc: 92@bugs.x2go.org

Subject: Re: [X2Go-Dev] Bug#92: Final img setup.py fix

Date: Tue, 12 Feb 2013 14:23:19 -0700

On 02/12/2013 02:17 PM, Mike Gabriel wrote:
> On Di 12 Feb 2013 21:52:32 CET Orion Poplawski wrote:
>
>> Version: 0.4.0.0
>> Tags: patch
>>
>> I've attached a patch to fix the installation of the needed img directory,
>> that got messed up copying from the windows part is seems.
>>
>> It appears to install and run okay with this.
>
> Thanks for spotting. Committed!
> http://code.x2go.org/gitweb?p=pyhoca-gui.git;a=commitdiff;h=440c0c8b9587707e85c87f1cd606d2feeba84260
>
>
> Mike
>

You're not fixing the glob() args.  With your version I end up with an empty 
directory.


-- 
Orion Poplawski
Technical Manager                     303-415-9701 x222
NWRA, Boulder Office                  FAX: 303-415-9702
3380 Mitchell Lane                       orion@nwra.com
Boulder, CO 80301                   http://www.nwra.com

Message #64 received at 92@bugs.x2go.org (full text, mbox, reply):

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: Orion Poplawski <orion@cora.nwra.com>

Cc: 92@bugs.x2go.org

Subject: Re: [X2Go-Dev] Bug#92: Final img setup.py fix

Date: Wed, 13 Feb 2013 05:56:12 +0100

[Message part 1 (text/plain, inline)]

Hi Orion

On Di 12 Feb 2013 22:23:19 CET Orion Poplawski wrote:

> On 02/12/2013 02:17 PM, Mike Gabriel wrote:
>> On Di 12 Feb 2013 21:52:32 CET Orion Poplawski wrote:
>>
>>> Version: 0.4.0.0
>>> Tags: patch
>>>
>>> I've attached a patch to fix the installation of the needed img directory,
>>> that got messed up copying from the windows part is seems.
>>>
>>> It appears to install and run okay with this.
>>
>> Thanks for spotting. Committed!
>> http://code.x2go.org/gitweb?p=pyhoca-gui.git;a=commitdiff;h=440c0c8b9587707e85c87f1cd606d2feeba84260
>>
>>

Now, this should do it...
http://code.x2go.org/gitweb?p=pyhoca-gui.git;a=commitdiff;h=f6a4c0af7740b348ea34d2e4d091940c4302c93f

Mike



-- 

DAS-NETZWERKTEAM
mike gabriel, rothenstein 5, 24214 neudorf-bornstein
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

Message #69 received at 92@bugs.x2go.org (full text, mbox, reply):

From: Orion Poplawski <orion@cora.nwra.com>

To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

Cc: 92@bugs.x2go.org

Subject: Re: [X2Go-Dev] Bug#92: Final img setup.py fix

Date: Wed, 13 Feb 2013 09:13:35 -0700

On 02/12/2013 09:56 PM, Mike Gabriel wrote:
> Hi Orion
>
> On Di 12 Feb 2013 22:23:19 CET Orion Poplawski wrote:
>
>> On 02/12/2013 02:17 PM, Mike Gabriel wrote:
>>> On Di 12 Feb 2013 21:52:32 CET Orion Poplawski wrote:
>>>
>>>> Version: 0.4.0.0
>>>> Tags: patch
>>>>
>>>> I've attached a patch to fix the installation of the needed img directory,
>>>> that got messed up copying from the windows part is seems.
>>>>
>>>> It appears to install and run okay with this.
>>>
>>> Thanks for spotting. Committed!
>>> http://code.x2go.org/gitweb?p=pyhoca-gui.git;a=commitdiff;h=440c0c8b9587707e85c87f1cd606d2feeba84260
>>>
>>>
>>>
>
> Now, this should do it...
> http://code.x2go.org/gitweb?p=pyhoca-gui.git;a=commitdiff;h=f6a4c0af7740b348ea34d2e4d091940c4302c93f
>
>
> Mike
>
>
>

Looks good.  Feel free to close this bug.

-- 
Orion Poplawski
Technical Manager                     303-415-9701 x222
NWRA, Boulder Office                  FAX: 303-415-9702
3380 Mitchell Lane                       orion@nwra.com
Boulder, CO 80301                   http://www.nwra.com

Send a report that this bug log contains spam.