X2Go Bug report logs - #87
parallel build issues

Toggle useless messages

Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

From: Orion Poplawski <orion@cora.nwra.com>

To: submit@bugs.x2go.org

Subject: parallel build issues

Date: Fri, 14 Dec 2012 11:18:37 -0700

[Message part 1 (text/plain, inline)]

Package: nx-libs
Version: 3.5.0.16
Tags: patch

I've been seeing the parallel build issues in nx-libs mentioned recently. 
Tracking the build closer, it looks like a lot is getting built during the 
"make depend" stage:

depending in lib/X11...
make[5]: Entering directory `/builddir/build/BUILD/nx-libs-HEAD/nx-X11/lib/X11'
cd ../../../nxcomp &&   /builddir/build/BUILD/nx-libs-HEAD/my_configure

(I've set CONFIGURE to point to my_configure following the opensuse 
buildserver rpm specfile)

Now, why is this happening?

In nx-X11/lib/X11/Makefile there are deps like:

depend:: $(NX_XCOMPLIBTARGET)

Which triggers a build of nxcomp.  These come from nx-X11/lib/X11/Imakefile 
and are complete nonsense - why are we building things during the depend 
stage?  Removing those exposes the lack of proper build dependencies between 
NX_X11, Xcomp, and Xcompext (and what the previous depend hack was trying to 
work around).

The attached patch I believe fixes both of these issues, and hopefully fixes 
the parallel make issue as well.  It's been building fine for me now.

-- 
Orion Poplawski
Technical Manager                     303-415-9701 x222
NWRA, Boulder Office                  FAX: 303-415-9702
3380 Mitchell Lane                       orion@nwra.com
Boulder, CO 80301                   http://www.nwra.com

[nx-libs-depend.patch (text/x-patch, attachment)]

Message #10 received at 87@bugs.x2go.org (full text, mbox, reply):

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: Orion Poplawski <orion@cora.nwra.com>, 87@bugs.x2go.org

Subject: Re: [X2Go-Dev] Bug#87: parallel build issues

Date: Fri, 14 Dec 2012 23:11:31 +0100

[Message part 1 (text/plain, inline)]

Hi Orion, hi Reinhard,

On Fr 14 Dez 2012 19:18:37 CET Orion Poplawski wrote:

> [...]

> The attached patch I believe fixes both of these issues, and  
> hopefully fixes the parallel make issue as well.  It's been building  
> fine for me now.
>

Reinhard, can you test the patch attached to this bug on your 32 core  
-j20 builder machine?

Greets,
Mike



-- 

DAS-NETZWERKTEAM
mike gabriel, rothenstein 5, 24214 neudorf-bornstein
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

Message #15 received at 87@bugs.x2go.org (full text, mbox, reply):

From: Reinhard Tartler <siretart@gmail.com>

To: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>, 87@bugs.x2go.org, x2go-dev@lists.berlios.de

Cc: Orion Poplawski <orion@cora.nwra.com>

Subject: Re: [X2Go-Dev] Bug#87: parallel build issues

Date: Sat, 15 Dec 2012 14:24:34 +0100

On Fri, Dec 14, 2012 at 11:11 PM, Mike Gabriel
<mike.gabriel@das-netzwerkteam.de> wrote:
> Hi Orion, hi Reinhard,
>
> On Fr 14 Dez 2012 19:18:37 CET Orion Poplawski wrote:
>
>> [...]
>
>
>> The attached patch I believe fixes both of these issues, and hopefully
>> fixes the parallel make issue as well.  It's been building fine for me now.
>>
>
> Reinhard, can you test the patch attached to this bug on your 32 core -j20
> builder machine?

The patch itself is not minimal. However, I think it touches the
critical part. Based on Orions proposed patch, I have edit
debian/patches/031_nx-X11_parallel-make.full.patch, which I think is
broken.

The first build seems to succeed, but I want to do a few additional
tests before pushing to git.

Thanks Orion for pushing in the right direction, I think your approach
is correct.

-- 
regards,
    Reinhard

Message #20 received at 87@bugs.x2go.org (full text, mbox, reply):

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: Reinhard Tartler <siretart@gmail.com>

Cc: 87@bugs.x2go.org, control@bugs.x2go.org

Subject: Re: [X2Go-Dev] Bug#87: parallel build issues [SOLVED]

Date: Sun, 16 Dec 2012 00:02:48 +0100

[Message part 1 (text/plain, inline)]

rtag #87 pending
thanks

Hi Reinhard, hi Orion,

On Sa 15 Dez 2012 14:24:34 CET Reinhard Tartler wrote:

> On Fri, Dec 14, 2012 at 11:11 PM, Mike Gabriel
> <mike.gabriel@das-netzwerkteam.de> wrote:
>> Hi Orion, hi Reinhard,
>>
>> On Fr 14 Dez 2012 19:18:37 CET Orion Poplawski wrote:
>>
>>> [...]
>>
>>
>>> The attached patch I believe fixes both of these issues, and hopefully
>>> fixes the parallel make issue as well.  It's been building fine for me now.
>>>
>>
>> Reinhard, can you test the patch attached to this bug on your 32 core -j20
>> builder machine?
>
> The patch itself is not minimal. However, I think it touches the
> critical part. Based on Orions proposed patch, I have edit
> debian/patches/031_nx-X11_parallel-make.full.patch, which I think is
> broken.
>
> The first build seems to succeed, but I want to do a few additional
> tests before pushing to git.
>
> Thanks Orion for pushing in the right direction, I think your approach
> is correct.

I have added a closure for this issue to the changelog:
http://code.x2go.org/gitweb?p=nx-libs.git;a=commitdiff;h=f2011a718adfab50d050abd282cfc04c8c534f75

The issue itself got fixed by this commit:
http://code.x2go.org/gitweb?p=nx-libs.git;a=commitdiff;h=d123923a501758cace37fc2138feff5751b0a25b

Good work you guys!!!

Mike

-- 

DAS-NETZWERKTEAM
mike gabriel, rothenstein 5, 24214 neudorf-bornstein
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

Message #27 received at 87@bugs.x2go.org (full text, mbox, reply):

From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

To: 87@bugs.x2go.org

Cc: control@bugs.x2go.org

Subject: Solved with release nx-libs 3.5.0.17

Date: Wed, 09 Jan 2013 12:40:29 +0100

[Message part 1 (text/plain, inline)]

close #87
thanks

This issue has been solved with nx-libs 3.5.0.17.

light+love
Mike

-- 

DAS-NETZWERKTEAM
mike gabriel, rothenstein 5, 24214 neudorf-bornstein
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

[Message part 2 (application/pgp-signature, inline)]

[Message part 3 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.