X2Go Bug report logs - #1601
Patch for x2goclient Qt5 build on Windows

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Orion Poplawski <orion@nwra.com>

Date: Tue, 9 May 2023 17:00:01 UTC

Severity: normal

Tags: patch

Found in version 4.1.2.2

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#1601: [X2Go-Dev] Bug#1601: Patch for x2goclient Qt5 build on Windows
Reply-To: uli42@gmx.de, 1601@bugs.x2go.org
Resent-From: Ulrich Sibiller <ulrich.sibiller@gmail.com>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Tue, 09 May 2023 17:30:03 +0000
Resent-Message-ID: <handler.1601.B1601.16836531684823@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 1601
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: patch
References: <04e068b1-91de-5d88-1e8f-e836cbbd028d@nwra.com> <04e068b1-91de-5d88-1e8f-e836cbbd028d@nwra.com>
Received: via spool by 1601-submit@bugs.x2go.org id=B1601.16836531684823
          (code B ref 1601); Tue, 09 May 2023 17:30:03 +0000
Received: (at 1601) by bugs.x2go.org; 9 May 2023 17:26:08 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: *
X-Spam-Status: No, score=1.1 required=3.0 tests=BAYES_40,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,FREEMAIL_REPLYTO,
	FREEMAIL_REPLYTO_END_DIGIT,HTML_MESSAGE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
	version=3.4.2
Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [IPv6:2001:4860:4864:20::34])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 077EE5DAEE;
	Tue,  9 May 2023 19:26:07 +0200 (CEST)
Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-1960539df06so2109110fac.1;
        Tue, 09 May 2023 10:26:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20221208; t=1683653165; x=1686245165;
        h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=I5jjD1uXnv05uXL3k9jUhpTL6f0UWNbCLPlXVynrPxc=;
        b=iqja1yninKa1f8U0DDvWT2Yk0fboyr0f8ZPmU8J7xb7O0PQePbkHNsozAfG4rv2c3m
         qeRNMigObBY0q3GRDRnrelRnW8JI7SdkzSACgkChKTAuwyDErYtUNMNxCvZTY1X27Yyd
         6A/U/Rvf0NmU48VkrNyE8f4IQ9JOK+HwQ2YMX3wM2QcGtvs1Jt0X+Z17hlBRtXAJpvYB
         s3Ev922kiBFy0p+zpyXe3gPMA3cm+f6L8Fxb5mpczUcceH9ne/B0B7SliaIFsHq2X7ms
         Xe2QBlTaSpKc0loJDz65v6sizMyD2ioTZ64CzTfCBOv2du53ZPa+JX2iOr/lxDcI38Sz
         EIkg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20221208; t=1683653165; x=1686245165;
        h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=I5jjD1uXnv05uXL3k9jUhpTL6f0UWNbCLPlXVynrPxc=;
        b=QlFQXnWEIEEJyePT1F/pjZAX0PBf8w7/uskTnHs/sNLAnu7wlBwv03kfpl2a0VaKPL
         gkoMs36Yr17+yS/9E6W883iw0z+vLu9MxpKF7Fy0+Wa2KexL5+6+tgZCm68F7xb8ACZn
         yRcU1MGNqD9DCNQzb2xBSOeKfBcD4nYS6QHfDS1kYIio04Wl/bGG/MJXPOTdidgwXlbx
         302dBcj5JBjjQonaeqNSZlfC2EChi9X19N9yOgd2DbveGGJvhp0BvHsLKOqdcUAUnElR
         Gl4jtxM/ULxtxn/lXcRsKCkUOqUggzGfMHozfBRbqAnIAtQ3QMKOW7H1IhPBVVLd18TS
         6hRA==
X-Gm-Message-State: AC+VfDytiM5rAfIQPn0VZqBx3WsxRRat18MVuGOHfgIsFdl7hzOYSUX+
	FCLq7BW1QADuFBYusB+diS6gYSOIHiDPFEIOJJY=
X-Google-Smtp-Source: ACHHUZ4rb5213VLmGGlTaRF2aewimv9sHWVReegdhH5agu2mrDJbK6ObKUUhZ1OG9esnGenVlqbgbm5AIKTHn5BUV5E=
X-Received: by 2002:a05:6871:582:b0:17e:d17c:1d19 with SMTP id
 u2-20020a056871058200b0017ed17c1d19mr6415500oan.8.1683653165379; Tue, 09 May
 2023 10:26:05 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <04e068b1-91de-5d88-1e8f-e836cbbd028d@nwra.com>
From: Ulrich Sibiller <ulrich.sibiller@gmail.com>
Date: Tue, 9 May 2023 19:25:39 +0200
Message-ID: <CANVnVY+=cw9K-fsBT6p72kwW0zABQscQQ1TNwKR+1r0-1NGYvA@mail.gmail.com>
To: Orion Poplawski <orion@nwra.com>, 1601@bugs.x2go.org
Cc: submit@bugs.x2go.org
Content-Type: multipart/alternative; boundary="000000000000d8f6de05fb460cde"

[Message part 1 (text/plain, inline)]
Iirc I have made some patches for the windows version. I thought they had
been merged but I must check that. For now try this:


#if QT_VERSION >= 0x050200
   largeIcon=QtWin::toHICON(icon.scaled(iconx,icony,
Qt::IgnoreAspectRatio,Qt::SmoothTransformation));
   smallIcon=QtWin::toHICON(icon.scaled(smallx,smally,
Qt::IgnoreAspectRatio,Qt::SmoothTransformation));
#else
   largeIcon=icon.scaled(iconx,icony,
Qt::IgnoreAspectRatio,Qt::SmoothTransformation).toWinHICON();
   smallIcon=icon.scaled(smallx,smally,
Qt::IgnoreAspectRatio,Qt::SmoothTransformation).toWinHICON();
#endif


Uli

Orion Poplawski <orion@nwra.com> schrieb am Di., 9. Mai 2023, 19:00:

> Package: x2goclient
> Version: 4.1.2.2
> Tag: patch
>
>
> When compiling against Qt5 5.15.9 I get:
>
> ../src/wapi.cpp: In function 'void wapiSetWindowIcon(HWND, const
> QPixmap&)':
> ../src/wapi.cpp:224:88: error: 'class QPixmap' has no member named
> 'toWinHICON'
>    224 |     largeIcon=icon.scaled(iconx,icony,
> Qt::IgnoreAspectRatio,Qt::SmoothTransformation).toWinHICON ();
>        |                        ^~~~~~~~~~
> ../src/wapi.cpp:225:90: error: 'class QPixmap' has no member named
> 'toWinHICON'
>    225 |     smallIcon=icon.scaled(smallx,smally,
> Qt::IgnoreAspectRatio,Qt::SmoothTransformation).toWinHICON ();
>        |                          ^~~~~~~~~~
>
> Now, the only call to wapiSetWindowIcon() is commented out, so I just
> commented out the wapiSetWindowIcon() code as we...  Looks like the
> current function to use is QImage::toHICON().
>
> I'm also curious that you need to shift to a Windows API call -
> shouldn't we be able to do everything in Qt?
>
>
>
> --
> Orion Poplawski
> he/him/his  - surely the least important thing about me
> IT Systems Manager                         720-772-5637
> NWRA, Boulder/CoRA Office             FAX: 303-415-9702
> 3380 Mitchell Lane                       orion@nwra.com
> Boulder, CO 80301                 https://www.nwra.com/
> _______________________________________________
> x2go-dev mailing list
> x2go-dev@lists.x2go.org
> https://lists.x2go.org/listinfo/x2go-dev
>

[Message part 2 (text/html, inline)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu May 9 20:06:46 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.