X2Go Bug report logs - #1601
Patch for x2goclient Qt5 build on Windows

version graph

Package: x2goclient; Maintainer for x2goclient is X2Go Developers <x2go-dev@lists.x2go.org>; Source for x2goclient is src:x2goclient.

Reported by: Orion Poplawski <orion@nwra.com>

Date: Tue, 9 May 2023 17:00:01 UTC

Severity: normal

Tags: patch

Found in version 4.1.2.2

Full log

🔗 View this message in rfc822 format

X-Loop: owner@bugs.x2go.org
Subject: Bug#1601: [X2Go-Dev] Bug#1601: Patch for x2goclient Qt5 build on Windows
Reply-To: Orion Poplawski <orion@nwra.com>, 1601@bugs.x2go.org
Resent-From: Orion Poplawski <orion@nwra.com>
Resent-To: x2go-dev@lists.x2go.org
Resent-CC: X2Go Developers <x2go-dev@lists.x2go.org>
X-Loop: owner@bugs.x2go.org
Resent-Date: Tue, 09 May 2023 18:20:03 +0000
Resent-Message-ID: <handler.1601.B1601.168365618910022@bugs.x2go.org>
Resent-Sender: owner@bugs.x2go.org
X-X2Go-PR-Message: followup 1601
X-X2Go-PR-Package: x2goclient
X-X2Go-PR-Keywords: patch
References: <04e068b1-91de-5d88-1e8f-e836cbbd028d@nwra.com> <CANVnVY+=cw9K-fsBT6p72kwW0zABQscQQ1TNwKR+1r0-1NGYvA@mail.gmail.com> <CANVnVY+vsPeNxz9C05vegOnvNoBqx0FKgMAruKMa=BF28sxU-g@mail.gmail.com> <04e068b1-91de-5d88-1e8f-e836cbbd028d@nwra.com>
Received: via spool by 1601-submit@bugs.x2go.org id=B1601.168365618910022
          (code B ref 1601); Tue, 09 May 2023 18:20:03 +0000
Received: (at 1601) by bugs.x2go.org; 9 May 2023 18:16:29 +0000
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
	ymir.das-netzwerkteam.de
X-Spam-Level: 
X-Spam-Status: No, score=-1.4 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,NICE_REPLY_A,SPF_HELO_PASS,
	T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
	version=3.4.2
Received: from GCC02-DM3-obe.outbound.protection.outlook.com (mail-dm3gcc02on20708.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d04::708])
	by ymir.das-netzwerkteam.de (Postfix) with ESMTPS id 1C7725DAEE;
	Tue,  9 May 2023 20:16:25 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=j6b4dQh8JlORLJI7WFtVXEaetmdvIJXCO0zu1nVwJiyxnhfInLPFtcrGlenbKYz7vuDjIf+bIFKb2XDBGp5oDxjbN0HeGvuBeQrpf8X01EC1gaw7vBH9wbWBOCVikNJAL2sER/vKUL6Z1V9LXP2AOwUdK3UQdntTzULl0utKVc39hreLcaLZjrVlDKUuB451ZI1ZwwbodtnFojfqxzBPM7IfbPgE3arigS1AT0kJeVcsw6bSK9ep9fIdqrTIUlZsPcnWt0GzPbjzeko8lyg+B9Mq1L3+6aWmsQSxTRsnaq9UCPi5Nq2jhb4HiEY2R6XCmAr8lNGsnkHHxqGikn3Eiw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=/AjzemkBbOF+uCeywe/nJ6ySbYMJ7OqIchDlOoU8rOg=;
 b=dNat4WGugbx9bHJTPVfDPxjRuuc7DxYMMwGTZUVpeMjviu0PLlBZbkaxe2QTN+31n003/qwESIuIVru63QbUuZZZd681EOjDJHivmVWAEb8yYQCY+8RmXzKyeMiGo4vZKaOckrZWy6VqdquNajH6NV2ntaYSO3vbV7C04tcDP8y9s6Ju5TkXZsrVxLKbem72NJjscDO8aYuufNf9Ye6ZcD+Hxt8cnK+u7P3p0BHg1+iVGxJAsxxH9Hife3eanrmxW0JSKWqJVUeUu7B/0fPJBe2/anOwTSSayXt4Z1k279pl2W04Z393Gqj2cYtj+wMh+2JMXgtuvee/2Q1GrEHZnA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nwra.com; dmarc=pass action=none header.from=nwra.com;
 dkim=pass header.d=nwra.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nwra.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=/AjzemkBbOF+uCeywe/nJ6ySbYMJ7OqIchDlOoU8rOg=;
 b=wzPaoyMU3daXvMLQXKDQ26hFYi6QyMs6Qsd5B7J7u3VYxUHge3SBxGZ5v3xECVeXeA1YmR2wAYjGopgjMNYzuBFVDJHIcYcVNouCa/lIUP3tUZvc7R7yJMBm1MSlnzWBjlYQiDAT07+557L4WdgDmq7GB3eM7QHtiTHwFSZtYVxO+N+leoLKrtzJx8El3gyklAo+qYniuUl5oSTLdQfdi0EtXX9r6yGjUFI1k7qMDPRHEzMvVid5ezOn95X9AQ8zeshz7Ziw2M2kTyMc1IbtqO54a/ZM0d83c7myK0L5bcPqnYfu1WbKIy2sDA3pTkemmVu+mL5H67QGRcnzmqqwQQ==
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nwra.com;
Received: from SJ0PR09MB6318.namprd09.prod.outlook.com (2603:10b6:a03:26b::14)
 by PH0PR09MB11645.namprd09.prod.outlook.com (2603:10b6:510:2c8::15) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.33; Tue, 9 May
 2023 18:16:21 +0000
Received: from SJ0PR09MB6318.namprd09.prod.outlook.com
 ([fe80::21ee:67bb:7cac:af4e]) by SJ0PR09MB6318.namprd09.prod.outlook.com
 ([fe80::21ee:67bb:7cac:af4e%7]) with mapi id 15.20.6363.033; Tue, 9 May 2023
 18:16:21 +0000
Message-ID: <888e8ec8-a449-2514-69b3-b66006460849@nwra.com>
Date: Tue, 9 May 2023 12:16:18 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
From: Orion Poplawski <orion@nwra.com>
To: uli42@gmx.de, 1601@bugs.x2go.org
Cc: submit@bugs.x2go.org
Content-Language: en-US
Organization: NorthWest Research Associates
In-Reply-To: <CANVnVY+vsPeNxz9C05vegOnvNoBqx0FKgMAruKMa=BF28sxU-g@mail.gmail.com>
Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="------------ms010303080707010202040009"
X-ClientProxiedBy: CYZPR05CA0010.namprd05.prod.outlook.com
 (2603:10b6:930:89::18) To SJ0PR09MB6318.namprd09.prod.outlook.com
 (2603:10b6:a03:26b::14)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR09MB6318:EE_|PH0PR09MB11645:EE_
X-MS-Office365-Filtering-Correlation-Id: 4b4c5a32-6c07-48b1-a62a-08db50b97d8e
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gU1L51M34DQHVnqnTRYPeT4VurTbBEeWky3diTD1eF3LLLTwgK8NWDyE37kGPChYTSndT9HWmv7m8kjEP0mHaudlWtETl8eu0oZQVvsjtxEFiVsUZQ7DI1JnGtH+Xfc3X+BQ0VABIK07aofG2EFeqT+30h6WROm9yUml4wQ+TJP3e686iKWfXZbGJpIlUx+q2eLe2kozUkGgsoO/IeEzAR4GJuRMqkl7X35lxbj69PPZr08FUvPHvPW9/ybkHp6B4RuLqB3C05b3UhLUeZLPS15fY0cXH63c5M1UjZDfoEdB1OZZ6XcH0+At1httbba2ICz3Bt0CfohRh6Mgkwa2d6moKBDBgtYJd6uxcpEiE4IZl5C2i7eXCC4pw0VRg7s9Cd+nwTXULHaM6sbBVSmmHeDdpFmiW/bUTvG248kBBIynWfXpwOeUQG5P3gXOzUpnR3S87r6xWq0P8559I4ekP2T33pJIl9O8+vRlCOkKBahlRgr3YNHIFl2Bz7lVvSLjF4D1WxPs6YQKCUKUGFMfZZnBoLf3ydcl1kXLAK0aWF9tRnpPns3VYWacn6W6uZfO8n1iMkP1KG1lOMD7HVjLNpJmyElHN2TKhCiE7im8BV6jQr1vWHXcnvtGuFgJYwvT5GpE55XYaqfOmuAtSxXzbA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR09MB6318.namprd09.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(39830400003)(366004)(396003)(451199021)(33964004)(36916002)(6486002)(6512007)(53546011)(26005)(6506007)(966005)(66574015)(36756003)(2616005)(31696002)(38100700002)(40140700001)(86362001)(41320700001)(186003)(4326008)(508600001)(2906002)(31686004)(5660300002)(8676002)(8936002)(66476007)(41300700001)(66556008)(66946007)(235185007)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	F2R3BiTUe6TH+dHgyrr/+rO1m2kLlmXoZs9EJA8Oqvb7GFOTmLJcAtVuEqx2d8KwnNnb9sDZZ6BJegXE8/Vsg13Kz6vVnQwfWzJjML3dQICRaYe3NOZhMs48OVWVoqtlq9mJhpstjzin5SnBCaZajWikpoZFw58QAYjiT/bAeNqZL17xytmrB98QFcWolspT/xYqC8aTynIqm95CH7ZFWd7/JtW4J2ZD5AL8uxp9bVTrgrozLpL3p5QnonJeLFd37HchZvKFlbzxDg0VVF/f5MX7z+/F7Z1WuiMFIckHl+HEKGCwfiBfqM2QVHMkqIwSaIrc/BzcNYzcePkKbo97YkdhejaLVX6B2S7oY6PClzZn6vitTAO+0Z4ors3TXZsAsVKLX3kEWMPHPB75e31C+OdraM8cSMTHb/d+Wptwal9oulHT+AYr09NWDe/bpNxMgWHC8tHFj06/wZODwu69VvMIfZx7wykWad/UuzmXJo2LMKd68TvrRo85coxYUsmdHOH+KhRDNBSZcp/TqQjt5SKTtxyxD6z2peT8kEvkIRGWFg/mE+gu+hazyqwBxyVxU/FrHycnlYmorDSEiTeEoC+bOttiQtPmSb6IR1UYsdDZ+enhW4PHuCjfjGaU4q6+V1eU0OFvxfopm5NJRYiSzVYeYFngwLaUEdk84UBxboH4wD/rQjjA7/8pDuHYV6TRSgZBcUf2cI7+ht6zaKPzZG66kGp59T3xhMPFKbEUGVX8l4Tpsf3N2bNl+cOHxQCNrn+Qq+nSMK7SWnqtLDi+tSv+Pi0fZrbvbwcxV+9dc2eG+6dbsw1FPe+68/zqjhqa6RxNI3r7sDVqK1ZRkWVDApxSs0Q1oDv+oxGrRrrVlFWLeaxanFxlhLl3/FYEnJ8NzzBDynJSq3xHS/ySUfW/OgConatF/7m/yxxrkCQVXnQALs0DeNBKIukpjzZnaDWT5mKaRC4h+cPvEUSQ3LzpMsTKoj1gm/psVdpD6tzXhf8+Ul5azyeqmJPzM7pB6WQk07U04v86IQFpJwkr3EgmLSosewdaj+muqM9m6VJdtMqSmJiWRShkQL24J4f3yCDRq5jtepOL2atjzJ+Fh6DFmzmctXQi55Vso+3H0or1/JbdXzfVT4qLLM17jAGsoNvnVCdPcSM5QDX5TTuZXMh+Dcpug3t+cTBZ+6nNO8KcvVlLD+HdNXZmwD5H71By4MzvuWxqApKuvkyS8cbMBzu0ucwoTs29Fy8ikKWy8YdKcMM/5u8j4MVaNPEr51Tb8lM93iOK2E82Zctx/2440Tz5GG4j7H3DP9VBgsesqHCUqG5rmMxGiKTfe6ylxVNqjnCCHA0+eDA9BVS/nwbT7nW9sFwFDjZImiuImzwEMpUBEYuomNcgra4eMn9TxTdcV2pM3F+CplFDm2fFAOrc8CaUHEtnhfhxU2wyFuO/EQ8BtpCwKIk6wTWXHtyEEXVFGPSA6vGdjaRJE5UfT08tDRrP4GmkC5TlqJ9o31cBXmr8Oz/RlMGivyVNM2SWf//z8d86+BeJELY7Z4FuTZBQeiLLhxWG2ZqJZnIEYjK08AFp9dzVrJuCeF0wGKCvn3Vnw2Nn
X-OriginatorOrg: nwra.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b4c5a32-6c07-48b1-a62a-08db50b97d8e
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR09MB6318.namprd09.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2023 18:16:21.1339
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 761303a3-2ec2-424e-8122-be8b689b4996
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR09MB11645

[Message part 1 (text/plain, inline)]
Gah, once again I make the mistake of not trying to build with the 
latest git
code.

So now I'm trying with that and getting:

i686-w64-mingw32-g++ -c -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 
-fexceptions --param=ssp-buffer-size=4 -fno-keep-inline-dllexport -O2 
-Wall -Wextra -mthreads -DUNICODE -DCFGCLIENT -DQT_STATIC 
-DQT_DESIGNER_STATIC -DDBUS_STATIC_BUILD -DPCRE_STATIC -DPCRE2_STATIC 
-DQT_NO_DEBUG -DQT_SVG_LIB -DQT_WIDGETS_LIB -DQT_WINEXTRAS_LIB 
-DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_NEEDS_QMAIN 
-I../../x2goclient-1ca43813937df9cd136ae6d282204604ab659fab -I. -I../src 
-I/usr/i686-w64-mingw32/sys-root/mingw/include/qt5 
-I/usr/i686-w64-mingw32/sys-root/mingw/include/qt5/QtSvg 
-I/usr/i686-w64-mingw32/sys-root/mingw/include/qt5/QtWidgets 
-I/usr/i686-w64-mingw32/sys-root/mingw/include/qt5/QtWinExtras 
-I/usr/i686-w64-mingw32/sys-root/mingw/include/qt5/QtGui 
-I/usr/i686-w64-mingw32/sys-root/mingw/include/qt5/QtNetwork 
-I/usr/i686-w64-mingw32/sys-root/mingw/include/qt5/QtCore -Irelease -I. 
-I/usr/i686-w64-mingw32/sys-root/mingw/share/qt5/mkspecs/mingw-w64-g++ 
-o release/wapi.o ../src/wapi.cpp
../src/wapi.cpp:25:10: fatal error: AccCtrl.h: No such file or directory
   25 | #include <AccCtrl.h>
      |          ^~~~~~~~~~~

I couldn't find anything that provided that on my system so I simply 
removed it.  And that seems to compile okay.

Ah, just realized I'm on a case sensitive system, so changing that to 
<accctrl.h> works too.  But perhaps it isn't really needed?

On 5/9/23 11:27, Ulrich Sibiller wrote:
> Hi again,
> 
> the current upstream of x2goclient contains these lines. So it looks
> like your QT_VERSION is not set correctly. (see
> https://code.x2go.org/gitweb?p=x2goclient.git;a=blob;f=src/wapi.cpp;h=12732c24b7b7cbf2da4cc8b0d0d9f782646960d3;hb=HEAD)
> 
> Uli
> 
> On Tue, May 9, 2023 at 7:25 PM Ulrich Sibiller
> <ulrich.sibiller@gmail.com> wrote:
>>
>> Iirc I have made some patches for the windows version. I thought they had been merged but I must check that. For now try this:
>>
>>
>> #if QT_VERSION >= 0x050200
>>    largeIcon=QtWin::toHICON(icon.scaled(iconx,icony, Qt::IgnoreAspectRatio,Qt::SmoothTransformation));
>>    smallIcon=QtWin::toHICON(icon.scaled(smallx,smally, Qt::IgnoreAspectRatio,Qt::SmoothTransformation));
>> #else
>>    largeIcon=icon.scaled(iconx,icony, Qt::IgnoreAspectRatio,Qt::SmoothTransformation).toWinHICON();
>>    smallIcon=icon.scaled(smallx,smally, Qt::IgnoreAspectRatio,Qt::SmoothTransformation).toWinHICON();
>> #endif
>>
>>
>> Uli
>>
>> Orion Poplawski <orion@nwra.com> schrieb am Di., 9. Mai 2023, 19:00:
>>>
>>> Package: x2goclient
>>> Version: 4.1.2.2
>>> Tag: patch
>>>
>>>
>>> When compiling against Qt5 5.15.9 I get:
>>>
>>> ../src/wapi.cpp: In function 'void wapiSetWindowIcon(HWND, const QPixmap&)':
>>> ../src/wapi.cpp:224:88: error: 'class QPixmap' has no member named
>>> 'toWinHICON'
>>>    224 |     largeIcon=icon.scaled(iconx,icony,
>>> Qt::IgnoreAspectRatio,Qt::SmoothTransformation).toWinHICON ();
>>>        |                        ^~~~~~~~~~
>>> ../src/wapi.cpp:225:90: error: 'class QPixmap' has no member named
>>> 'toWinHICON'
>>>    225 |     smallIcon=icon.scaled(smallx,smally,
>>> Qt::IgnoreAspectRatio,Qt::SmoothTransformation).toWinHICON ();
>>>        |                          ^~~~~~~~~~
>>>
>>> Now, the only call to wapiSetWindowIcon() is commented out, so I just
>>> commented out the wapiSetWindowIcon() code as we...  Looks like the
>>> current function to use is QImage::toHICON().
>>>
>>> I'm also curious that you need to shift to a Windows API call -
>>> shouldn't we be able to do everything in Qt?
>>>
>>>
>>>
>>> --
>>> Orion Poplawski
>>> he/him/his  - surely the least important thing about me
>>> IT Systems Manager                         720-772-5637
>>> NWRA, Boulder/CoRA Office             FAX: 303-415-9702
>>> 3380 Mitchell Lane                       orion@nwra.com
>>> Boulder, CO 80301                 https://www.nwra.com/_______________________________________________
>>> x2go-dev mailing list
>>> x2go-dev@lists.x2go.org
>>> https://lists.x2go.org/listinfo/x2go-dev

-- 
Orion Poplawski
IT Systems Manager                         720-772-5637
NWRA, Boulder/CoRA Office             FAX: 303-415-9702
3380 Mitchell Lane                       orion@nwra.com
Boulder, CO 80301                 https://www.nwra.com/


[smime.p7s (application/pkcs7-signature, attachment)]

Send a report that this bug log contains spam.

X2Go Developers <owner@bugs.x2go.org>. Last modified: Thu May 9 21:10:15 2024; Machine Name: ymir.das-netzwerkteam.de

X2Go Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.