X2Go Bug report logs - #1019
PATH not correctly set while executing xmodmap

Toggle useless messages

Message #5 received at submit@bugs.x2go.org (full text, mbox, reply):

From: Sebastian Fey <sebastian.fey@tu-dortmund.de>

To: submit@bugs.x2go.org

Subject: xcodemap is missing on OS X 10.11

Date: Tue, 5 Apr 2016 13:45:16 +0200

[Message part 1 (text/plain, inline)]

Package: x2go OS X client
Version: 4.0.5.1

After starting the x2go client, opening a connection and logging in, the 
client reports a missing "xmodmap" binary. The error message is attached 
at the bottom.

The xmodmap binary on my system is located in "/opt/X11/bin/xmodmap". 
The directory path was added to the $PATH variable, but unfortunately 
the client doesn't seem to read the $PATH variable. Due to the new "SIP" 
feature in the new OS X one is not allowed to write to the folders in 
which the client is looking for the binary (even with root privileges).

I'm running OS X 10.11.4 and XQuartz 2.7.8 (xorg-server 1.16.4).

Error message:

"xmodmap failed to start.

This likely means the binary is not available. The current search path 
is: /usr/bin:/bin:/usr/sbin:/sbin X2Go Client will now terminate. File a 
bug report as outlined on the bugs wiki page 
<http://wiki.x2go.org/doku.php/wiki:bugs>."

[Message part 2 (text/html, inline)]

Message #10 received at 1019@bugs.x2go.org (full text, mbox, reply):

From: Mattia Cantono <mattia.cantono@polito.it>

To: 1019@bugs.x2go.org

Subject: Confirmed xmodmap issue

Date: Tue, 5 Apr 2016 19:18:54 +0200

[Message part 1 (text/plain, inline)]

I can confirm this bug on my el Capitan 10.11.4 installation with XQuartz
2.78.

The issue seems to be related to the fixing of bug 487

http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=487

In particular, in the latest version of the function onmainwindow.ccp,
lines 5622-5624 are not working, since the path, that is the one that is
displayed in the error message of the previous message, is not modified.
Thus, the path does not include folders such as /opt/X11/bin/ and xmodmap
cannot be found.

Best,

Mattia Cantono

[Message part 2 (text/html, inline)]

Message #15 received at 1019@bugs.x2go.org (full text, mbox, reply):

From: Mihai Moldovan <ionic@ionic.de>

To: sebastian.fey@tu-dortmund.de, 1019@bugs.x2go.org

Subject: Re: [X2Go-Dev] Bug#1019: xcodemap is missing on OS X 10.11

Date: Wed, 6 Apr 2016 05:44:56 +0200

[Message part 1 (text/plain, inline)]

On 05.04.2016 01:45 PM, Sebastian Fey wrote:
> Package: x2go OS X client
> Version: 4.0.5.1
> 
> After starting the x2go client, opening a connection and logging in, the client
> reports a missing "xmodmap" binary. The error message is attached at the bottom.
> 
> The xmodmap binary on my system is located in "/opt/X11/bin/xmodmap". The
> directory path was added to the $PATH variable, but unfortunately the client
> doesn't seem to read the $PATH variable. Due to the new "SIP" feature in the new
> OS X one is not allowed to write to the folders in which the client is looking
> for the binary (even with root privileges).
> 
> I'm running OS X 10.11.4 and XQuartz 2.7.8 (xorg-server 1.16.4).

That error was caused by me. SIP has nothing to do with it, we don't write to
arbitrary system directories. :)

I'll write up a fix and probably re-release the binaries, because this is a
pretty huge deal-breaker on OS X.

My apologies to all who ran into this issue.



Mihai

[signature.asc (application/pgp-signature, attachment)]

Message #28 received at 1019@bugs.x2go.org (full text, mbox, reply):

From: Mihai Moldovan <ionic@ionic.de>

To: 1019-submitter@bugs.x2go.org

Cc: control@bugs.x2go.org, 1019@bugs.x2go.org

Subject: X2Go issue (in src:x2goclient) has been marked as pending for release

Date: Wed, 6 Apr 2016 06:58:07 +0200 (CEST)

tag #1019 pending
fixed #1019 4.0.5.2
thanks

Hello,

X2Go issue #1019 (src:x2goclient) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

    http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=3772ad2

The issue will most likely be fixed in src:x2goclient (4.0.5.2).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 3772ad2ff7b6553f71790da0527a9e1d5e399ddb
Author: Mihai Moldovan <ionic@ionic.de>
Date:   Wed Apr 6 06:55:33 2016 +0200

    src/onmainwindow.cpp: add (default) MacPorts prefix, /usr/local/bin and /opt/X11/bin to x2goclient's environment and child environments before starting xmodmap. Fixes: #1019.
    
    Requires a re-release of X2Go Client for OS X.

diff --git a/debian/changelog b/debian/changelog
index 2030cd5..c058a99 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -14,6 +14,10 @@ x2goclient (4.0.5.2-0x2go1) UNRELEASED; urgency=medium
       This particular style has been removed/replaced by Fusion, which
       incorporates features of both Plastique and Clearlooks styles.
     - x2goclient.spec: whitespace only.
+    - src/onmainwindow.cpp: add (default) MacPorts prefix, /usr/local/bin and
+      /opt/X11/bin to x2goclient's environment and child environments before
+      starting xmodmap. Fixes: #1019. Requires a re-release of X2Go Client for
+      OS X.
 
   [ Mike DePaulo ]
   * New upstream release (4.0.5.2):

Message #40 received at 1019@bugs.x2go.org (full text, mbox, reply):

From: Mihai Moldovan <ionic@ionic.de>

To: 1019@bugs.x2go.org

Subject: Re: [X2Go-Dev] X2Go issue (in src:x2goclient) has been marked as pending for release

Date: Wed, 6 Apr 2016 07:03:58 +0200

[Message part 1 (text/plain, inline)]

On 06.04.2016 06:58 AM, Mihai Moldovan wrote:
> tag #1019 pending
> fixed #1019 4.0.5.2

Even though this bug will be marked as fixed in 4.0.5.2, I'll take the hotfix I
just pushed, rebase it onto 4.0.5.1 and rebuild the OS X binaries and also
re-publish them later today/tomorrow.



Mihai

[signature.asc (application/pgp-signature, attachment)]

Message #45 received at 1019@bugs.x2go.org (full text, mbox, reply):

From: Mihai Moldovan <ionic@ionic.de>

To: 1019-submitter@bugs.x2go.org

Cc: control@bugs.x2go.org, 1019@bugs.x2go.org

Subject: X2Go issue (in src:x2goclient) has been marked as closed

Date: Wed, 6 Apr 2016 17:15:29 +0200 (CEST)

close #1019
thanks

Hello,

we are very hopeful that X2Go issue #1019 reported by you
has been resolved in the new release (4.0.5.1) of the
X2Go source project »src:x2goclient«.

You can view the complete changelog entry of src:x2goclient (4.0.5.1)
below, and you can use the following link to view all the code changes
between this and the last release of src:x2goclient.

    http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=911e9b243c21357e49bc477b5323805ff43ef56a;hp=c80b04add271dcdac482c2526708a21b0ec4932c

If you feel that the issue has not been resolved satisfyingly, feel
free to reopen this bug report or submit a follow-up report with
further observations described based on the new released version
of src:x2goclient.

Thanks a lot for contributing to X2Go!!!

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
X2Go Component: src:x2goclient
Version: 4.0.5.1-0x2go2
Status: RELEASE
Date: Wed, 06 Apr 2016 17:10:10 +0100
Fixes: 1019
Changes: 
 x2goclient (4.0.5.1-0x2go2) RELEASED; urgency=medium
 .
   [ Mihai Moldovan ]
   * Hotfix release for OS X (4.0.5.1):
     - src/onmainwindow.cpp: add (default) MacPorts prefix, /usr/local/bin and
       /opt/X11/bin to x2goclient's environment and child environments before
       starting xmodmap. Fixes: #1019. Requires a re-release of X2Go Client for
       OS X.

Send a report that this bug log contains spam.